Re: Please review PR #214

2018-11-26 Thread Bruno Baptista 

Hi Romain,

Thanks for you feedback.

I've pushed changes and added a comment to the PR.

Cheers.

Bruno Baptista
https://twitter.com/brunobat_


On 26/11/18 17:11, Romain Manni-Bucau wrote:

Hello Bruno,

I put some suggestions on the PR, hope it helps.

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le lun. 26 nov. 2018 à 18:02, Bruno Baptista  a écrit :


Hi,

I think the code for this example: TOMEE-2283 New Example: Websocket
with TLS and Basic Auth 

Is ready for review here: https://github.com/apache/tomee/pull/214

Can one of you please take a look?

Cheers

--
Bruno Baptista
https://twitter.com/brunobat_

Re: Please review PR #214

2018-11-26 Thread Romain Manni-Bucau 
Hello Bruno,

I put some suggestions on the PR, hope it helps.

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le lun. 26 nov. 2018 à 18:02, Bruno Baptista  a écrit :

> Hi,
>
> I think the code for this example: TOMEE-2283 New Example: Websocket
> with TLS and Basic Auth 
>
> Is ready for review here: https://github.com/apache/tomee/pull/214
>
> Can one of you please take a look?
>
> Cheers
>
> --
> Bruno Baptista
> https://twitter.com/brunobat_
>
>
>

Please review PR #214

2018-11-26 Thread Bruno Baptista 

Hi,

I think the code for this example: TOMEE-2283 New Example: Websocket 
with TLS and Basic Auth 


Is ready for review here: https://github.com/apache/tomee/pull/214

Can one of you please take a look?

Cheers

--
Bruno Baptista
https://twitter.com/brunobat_