[GitHub] [tomee] jgallimore merged pull request #541: TOMEE-2481 - Move code using PropertyEditors (deprecated class) to PropertyEditorRegistry
jgallimore merged pull request #541: TOMEE-2481 - Move code using PropertyEditors (deprecated class) to PropertyEditorRegistry URL: https://github.com/apache/tomee/pull/541 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] rzo1 opened a new pull request #541: TOMEE-2481 - Move code using PropertyEditors (deprecated class) to PropertyEditorRegistry
rzo1 opened a new pull request #541: TOMEE-2481 - Move code using PropertyEditors (deprecated class) to PropertyEditorRegistry URL: https://github.com/apache/tomee/pull/541 Hi, this PR is a follow up of the discussion in https://github.com/apache/tomee/pull/427 and reflects the changes requested by @jgallimore I tied the changes to the lifecycle of the components using the `PropertyEditorRegistry` in each case. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] asf-ci commented on issue #541: TOMEE-2481 - Move code using PropertyEditors (deprecated class) to PropertyEditorRegistry
asf-ci commented on issue #541: TOMEE-2481 - Move code using PropertyEditors (deprecated class) to PropertyEditorRegistry URL: https://github.com/apache/tomee/pull/541#issuecomment-523874982 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] asf-ci commented on issue #541: TOMEE-2481 - Move code using PropertyEditors (deprecated class) to PropertyEditorRegistry
asf-ci commented on issue #541: TOMEE-2481 - Move code using PropertyEditors (deprecated class) to PropertyEditorRegistry URL: https://github.com/apache/tomee/pull/541#issuecomment-523874985 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] asf-ci commented on issue #541: TOMEE-2481 - Move code using PropertyEditors (deprecated class) to PropertyEditorRegistry
asf-ci commented on issue #541: TOMEE-2481 - Move code using PropertyEditors (deprecated class) to PropertyEditorRegistry URL: https://github.com/apache/tomee/pull/541#issuecomment-523874983 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: PropertyEditors deprecated class.
Hi Jon, thank you for your review, I'll take a look after we finish the changes for java and have it merged on master Em seg, 4 de mar de 2019 às 08:27, Jonathan Gallimore < jonathan.gallim...@gmail.com> escreveu: > Added feedback on the PR, but including it here for visibility: > > In LocalJMXCommand the PropertyEditorRegistry is held as a field. In other > places, this is doing PropertyEditorRegistry.registerDefaults() when > calling getValue(), which has to go an do a bunch of registration each > time. > > What do we think the lifecycle of a PropertyEditorRegistry should be? I did > a quick search for references, which throws up ManagedMBean, > ActiveMQ5Factory, JMSProducerImpl, and I would have thought it could be > tied to the lifecycle of the components using it in each case (i.e. - make > it a field). > > Thoughts? > > Jon > > On Mon, Mar 4, 2019 at 10:34 AM Jonathan Gallimore < > jonathan.gallim...@gmail.com> wrote: > > > Interesting. Thanks for the PR - looking at it now. > > > > Jon > > > > On Thu, Feb 28, 2019 at 3:26 PM Daniel Cunha > wrote: > > > >> Hi Folks, > >> > >> I've created the ticket > https://issues.apache.org/jira/browse/TOMEE-2481 > >> > >> That because the class PropertyEditors is a deprected class, because of > >> that we are moving it to use the PropertyEditorRegistry as indicated on > >> the > >> PropertyEditors comment: this is all static and leaks, use > >> PropertyEditorRegistry > >> > >> PR is opened: https://github.com/apache/tomee/pull/427 > >> > >> Pleas review it. > >> > >> -- > >> Daniel "soro" Cunha > >> https://twitter.com/dvlc_ > >> > > > -- Daniel "soro" Cunha https://twitter.com/dvlc_
Re: PropertyEditors deprecated class.
Added feedback on the PR, but including it here for visibility: In LocalJMXCommand the PropertyEditorRegistry is held as a field. In other places, this is doing PropertyEditorRegistry.registerDefaults() when calling getValue(), which has to go an do a bunch of registration each time. What do we think the lifecycle of a PropertyEditorRegistry should be? I did a quick search for references, which throws up ManagedMBean, ActiveMQ5Factory, JMSProducerImpl, and I would have thought it could be tied to the lifecycle of the components using it in each case (i.e. - make it a field). Thoughts? Jon On Mon, Mar 4, 2019 at 10:34 AM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Interesting. Thanks for the PR - looking at it now. > > Jon > > On Thu, Feb 28, 2019 at 3:26 PM Daniel Cunha wrote: > >> Hi Folks, >> >> I've created the ticket https://issues.apache.org/jira/browse/TOMEE-2481 >> >> That because the class PropertyEditors is a deprected class, because of >> that we are moving it to use the PropertyEditorRegistry as indicated on >> the >> PropertyEditors comment: this is all static and leaks, use >> PropertyEditorRegistry >> >> PR is opened: https://github.com/apache/tomee/pull/427 >> >> Pleas review it. >> >> -- >> Daniel "soro" Cunha >> https://twitter.com/dvlc_ >> >
Re: PropertyEditors deprecated class.
Interesting. Thanks for the PR - looking at it now. Jon On Thu, Feb 28, 2019 at 3:26 PM Daniel Cunha wrote: > Hi Folks, > > I've created the ticket https://issues.apache.org/jira/browse/TOMEE-2481 > > That because the class PropertyEditors is a deprected class, because of > that we are moving it to use the PropertyEditorRegistry as indicated on the > PropertyEditors comment: this is all static and leaks, use > PropertyEditorRegistry > > PR is opened: https://github.com/apache/tomee/pull/427 > > Pleas review it. > > -- > Daniel "soro" Cunha > https://twitter.com/dvlc_ >
PropertyEditors deprecated class.
Hi Folks, I've created the ticket https://issues.apache.org/jira/browse/TOMEE-2481 That because the class PropertyEditors is a deprected class, because of that we are moving it to use the PropertyEditorRegistry as indicated on the PropertyEditors comment: this is all static and leaks, use PropertyEditorRegistry PR is opened: https://github.com/apache/tomee/pull/427 Pleas review it. -- Daniel "soro" Cunha https://twitter.com/dvlc_
