Re: [tools-dev] Build Bots error in WITH_LANG variable

2011-02-08 Thread Stephan Bergmann 

On 02/08/11 09:12, Gregor Hartmann wrote:

The script tries to add the languages that might be set in the buildbot
frontend. So the user input should get normalized and then checked if it
contains any languages and only then the variable should get appended
seperated by a space.


While we are at it, wouldn't it be better to directly pass this to 
configure via --with-lang?


-Stephan

-
To unsubscribe, e-mail: dev-unsubscr...@tools.openoffice.org
For additional commands, e-mail: dev-h...@tools.openoffice.org

Re: [tools-dev] Build Bots error in WITH_LANG variable

2011-02-08 Thread Gregor Hartmann 

True,

The script tries to add the languages that might be set in the buildbot 
frontend. So the user input should get normalized and then checked if it 
contains any languages and only then the variable should get appended 
seperated by a space.


It might also be that the definition of WITH_LANG originally is that it 
can contain spaces even if not needed. At least it obviously worked so far.


Kurt could you take care of that.

Cheers
Gregor

Stephan Bergmann schrieb:

On 02/05/11 18:53, Mathias Bauer wrote:

the CWS gnumake3 failed in all build bots. The reason is that -
according to the logs - the variable "WITH_LANG" is set to ' '.

See:

http://termite.services.openoffice.org/buildbot/builders/Windows-2003/builds/1994/steps/Compile/logs/stdio 




(in case it's still there)

Does anybody know why? IMHO it should be empty or unset.


 
apparently is the culprit.  Maybe Gregor can shed some light on this.


-Stephan

-
To unsubscribe, e-mail: dev-unsubscr...@tools.openoffice.org
For additional commands, e-mail: dev-h...@tools.openoffice.org





--
ORACLE
Gregor Hartmann | Software Developer
Phone: +49 40 23 646 500
Oracle Office GBU

ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Rijnzathe 6, 3454PV De Meern, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Geschäftsführer: Jürgen Kunz, Marcel van de Molen, Alexander van der Ven

Oracle is committed to developing practices and products that help 
protect the environment



-
To unsubscribe, e-mail: dev-unsubscr...@tools.openoffice.org
For additional commands, e-mail: dev-h...@tools.openoffice.org

Re: [tools-dev] Build Bots error in WITH_LANG variable

2011-02-07 Thread Stephan Bergmann 

On 02/05/11 18:53, Mathias Bauer wrote:

the CWS gnumake3 failed in all build bots. The reason is that -
according to the logs - the variable "WITH_LANG" is set to ' '.

See:

http://termite.services.openoffice.org/buildbot/builders/Windows-2003/builds/1994/steps/Compile/logs/stdio


(in case it's still there)

Does anybody know why? IMHO it should be empty or unset.


 
apparently is the culprit.  Maybe Gregor can shed some light on this.


-Stephan

-
To unsubscribe, e-mail: dev-unsubscr...@tools.openoffice.org
For additional commands, e-mail: dev-h...@tools.openoffice.org

[tools-dev] Build Bots error in WITH_LANG variable

2011-02-05 Thread Mathias Bauer 

Hi,

the CWS gnumake3 failed in all build bots. The reason is that - 
according to the logs - the variable "WITH_LANG" is set to ' '.


See:

http://termite.services.openoffice.org/buildbot/builders/Windows-2003/builds/1994/steps/Compile/logs/stdio

(in case it's still there)

Does anybody know why? IMHO it should be empty or unset.

I don't think that it makes sense to check WITH_LANG in makefiles for 
being empty or a space. For the time being I will do it to get the CWS 
approved. But IMHO we should fix the build bots.


Regards,
Mathias

--
Mathias Bauer (mba) - Project Lead OpenOffice.org Writer
OpenOffice.org Engineering at Oracle: http://blogs.sun.com/GullFOSS
Please don't reply to "nospamfor...@gmx.de".
I use it for the OOo lists and only rarely read other mails sent to it.

-
To unsubscribe, e-mail: dev-unsubscr...@tools.openoffice.org
For additional commands, e-mail: dev-h...@tools.openoffice.org