[GitHub] [incubator-tubemq] TisonKun commented on issue #10: [TUBEMQ-19] correct parameter spelling

2020-01-12 Thread GitBox
TisonKun commented on issue #10: [TUBEMQ-19] correct parameter spelling
URL: https://github.com/apache/incubator-tubemq/pull/10#issuecomment-573529341
 
 
   Thanks for your contribution @Technoboy- . As a suggestion you can use a 
detailed title instead of a general one. A detailed title helps on reading 
commit log later.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-tubemq] Technoboy- opened a new pull request #10: [TUBEMQ-19] correct parameter spelling

2020-01-12 Thread GitBox
Technoboy- opened a new pull request #10: [TUBEMQ-19] correct parameter spelling
URL: https://github.com/apache/incubator-tubemq/pull/10
 
 
   https://issues.apache.org/jira/browse/TUBEMQ-19


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: [DISCUSS] Make every user an Assignable User on JIRA

2020-01-12 Thread Yiheng Wang
+1. We can assign the JIRA to the contributor when her/his patch gets
merged.

On Sat, Jan 11, 2020 at 12:24 AM tison  wrote:

> Hi developers,
>
> I just notice that our contributor cannot be assigned as the assignee of a
> JIRA even if he is the
> actually assignee. Here I'd like to propose that we make every user
> an Assignable User on JIRA.
>
> Note that it doesn't mean everyone can assign an issue to someone, which is
> the permission
> "Assign Issues". IIUC we should ask for infra to change it.
>
> Best,
> tison.
>


[Result][Vote] Commit title format

2020-01-12 Thread Yiheng Wang
Hi community

The voting result is
Option A: 5 votes
Option B: 0 vote
Option C: 0 vote
Other: 2 votes

So please follow the below formats in the commit message/PRs
[TUBEMQ-XXX][optional components] PR description

I will update the wiki.

Thanks
Yiheng


[GitHub] [incubator-tubemq] gosonzhang merged pull request #9: [TUBEMQ-18] Correct TMaster#idGenerater to TMaster#idGenerator

2020-01-12 Thread GitBox
gosonzhang merged pull request #9: [TUBEMQ-18] Correct TMaster#idGenerater to 
TMaster#idGenerator
URL: https://github.com/apache/incubator-tubemq/pull/9
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-tubemq] gosonzhang commented on issue #9: [TUBEMQ-18] Correct TMaster#idGenerater to TMaster#idGenerator

2020-01-12 Thread GitBox
gosonzhang commented on issue #9: [TUBEMQ-18] Correct TMaster#idGenerater to 
TMaster#idGenerator
URL: https://github.com/apache/incubator-tubemq/pull/9#issuecomment-573485366
 
 
   Thanks @Technoboy- 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-tubemq] Technoboy- opened a new pull request #9: [TUBEMQ-18] Correct TMaster#idGenerater to TMaster#idGenerator

2020-01-12 Thread GitBox
Technoboy- opened a new pull request #9: [TUBEMQ-18] Correct 
TMaster#idGenerater to TMaster#idGenerator
URL: https://github.com/apache/incubator-tubemq/pull/9
 
 
   https://issues.apache.org/jira/browse/TUBEMQ-18


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services