[GitHub] [incubator-tubemq] yiheng commented on issue #19: [TUBEMQ-12]Change to use Apache License V2 and enable RAT check

2020-02-10 Thread GitBox
yiheng commented on issue #19: [TUBEMQ-12]Change to use Apache License V2 and 
enable RAT check
URL: https://github.com/apache/incubator-tubemq/pull/19#issuecomment-584096458
 
 
   IMHO, the change is not reviewable without check in the enable RAT check 
change. No one can review such changes. Instead, if we enable the RAT check. 
The change can be verified automatically by the travis build job. Then we just 
need to review the RAT enable check change.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-tubemq] yiheng commented on issue #19: [TUBEMQ-12]Change to use Apache License V2 and enable RAT check

2020-02-10 Thread GitBox
yiheng commented on issue #19: [TUBEMQ-12]Change to use Apache License V2 and 
enable RAT check
URL: https://github.com/apache/incubator-tubemq/pull/19#issuecomment-584095239
 
 
   I suggest split the JIRA into small sub-tasks


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-tubemq] yiheng commented on issue #19: [TUBEMQ-12]Change to use Apache License V2 and enable RAT check

2020-02-10 Thread GitBox
yiheng commented on issue #19: [TUBEMQ-12]Change to use Apache License V2 and 
enable RAT check
URL: https://github.com/apache/incubator-tubemq/pull/19#issuecomment-584087636
 
 
   can you highlight where do we enable RAT check?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services