[jira] [Commented] (TUSCANY-4029) Binding object inadvertently shared across Endpoint and EndpointReference causes errors
[ https://issues.apache.org/jira/browse/TUSCANY-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13235449#comment-13235449 ] ant elder commented on TUSCANY-4029: Hi Raymond, I've had a look at the RESTBindingInvoker code and i think thats actually where the bug is. Rather than relying on the Binding objects getting shared across service and reference RESTBindingInvoker should be using endpointReference.getTargetEndpoint().getBinding().getURI() to get the URI of the deployed service. That approach will work regardless of whether or not the same instance is shared and it will work with Tuscany's dynamic and distributed domain. Binding object inadvertently shared across Endpoint and EndpointReference causes errors --- Key: TUSCANY-4029 URL: https://issues.apache.org/jira/browse/TUSCANY-4029 Project: Tuscany Issue Type: Bug Reporter: ant elder The Binding object stored in the EndpointReference is the same object as stored in the Endpoint which can cause obscure errors when setting attributes on the service also effects the reference and vica versa. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TUSCANY-4029) Binding object inadvertently shared across Endpoint and EndpointReference causes errors
[ https://issues.apache.org/jira/browse/TUSCANY-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13235027#comment-13235027 ] Raymond Feng commented on TUSCANY-4029: --- Hi, are you affected by the fact that the reference gets the same instance of binding from the service side? This change breaks the case where we use @target in the reference element to wire components using non-SCA bindings. For example, the RESTBindingInvoker uses the binding.uri to find out the target address. Since now it's a clone, the value won't be updated when the service binding set the deployed URI. Binding object inadvertently shared across Endpoint and EndpointReference causes errors --- Key: TUSCANY-4029 URL: https://issues.apache.org/jira/browse/TUSCANY-4029 Project: Tuscany Issue Type: Bug Reporter: ant elder The Binding object stored in the EndpointReference is the same object as stored in the Endpoint which can cause obscure errors when setting attributes on the service also effects the reference and vica versa. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
