[jira] [Resolved] (TWILL-177) ZKDiscoveryService should have a way to remove its connection watcher
[ https://issues.apache.org/jira/browse/TWILL-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terence Yim resolved TWILL-177. --- Resolution: Fixed > ZKDiscoveryService should have a way to remove its connection watcher > - > > Key: TWILL-177 > URL: https://issues.apache.org/jira/browse/TWILL-177 > Project: Apache Twill > Issue Type: Bug > Components: discovery >Reporter: Albert Shau >Assignee: Terence Yim > Fix For: 0.8.0 > > > The ZKDiscoveryService adds a connection watcher in its constructor, but has > no way to remove it. As a result, if somebody is creating new instances, the > number of watches will slowly grow. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] twill pull request #8: (TWILL-177) Make ZKDiscoveryService AutoCloseable
Github user asfgit closed the pull request at: https://github.com/apache/twill/pull/8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TWILL-177) ZKDiscoveryService should have a way to remove its connection watcher
[ https://issues.apache.org/jira/browse/TWILL-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15488458#comment-15488458 ] ASF GitHub Bot commented on TWILL-177: -- Github user asfgit closed the pull request at: https://github.com/apache/twill/pull/8 > ZKDiscoveryService should have a way to remove its connection watcher > - > > Key: TWILL-177 > URL: https://issues.apache.org/jira/browse/TWILL-177 > Project: Apache Twill > Issue Type: Bug > Components: discovery >Reporter: Albert Shau >Assignee: Terence Yim > Fix For: 0.8.0 > > > The ZKDiscoveryService adds a connection watcher in its constructor, but has > no way to remove it. As a result, if somebody is creating new instances, the > number of watches will slowly grow. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TWILL-177) ZKDiscoveryService should have a way to remove its connection watcher
[ https://issues.apache.org/jira/browse/TWILL-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15488099#comment-15488099 ] ASF GitHub Bot commented on TWILL-177: -- Github user albertshau commented on a diff in the pull request: https://github.com/apache/twill/pull/8#discussion_r78623437 --- Diff: twill-yarn/src/test/java/org/apache/twill/yarn/YarnTestSuite.java --- @@ -17,8 +17,15 @@ */ package org.apache.twill.yarn; +import org.junit.After; +import org.junit.Before; +import org.junit.Rule; +import org.junit.rules.ExternalResource; +import org.junit.rules.TestName; --- End diff -- unused imports? > ZKDiscoveryService should have a way to remove its connection watcher > - > > Key: TWILL-177 > URL: https://issues.apache.org/jira/browse/TWILL-177 > Project: Apache Twill > Issue Type: Bug > Components: discovery >Reporter: Albert Shau >Assignee: Terence Yim > Fix For: 0.8.0 > > > The ZKDiscoveryService adds a connection watcher in its constructor, but has > no way to remove it. As a result, if somebody is creating new instances, the > number of watches will slowly grow. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] twill pull request #8: (TWILL-177) Make ZKDiscoveryService AutoCloseable
Github user albertshau commented on a diff in the pull request: https://github.com/apache/twill/pull/8#discussion_r78623437 --- Diff: twill-yarn/src/test/java/org/apache/twill/yarn/YarnTestSuite.java --- @@ -17,8 +17,15 @@ */ package org.apache.twill.yarn; +import org.junit.After; +import org.junit.Before; +import org.junit.Rule; +import org.junit.rules.ExternalResource; +import org.junit.rules.TestName; --- End diff -- unused imports? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
