[GitHub] twill issue #14: TWILL-138 Runtime log level change
Github user yaojiefeng commented on the issue: https://github.com/apache/twill/pull/14 Thanks! @hsaputra --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TWILL-138) Runtime change of Application runnable log level
[ https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15744792#comment-15744792 ] ASF GitHub Bot commented on TWILL-138: -- Github user yaojiefeng commented on the issue: https://github.com/apache/twill/pull/14 Thanks! @hsaputra > Runtime change of Application runnable log level > > > Key: TWILL-138 > URL: https://issues.apache.org/jira/browse/TWILL-138 > Project: Apache Twill > Issue Type: New Feature > Components: core >Reporter: Henry Saputra >Assignee: Yaojie Feng > Fix For: 0.9.0 > > > With TWILL-24 is supported for setting log level when starting the Twill > application, next enhancement is to able to send command to update the > aggregate log level for a particular runnable in a Twill application. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] twill pull request #18: Fix reset log level for runnables started up later
GitHub user yaojiefeng opened a pull request: https://github.com/apache/twill/pull/18 Fix reset log level for runnables started up later There is a bug when we try to reset log levels for some runnables which are started up later, e.g, restart or instance changes, after some runtime log level changes. For now, when we start up the `TwillContainerService`, we set log levels based on the what we try to set in `TwillPreparer` + runtime log levels. But we do not memorize the old log level for loggers changed at runtime. So we we reset, we will not get back to the state we want. This PR fixes this by memorizing the log level changes coming from runtime. And remove when we call reset. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yaojiefeng/twill fix/remember-the-runtime-log-level-change-during-startup Alternatively you can review and apply these changes as the patch at: https://github.com/apache/twill/pull/18.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #18 commit ae01446bfd9c02982428b8b25ec7fe40b33c89f6 Author: yaojiefeng Date: 2016-12-13T12:03:55Z fix reset log level for runnables --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] twill issue #18: Fix reset log level for runnables started up later
Github user chtyim commented on the issue: https://github.com/apache/twill/pull/18 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] twill pull request #18: Fix reset log level for runnables started up later
Github user asfgit closed the pull request at: https://github.com/apache/twill/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] twill pull request #17: Change initial application submission log message fr...
Github user asfgit closed the pull request at: https://github.com/apache/twill/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] twill pull request #19: Fix ConcurrentModificationException from removal in ...
GitHub user yaojiefeng opened a pull request: https://github.com/apache/twill/pull/19 Fix ConcurrentModificationException from removal in map and refactor ⦠â¦the code Removing loglevel from the map during iteration will cause ConcurrentModificationException. Now Using Iterator to iterate the map and remove. Also refactored the code a bit. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yaojiefeng/twill fix/Remove-during-iteration-and-refactor Alternatively you can review and apply these changes as the patch at: https://github.com/apache/twill/pull/19.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #19 commit 68ecea9fa3303ecd1e98ca0aae034df971c11590 Author: yaojiefeng Date: 2016-12-13T23:08:54Z Fix ConcurrentModificationException from removal in map and refactor the code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] twill issue #19: Fix ConcurrentModificationException from removal in map and...
Github user chtyim commented on the issue: https://github.com/apache/twill/pull/19 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] twill pull request #19: Fix ConcurrentModificationException from removal in ...
Github user asfgit closed the pull request at: https://github.com/apache/twill/pull/19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] twill pull request #20: Remove unnecessary methods to get the root log level
GitHub user yaojiefeng opened a pull request: https://github.com/apache/twill/pull/20 Remove unnecessary methods to get the root log level Since we are now setting the log level once the `TwillContainerService` starts up. We no longer need the get root log level from `TwillContainerMain`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yaojiefeng/twill fix/root-log-level Alternatively you can review and apply these changes as the patch at: https://github.com/apache/twill/pull/20.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #20 commit 481a7c7895557ae1881310a4b91d524d514f08e5 Author: yaojiefeng Date: 2016-12-14T02:58:36Z Remove unnecessary methods to get the root log level --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] twill issue #20: Remove unnecessary methods to get the root log level
Github user chtyim commented on the issue: https://github.com/apache/twill/pull/20 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] twill pull request #20: Remove unnecessary methods to get the root log level
Github user asfgit closed the pull request at: https://github.com/apache/twill/pull/20 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[VOTE] Release of Apache Twill-0.9.0 [rc1]
Hi all, This is a call for a vote on releasing Apache Twill 0.9.0, release candidate 1. This is the 10th release of Twill. The source tarball, including signatures, digests, etc. can be found at: https://dist.apache.org/repos/dist/dev/twill/0.9.0-rc1/src The tag to be voted upon is v0.9.0: https://git-wip-us.apache.org/repos/asf?p=twill.git;a=shortlog;h=refs/tags/v0.9.0 The release hash is 960784bb2f8b4ecda37b95eaf662aa53acfc2ca1: https://git-wip-us.apache.org/repos/asf?p=twill.git;a=commit;h=960784bb2f8b4ecda37b95eaf662aa53acfc2ca1 The Nexus Staging URL: https://repository.apache.org/content/repositories/orgapachetwill-1021 Release artifacts are signed with the following key: https://people.apache.org/keys/committer/chtyim.asc KEYS file available: https://dist.apache.org/repos/dist/dev/twill/KEYS For information about the contents of this release, see: https://dist.apache.org/repos/dist/dev/twill/0.9.0-rc1/CHANGES.txt Please vote on releasing this package as Apache Twill 0.9.0 The vote will be open for 72 hours. [ ] +1 Release this package as Apache Twill 0.9.0 [ ] +0 no opinion [ ] -1 Do not release this package because ... +1 from myself Thanks, Terence
Re: [VOTE] Release of Apache Twill-0.9.0 [rc1]
+1 Verified that the project can be built and all tests pass, verified checksums, signature. Albert On Tuesday, December 13, 2016 8:26 PM, Terence Yim wrote: Hi all, This is a call for a vote on releasing Apache Twill 0.9.0, release candidate 1. This is the 10th release of Twill. The source tarball, including signatures, digests, etc. can be found at: https://dist.apache.org/repos/dist/dev/twill/0.9.0-rc1/src The tag to be voted upon is v0.9.0: https://git-wip-us.apache.org/repos/asf?p=twill.git;a=shortlog;h=refs/tags/v0.9.0 The release hash is 960784bb2f8b4ecda37b95eaf662aa53acfc2ca1: https://git-wip-us.apache.org/repos/asf?p=twill.git;a=commit;h=960784bb2f8b4ecda37b95eaf662aa53acfc2ca1 The Nexus Staging URL: https://repository.apache.org/content/repositories/orgapachetwill-1021 Release artifacts are signed with the following key: https://people.apache.org/keys/committer/chtyim.asc KEYS file available: https://dist.apache.org/repos/dist/dev/twill/KEYS For information about the contents of this release, see: https://dist.apache.org/repos/dist/dev/twill/0.9.0-rc1/CHANGES.txt Please vote on releasing this package as Apache Twill 0.9.0 The vote will be open for 72 hours. [ ] +1 Release this package as Apache Twill 0.9.0 [ ] +0 no opinion [ ] -1 Do not release this package because ... +1 from myself Thanks, Terence
