[jira] [Commented] (TWILL-210) ServiceMain does not handle well URI without authority
[ https://issues.apache.org/jira/browse/TWILL-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843928#comment-15843928 ] Yuliya Feldman commented on TWILL-210: -- [~chtyim] Thank you. It was really quick. > ServiceMain does not handle well URI without authority > -- > > Key: TWILL-210 > URL: https://issues.apache.org/jira/browse/TWILL-210 > Project: Apache Twill > Issue Type: Bug > Components: yarn >Affects Versions: 0.8.0, 0.9.0 >Reporter: Yuliya Feldman >Assignee: Yuliya Feldman > Fix For: 0.10.0 > > > When figuring out defaultFS from path ServiceMain does not handle correctly > FileSystems that do not provide URI authority > E.g. maprfs:/// -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TWILL-210) ServiceMain does not handle well URI without authority
[ https://issues.apache.org/jira/browse/TWILL-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843763#comment-15843763 ] Terence Yim commented on TWILL-210: --- Changes merged. Thanks [~yufeldman] for the contribution. > ServiceMain does not handle well URI without authority > -- > > Key: TWILL-210 > URL: https://issues.apache.org/jira/browse/TWILL-210 > Project: Apache Twill > Issue Type: Bug > Components: yarn >Affects Versions: 0.8.0, 0.9.0 >Reporter: Yuliya Feldman >Assignee: Yuliya Feldman > Fix For: 0.10.0 > > > When figuring out defaultFS from path ServiceMain does not handle correctly > FileSystems that do not provide URI authority > E.g. maprfs:/// -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (TWILL-210) ServiceMain does not handle well URI without authority
[ https://issues.apache.org/jira/browse/TWILL-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terence Yim resolved TWILL-210. --- Resolution: Fixed > ServiceMain does not handle well URI without authority > -- > > Key: TWILL-210 > URL: https://issues.apache.org/jira/browse/TWILL-210 > Project: Apache Twill > Issue Type: Bug > Components: yarn >Affects Versions: 0.8.0, 0.9.0 >Reporter: Yuliya Feldman >Assignee: Yuliya Feldman > Fix For: 0.10.0 > > > When figuring out defaultFS from path ServiceMain does not handle correctly > FileSystems that do not provide URI authority > E.g. maprfs:/// -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TWILL-210) ServiceMain does not handle well URI without authority
[ https://issues.apache.org/jira/browse/TWILL-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terence Yim updated TWILL-210: -- Fix Version/s: 0.10.0 > ServiceMain does not handle well URI without authority > -- > > Key: TWILL-210 > URL: https://issues.apache.org/jira/browse/TWILL-210 > Project: Apache Twill > Issue Type: Bug > Components: yarn >Affects Versions: 0.8.0, 0.9.0 >Reporter: Yuliya Feldman >Assignee: Yuliya Feldman > Fix For: 0.10.0 > > > When figuring out defaultFS from path ServiceMain does not handle correctly > FileSystems that do not provide URI authority > E.g. maprfs:/// -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] twill pull request #28: TWILL-210 Ability to handle FileSystems that do not ...
Github user asfgit closed the pull request at: https://github.com/apache/twill/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TWILL-210) ServiceMain does not handle well URI without authority
[ https://issues.apache.org/jira/browse/TWILL-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843762#comment-15843762 ] ASF GitHub Bot commented on TWILL-210: -- Github user asfgit closed the pull request at: https://github.com/apache/twill/pull/28 > ServiceMain does not handle well URI without authority > -- > > Key: TWILL-210 > URL: https://issues.apache.org/jira/browse/TWILL-210 > Project: Apache Twill > Issue Type: Bug > Components: yarn >Affects Versions: 0.8.0, 0.9.0 >Reporter: Yuliya Feldman >Assignee: Yuliya Feldman > Fix For: 0.10.0 > > > When figuring out defaultFS from path ServiceMain does not handle correctly > FileSystems that do not provide URI authority > E.g. maprfs:/// -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TWILL-210) ServiceMain does not handle well URI without authority
[ https://issues.apache.org/jira/browse/TWILL-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terence Yim updated TWILL-210: -- Assignee: Yuliya Feldman > ServiceMain does not handle well URI without authority > -- > > Key: TWILL-210 > URL: https://issues.apache.org/jira/browse/TWILL-210 > Project: Apache Twill > Issue Type: Bug > Components: yarn >Affects Versions: 0.8.0, 0.9.0 >Reporter: Yuliya Feldman >Assignee: Yuliya Feldman > > When figuring out defaultFS from path ServiceMain does not handle correctly > FileSystems that do not provide URI authority > E.g. maprfs:/// -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TWILL-210) ServiceMain does not handle well URI without authority
[ https://issues.apache.org/jira/browse/TWILL-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843759#comment-15843759 ] ASF GitHub Bot commented on TWILL-210: -- Github user chtyim commented on the issue: https://github.com/apache/twill/pull/28 LGTM > ServiceMain does not handle well URI without authority > -- > > Key: TWILL-210 > URL: https://issues.apache.org/jira/browse/TWILL-210 > Project: Apache Twill > Issue Type: Bug > Components: yarn >Affects Versions: 0.8.0, 0.9.0 >Reporter: Yuliya Feldman > > When figuring out defaultFS from path ServiceMain does not handle correctly > FileSystems that do not provide URI authority > E.g. maprfs:/// -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] twill issue #28: TWILL-210 Ability to handle FileSystems that do not have au...
Github user chtyim commented on the issue: https://github.com/apache/twill/pull/28 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TWILL-210) ServiceMain does not handle well URI without authority
[ https://issues.apache.org/jira/browse/TWILL-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843607#comment-15843607 ] ASF GitHub Bot commented on TWILL-210: -- GitHub user yufeldman opened a pull request: https://github.com/apache/twill/pull/28 TWILL-210 Ability to handle FileSystems that do not have authority You can merge this pull request into a Git repository by running: $ git pull https://github.com/yufeldman/twill branch-TWILL-210 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/twill/pull/28.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #28 commit 9bae0e9671dae95407902461da9f9f41e0e135eb Author: Yuliya Feldman Date: 2017-01-27T22:49:58Z TWILL-210 Ability to handle FileSystems that do not have authority > ServiceMain does not handle well URI without authority > -- > > Key: TWILL-210 > URL: https://issues.apache.org/jira/browse/TWILL-210 > Project: Apache Twill > Issue Type: Bug > Components: yarn >Affects Versions: 0.8.0, 0.9.0 >Reporter: Yuliya Feldman > > When figuring out defaultFS from path ServiceMain does not handle correctly > FileSystems that do not provide URI authority > E.g. maprfs:/// -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] twill pull request #28: TWILL-210 Ability to handle FileSystems that do not ...
GitHub user yufeldman opened a pull request: https://github.com/apache/twill/pull/28 TWILL-210 Ability to handle FileSystems that do not have authority You can merge this pull request into a Git repository by running: $ git pull https://github.com/yufeldman/twill branch-TWILL-210 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/twill/pull/28.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #28 commit 9bae0e9671dae95407902461da9f9f41e0e135eb Author: Yuliya Feldman Date: 2017-01-27T22:49:58Z TWILL-210 Ability to handle FileSystems that do not have authority --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (TWILL-210) ServiceMain does not handle well URI without authority
Yuliya Feldman created TWILL-210: Summary: ServiceMain does not handle well URI without authority Key: TWILL-210 URL: https://issues.apache.org/jira/browse/TWILL-210 Project: Apache Twill Issue Type: Bug Components: yarn Affects Versions: 0.9.0, 0.8.0 Reporter: Yuliya Feldman When figuring out defaultFS from path ServiceMain does not handle correctly FileSystems that do not provide URI authority E.g. maprfs:/// -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] twill pull request #27: Fix location permission test for older Hadoop versio...
Github user asfgit closed the pull request at: https://github.com/apache/twill/pull/27 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TWILL-181) Control the maximum number of retries for failed application starts
[ https://issues.apache.org/jira/browse/TWILL-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843522#comment-15843522 ] ASF GitHub Bot commented on TWILL-181: -- Github user serranom commented on the issue: https://github.com/apache/twill/pull/23 @hsaputra , that is the failure I see as intermittent. My comment above has a relevant log excerpt. I'm planning on trying to dig into it today or tomorrow. > Control the maximum number of retries for failed application starts > --- > > Key: TWILL-181 > URL: https://issues.apache.org/jira/browse/TWILL-181 > Project: Apache Twill > Issue Type: Improvement > Components: yarn >Affects Versions: 0.7.0-incubating >Reporter: Martin Serrano >Assignee: Martin Serrano > Fix For: 0.10.0 > > > If an application consistently exits with a non-zero code, twill will > attempt to restart indefinitely. I ran into this issue and a list search > also reveals [others| http://markmail.org/message/dehx7r6tpqgcmjh4]. > There should be a mechanism to specify the maximum number of retries until > the application fails. Ideally by default there would be a non-infinite > maximum. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] twill issue #23: (TWILL-181) allow setting the maximum number of retries per...
Github user serranom commented on the issue: https://github.com/apache/twill/pull/23 @hsaputra , that is the failure I see as intermittent. My comment above has a relevant log excerpt. I'm planning on trying to dig into it today or tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TWILL-181) Control the maximum number of retries for failed application starts
[
https://issues.apache.org/jira/browse/TWILL-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843520#comment-15843520
]
ASF GitHub Bot commented on TWILL-181:
--
Github user serranom commented on a diff in the pull request:
https://github.com/apache/twill/pull/23#discussion_r98294126
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java
---
@@ -113,9 +117,11 @@ public Integer apply(BitSet input) {
private final Location applicationLocation;
private final Set runnableNames;
private final Map> logLevels;
+ private final Map maxRetries;
--- End diff --
I'm taking a look at this.
> Control the maximum number of retries for failed application starts
> ---
>
> Key: TWILL-181
> URL: https://issues.apache.org/jira/browse/TWILL-181
> Project: Apache Twill
> Issue Type: Improvement
> Components: yarn
>Affects Versions: 0.7.0-incubating
>Reporter: Martin Serrano
>Assignee: Martin Serrano
> Fix For: 0.10.0
>
>
> If an application consistently exits with a non-zero code, twill will
> attempt to restart indefinitely. I ran into this issue and a list search
> also reveals [others| http://markmail.org/message/dehx7r6tpqgcmjh4].
> There should be a mechanism to specify the maximum number of retries until
> the application fails. Ideally by default there would be a non-infinite
> maximum.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] twill pull request #23: (TWILL-181) allow setting the maximum number of retr...
Github user serranom commented on a diff in the pull request:
https://github.com/apache/twill/pull/23#discussion_r98294126
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java
---
@@ -113,9 +117,11 @@ public Integer apply(BitSet input) {
private final Location applicationLocation;
private final Set runnableNames;
private final Map> logLevels;
+ private final Map maxRetries;
--- End diff --
I'm taking a look at this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (TWILL-181) Control the maximum number of retries for failed application starts
[ https://issues.apache.org/jira/browse/TWILL-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843311#comment-15843311 ] ASF GitHub Bot commented on TWILL-181: -- Github user hsaputra commented on the issue: https://github.com/apache/twill/pull/23 Seems like one of the tests failed related to new one you added: ` MaxRetriesTestRun.maxRetriesTwoInstances` Could you quickly take a peek? https://s3.amazonaws.com/archive.travis-ci.org/jobs/192819935/log.txt > Control the maximum number of retries for failed application starts > --- > > Key: TWILL-181 > URL: https://issues.apache.org/jira/browse/TWILL-181 > Project: Apache Twill > Issue Type: Improvement > Components: yarn >Affects Versions: 0.7.0-incubating >Reporter: Martin Serrano >Assignee: Martin Serrano > Fix For: 0.10.0 > > > If an application consistently exits with a non-zero code, twill will > attempt to restart indefinitely. I ran into this issue and a list search > also reveals [others| http://markmail.org/message/dehx7r6tpqgcmjh4]. > There should be a mechanism to specify the maximum number of retries until > the application fails. Ideally by default there would be a non-infinite > maximum. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] twill issue #23: (TWILL-181) allow setting the maximum number of retries per...
Github user hsaputra commented on the issue: https://github.com/apache/twill/pull/23 Seems like one of the tests failed related to new one you added: ` MaxRetriesTestRun.maxRetriesTwoInstances` Could you quickly take a peek? https://s3.amazonaws.com/archive.travis-ci.org/jobs/192819935/log.txt --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] twill issue #27: Fix location permission test for older Hadoop versions
Github user chtyim commented on the issue: https://github.com/apache/twill/pull/27 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] twill pull request #27: Fix location permission test for older Hadoop versio...
GitHub user anew opened a pull request: https://github.com/apache/twill/pull/27 Fix location permission test for older Hadoop versions In older Hadoop versions (2.0), files are always created with permissions that do not have execute bits. In later Hadoop versions, execute permissions are permitted for files. This changes the test location permission case to adjust the expected permissions for the missing execute bits, based on the Hadoop version. Also fixes an intriguing bug where creating a directory (say a/b/c/) one of whose parents (say a/b) already exists as a file, Hadoop throws an access control exception. This is because the execute bit is not set on files. We must expect that exception and handle it properly. You can merge this pull request into a Git repository by running: $ git pull https://github.com/anew/twill fix-perm-hadoop20 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/twill/pull/27.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #27 commit eba8b495119ed72d39e0f044bcb2ef62396294b7 Author: anew Date: 2017-01-27T03:54:21Z fix permission test for Hadoop 2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
