[jira] [Commented] (TWILL-248) Upgrade to latest Netty 4.1
[ https://issues.apache.org/jira/browse/TWILL-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16199368#comment-16199368 ] ASF GitHub Bot commented on TWILL-248: -- Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/62#discussion_r143854276 --- Diff: twill-yarn/src/main/java/org/apache/twill/yarn/ResourceReportClient.java --- @@ -52,12 +54,16 @@ public ResourceReport get() { for (URL url : resourceUrls) { try { -Reader reader = new BufferedReader(new InputStreamReader(url.openStream(), Charsets.UTF_8)); -try { +HttpURLConnection urlConn = (HttpURLConnection) url.openConnection(); --- End diff -- Not entirely. This is to enable compression when fetching the report. > Upgrade to latest Netty 4.1 > --- > > Key: TWILL-248 > URL: https://issues.apache.org/jira/browse/TWILL-248 > Project: Apache Twill > Issue Type: Task > Components: core >Reporter: Terence Yim >Assignee: Terence Yim > > Netty 3.x has been EOL -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] twill pull request #62: (TWILL-248) Upgrade to use Netty-4.1
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/62#discussion_r143854276 --- Diff: twill-yarn/src/main/java/org/apache/twill/yarn/ResourceReportClient.java --- @@ -52,12 +54,16 @@ public ResourceReport get() { for (URL url : resourceUrls) { try { -Reader reader = new BufferedReader(new InputStreamReader(url.openStream(), Charsets.UTF_8)); -try { +HttpURLConnection urlConn = (HttpURLConnection) url.openConnection(); --- End diff -- Not entirely. This is to enable compression when fetching the report. ---
[jira] [Commented] (TWILL-248) Upgrade to latest Netty 4.1
[ https://issues.apache.org/jira/browse/TWILL-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16199328#comment-16199328 ] ASF GitHub Bot commented on TWILL-248: -- Github user hsaputra commented on the issue: https://github.com/apache/twill/pull/62 One question about change form using BufferedReader, but looks good. If passes tests +1 > Upgrade to latest Netty 4.1 > --- > > Key: TWILL-248 > URL: https://issues.apache.org/jira/browse/TWILL-248 > Project: Apache Twill > Issue Type: Task > Components: core >Reporter: Terence Yim >Assignee: Terence Yim > > Netty 3.x has been EOL -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] twill issue #62: (TWILL-248) Upgrade to use Netty-4.1
Github user hsaputra commented on the issue: https://github.com/apache/twill/pull/62 One question about change form using BufferedReader, but looks good. If passes tests +1 ---
[GitHub] twill pull request #62: (TWILL-248) Upgrade to use Netty-4.1
Github user hsaputra commented on a diff in the pull request: https://github.com/apache/twill/pull/62#discussion_r143848112 --- Diff: twill-yarn/src/main/java/org/apache/twill/yarn/ResourceReportClient.java --- @@ -52,12 +54,16 @@ public ResourceReport get() { for (URL url : resourceUrls) { try { -Reader reader = new BufferedReader(new InputStreamReader(url.openStream(), Charsets.UTF_8)); -try { +HttpURLConnection urlConn = (HttpURLConnection) url.openConnection(); --- End diff -- Is this change related to Netty upgrade? ---
[jira] [Commented] (TWILL-248) Upgrade to latest Netty 4.1
[ https://issues.apache.org/jira/browse/TWILL-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16199326#comment-16199326 ] ASF GitHub Bot commented on TWILL-248: -- Github user hsaputra commented on a diff in the pull request: https://github.com/apache/twill/pull/62#discussion_r143848112 --- Diff: twill-yarn/src/main/java/org/apache/twill/yarn/ResourceReportClient.java --- @@ -52,12 +54,16 @@ public ResourceReport get() { for (URL url : resourceUrls) { try { -Reader reader = new BufferedReader(new InputStreamReader(url.openStream(), Charsets.UTF_8)); -try { +HttpURLConnection urlConn = (HttpURLConnection) url.openConnection(); --- End diff -- Is this change related to Netty upgrade? > Upgrade to latest Netty 4.1 > --- > > Key: TWILL-248 > URL: https://issues.apache.org/jira/browse/TWILL-248 > Project: Apache Twill > Issue Type: Task > Components: core >Reporter: Terence Yim >Assignee: Terence Yim > > Netty 3.x has been EOL -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TWILL-248) Upgrade to latest Netty 4.1
[ https://issues.apache.org/jira/browse/TWILL-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16199301#comment-16199301 ] ASF GitHub Bot commented on TWILL-248: -- GitHub user chtyim opened a pull request: https://github.com/apache/twill/pull/62 (TWILL-248) Upgrade to use Netty-4.1 - Also enable ResourceReportClient to use HTTP compression You can merge this pull request into a Git repository by running: $ git pull https://github.com/chtyim/twill feature/TWILL-248-upgrade-netty-4.1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/twill/pull/62.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #62 commit 321e7ba0116ccb7ba1c9b814ff60ad0dfd4ac3e5 Author: Terence Yim Date: 2017-10-10T20:26:11Z (TWILL-248) Upgrade to use Netty-4.1 - Also enable ResourceReportClient to use HTTP compression > Upgrade to latest Netty 4.1 > --- > > Key: TWILL-248 > URL: https://issues.apache.org/jira/browse/TWILL-248 > Project: Apache Twill > Issue Type: Task > Components: core >Reporter: Terence Yim >Assignee: Terence Yim > > Netty 3.x has been EOL -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] twill pull request #62: (TWILL-248) Upgrade to use Netty-4.1
GitHub user chtyim opened a pull request: https://github.com/apache/twill/pull/62 (TWILL-248) Upgrade to use Netty-4.1 - Also enable ResourceReportClient to use HTTP compression You can merge this pull request into a Git repository by running: $ git pull https://github.com/chtyim/twill feature/TWILL-248-upgrade-netty-4.1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/twill/pull/62.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #62 commit 321e7ba0116ccb7ba1c9b814ff60ad0dfd4ac3e5 Author: Terence Yim Date: 2017-10-10T20:26:11Z (TWILL-248) Upgrade to use Netty-4.1 - Also enable ResourceReportClient to use HTTP compression ---
[jira] [Updated] (TWILL-248) Upgrade to latest Netty 4.1
[ https://issues.apache.org/jira/browse/TWILL-248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terence Yim updated TWILL-248: -- Issue Type: Task (was: Bug) > Upgrade to latest Netty 4.1 > --- > > Key: TWILL-248 > URL: https://issues.apache.org/jira/browse/TWILL-248 > Project: Apache Twill > Issue Type: Task > Components: core >Reporter: Terence Yim >Assignee: Terence Yim > > Netty 3.x has been EOL -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (TWILL-248) Upgrade to latest Netty 4.1
Terence Yim created TWILL-248: - Summary: Upgrade to latest Netty 4.1 Key: TWILL-248 URL: https://issues.apache.org/jira/browse/TWILL-248 Project: Apache Twill Issue Type: Bug Components: core Reporter: Terence Yim Assignee: Terence Yim Netty 3.x has been EOL -- This message was sent by Atlassian JIRA (v6.4.14#64029)