[GitHub] twill pull request #57: (TWILL-147) Allow using external Kafka server for lo...

2017-07-21 Thread fonelor
GitHub user fonelor opened a pull request:

https://github.com/apache/twill/pull/57

(TWILL-147) Allow using external Kafka server for log collection

Now external kafka servers could be used for log aggregation
Kafka updated to 0.10.2.0
Embedded kafka server starts if log aggregation is enabled and no external 
kafka servers configured
removed old zk based kafka broker discovery service

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fonelor/twill feature/kafka_upgrade

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/twill/pull/57.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #57


commit 6816ea9945d76921363960043b0bfc392d320cd9
Author: Sergey Filippov <sergey.filip...@firstlinesoftware.com>
Date:   2017-07-14T09:47:21Z

started kafka migration

commit 9f94b4e38ff7bcd8356f9c5671537c9787f93eb6
Author: Sergey Filippov <sergey.filip...@firstlinesoftware.com>
Date:   2017-07-18T15:51:47Z

implemented new KafkaConsumer and new KafkaProducer

commit bd4803e8959b632f9c09ddfc4ec644a461175eea
Author: Sergey Filippov <sergey.filip...@firstlinesoftware.com>
Date:   2017-07-19T15:20:03Z

fixed jmx problems with client.id for consumer
fixed no payload in logger FetchedMessage
fixed incorrect scheduling and running of KafkaConsumer task

commit e98d2f4f92d15a115ef260095ab2f95b6b990417
Author: Sergey Filippov <sergey.filip...@firstlinesoftware.com>
Date:   2017-07-20T15:33:20Z

fixed KafkaTest
removed Encoders
implemented broker.id generation

commit 8bbcb1a417fbeaa22d51b7307c13e1efa3ade71d
Author: Sergey Filippov <sergey.filip...@firstlinesoftware.com>
Date:   2017-07-21T08:37:23Z

checkStyle

commit 92937a5b76c368af7ee86f2a495670aaa4d8c6bb
Author: Sergey Filippov <sergey.filip...@firstlinesoftware.com>
Date:   2017-07-21T08:50:31Z

fixed compressing setting

commit 71d3db756a79f897c4265443a400375ec9f386bb
Author: Sergey Filippov <sergey.filip...@firstlinesoftware.com>
Date:   2017-07-21T09:06:07Z

clean up
revert code moving
added slf4j-log4j12 for testing with kafka

commit 7667767cd54981f55bee12c3cecc69cc5bd00cbd
Author: Sergey Filippov <sergey.filip...@firstlinesoftware.com>
Date:   2017-07-21T09:15:20Z

added kafka bootstrap servers configuration to TwillPreparer

commit cbc7a554e43b80a6622f1a065a3501dc27d88e64
Author: Sergey Filippov <sergey.filip...@firstlinesoftware.com>
Date:   2017-07-21T09:18:59Z

Removed old kafka services




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] twill issue #56: (TWILL-238) Change TwillController restartInstances API

2017-07-14 Thread fonelor
Github user fonelor commented on the issue:

https://github.com/apache/twill/pull/56
  
Reverted reformatting


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] twill pull request #56: (TWILL-238) Change TwillController restartInstances ...

2017-07-14 Thread fonelor
Github user fonelor commented on a diff in the pull request:

https://github.com/apache/twill/pull/56#discussion_r127425262
  
--- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java 
---
@@ -17,15 +17,14 @@
  */
 package org.apache.twill.api;
 
-import org.apache.twill.api.logging.LogEntry;
-import org.apache.twill.api.logging.LogHandler;
-import org.apache.twill.discovery.Discoverable;
-import org.apache.twill.discovery.ServiceDiscovered;
-
 import java.util.Map;
 import java.util.Set;
 import java.util.concurrent.Future;
 import javax.annotation.Nullable;
+import org.apache.twill.api.logging.LogEntry;
--- End diff --

i've reverted reformatting changes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] twill issue #56: (TWILL-238) Change TwillController restartInstances API

2017-07-11 Thread fonelor
Github user fonelor commented on the issue:

https://github.com/apache/twill/pull/56
  
Thank you, serranom, for your comment. Is there any way to set "right" 
order of imports in IDEA? I've imported settings from HowToContribute page, but 
it seems, that it still wants to move imports.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] twill pull request #56: implemented issue TWILL-238: restart instances with ...

2017-07-08 Thread fonelor
GitHub user fonelor opened a pull request:

https://github.com/apache/twill/pull/56

implemented issue TWILL-238: restart instances with Set of Integers

Implemented https://issues.apache.org/jira/browse/TWILL-238 

New method in TwillController to restart instances of runnable

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fonelor/twill feature/238_restartinstances_api

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/twill/pull/56.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #56


commit eb184e6aa727d93fce4e6e4e33c729eb09017750
Author: Sergey Filippov <firstrole...@yandex.ru>
Date:   2017-07-08T11:24:22Z

implemented issue TWILL-238: restart instances with Set of Integers




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---