[GitHub] twill issue #23: (TWILL-181) allow setting the maximum number of retries per...
Github user hsaputra commented on the issue: https://github.com/apache/twill/pull/23 Looks like not related to this PR. Will merge EOD if no more comment. Thanks again for the hard work, @serranom --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] twill issue #23: (TWILL-181) allow setting the maximum number of retries per...
Github user serranom commented on the issue: https://github.com/apache/twill/pull/23 I looked at the latest CI run and the failure is related to some `twill-zookeeper` project issue -- not yarn --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] twill issue #23: (TWILL-181) allow setting the maximum number of retries per...
Github user hsaputra commented on the issue: https://github.com/apache/twill/pull/23 I am having problem applying the patch, could you kindly rebase the patch into single commit? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] twill issue #23: (TWILL-181) allow setting the maximum number of retries per...
Github user serranom commented on the issue: https://github.com/apache/twill/pull/23 My pleasure. It was a good way to get to know twill code base. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] twill issue #23: (TWILL-181) allow setting the maximum number of retries per...
Github user serranom commented on the issue: https://github.com/apache/twill/pull/23 I found that there is still a race condition in ApplicationMasterService.launchRunnable. If the number of instances is increased right after the original request is fullfilled, the current logic can result in the original request not being polled resulting in future requests hanging. This seems to be a fairly unlikely case in the real world, but I'll file a JIRA for it. For now, I've reworked the test to wait until launchRunnable has done the polling for the original request. This PR is now complete. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] twill issue #23: (TWILL-181) allow setting the maximum number of retries per...
Github user serranom commented on the issue: https://github.com/apache/twill/pull/23 ugh. I'll take a look, I may have messed up the merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] twill issue #23: (TWILL-181) allow setting the maximum number of retries per...
Github user serranom commented on the issue: https://github.com/apache/twill/pull/23 I think this is set now. I've updated the PR with instance-based maxRetries changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] twill issue #23: (TWILL-181) allow setting the maximum number of retries per...
Github user serranom commented on the issue: https://github.com/apache/twill/pull/23 @hsaputra , that is the failure I see as intermittent. My comment above has a relevant log excerpt. I'm planning on trying to dig into it today or tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] twill issue #23: (TWILL-181) allow setting the maximum number of retries per...
Github user serranom commented on the issue: https://github.com/apache/twill/pull/23 @hsaputra, since I have a bug to fix, the updated request will trigger the rebuild. thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] twill issue #23: (TWILL-181) allow setting the maximum number of retries per...
Github user serranom commented on the issue: https://github.com/apache/twill/pull/23 Thanks Henry! No rush on my account, I was just checking in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
