[GitHub] twill issue #49: (TWILL-229) Default to use logback_template.xml to configur...

2017-03-30 Thread yaojiefeng
Github user yaojiefeng commented on the issue:

https://github.com/apache/twill/pull/49
  
I see. LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] twill issue #49: (TWILL-229) Default to use logback_template.xml to configur...

2017-03-30 Thread chtyim
Github user chtyim commented on the issue:

https://github.com/apache/twill/pull/49
  
For AM, currently it is not settable. For Runnable containers, user can add 
as resources / localize a `logback.xml` file and specify it in the classpath.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] twill issue #49: (TWILL-229) Default to use logback_template.xml to configur...

2017-03-30 Thread yaojiefeng
Github user yaojiefeng commented on the issue:

https://github.com/apache/twill/pull/49
  
Changes LGTM, may I ask where do we set the logback if it is overriden by 
user?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---