[GitHub] twill pull request #22: (TWILL-187) Added max start time

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/twill/pull/22


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] twill pull request #22: (TWILL-187) Added max start time

[chtyim]

Github user chtyim commented on a diff in the pull request:

https://github.com/apache/twill/pull/22#discussion_r95050430
  
--- Diff: twill-api/src/main/java/org/apache/twill/api/TwillPreparer.java 
---
@@ -257,8 +258,19 @@
   TwillPreparer setLogLevels(String runnableName, Map logLevelsForRunnable);
 
   /**
-   * Starts the application.
+   * Starts the application. It's the same as calling {@link #start(long, 
TimeUnit)} with timeout of 60 seconds.
--- End diff --

There is, however it's defined in the core module, hence can't refer to it 
in the API module


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] twill pull request #22: (TWILL-187) Added max start time

[gokulavasan]

Github user gokulavasan commented on a diff in the pull request:

https://github.com/apache/twill/pull/22#discussion_r95049555
  
--- Diff: twill-api/src/main/java/org/apache/twill/api/TwillPreparer.java 
---
@@ -257,8 +258,19 @@
   TwillPreparer setLogLevels(String runnableName, Map logLevelsForRunnable);
 
   /**
-   * Starts the application.
+   * Starts the application. It's the same as calling {@link #start(long, 
TimeUnit)} with timeout of 60 seconds.
--- End diff --

Is there any constant that we can refer to for '60' ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] twill pull request #22: (TWILL-187) Added max start time

[chtyim]

GitHub user chtyim opened a pull request:

https://github.com/apache/twill/pull/22

(TWILL-187) Added max start time



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/chtyim/twill feature/twill-187

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/twill/pull/22.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #22


commit 5a2227303cfcf039d714f5b8917d06325066d17d
Author: Terence Yim 
Date:   2017-01-07T01:56:53Z

(TWILL-187) Added max start time




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---