[GitHub] twill pull request #32: (TWILL-218), add the OptionSpec class as an explicit...

2017-02-13 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/twill/pull/32


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] twill pull request #32: (TWILL-218), add the OptionSpec class as an explicit...

2017-02-13 Thread serranom
GitHub user serranom opened a pull request:

https://github.com/apache/twill/pull/32

(TWILL-218), add the OptionSpec class as an explicit dependency for the…

… appmaster

I added the jar to the respective poms and added OptionSpec to the 
appmaster dependency calculation.  The dependency shows up because of Kafka:

[INFO] |  |  \- org.apache.kafka:kafka_2.10:jar:0.8.0:compile
[INFO] |  | +- org.scala-lang:scala-library:jar:2.10.1:compile
[INFO] |  | +- net.sf.jopt-simple:jopt-simple:jar:3.2:compile
[INFO] |  | +- org.scala-lang:scala-compiler:jar:2.10.1:compile
[INFO] |  | |  \- org.scala-lang:scala-reflect:jar:2.10.1:compile
[INFO] |  | +- com.101tec:zkclient:jar:0.3:compile
[INFO] |  | +- com.yammer.metrics:metrics-core:jar:2.2.0:compile
[INFO] |  | \- 
com.yammer.metrics:metrics-annotation:jar:2.2.0:compile

However the twill dependency mechanism does not detect the dependency.  By 
making it explicit, it will always end up in the `twill.jar`

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/serranom/twill twill-218

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/twill/pull/32.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #32


commit 989fb9926ba1d2dffdc66d3866080e66c5eeea1a
Author: serranom 
Date:   2017-02-13T20:34:30Z

TWILL-218, add the OptionSpec class as an explicit dependency for the 
appmaster




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---