[GitHub] twill pull request #34: (TWILL-186) Fix NPE and container size mismatch
Github user asfgit closed the pull request at: https://github.com/apache/twill/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] twill pull request #34: (TWILL-186) Fix NPE and container size mismatch
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/34#discussion_r103596214 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/yarn/AbstractYarnAMClient.java --- @@ -50,12 +51,11 @@ private static final Logger LOG = LoggerFactory.getLogger(AbstractYarnAMClient.class); // Map from a unique ID to inflight requests - private final Multimap containerRequests; - - // List of requests pending to send through allocate call - private final List requests; + private final Multimap inflightRequests; + // Map from a unique ID to pending requests. It is for recording --- End diff -- Oh. It is for recording the container requests that has yet to be sent to RM. Will update the comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] twill pull request #34: (TWILL-186) Fix NPE and container size mismatch
Github user anwar6953 commented on a diff in the pull request: https://github.com/apache/twill/pull/34#discussion_r103595352 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/yarn/AbstractYarnAMClient.java --- @@ -50,12 +51,11 @@ private static final Logger LOG = LoggerFactory.getLogger(AbstractYarnAMClient.class); // Map from a unique ID to inflight requests - private final Multimap containerRequests; - - // List of requests pending to send through allocate call - private final List requests; + private final Multimap inflightRequests; + // Map from a unique ID to pending requests. It is for recording --- End diff -- It is for recording what? (incomplete sentence?) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
