[GitHub] twill pull request #8: (TWILL-177) Make ZKDiscoveryService AutoCloseable

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/twill/pull/8


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] twill pull request #8: (TWILL-177) Make ZKDiscoveryService AutoCloseable

[albertshau]

Github user albertshau commented on a diff in the pull request:

https://github.com/apache/twill/pull/8#discussion_r78623437
  
--- Diff: twill-yarn/src/test/java/org/apache/twill/yarn/YarnTestSuite.java 
---
@@ -17,8 +17,15 @@
  */
 package org.apache.twill.yarn;
 
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.rules.ExternalResource;
+import org.junit.rules.TestName;
--- End diff --

unused imports?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] twill pull request #8: (TWILL-177) Make ZKDiscoveryService AutoCloseable

[anwar6953]

Github user anwar6953 commented on a diff in the pull request:

https://github.com/apache/twill/pull/8#discussion_r76680691
  
--- Diff: twill-yarn/src/test/java/org/apache/twill/yarn/BaseYarnTest.java 
---
@@ -66,6 +69,18 @@ protected void after() {
 }
   };
 
+  @Rule
+  public final TestName testName = new TestName();
+
+  @Before
+  public void beforeTest() {
+LOG.info("Before test {}", testName.getMethodName());
--- End diff --

this was just for investigation? Can be removed now?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] twill pull request #8: (TWILL-177) Make ZKDiscoveryService AutoCloseable

[chtyim]

GitHub user chtyim opened a pull request:

https://github.com/apache/twill/pull/8

(TWILL-177) Make ZKDiscoveryService AutoCloseable

- Release ZK watches when closed

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/chtyim/twill feature/twill-177

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/twill/pull/8.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #8


commit 98bcb2d05b02b45bdf0937fb936befb558260b3b
Author: Terence Yim 
Date:   2016-08-26T01:41:15Z

(TWILL-177) Make ZKDiscoveryService AutoCloseable

- Release ZK watches when closed




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---