[jira] [Commented] (TWILL-207) Better have the cache name purely based on class hash to encourage greater reuse.
[ https://issues.apache.org/jira/browse/TWILL-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893833#comment-15893833 ] ASF GitHub Bot commented on TWILL-207: -- Github user asfgit closed the pull request at: https://github.com/apache/twill/pull/35 > Better have the cache name purely based on class hash to encourage greater > reuse. > - > > Key: TWILL-207 > URL: https://issues.apache.org/jira/browse/TWILL-207 > Project: Apache Twill > Issue Type: Improvement >Reporter: Terence Yim >Assignee: Terence Yim > Fix For: 0.11.0 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TWILL-207) Better have the cache name purely based on class hash to encourage greater reuse.
[ https://issues.apache.org/jira/browse/TWILL-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892586#comment-15892586 ] ASF GitHub Bot commented on TWILL-207: -- Github user hsaputra commented on the issue: https://github.com/apache/twill/pull/35 +1 > Better have the cache name purely based on class hash to encourage greater > reuse. > - > > Key: TWILL-207 > URL: https://issues.apache.org/jira/browse/TWILL-207 > Project: Apache Twill > Issue Type: Improvement >Reporter: Terence Yim >Assignee: Terence Yim > Fix For: 0.11.0 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TWILL-207) Better have the cache name purely based on class hash to encourage greater reuse.
[ https://issues.apache.org/jira/browse/TWILL-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892573#comment-15892573 ] ASF GitHub Bot commented on TWILL-207: -- Github user hsaputra commented on the issue: https://github.com/apache/twill/pull/35 Ah, yes, sorry, I thought I added the ignore white spaces when load the files changes view. > Better have the cache name purely based on class hash to encourage greater > reuse. > - > > Key: TWILL-207 > URL: https://issues.apache.org/jira/browse/TWILL-207 > Project: Apache Twill > Issue Type: Improvement >Reporter: Terence Yim >Assignee: Terence Yim > Fix For: 0.11.0 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TWILL-207) Better have the cache name purely based on class hash to encourage greater reuse.
[ https://issues.apache.org/jira/browse/TWILL-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892566#comment-15892566 ] Terence Yim commented on TWILL-207: --- @hsaput , as the title suggested, it encourage reuse of cached files. I added a link to the related jira that had the file caching logic added. > Better have the cache name purely based on class hash to encourage greater > reuse. > - > > Key: TWILL-207 > URL: https://issues.apache.org/jira/browse/TWILL-207 > Project: Apache Twill > Issue Type: Improvement >Reporter: Terence Yim >Assignee: Terence Yim > Fix For: 0.11.0 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TWILL-207) Better have the cache name purely based on class hash to encourage greater reuse.
[ https://issues.apache.org/jira/browse/TWILL-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892553#comment-15892553 ] ASF GitHub Bot commented on TWILL-207: -- Github user chtyim commented on the issue: https://github.com/apache/twill/pull/35 As said in the description, you will see the important changes when ignoring white space changes > Better have the cache name purely based on class hash to encourage greater > reuse. > - > > Key: TWILL-207 > URL: https://issues.apache.org/jira/browse/TWILL-207 > Project: Apache Twill > Issue Type: Improvement >Reporter: Terence Yim >Assignee: Terence Yim > Fix For: 0.11.0 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TWILL-207) Better have the cache name purely based on class hash to encourage greater reuse.
[ https://issues.apache.org/jira/browse/TWILL-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892533#comment-15892533 ] ASF GitHub Bot commented on TWILL-207: -- Github user hsaputra commented on the issue: https://github.com/apache/twill/pull/35 This PR contains both style and functional change, could you help tell a bit where the important changes happen? > Better have the cache name purely based on class hash to encourage greater > reuse. > - > > Key: TWILL-207 > URL: https://issues.apache.org/jira/browse/TWILL-207 > Project: Apache Twill > Issue Type: Improvement >Reporter: Terence Yim >Assignee: Terence Yim > Fix For: 0.11.0 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TWILL-207) Better have the cache name purely based on class hash to encourage greater reuse.
[ https://issues.apache.org/jira/browse/TWILL-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892532#comment-15892532 ] Henry Saputra commented on TWILL-207: - Could you add bit more description why this changes needed ? Would help with reviews and audit later on. > Better have the cache name purely based on class hash to encourage greater > reuse. > - > > Key: TWILL-207 > URL: https://issues.apache.org/jira/browse/TWILL-207 > Project: Apache Twill > Issue Type: Improvement >Reporter: Terence Yim >Assignee: Terence Yim > Fix For: 0.11.0 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TWILL-207) Better have the cache name purely based on class hash to encourage greater reuse.
[ https://issues.apache.org/jira/browse/TWILL-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891603#comment-15891603 ] ASF GitHub Bot commented on TWILL-207: -- Github user chtyim commented on the issue: https://github.com/apache/twill/pull/35 Force push a change to trigger travis build again. > Better have the cache name purely based on class hash to encourage greater > reuse. > - > > Key: TWILL-207 > URL: https://issues.apache.org/jira/browse/TWILL-207 > Project: Apache Twill > Issue Type: Improvement >Reporter: Terence Yim >Assignee: Terence Yim > Fix For: 0.11.0 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TWILL-207) Better have the cache name purely based on class hash to encourage greater reuse.
[ https://issues.apache.org/jira/browse/TWILL-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15889342#comment-15889342 ] ASF GitHub Bot commented on TWILL-207: -- Github user anwar6953 commented on the issue: https://github.com/apache/twill/pull/35 LGTM > Better have the cache name purely based on class hash to encourage greater > reuse. > - > > Key: TWILL-207 > URL: https://issues.apache.org/jira/browse/TWILL-207 > Project: Apache Twill > Issue Type: Improvement >Reporter: Terence Yim >Assignee: Terence Yim > Fix For: 0.11.0 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TWILL-207) Better have the cache name purely based on class hash to encourage greater reuse.
[ https://issues.apache.org/jira/browse/TWILL-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15889330#comment-15889330 ] ASF GitHub Bot commented on TWILL-207: -- GitHub user chtyim opened a pull request: https://github.com/apache/twill/pull/35 (TWILL-207) Only use list of class names as the cache name - Also some indentation changes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/chtyim/twill feature/twill-207 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/twill/pull/35.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #35 commit 542850875e0aecbe34d16bca962186b3d32bfb19 Author: Terence Yim Date: 2017-03-01T02:03:45Z (TWILL-207) Only use list of class names as the cache name - Also some indentation changes. > Better have the cache name purely based on class hash to encourage greater > reuse. > - > > Key: TWILL-207 > URL: https://issues.apache.org/jira/browse/TWILL-207 > Project: Apache Twill > Issue Type: Improvement >Reporter: Terence Yim >Assignee: Terence Yim > Fix For: 0.11.0 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
