Re: Bundled jar ability to pick up local jars

2017-02-15 Thread Henry Saputra
Awesome! Please do keep the questions and suggestions coming =)

- Henry

On Wed, Feb 15, 2017 at 3:33 PM, Yuliya Feldman  wrote:

> Already figured
>
> Thanks,
> Yuliya
>
> On Wed, Feb 15, 2017 at 2:51 PM, Henry Saputra 
> wrote:
>
> > Hi Yuliya,
> >
> > With bundled jar approach you need to include all your dependencies in
> that
> > app jar itself and the dependencies put in the "lib" directory specified
> by
> > setLibFolder.
> >
> > For example:
> > https://github.com/apache/twill/blob/2a8de333f4014fbcbcde826e507b9d
> > 8810554ffc/twill-examples/yarn/src/main/java/org/apache/
> > twill/example/yarn/
> > BundledJarExample.java
> >
> > Here is the link to source that explain the format of the bundled jar:
> >
> > https://github.com/apache/twill/blob/2a8de333f4014fbcbcde826e507b9d
> > 8810554ffc/twill-ext/src/main/java/org/apache/twill/ext/
> > BundledJarRunner.java
> >
> >
> > - Henry
> >
> > On Tue, Feb 14, 2017 at 11:25 PM, Yuliya Feldman 
> > wrote:
> >
> > > Let me even further rephrase the question
> > >
> > > What should be the structure of bundled jar
> > >
> > > It feels like it should be classes of the main jar + lib folder with
> > > additional jars - it can not be main jar + lib folder with jars, as in
> > this
> > > case main jar is not really loaded since it loads parent jar (one that
> is
> > > defined as "bundled")
> > >
> > > Thanks
> > >
> > > On Tue, Feb 14, 2017 at 6:54 PM, Yuliya Feldman 
> > wrote:
> > >
> > > >  Sorry,
> > > >
> > > > I probably was not clear. I understand that TwillContainer launcher
> > will
> > > > take classpath into consideration.
> > > > I was more wondering about bundledjar loading - we load it in a
> > separate
> > > > classloader, so everything has to be included into bundled jar,
> > otherwise
> > > > it does not seem to work, as it will be missing dependencies -
> nothing
> > is
> > > > loaded outside of the jar itself.
> > > >
> > > > Thanks
> > > >
> > > > On Tue, Feb 14, 2017 at 6:39 PM, Terence Yim 
> wrote:
> > > >
> > > >> Hi,
> > > >>
> > > >> If a jar is already available on the node, you can use
> > > >> TwillPreparer.withClasspath to include those to the container
> > classpath.
> > > >>
> > > >> Terence
> > > >>
> > > >> Sent from my iPhone
> > > >>
> > > >> > On Feb 14, 2017, at 6:32 PM, Yuliya Feldman 
> > > wrote:
> > > >> >
> > > >> > Hello there,
> > > >> >
> > > >> > I have a question regarding Bundled jar.
> > > >> >
> > > >> > Is there is anyway I could pick up some jar/config form the node
> > where
> > > >> it
> > > >> > is running so it is not prepackaged within bundled jar itself.
> > > >> >
> > > >> > Thanks
> > > >>
> > > >
> > > >
> > >
> >
>


Re: Bundled jar ability to pick up local jars

2017-02-15 Thread Yuliya Feldman
Already figured

Thanks,
Yuliya

On Wed, Feb 15, 2017 at 2:51 PM, Henry Saputra 
wrote:

> Hi Yuliya,
>
> With bundled jar approach you need to include all your dependencies in that
> app jar itself and the dependencies put in the "lib" directory specified by
> setLibFolder.
>
> For example:
> https://github.com/apache/twill/blob/2a8de333f4014fbcbcde826e507b9d
> 8810554ffc/twill-examples/yarn/src/main/java/org/apache/
> twill/example/yarn/
> BundledJarExample.java
>
> Here is the link to source that explain the format of the bundled jar:
>
> https://github.com/apache/twill/blob/2a8de333f4014fbcbcde826e507b9d
> 8810554ffc/twill-ext/src/main/java/org/apache/twill/ext/
> BundledJarRunner.java
>
>
> - Henry
>
> On Tue, Feb 14, 2017 at 11:25 PM, Yuliya Feldman 
> wrote:
>
> > Let me even further rephrase the question
> >
> > What should be the structure of bundled jar
> >
> > It feels like it should be classes of the main jar + lib folder with
> > additional jars - it can not be main jar + lib folder with jars, as in
> this
> > case main jar is not really loaded since it loads parent jar (one that is
> > defined as "bundled")
> >
> > Thanks
> >
> > On Tue, Feb 14, 2017 at 6:54 PM, Yuliya Feldman 
> wrote:
> >
> > >  Sorry,
> > >
> > > I probably was not clear. I understand that TwillContainer launcher
> will
> > > take classpath into consideration.
> > > I was more wondering about bundledjar loading - we load it in a
> separate
> > > classloader, so everything has to be included into bundled jar,
> otherwise
> > > it does not seem to work, as it will be missing dependencies - nothing
> is
> > > loaded outside of the jar itself.
> > >
> > > Thanks
> > >
> > > On Tue, Feb 14, 2017 at 6:39 PM, Terence Yim  wrote:
> > >
> > >> Hi,
> > >>
> > >> If a jar is already available on the node, you can use
> > >> TwillPreparer.withClasspath to include those to the container
> classpath.
> > >>
> > >> Terence
> > >>
> > >> Sent from my iPhone
> > >>
> > >> > On Feb 14, 2017, at 6:32 PM, Yuliya Feldman 
> > wrote:
> > >> >
> > >> > Hello there,
> > >> >
> > >> > I have a question regarding Bundled jar.
> > >> >
> > >> > Is there is anyway I could pick up some jar/config form the node
> where
> > >> it
> > >> > is running so it is not prepackaged within bundled jar itself.
> > >> >
> > >> > Thanks
> > >>
> > >
> > >
> >
>


Re: Bundled jar ability to pick up local jars

2017-02-15 Thread Henry Saputra
Hi Yuliya,

With bundled jar approach you need to include all your dependencies in that
app jar itself and the dependencies put in the "lib" directory specified by
setLibFolder.

For example:
https://github.com/apache/twill/blob/2a8de333f4014fbcbcde826e507b9d
8810554ffc/twill-examples/yarn/src/main/java/org/apache/twill/example/yarn/
BundledJarExample.java

Here is the link to source that explain the format of the bundled jar:

https://github.com/apache/twill/blob/2a8de333f4014fbcbcde826e507b9d8810554ffc/twill-ext/src/main/java/org/apache/twill/ext/BundledJarRunner.java


- Henry

On Tue, Feb 14, 2017 at 11:25 PM, Yuliya Feldman  wrote:

> Let me even further rephrase the question
>
> What should be the structure of bundled jar
>
> It feels like it should be classes of the main jar + lib folder with
> additional jars - it can not be main jar + lib folder with jars, as in this
> case main jar is not really loaded since it loads parent jar (one that is
> defined as "bundled")
>
> Thanks
>
> On Tue, Feb 14, 2017 at 6:54 PM, Yuliya Feldman  wrote:
>
> >  Sorry,
> >
> > I probably was not clear. I understand that TwillContainer launcher will
> > take classpath into consideration.
> > I was more wondering about bundledjar loading - we load it in a separate
> > classloader, so everything has to be included into bundled jar, otherwise
> > it does not seem to work, as it will be missing dependencies - nothing is
> > loaded outside of the jar itself.
> >
> > Thanks
> >
> > On Tue, Feb 14, 2017 at 6:39 PM, Terence Yim  wrote:
> >
> >> Hi,
> >>
> >> If a jar is already available on the node, you can use
> >> TwillPreparer.withClasspath to include those to the container classpath.
> >>
> >> Terence
> >>
> >> Sent from my iPhone
> >>
> >> > On Feb 14, 2017, at 6:32 PM, Yuliya Feldman 
> wrote:
> >> >
> >> > Hello there,
> >> >
> >> > I have a question regarding Bundled jar.
> >> >
> >> > Is there is anyway I could pick up some jar/config form the node where
> >> it
> >> > is running so it is not prepackaged within bundled jar itself.
> >> >
> >> > Thanks
> >>
> >
> >
>


Re: Bundled jar ability to pick up local jars

2017-02-14 Thread Yuliya Feldman
Let me even further rephrase the question

What should be the structure of bundled jar

It feels like it should be classes of the main jar + lib folder with
additional jars - it can not be main jar + lib folder with jars, as in this
case main jar is not really loaded since it loads parent jar (one that is
defined as "bundled")

Thanks

On Tue, Feb 14, 2017 at 6:54 PM, Yuliya Feldman  wrote:

>  Sorry,
>
> I probably was not clear. I understand that TwillContainer launcher will
> take classpath into consideration.
> I was more wondering about bundledjar loading - we load it in a separate
> classloader, so everything has to be included into bundled jar, otherwise
> it does not seem to work, as it will be missing dependencies - nothing is
> loaded outside of the jar itself.
>
> Thanks
>
> On Tue, Feb 14, 2017 at 6:39 PM, Terence Yim  wrote:
>
>> Hi,
>>
>> If a jar is already available on the node, you can use
>> TwillPreparer.withClasspath to include those to the container classpath.
>>
>> Terence
>>
>> Sent from my iPhone
>>
>> > On Feb 14, 2017, at 6:32 PM, Yuliya Feldman  wrote:
>> >
>> > Hello there,
>> >
>> > I have a question regarding Bundled jar.
>> >
>> > Is there is anyway I could pick up some jar/config form the node where
>> it
>> > is running so it is not prepackaged within bundled jar itself.
>> >
>> > Thanks
>>
>
>


Re: Bundled jar ability to pick up local jars

2017-02-14 Thread Yuliya Feldman
 Sorry,

I probably was not clear. I understand that TwillContainer launcher will
take classpath into consideration.
I was more wondering about bundledjar loading - we load it in a separate
classloader, so everything has to be included into bundled jar, otherwise
it does not seem to work, as it will be missing dependencies - nothing is
loaded outside of the jar itself.

Thanks

On Tue, Feb 14, 2017 at 6:39 PM, Terence Yim  wrote:

> Hi,
>
> If a jar is already available on the node, you can use
> TwillPreparer.withClasspath to include those to the container classpath.
>
> Terence
>
> Sent from my iPhone
>
> > On Feb 14, 2017, at 6:32 PM, Yuliya Feldman  wrote:
> >
> > Hello there,
> >
> > I have a question regarding Bundled jar.
> >
> > Is there is anyway I could pick up some jar/config form the node where it
> > is running so it is not prepackaged within bundled jar itself.
> >
> > Thanks
>


Re: Bundled jar ability to pick up local jars

2017-02-14 Thread Terence Yim
Hi,

If a jar is already available on the node, you can use 
TwillPreparer.withClasspath to include those to the container classpath.

Terence

Sent from my iPhone

> On Feb 14, 2017, at 6:32 PM, Yuliya Feldman  wrote:
> 
> Hello there,
> 
> I have a question regarding Bundled jar.
> 
> Is there is anyway I could pick up some jar/config form the node where it
> is running so it is not prepackaged within bundled jar itself.
> 
> Thanks


Bundled jar ability to pick up local jars

2017-02-14 Thread Yuliya Feldman
Hello there,

I have a question regarding Bundled jar.

Is there is anyway I could pick up some jar/config form the node where it
is running so it is not prepackaged within bundled jar itself.

Thanks