[jira] [Created] (UIMA-5964) null matchedText value in ConceptMapper when OrderIndependentLookup is false.

2019-01-17 Thread Francisco Abad (JIRA)
Francisco Abad created UIMA-5964:


 Summary: null matchedText value in ConceptMapper when 
OrderIndependentLookup is false.
 Key: UIMA-5964
 URL: https://issues.apache.org/jira/browse/UIMA-5964
 Project: UIMA
  Issue Type: Bug
  Components: addons
Affects Versions: ConceptMapper-2.10.2
Reporter: Francisco Abad
 Attachments: image-2019-01-17-09-30-51-818.png

I'm trying the concept mapper and I noted that the field relative to 
ResultingAnnotationMatchedTextFeature in the generated annotations was always 
null:

!image-2019-01-17-09-30-51-818.png!

I checked the source code and I figured out that this feature is loaded from a 
"unsorted" property from DictionaryResource_impl class, which is only 
initialized when the parameter "OrderIndependentLookup" is true. In this case, 
the matched text field is not null. I think "unsorted" should be initialized 
always to avoid this behavior.

Greetings,
Francisco Abad.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (UIMA-5964) null matchedText value in ConceptMapper when OrderIndependentLookup is false.

2019-01-17 Thread Francisco Abad (JIRA)


[ 
https://issues.apache.org/jira/browse/UIMA-5964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16744827#comment-16744827
 ] 

Francisco Abad commented on UIMA-5964:
--

I've created a pull request in github with a fix:
https://github.com/apache/uima-addons/pull/1

> null matchedText value in ConceptMapper when OrderIndependentLookup is false.
> -
>
> Key: UIMA-5964
> URL: https://issues.apache.org/jira/browse/UIMA-5964
> Project: UIMA
>  Issue Type: Bug
>  Components: addons
>Affects Versions: ConceptMapper-2.10.2
>Reporter: Francisco Abad
>Priority: Minor
>  Labels: easyfix
> Attachments: image-2019-01-17-09-30-51-818.png
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> I'm trying the concept mapper and I noted that the field relative to 
> ResultingAnnotationMatchedTextFeature in the generated annotations was always 
> null:
> !image-2019-01-17-09-30-51-818.png!
> I checked the source code and I figured out that this feature is loaded from 
> a "unsorted" property from DictionaryResource_impl class, which is only 
> initialized when the parameter "OrderIndependentLookup" is true. In this 
> case, the matched text field is not null. I think "unsorted" should be 
> initialized always to avoid this behavior.
> Greetings,
> Francisco Abad.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (UIMA-5963) UIMA-DUCC: parameterize client protocol handler retry timeout

2019-01-17 Thread Jerry Cwiklik (JIRA)


 [ 
https://issues.apache.org/jira/browse/UIMA-5963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jerry Cwiklik closed UIMA-5963.
---
Resolution: Fixed

Modified to allow application to customize number of retries and amount of time 
to sleep between retries when application has no tasks

> UIMA-DUCC: parameterize client protocol handler retry timeout
> -
>
> Key: UIMA-5963
> URL: https://issues.apache.org/jira/browse/UIMA-5963
> Project: UIMA
>  Issue Type: Improvement
>  Components: DUCC
>Reporter: Jerry Cwiklik
>Assignee: Jerry Cwiklik
>Priority: Major
> Fix For: 2.2.3-Ducc
>
>
> Currently, the client's protocol handler retry code which handles no tasks 
> available scenario uses hard coded values for retry count and wait time 
> between retries. Both of these params should be configurable by an 
> application. 
> Both the DuccServiceDriver and DuccServiceProtocolHandler expose initialize() 
> method with a single param of type Properties. Through this interface an 
> application can pass in both properties using new property names defined in 
> ServiceDriver class:
>  public static String DriverTaskRetryCount = "driver.task.retry.count";
>  public static String DriverTaskWaitTime = "driver.task.wait.time.millis";
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (UIMA-5960) UIMA-DUCC: Modify pull service client protocol handler wait strategy

2019-01-17 Thread Jerry Cwiklik (JIRA)


 [ 
https://issues.apache.org/jira/browse/UIMA-5960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jerry Cwiklik closed UIMA-5960.
---
Resolution: Duplicate

This issue is duplicate of https://issues.apache.org/jira/browse/UIMA-5963  

> UIMA-DUCC: Modify pull service client protocol handler wait strategy
> 
>
> Key: UIMA-5960
> URL: https://issues.apache.org/jira/browse/UIMA-5960
> Project: UIMA
>  Issue Type: Bug
>  Components: DUCC
>Reporter: Jerry Cwiklik
>Assignee: Jerry Cwiklik
>Priority: Major
> Fix For: 2.2.3-Ducc
>
>
> Pull service client protocol handler is not polling for tasks correctly. It 
> should poll N times and waiting for M seconds between retries. Expose both N 
> and M through a new API to allow for customized wait times.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (UIMA-5959) UIMA_DUCC: The DefaultNoTaskAvailableStrategy not accepting 0 in ctor

2019-01-17 Thread Jerry Cwiklik (JIRA)


 [ 
https://issues.apache.org/jira/browse/UIMA-5959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jerry Cwiklik closed UIMA-5959.
---
Resolution: Fixed

Modified to accept zero as a valid value and in such case no waiting is done

> UIMA_DUCC: The DefaultNoTaskAvailableStrategy not accepting 0 in ctor
> -
>
> Key: UIMA-5959
> URL: https://issues.apache.org/jira/browse/UIMA-5959
> Project: UIMA
>  Issue Type: Bug
>  Components: DUCC
>Reporter: Jerry Cwiklik
>Assignee: Jerry Cwiklik
>Priority: Major
> Fix For: 2.2.3-Ducc
>
>
> The DefaultNoTaskAvailableStrategy ignores 0 for waitTimeInSecs. It should 
> accept it to allow this code to not wait.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (UIMA-5964) null matchedText value in ConceptMapper when OrderIndependentLookup is false.

2019-01-17 Thread Marshall Schor (JIRA)


 [ 
https://issues.apache.org/jira/browse/UIMA-5964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marshall Schor reassigned UIMA-5964:


Assignee: Michael Tanenblatt

> null matchedText value in ConceptMapper when OrderIndependentLookup is false.
> -
>
> Key: UIMA-5964
> URL: https://issues.apache.org/jira/browse/UIMA-5964
> Project: UIMA
>  Issue Type: Bug
>  Components: addons
>Affects Versions: ConceptMapper-2.10.2
>Reporter: Francisco Abad
>Assignee: Michael Tanenblatt
>Priority: Minor
>  Labels: easyfix
> Attachments: image-2019-01-17-09-30-51-818.png
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> I'm trying the concept mapper and I noted that the field relative to 
> ResultingAnnotationMatchedTextFeature in the generated annotations was always 
> null:
> !image-2019-01-17-09-30-51-818.png!
> I checked the source code and I figured out that this feature is loaded from 
> a "unsorted" property from DictionaryResource_impl class, which is only 
> initialized when the parameter "OrderIndependentLookup" is true. In this 
> case, the matched text field is not null. I think "unsorted" should be 
> initialized always to avoid this behavior.
> Greetings,
> Francisco Abad.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)