[jira] [Commented] (UIMA-5964) null matchedText value in ConceptMapper when OrderIndependentLookup is false.
[ https://issues.apache.org/jira/browse/UIMA-5964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756524#comment-16756524 ] Marshall Schor commented on UIMA-5964: -- This would also increase the size of the dictionary entries when "sorted" was being used. > null matchedText value in ConceptMapper when OrderIndependentLookup is false. > - > > Key: UIMA-5964 > URL: https://issues.apache.org/jira/browse/UIMA-5964 > Project: UIMA > Issue Type: Bug > Components: addons >Affects Versions: ConceptMapper-2.10.2 >Reporter: Francisco Abad >Assignee: Michael Tanenblatt >Priority: Minor > Labels: easyfix > Attachments: image-2019-01-17-09-30-51-818.png > > Original Estimate: 1h > Remaining Estimate: 1h > > I'm trying the concept mapper and I noted that the field relative to > ResultingAnnotationMatchedTextFeature in the generated annotations was always > null: > !image-2019-01-17-09-30-51-818.png! > I checked the source code and I figured out that this feature is loaded from > a "unsorted" property from DictionaryResource_impl class, which is only > initialized when the parameter "OrderIndependentLookup" is true. In this > case, the matched text field is not null. I think "unsorted" should be > initialized always to avoid this behavior. > Greetings, > Francisco Abad. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (UIMA-5964) null matchedText value in ConceptMapper when OrderIndependentLookup is false.
[ https://issues.apache.org/jira/browse/UIMA-5964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16755310#comment-16755310 ] Marshall Schor commented on UIMA-5964: -- Hi Francisco, this fix may cost a performance hit; do you have any suggestions on how to mitigate that for users who do not need this? Would it be reasonable to add some kind of configuration parameter for this Annotator to control whether this is done? > null matchedText value in ConceptMapper when OrderIndependentLookup is false. > - > > Key: UIMA-5964 > URL: https://issues.apache.org/jira/browse/UIMA-5964 > Project: UIMA > Issue Type: Bug > Components: addons >Affects Versions: ConceptMapper-2.10.2 >Reporter: Francisco Abad >Assignee: Michael Tanenblatt >Priority: Minor > Labels: easyfix > Attachments: image-2019-01-17-09-30-51-818.png > > Original Estimate: 1h > Remaining Estimate: 1h > > I'm trying the concept mapper and I noted that the field relative to > ResultingAnnotationMatchedTextFeature in the generated annotations was always > null: > !image-2019-01-17-09-30-51-818.png! > I checked the source code and I figured out that this feature is loaded from > a "unsorted" property from DictionaryResource_impl class, which is only > initialized when the parameter "OrderIndependentLookup" is true. In this > case, the matched text field is not null. I think "unsorted" should be > initialized always to avoid this behavior. > Greetings, > Francisco Abad. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (UIMA-5964) null matchedText value in ConceptMapper when OrderIndependentLookup is false.
[ https://issues.apache.org/jira/browse/UIMA-5964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748829#comment-16748829 ] Marshall Schor commented on UIMA-5964: -- Michael Tanenblatt commented on the pull request, copied here: After going through the code manually, it does appear that the proposed change should do the right thing. I’ve been trying to figure out why that was never a reported problem, but I guess it was because when not using sorting, the array of matched tokens can be consulted to compute the matched string. Making this change would therefore be a reasonable convenience. > null matchedText value in ConceptMapper when OrderIndependentLookup is false. > - > > Key: UIMA-5964 > URL: https://issues.apache.org/jira/browse/UIMA-5964 > Project: UIMA > Issue Type: Bug > Components: addons >Affects Versions: ConceptMapper-2.10.2 >Reporter: Francisco Abad >Assignee: Michael Tanenblatt >Priority: Minor > Labels: easyfix > Attachments: image-2019-01-17-09-30-51-818.png > > Original Estimate: 1h > Remaining Estimate: 1h > > I'm trying the concept mapper and I noted that the field relative to > ResultingAnnotationMatchedTextFeature in the generated annotations was always > null: > !image-2019-01-17-09-30-51-818.png! > I checked the source code and I figured out that this feature is loaded from > a "unsorted" property from DictionaryResource_impl class, which is only > initialized when the parameter "OrderIndependentLookup" is true. In this > case, the matched text field is not null. I think "unsorted" should be > initialized always to avoid this behavior. > Greetings, > Francisco Abad. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (UIMA-5964) null matchedText value in ConceptMapper when OrderIndependentLookup is false.
[ https://issues.apache.org/jira/browse/UIMA-5964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16744827#comment-16744827 ] Francisco Abad commented on UIMA-5964: -- I've created a pull request in github with a fix: https://github.com/apache/uima-addons/pull/1 > null matchedText value in ConceptMapper when OrderIndependentLookup is false. > - > > Key: UIMA-5964 > URL: https://issues.apache.org/jira/browse/UIMA-5964 > Project: UIMA > Issue Type: Bug > Components: addons >Affects Versions: ConceptMapper-2.10.2 >Reporter: Francisco Abad >Priority: Minor > Labels: easyfix > Attachments: image-2019-01-17-09-30-51-818.png > > Original Estimate: 1h > Remaining Estimate: 1h > > I'm trying the concept mapper and I noted that the field relative to > ResultingAnnotationMatchedTextFeature in the generated annotations was always > null: > !image-2019-01-17-09-30-51-818.png! > I checked the source code and I figured out that this feature is loaded from > a "unsorted" property from DictionaryResource_impl class, which is only > initialized when the parameter "OrderIndependentLookup" is true. In this > case, the matched text field is not null. I think "unsorted" should be > initialized always to avoid this behavior. > Greetings, > Francisco Abad. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
