[jira] [Commented] (UIMA-6185) Upgrade parent POM plugins
[ https://issues.apache.org/jira/browse/UIMA-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17080638#comment-17080638 ] Richard Eckart de Castilho commented on UIMA-6185: -- So, how shall we proceed here? As far as I can tell, nobody else provided an opinion on the mailing list... > Upgrade parent POM plugins > -- > > Key: UIMA-6185 > URL: https://issues.apache.org/jira/browse/UIMA-6185 > Project: UIMA > Issue Type: Improvement > Components: Build, Packaging and Test >Reporter: Richard Eckart de Castilho >Assignee: Richard Eckart de Castilho >Priority: Minor > Fix For: parent-pom-14 > > > * upgrade to Apache parent POM 23 > * upgrade Maven plugin versions where feasible -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (UIMA-6185) Upgrade parent POM plugins
[ https://issues.apache.org/jira/browse/UIMA-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029947#comment-17029947 ] Marshall Schor commented on UIMA-6185: -- That comment was just to document which maven plugins versions we were inheriting from the apache-wide pom. We always have a choice *not* to update the parent-pom of the uima-wide pom, to avoid checking if it's ok to update these. If people didn't want to do that work, it would seem the right answer would be to not update the parent-pom. I agree that if there was a use case, where (a) we needed to update to the current apache-wide pom as the parent, but (b) didn't want to change the version numbers of the maven plugins we were using, then we could lock these down in the uima-wide pom. But I don't think we have that use case... ? I would have thought the reason to upgrade to the more recent apache-wide pom was to "pickup" the updates to the maven plugin tooling. > Upgrade parent POM plugins > -- > > Key: UIMA-6185 > URL: https://issues.apache.org/jira/browse/UIMA-6185 > Project: UIMA > Issue Type: Improvement > Components: Build, Packaging and Test >Reporter: Richard Eckart de Castilho >Assignee: Richard Eckart de Castilho >Priority: Minor > Fix For: parent-pom-14 > > > * upgrade to Apache parent POM 23 > * upgrade Maven plugin versions where feasible -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (UIMA-6185) Upgrade parent POM plugins
[
https://issues.apache.org/jira/browse/UIMA-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029912#comment-17029912
]
Richard Eckart de Castilho commented on UIMA-6185:
--
In the current parent POM, we have this comment:
{code}
{code}
I don't know, but it seems redundant and tedious to lumber through that when
updating the ASF parent POM version that our parent POM inherits from when we
can as well defined the plugins locally and lock them down - placing any
comments we might have right next to the respectively locked down version.
> Upgrade parent POM plugins
> --
>
> Key: UIMA-6185
> URL: https://issues.apache.org/jira/browse/UIMA-6185
> Project: UIMA
> Issue Type: Improvement
> Components: Build, Packaging and Test
>Reporter: Richard Eckart de Castilho
>Assignee: Richard Eckart de Castilho
>Priority: Minor
> Fix For: parent-pom-14
>
>
> * upgrade to Apache parent POM 23
> * upgrade Maven plugin versions where feasible
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (UIMA-6185) Upgrade parent POM plugins
[ https://issues.apache.org/jira/browse/UIMA-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029903#comment-17029903 ] Marshall Schor commented on UIMA-6185: -- I agree the git tooling supporting branches and reviews are nicer than doing things in SVN :) > Upgrade parent POM plugins > -- > > Key: UIMA-6185 > URL: https://issues.apache.org/jira/browse/UIMA-6185 > Project: UIMA > Issue Type: Improvement > Components: Build, Packaging and Test >Reporter: Richard Eckart de Castilho >Assignee: Richard Eckart de Castilho >Priority: Minor > Fix For: parent-pom-14 > > > * upgrade to Apache parent POM 23 > * upgrade Maven plugin versions where feasible -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (UIMA-6185) Upgrade parent POM plugins
[ https://issues.apache.org/jira/browse/UIMA-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029896#comment-17029896 ] Marshall Schor commented on UIMA-6185: -- I agree that for a repeatable build, all versions should be locked down at some level. Individual projects can decide when to use a new plugin version, in their individual POM. But I think for many projects, they would rather let these progress as common shared POMs are updated. The uima-wide pom factors out some common things. It has a dependency on a specific version of the apache-wide pom. So when that dependency is updated, it is "locked down" in the sense that the builds are repeatable. For maven plugins, I think it is preferable to occasionally have these updated to the apache-wide current versions, because these keep up to date with the (slowly) evolving maven ecosystem. Re: transparency: I was thinking this proposal should have been called out for discussion explicitly in the dev list (I've done that...). I continue to feel that we should be flexible on the PR/review model vs commit to master. I agree with you that for significant changes, the PR/review model is appropriate, provided there's someone suitable willing and able to do a good review job :) . I continue to feel that for small / trivial changes, no review is needed, when the likelyhood of needing to roll back is small. > Upgrade parent POM plugins > -- > > Key: UIMA-6185 > URL: https://issues.apache.org/jira/browse/UIMA-6185 > Project: UIMA > Issue Type: Improvement > Components: Build, Packaging and Test >Reporter: Richard Eckart de Castilho >Assignee: Richard Eckart de Castilho >Priority: Minor > Fix For: parent-pom-14 > > > * upgrade to Apache parent POM 23 > * upgrade Maven plugin versions where feasible -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (UIMA-6185) Upgrade parent POM plugins
[ https://issues.apache.org/jira/browse/UIMA-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029890#comment-17029890 ] Richard Eckart de Castilho commented on UIMA-6185: -- Not that we wouldn't have discussed changes with the old model, but if felt much more optional. I would have preferred to branch in git and do a proper PR rather than branching in svn though ;) > Upgrade parent POM plugins > -- > > Key: UIMA-6185 > URL: https://issues.apache.org/jira/browse/UIMA-6185 > Project: UIMA > Issue Type: Improvement > Components: Build, Packaging and Test >Reporter: Richard Eckart de Castilho >Assignee: Richard Eckart de Castilho >Priority: Minor > Fix For: parent-pom-14 > > > * upgrade to Apache parent POM 23 > * upgrade Maven plugin versions where feasible -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (UIMA-6185) Upgrade parent POM plugins
[ https://issues.apache.org/jira/browse/UIMA-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029872#comment-17029872 ] Richard Eckart de Castilho commented on UIMA-6185: -- IMHO for a repeatable build, all versions should be locked down at some level. IMHO we should decide when to use a new plugin version, not the plugin provider. We also lock down dependency versions, right? A comment would be warranted if there is a specific reason to stay at a particular version rather than allowing upgrading to the latest version. I'd rather lock them down at a level we control than at a level we do not control - but my opinion about that is not too strong. Regarding transparency: this is why I much prefer the PR/review model instead of the commit-to-master-and-maybe-discuss-later model because review **is** build-in. Had we not been using the PR/review model, I may never have made/proposed these changes. > Upgrade parent POM plugins > -- > > Key: UIMA-6185 > URL: https://issues.apache.org/jira/browse/UIMA-6185 > Project: UIMA > Issue Type: Improvement > Components: Build, Packaging and Test >Reporter: Richard Eckart de Castilho >Assignee: Richard Eckart de Castilho >Priority: Minor > Fix For: parent-pom-14 > > > * upgrade to Apache parent POM 23 > * upgrade Maven plugin versions where feasible -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (UIMA-6185) Upgrade parent POM plugins
[ https://issues.apache.org/jira/browse/UIMA-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029855#comment-17029855 ] Marshall Schor commented on UIMA-6185: -- I think these kinds of proposals/changes should be discussed more transparently. It seems to me that locking down versions is only (historically) needed very occasionally. If a version needs to be locked down, I would rather see it done at the project level, rather than at a uima-wide level, unless there is a known issue that affects everything. And then, for those issues, I would suggest a big comment in the file locking it down, pointing to the reasons ( a Jira issue or other explanation) as to why this is being done. So my view is not to lock these down in the uima-wide pom, unless we know of a requirement that spans all (or at least most) of our projects. Other views pro / con ? > Upgrade parent POM plugins > -- > > Key: UIMA-6185 > URL: https://issues.apache.org/jira/browse/UIMA-6185 > Project: UIMA > Issue Type: Improvement > Components: Build, Packaging and Test >Reporter: Richard Eckart de Castilho >Assignee: Richard Eckart de Castilho >Priority: Minor > Fix For: parent-pom-14 > > > * upgrade to Apache parent POM 23 > * upgrade Maven plugin versions where feasible -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (UIMA-6185) Upgrade parent POM plugins
[ https://issues.apache.org/jira/browse/UIMA-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029660#comment-17029660 ] Richard Eckart de Castilho commented on UIMA-6185: -- I added version locks for everything so we don't always have to look at the upstream POM or effective POM to see/set what version of a plugin we are using. It is true, it was not like this before. There are pro/cons for both approaches. Consider it a proposal ;) > Upgrade parent POM plugins > -- > > Key: UIMA-6185 > URL: https://issues.apache.org/jira/browse/UIMA-6185 > Project: UIMA > Issue Type: Improvement > Components: Build, Packaging and Test >Reporter: Richard Eckart de Castilho >Assignee: Richard Eckart de Castilho >Priority: Minor > Fix For: parent-pom-14 > > > * upgrade to Apache parent POM 23 > * upgrade Maven plugin versions where feasible -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (UIMA-6185) Upgrade parent POM plugins
[ https://issues.apache.org/jira/browse/UIMA-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029302#comment-17029302 ] Marshall Schor commented on UIMA-6185: -- The apache-wide pom v 23 has plugin-management entries for many of the plugins that were added to the uima-wide pom. Aren't these redundant? Example: the apache-wide pom has maven-remote-resources-plugin at v 1.7.0, and this was also added to the uima-wide pom. There are others, too... It seems we should remove these from the uima-wide pom, unless we're trying to "lock down" the versions at that level, which I didn't think we were? > Upgrade parent POM plugins > -- > > Key: UIMA-6185 > URL: https://issues.apache.org/jira/browse/UIMA-6185 > Project: UIMA > Issue Type: Improvement > Components: Build, Packaging and Test >Reporter: Richard Eckart de Castilho >Assignee: Richard Eckart de Castilho >Priority: Minor > Fix For: parent-pom-14 > > > * upgrade to Apache parent POM 23 > * upgrade Maven plugin versions where feasible -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (UIMA-6185) Upgrade parent POM plugins
[ https://issues.apache.org/jira/browse/UIMA-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029266#comment-17029266 ] Marshall Schor commented on UIMA-6185: -- Started review > Upgrade parent POM plugins > -- > > Key: UIMA-6185 > URL: https://issues.apache.org/jira/browse/UIMA-6185 > Project: UIMA > Issue Type: Improvement > Components: Build, Packaging and Test >Reporter: Richard Eckart de Castilho >Assignee: Richard Eckart de Castilho >Priority: Minor > Fix For: parent-pom-14 > > > * upgrade to Apache parent POM 23 > * upgrade Maven plugin versions where feasible -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (UIMA-6185) Upgrade parent POM plugins
[ https://issues.apache.org/jira/browse/UIMA-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028489#comment-17028489 ] Richard Eckart de Castilho commented on UIMA-6185: -- Build uima-uimaj with these changes. Installed Eclipse plugins into fresh Eclipse 12-2019. Started CVD. Looks reasonable. > Upgrade parent POM plugins > -- > > Key: UIMA-6185 > URL: https://issues.apache.org/jira/browse/UIMA-6185 > Project: UIMA > Issue Type: Improvement > Components: Build, Packaging and Test >Reporter: Richard Eckart de Castilho >Assignee: Richard Eckart de Castilho >Priority: Minor > Fix For: parent-pom-14 > > > * upgrade to Apache parent POM 23 > * upgrade Maven plugin versions where feasible -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (UIMA-6185) Upgrade parent POM plugins
[ https://issues.apache.org/jira/browse/UIMA-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028488#comment-17028488 ] Richard Eckart de Castilho commented on UIMA-6185: -- [~schor] I have staged the changes here: https://svn.apache.org/repos/asf/uima/build/branches/UIMA-6185-Upgrade-parent-POM-plugins > Upgrade parent POM plugins > -- > > Key: UIMA-6185 > URL: https://issues.apache.org/jira/browse/UIMA-6185 > Project: UIMA > Issue Type: Improvement > Components: Build, Packaging and Test >Reporter: Richard Eckart de Castilho >Assignee: Richard Eckart de Castilho >Priority: Minor > Fix For: parent-pom-14 > > > * upgrade to Apache parent POM 23 > * upgrade Maven plugin versions where feasible -- This message was sent by Atlassian Jira (v8.3.4#803005)
