Re: [VOTE] Release Apache Uniffle (Incubating) 0.7.0-rc1

2023-02-28 Thread Kaijie Chen
-1 (non-binding)

There is a unexpected `pom.xml.versionsBackup` in the source directory.
And the version inside it is `0.7.0-snapshot`.

I have checked:

* Download links, checksums and PGP signatures are valid.
* Source code distributions have correct names matching the current release.
* Release files have the word incubating in their name.
* DISCLAIMER, LICENSE and NOTICE files are correct.
* All files have license headers if necessary.
* No unlicensed compiled archives bundled in source archive.
* The source tarball matches the git tag.
* Build from source is successful, with all major profiles.

Best,
Kaijie

On 2023/03/01 02:40:24 Junfan Zhang wrote:
> Hi Uniffle community,
> 
> This is a call for vote to release Apache Uniffle (Incubating) 0.7.0-rc1
> 
> Comparing to 0.6.1, a bug fix of memory leak is included:
> https://github.com/apache/incubator-uniffle/compare/v0.6.1..v0.7.0-rc1
> 
> The git tag to be voted upon:
> https://github.com/apache/incubator-uniffle/tree/v0.7.0-rc1
> 
> The git commit hash:
> 28ff211e32baa1c1a731628594144794400568d5
> 
> The source tarballs can be found at:
> https://dist.apache.org/repos/dist/dev/incubator/uniffle/0.7.0-rc1/
> 
> Fingerprint of the PGP key release artifacts are signed with:
> 0CF4889DD77BDD442FAE334495A12D262CEB34D0
> 
> My public key to verify signatures can be found in:
> https://dist.apache.org/repos/dist/dev/incubator/uniffle/KEYS
> 
> The vote will be open for at least 72 hours or until necessary
> number of votes are reached.
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and the reason)
> 
> Checklist for release:
> 
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> Steps to validate the release:
> https://linkis.apache.org/community/how-to-verify
> 
> Starting with my +1 (non-binding):
> 
> * Download links, checksums and PGP signatures are valid.
> * Source code distributions have correct names matching the current release.
> * Release files have the word incubating in their name.
> * DISCLAIMER, LICENSE and NOTICE files are correct.
> * All files have license headers if necessary.
> * No unlicensed compiled archives bundled in source archive.
> * The source tarball matches the git tag.
> * Build from source is successful, Uniffle CI passed. [1]
> 
> Thanks,
> Junfan Zhang
> 
> ---
> [1]: https://github.com/apache/incubator-uniffle/actions/runs/4292488539
> 


Re: [VOTE] Release Apache Uniffle (Incubating) 0.7.0-rc1

2023-02-28 Thread roryqi
Have you run uts in your local machine?
I run `mvn package` twice. They all failed.
Maybe we should cherrypick test fix to branch 0.7.
https://github.com/apache/incubator-uniffle/issues/408
https://github.com/apache/incubator-uniffle/issues/612


Re: [VOTE] Release Apache Uniffle (Incubating) 0.7.0-rc1

2023-03-01 Thread Kaijie Chen
PS: please remove all `**/pom.xml.versionsBackup` files introduced in this 
commit.

https://github.com/apache/incubator-uniffle/commit/28ff211e32baa1c1a731628594144794400568d5

On 2023/03/01 06:25:28 roryqi wrote:
> Have you run uts in your local machine?
> I run `mvn package` twice. They all failed.
> Maybe we should cherrypick test fix to branch 0.7.
> https://github.com/apache/incubator-uniffle/issues/408
> https://github.com/apache/incubator-uniffle/issues/612
> 


Re: [VOTE] Release Apache Uniffle (Incubating) 0.7.0-rc1

2023-03-06 Thread zhang junfan
Let me cancel this vote and I will raise another version of rc2 to fix above 
problems.

Best
Junfan Zhang

From: Kaijie Chen 
Sent: Wednesday, March 1, 2023 4:57:15 PM
To: dev@uniffle.apache.org 
Subject: Re: [VOTE] Release Apache Uniffle (Incubating) 0.7.0-rc1

PS: please remove all `**/pom.xml.versionsBackup` files introduced in this 
commit.

https://github.com/apache/incubator-uniffle/commit/28ff211e32baa1c1a731628594144794400568d5

On 2023/03/01 06:25:28 roryqi wrote:
> Have you run uts in your local machine?
> I run `mvn package` twice. They all failed.
> Maybe we should cherrypick test fix to branch 0.7.
> https://github.com/apache/incubator-uniffle/issues/408
> https://github.com/apache/incubator-uniffle/issues/612
>