Re: Fixing build issues in 1.x but not 2.x
VELOCITY-862 would probably still apply to the 2.x branch, i suspect. Moving on with 1.8 sounds sensible to me. On Tue, Jun 2, 2015 at 7:46 PM, Mike Kienenberger wrote: > I hope it's not a problem, but I'm only applying the build process > fixes to the 1.x branch and not the 2.x branch. > > My thinking is that the work has most likely already been done on 2.x, > and I'm also not sure I have the time to invest in the 2.x branch. > > If you see something that you think I should also apply to 2.x, let me > know, and I'll try to find time to make it happen -- or apply it > yourself. > > I know we have 1.7.1 as a potential release candidate, but I think we > should skip it and start with a 1.8 release. As an end-user, I would > expect 1.7.1 to be built with the same tools as 1.7, and I doubt any > of us have java 1.4 installed any longer. > > - > To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org > For additional commands, e-mail: dev-h...@velocity.apache.org > >
Re: 1.8-SNAPSHOT as version for 1.x pom.xml?
When it's more work to open the issue than fix it, just fix it. :) On Tue, Jun 2, 2015 at 7:57 PM, Mike Kienenberger wrote: > Do you think we need to open issues for trivial obviously-broken build > issues like this? > > I'm going to guess no. > > On Tue, Jun 2, 2015 at 10:56 PM, Sergiu Dumitriu > wrote: > > 1.7 is definitely wrong, since a non -SNAPSHOT version should only be > > present in a tagged release. So yes, that needs to be changed. > > > > On 06/02/2015 10:52 PM, Mike Kienenberger wrote: > >> My maven knowledge is tragically small. > >> Do we need to make the following change for the 1.x pom.xml? > >> > >> Index: pom.xml > >> === > >> --- pom.xml(revision 1683209) > >> +++ pom.xml(working copy) > >> @@ -33,7 +33,7 @@ > >> > >>org.apache.velocity > >>velocity > >> - 1.7 > >> + 1.8-SNAPSHOT > >> > >>Apache Velocity > >>http://velocity.apache.org/engine/devel/ > >> > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org > >> For additional commands, e-mail: dev-h...@velocity.apache.org > >> > > > > > > -- > > Sergiu Dumitriu > > http://purl.org/net/sergiu/ > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org > > For additional commands, e-mail: dev-h...@velocity.apache.org > > > > - > To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org > For additional commands, e-mail: dev-h...@velocity.apache.org > >
[jira] [Reopened] (VELOCITY-862) Rebuilding parser using javacc 4.1 loses Node import
[ https://issues.apache.org/jira/browse/VELOCITY-862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Kienenberger reopened VELOCITY-862: Reopening at Nathan's suggestion that we may want to apply this to 2.x > Rebuilding parser using javacc 4.1 loses Node import > > > Key: VELOCITY-862 > URL: https://issues.apache.org/jira/browse/VELOCITY-862 > Project: Velocity > Issue Type: Improvement > Components: Build >Reporter: Mike Kienenberger >Assignee: Mike Kienenberger > Fix For: 1.x > > Attachments: build.xml-parser-imports-v3.patch > > > JavaCC 4.2 loses the "org.apache.velocity.runtime.parser.node.Node" import > for JJTParserState.java when rebuilding the parser. > Adding nodepackage="org.apache.velocity.runtime.parser.node" to the jjtree > ant task in the build script will add the following import automatically > which is better than no import or manually adding the import later: > import org.apache.velocity.runtime.parser.*; -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
