[GitHub] [velocity-tools] michael-o commented on pull request #15: VELOCITY-942 - VelocityViewServlet extending from jakarta.servlet instead of javax.servlet
michael-o commented on PR #15: URL: https://github.com/apache/velocity-tools/pull/15#issuecomment-1633095679 I can easily explain why I have immediate closed this out: Before opening a PR for such a high-impact change I would expect a discussion in the JIRA issue about a possible solution for everyone. You just dropping off this PR which solves *your* problem by changing the code in main leaving *everyone else* behind which do rely on `javax` namespace for the years to come. This is not acceptable. I totally understand that people including you want to make use of `jakarta` namespace, but this is not the right approach. @ppodgorsek This is zero modernization Velocity, it is merely a namespace change, that's it. Make a reasonable proposal and I will have a look at this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
[jira] [Moved] (VELTOOLS-202) VelocityViewServlet extending from jakarta.servlet instead of javax.servlet
[ https://issues.apache.org/jira/browse/VELTOOLS-202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov moved VELOCITY-942 to VELTOOLS-202: -- Component/s: VelocityView (was: Engine) Key: VELTOOLS-202 (was: VELOCITY-942) Project: Velocity Tools (was: Velocity) > VelocityViewServlet extending from jakarta.servlet instead of javax.servlet > --- > > Key: VELTOOLS-202 > URL: https://issues.apache.org/jira/browse/VELTOOLS-202 > Project: Velocity Tools > Issue Type: New Feature > Components: VelocityView >Reporter: David Ruiz de Azua >Priority: Trivial > > To whom may concern, > Currently VelocityViewServlet extends from javax rather than jakarta. > Due the cutover from Java to Jakarta, *is there any plan to make Apache > Velocity compatible with Servlet 5.0?* > Not sure if there are any plans to make the transition to Jakarta namespace > and if there is any ETA for it. > [https://jakarta.ee/specifications/servlet/5.0/apidocs/jakarta/servlet/http/httpservlet] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
[GitHub] [velocity-tools] ppodgorsek commented on pull request #15: VELOCITY-942 - VelocityViewServlet extending from jakarta.servlet instead of javax.servlet
ppodgorsek commented on PR #15: URL: https://github.com/apache/velocity-tools/pull/15#issuecomment-1632979410 @michael-o Can you explain why modernising Velocity to use Jakarta is a joke for you? It's not right to expect all downstream projects to use the Tomcat migration tool when this issue can be easily fixed centrally in Velocity. If Velocity is never updated, should the community consider that it's part of the Apache attic? I'm more than happy to switch to Thymeleaf if that's the attitude we get when trying to contribute to make a project more usable. Besides, it would be good to also keep the issue tracker up-to-date with explanations there too, that's the basics. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
[GitHub] [velocity-tools] ChristopherSchultz commented on pull request #15: VELOCITY-942 - VelocityViewServlet extending from jakarta.servlet instead of javax.servlet
ChristopherSchultz commented on PR #15: URL: https://github.com/apache/velocity-tools/pull/15#issuecomment-1632889781 I think it's totally serious. IMO, VelocityTools needs a branch (or main) to migrate to Jakarta EE. Not everybody is going to let their web applications languish forever. At $work we are planning our migrations and for the time being we are looking at relying on Tomcat's Migration Tool for projects like Velocity-Tools that don't appear to have any plans to produce compatible versions. That's not a good long-term solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
[GitHub] [velocity-tools] michael-o commented on pull request #15: VELOCITY-942 - VelocityViewServlet extending from jakarta.servlet instead of javax.servlet
michael-o commented on PR #15: URL: https://github.com/apache/velocity-tools/pull/15#issuecomment-1632855512 This can't be serious -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
[GitHub] [velocity-tools] michael-o closed pull request #15: VELOCITY-942 - VelocityViewServlet extending from jakarta.servlet instead of javax.servlet
michael-o closed pull request #15: VELOCITY-942 - VelocityViewServlet extending from jakarta.servlet instead of javax.servlet URL: https://github.com/apache/velocity-tools/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
[GitHub] [velocity-tools] ppodgorsek opened a new pull request, #15: VELOCITY-942 - VelocityViewServlet extending from jakarta.servlet instead of javax.servlet
ppodgorsek opened a new pull request, #15: URL: https://github.com/apache/velocity-tools/pull/15 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
