[jira] [Comment Edited] (VELTOOLS-202) VelocityViewServlet extending from jakarta.servlet instead of javax.servlet
[ https://issues.apache.org/jira/browse/VELTOOLS-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805082#comment-17805082 ] Martin Tzvetanov Grigorov edited comment on VELTOOLS-202 at 1/10/24 11:33 AM: -- OK, we have a progress on the technical part! Let's continue! Which module has been renamed ? In https://github.com/apache/velocity-tools/pull/15/files I don't see renamed (Maven?!) module. I see updated Maven dependencies and updated Java imports. This matches with my idea of having two branches - one for javax and one for jakarta. The contributor offered a PR against `master` branch. Here any Velocity maintainer can create a branch for Javax from master before merging this PR and use this new branch for Javax releases and use master for Jakarta releases. The (Maven) version in the PR should be updated to 4.0-SNAPSHOT too. Later when there is a fix/improvement in either branches the maintainers could easily use `git cherry-pick -x someSHA` to port the commit to the other branch, if needed. If the cherry-pick fails then some manual work may be needed! It is a small effort! But the maintainer could always ask the contributor to open a second PR for the other branch if the effort is bigger! The release manager will have to make two releases until there are users for Javax but this is how it is. Again I think this is little extra work! You can also explain how you think it should be done and hopefully someone will do it one day! was (Author: mgrigorov): OK, we have a progress on the technical part! Let's continue! Which module has been renamed ? In https://github.com/apache/velocity-tools/pull/15/files I don't see renamed (Maven?!) module. I see updated Maven dependencies and updated Java imports. This matches with my idea of having two branches - one for javax and one for jakarta. The contributor offered a PR against `master` branch. Here any Velocity maintainer can create a branch for Javax from master before merging this PR and use this new branch for Javax releases and use master for Jakarta releases. The Maven version in the PR should be updated to 4.0-SNAPSHOT too. Later when there is a fix/improvement in either branches the maintainers could easily use `git cherry-pick -x someSHA` to port the commit to the other branch, if needed. If the cherry-pick fails then some manual work may be needed! It is a small effort! But the maintainer could always ask the contributor to open a second PR for the other branch if the effort is bigger! The release manager will have to make two releases until there are users for Javax but this is how it is. Again I think this is little extra work! You can also explain how you think it should be done and hopefully someone will do it one day! > VelocityViewServlet extending from jakarta.servlet instead of javax.servlet > --- > > Key: VELTOOLS-202 > URL: https://issues.apache.org/jira/browse/VELTOOLS-202 > Project: Velocity Tools > Issue Type: New Feature > Components: VelocityView >Reporter: David Ruiz de Azua >Priority: Trivial > > To whom may concern, > Currently VelocityViewServlet extends from javax rather than jakarta. > Due the cutover from Java to Jakarta, *is there any plan to make Apache > Velocity compatible with Servlet 5.0?* > Not sure if there are any plans to make the transition to Jakarta namespace > and if there is any ETA for it. > [https://jakarta.ee/specifications/servlet/5.0/apidocs/jakarta/servlet/http/httpservlet] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
[jira] [Commented] (VELTOOLS-202) VelocityViewServlet extending from jakarta.servlet instead of javax.servlet
[ https://issues.apache.org/jira/browse/VELTOOLS-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805082#comment-17805082 ] Martin Tzvetanov Grigorov commented on VELTOOLS-202: OK, we have a progress on the technical part! Let's continue! Which module has been renamed ? In https://github.com/apache/velocity-tools/pull/15/files I don't see renamed (Maven?!) module. I see updated Maven dependencies and updated Java imports. This matches with my idea of having two branches - one for javax and one for jakarta. The contributor offered a PR against `master` branch. Here any Velocity maintainer can create a branch for Javax from master before merging this PR and use this new branch for Javax releases and use master for Jakarta releases. The Maven version in the PR should be updated to 4.0-SNAPSHOT too. Later when there is a fix/improvement in either branches the maintainers could easily use `git cherry-pick -x someSHA` to port the commit to the other branch, if needed. If the cherry-pick fails then some manual work may be needed! It is a small effort! But the maintainer could always ask the contributor to open a second PR for the other branch if the effort is bigger! The release manager will have to make two releases until there are users for Javax but this is how it is. Again I think this is little extra work! You can also explain how you think it should be done and hopefully someone will do it one day! > VelocityViewServlet extending from jakarta.servlet instead of javax.servlet > --- > > Key: VELTOOLS-202 > URL: https://issues.apache.org/jira/browse/VELTOOLS-202 > Project: Velocity Tools > Issue Type: New Feature > Components: VelocityView >Reporter: David Ruiz de Azua >Priority: Trivial > > To whom may concern, > Currently VelocityViewServlet extends from javax rather than jakarta. > Due the cutover from Java to Jakarta, *is there any plan to make Apache > Velocity compatible with Servlet 5.0?* > Not sure if there are any plans to make the transition to Jakarta namespace > and if there is any ETA for it. > [https://jakarta.ee/specifications/servlet/5.0/apidocs/jakarta/servlet/http/httpservlet] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
Re: untying the javax->jakarta knot, anyone?
On 2024/01/10 10:15:27 Gernot Hueller wrote: > > Hello all, > > VelocityTools (VelocityViewServlet and friends) reference Servlet API and > that was stripped of any "Java" label not to violate Oracle's trademark > (https://www.theserverside.com/blog/Coffee-Talk-Java-News-Stories-and-Opinions/Re-introducing-Jakarta-EE-Eclipse-takes-Java-EE-back-to-its-roots) > the package change was introduced with Jakarta Servlet 5.0 from October 2020 > (https://en.wikipedia.org/wiki/Jakarta_Servlet) > Velocity-tools however is still stuck in servlet APi 3.1 (from May 2013) > (https://velocity.apache.org/tools/3.1/changes.html) > > 3 years without action is too long. Somehow, this change must be addressed. > Not doing anything would indicate to users that velocity is dead and users > would look for other solutions. > So, what could be done? We are short in committers, that's a fact. It is more or less Claude and me, effectively. > I personally like "the log4j2 solution": two separate maven artefacts, user > chooses if he wants "this or that" package name (see > https://logging.apache.org/log4j/2.x/manual/webapp.html) > IDK how they build it (switch package names in source code? clone code?) but > maybe the same approach could be used for VelocityTools? This is my preference as well, two modules. Maybe a common module as a dep to avoid duplication, but that can be only decided after an evaluation. > I could even imagine to leave old servlet API totally behind. Whoever needs > old servlet stays on tools 3.1 (or, if any bugfix, 3.1.1), others move on. Me not because javax namespace will live for many for many years for a lot of reasons. I don't see a reason not to support it. As Mark Thomas said: Tomcat 9.x will be supported for as long as there is demand for it and likely other Servlet containers. Are you interesting to work on this, if yes? What would be your plan? I'd be willing to discuss your idea and review it. M - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
untying the javax->jakarta knot, anyone?
Hello all, VelocityTools (VelocityViewServlet and friends) reference Servlet API and that was stripped of any "Java" label not to violate Oracle's trademark (https://www.theserverside.com/blog/Coffee-Talk-Java-News-Stories-and-Opinions/Re-introducing-Jakarta-EE-Eclipse-takes-Java-EE-back-to-its-roots) the package change was introduced with Jakarta Servlet 5.0 from October 2020 (https://en.wikipedia.org/wiki/Jakarta_Servlet) Velocity-tools however is still stuck in servlet APi 3.1 (from May 2013) (https://velocity.apache.org/tools/3.1/changes.html) 3 years without action is too long. Somehow, this change must be addressed. Not doing anything would indicate to users that velocity is dead and users would look for other solutions. So, what could be done? I personally like "the log4j2 solution": two separate maven artefacts, user chooses if he wants "this or that" package name (see https://logging.apache.org/log4j/2.x/manual/webapp.html) IDK how they build it (switch package names in source code? clone code?) but maybe the same approach could be used for VelocityTools? I could even imagine to leave old servlet API totally behind. Whoever needs old servlet stays on tools 3.1 (or, if any bugfix, 3.1.1), others move on. Any opinions? cheers, Gernot - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
[jira] [Comment Edited] (VELTOOLS-202) VelocityViewServlet extending from jakarta.servlet instead of javax.servlet
[ https://issues.apache.org/jira/browse/VELTOOLS-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805047#comment-17805047 ] Michael Osipov edited comment on VELTOOLS-202 at 1/10/24 10:12 AM: --- reasonable: You don't just rename the old module, you add a second one, but better before even writing a single line I'd discuss my PR idea. It is not me who needs to start the discussion, but he because he wants to change something, not me. was (Author: michael-o): reasonable: You don't just rename the old module, you add a second one, but better before even writing a single line I'd discuss my PR idea. It is not me who needs to start the discussion, but the he because he wants to change something, not me. > VelocityViewServlet extending from jakarta.servlet instead of javax.servlet > --- > > Key: VELTOOLS-202 > URL: https://issues.apache.org/jira/browse/VELTOOLS-202 > Project: Velocity Tools > Issue Type: New Feature > Components: VelocityView >Reporter: David Ruiz de Azua >Priority: Trivial > > To whom may concern, > Currently VelocityViewServlet extends from javax rather than jakarta. > Due the cutover from Java to Jakarta, *is there any plan to make Apache > Velocity compatible with Servlet 5.0?* > Not sure if there are any plans to make the transition to Jakarta namespace > and if there is any ETA for it. > [https://jakarta.ee/specifications/servlet/5.0/apidocs/jakarta/servlet/http/httpservlet] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
[jira] [Comment Edited] (VELTOOLS-202) VelocityViewServlet extending from jakarta.servlet instead of javax.servlet
[ https://issues.apache.org/jira/browse/VELTOOLS-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805047#comment-17805047 ] Michael Osipov edited comment on VELTOOLS-202 at 1/10/24 10:07 AM: --- reasonable: You don't just rename the old module, you add a second one, but better before even writing a single line I'd discuss my PR idea. It is not me who needs to start the discussion, but the he because he wants to change something, not me. was (Author: michael-o): reasonable: You don't just rename the old module, you add a second one, but better before even writing a single line I'd discuss my PR idea. > VelocityViewServlet extending from jakarta.servlet instead of javax.servlet > --- > > Key: VELTOOLS-202 > URL: https://issues.apache.org/jira/browse/VELTOOLS-202 > Project: Velocity Tools > Issue Type: New Feature > Components: VelocityView >Reporter: David Ruiz de Azua >Priority: Trivial > > To whom may concern, > Currently VelocityViewServlet extends from javax rather than jakarta. > Due the cutover from Java to Jakarta, *is there any plan to make Apache > Velocity compatible with Servlet 5.0?* > Not sure if there are any plans to make the transition to Jakarta namespace > and if there is any ETA for it. > [https://jakarta.ee/specifications/servlet/5.0/apidocs/jakarta/servlet/http/httpservlet] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
[jira] [Commented] (VELTOOLS-202) VelocityViewServlet extending from jakarta.servlet instead of javax.servlet
[ https://issues.apache.org/jira/browse/VELTOOLS-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805044#comment-17805044 ] Martin Tzvetanov Grigorov commented on VELTOOLS-202: Define "reasonable"! Most people (me included) don't like being treated as in https://github.com/apache/velocity-tools/pull/15#issuecomment-1632855512 (closing the PR with a simple comment like "This can't be serious") The discussion in the mailing list could happen in parallel by asking the contributor more politely, or by starting it yourself, or by adding a comment how you think it should be done, or ... (many other options). Doing what you did there just gives bad impression to Velocity project and to Apache in general! IMO your behavior is not reasonable but this is getting personal, so let's stop! > VelocityViewServlet extending from jakarta.servlet instead of javax.servlet > --- > > Key: VELTOOLS-202 > URL: https://issues.apache.org/jira/browse/VELTOOLS-202 > Project: Velocity Tools > Issue Type: New Feature > Components: VelocityView >Reporter: David Ruiz de Azua >Priority: Trivial > > To whom may concern, > Currently VelocityViewServlet extends from javax rather than jakarta. > Due the cutover from Java to Jakarta, *is there any plan to make Apache > Velocity compatible with Servlet 5.0?* > Not sure if there are any plans to make the transition to Jakarta namespace > and if there is any ETA for it. > [https://jakarta.ee/specifications/servlet/5.0/apidocs/jakarta/servlet/http/httpservlet] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
[jira] [Commented] (VELTOOLS-202) VelocityViewServlet extending from jakarta.servlet instead of javax.servlet
[ https://issues.apache.org/jira/browse/VELTOOLS-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805040#comment-17805040 ] Michael Osipov commented on VELTOOLS-202: - Why? If someone provides are reasonable patch, both can be supported. No issue, but don't forget: this is a volunteer project. We work on stuff we have time for and care about. That's it. > VelocityViewServlet extending from jakarta.servlet instead of javax.servlet > --- > > Key: VELTOOLS-202 > URL: https://issues.apache.org/jira/browse/VELTOOLS-202 > Project: Velocity Tools > Issue Type: New Feature > Components: VelocityView >Reporter: David Ruiz de Azua >Priority: Trivial > > To whom may concern, > Currently VelocityViewServlet extends from javax rather than jakarta. > Due the cutover from Java to Jakarta, *is there any plan to make Apache > Velocity compatible with Servlet 5.0?* > Not sure if there are any plans to make the transition to Jakarta namespace > and if there is any ETA for it. > [https://jakarta.ee/specifications/servlet/5.0/apidocs/jakarta/servlet/http/httpservlet] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
