Re: [VOTE] Release Velocity Engine version 2.4
Guys, last day for votes. Please have a look. - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
Re: [VOTE] Release Velocity Tools version 3.2
Guys, last day for votes. Please have a look. - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
Re: [VOTE] Release Velocity Engine version 2.4
It's too bad I'm so busy those days to incorporate a few more issues. But +1 anyway, that's already something. Claude On 13/02/2024 14:35, Michael Osipov wrote: Guys, last day for votes. Please have a look. - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
Re: [VOTE] Release Velocity Engine version 2.4
Ooops, changing my vote to -1, I have a problem building: [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.012 s <<< FAILURE! -- in org.apache.velocity.test.issues.VelTools66TestCase [ERROR] org.apache.velocity.test.issues.VelTools66TestCase.testVelTools66 -- Time elapsed: 0.011 s <<< ERROR! java.lang.UnsupportedOperationException: The Security Manager is deprecated and will be removed in a future release at java.base/java.lang.System.setSecurityManager(System.java:416) at org.apache.velocity.test.issues.VelTools66TestCase.setUp(VelTools66TestCase.java:61) at junit.framework.TestCase.runBare(TestCase.java:140) at junit.framework.TestResult$1.protect(TestResult.java:122) at junit.framework.TestResult.runProtected(TestResult.java:142) at junit.framework.TestResult.run(TestResult.java:125) at junit.framework.TestCase.run(TestCase.java:130) at junit.framework.TestSuite.runTest(TestSuite.java:241) at junit.framework.TestSuite.run(TestSuite.java:236) at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:90) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:316) at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:240) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:214) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:155) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:385) at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162) at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:507) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:495) $ java -version openjdk version "18.0.2-ea" 2022-07-19 OpenJDK Runtime Environment (build 18.0.2-ea+9-Ubuntu-2ubuntu1) OpenJDK 64-Bit Server VM (build 18.0.2-ea+9-Ubuntu-2ubuntu1, mixed mode, sharing) On 13/02/2024 16:19, Claude Brisson wrote: It's too bad I'm so busy those days to incorporate a few more issues. But +1 anyway, that's already something. Claude On 13/02/2024 14:35, Michael Osipov wrote: Guys, last day for votes. Please have a look. - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
Re: [VOTE] Release Velocity Tools version 3.2
Since I could not build the engine RC, I cannot test the tools RC without tweaking the poms. Usually, I first release the engine then the tools. Also, I think it is a good practice to name RC tags 2.4-rc1, etc. and to only tag the release with 2.4. Best, Claude On 13/02/2024 14:35, Michael Osipov wrote: Guys, last day for votes. Please have a look. - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
Re: [VOTE] Release Velocity Engine version 2.4
On 2024/02/13 15:23:36 Claude Brisson wrote: > Ooops, changing my vote to -1, I have a problem building: > > [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: > 0.012 s <<< FAILURE! -- in > org.apache.velocity.test.issues.VelTools66TestCase > [ERROR] > org.apache.velocity.test.issues.VelTools66TestCase.testVelTools66 -- > Time elapsed: 0.011 s <<< ERROR! > java.lang.UnsupportedOperationException: The Security Manager is > deprecated and will be removed in a future release > at java.base/java.lang.System.setSecurityManager(System.java:416) That is expected, this test needs to be skipped after Java 17 because of the SecurityManager removal. I don't consider this as a show stopper. - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
Re: [VOTE] Release Velocity Engine version 2.4
On 2024/02/13 16:32:30 Michael Osipov wrote: > On 2024/02/13 15:23:36 Claude Brisson wrote: > > Ooops, changing my vote to -1, I have a problem building: > > > > [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: > > 0.012 s <<< FAILURE! -- in > > org.apache.velocity.test.issues.VelTools66TestCase > > [ERROR] > > org.apache.velocity.test.issues.VelTools66TestCase.testVelTools66 -- > > Time elapsed: 0.011 s <<< ERROR! > > java.lang.UnsupportedOperationException: The Security Manager is > > deprecated and will be removed in a future release > > at java.base/java.lang.System.setSecurityManager(System.java:416) > > That is expected, this test needs to be skipped after Java 17 because of the > SecurityManager removal. I don't consider this as a show stopper. Test can be removed: https://github.com/apache/velocity-engine/pull/42 - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
[PR] Upgrade to EasyMock 5.2.0 [velocity-tools]
michael-o opened a new pull request, #17: URL: https://github.com/apache/velocity-tools/pull/17 This fixes test failures on newer Java versions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
Re: [VOTE] Release Velocity Tools version 3.2
On 2024/02/13 15:25:42 Claude Brisson wrote: > Since I could not build the engine RC, I cannot test the tools RC > without tweaking the poms. As a followup to your comments I found another issue for tests: https://github.com/apache/velocity-tools/pull/17 Though, it is not a blocker because it does not affect runtime behavior, just testing. - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
Re: [VOTE] Release Velocity Tools version 3.2
Maybe it's nitpicking, but having the users being able to build without errors is a precaution which is worth repackaging an engine RC, since we're at it... no? On 13/02/2024 18:09, Michael Osipov wrote: On 2024/02/13 15:25:42 Claude Brisson wrote: Since I could not build the engine RC, I cannot test the tools RC without tweaking the poms. As a followup to your comments I found another issue for tests: https://github.com/apache/velocity-tools/pull/17 Though, it is not a blocker because it does not affect runtime behavior, just testing. - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
Re: [VOTE] Release Velocity Tools version 3.2
On 2024/02/13 17:39:38 Claude Brisson wrote: > Maybe it's nitpicking, but having the users being able to build without > errors is a precaution which is worth repackaging an engine RC, since > we're at it... no? I don't consider this as nitpicking, but you need to consider the failure reason as well. The actual code works as intended. Your points are valid. Do you want me to drop, remove the test and re-roll the release? M - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
[CANCELED] [VOTE] Release Velocity Engine version 2.4
Canceling the vote and dropping the release. It did not reach the required quorum. - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
[CANCEL] [VOTE] Release Velocity Tools version 3.2
Canceling the vote and dropping the release. It did not reach the required quorum. - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
[jira] [Created] (VELTOOLS-206) Upgrade to Velocity Engine 2.4.1
Michael Osipov created VELTOOLS-206: --- Summary: Upgrade to Velocity Engine 2.4.1 Key: VELTOOLS-206 URL: https://issues.apache.org/jira/browse/VELTOOLS-206 Project: Velocity Tools Issue Type: Task Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 3.2.1 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
[PR] Skim and correct README [velocity-tools]
michael-o opened a new pull request, #18: URL: https://github.com/apache/velocity-tools/pull/18 There is no reason to duplicate information from the POM and force devs to keep the information in sync. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org
