Re: Replace Facebook/Yoga with a new implementation.
How's it going？ We need to release a version as soon as Yoga is removed. Thanks. Adam Feng On 12 Oct 2017, 10:37 PM +0800, 申远 , wrote: > flex-grow is already supported by flex shorthand, and it’s possible to > support flex-shrink in later version. > While, flex-basis is the same as main size which is supported already except > for percent value. I think support percent unit is a huge, duplicate and > unnecessary work for most CSS style, after all I am trying to achieve an > elegant implementation of CSS, excluding dummy, heavy, duplicate part of CSS. > But It makes sense that flex-basis should support and only support percent > value. For baseline, I think if iOS Framework is able to pass ascent, > descent, half-leading, top and bottom to layout engine, layout engine itself > has no problem to manipulate these values. > > > 在 2017年10月12日，17:16，xing zhang 写道： > > > > Should we consider about layout percent unit, flex-shrink, flex-grow, > > flexBasis, and baseline in align-Items ? > > > > 2017-10-12 16:54 GMT+08:00 申远 : > > > > > Dear all, > > > > > > I’m considering replacing Facebook/Yoga to a new layout system based on > > > Google/Flexbox due to Facebook’s additional patent issue. Besides, this > > > new > > > layout system will provide some new css style like order, etc. > > > > > > Any advise for the new layout system? > > > > > > PS: I need some advise about the name of the layout system. >
Re: the max-width for css-style should be taken into consideration when drawing text
Thanks for your contribution, I have seen the pull request and reviewed the code, it looked good to me, can `max-height` also be supported? Thanks. Adam Feng On 5 Nov 2017, 12:22 PM +0800, xing zhang , wrote: > Hi , I open an issue for support max-width in iOS, as it works well both > on Android and web. > > As I test the css for `max-width`, it works well both on Android and Web > platform except iOS. > Here is the test code on DotWe website: > > http://dotwe.org/vue/7e556c582a55630518d0bf6336ddde0e > > When meassuring the width of drawing text , the max-width of css-style should > take into consideration.It seems that only width for css-style works. > > The attachment is the screenshot both on iOS and web(html5). > > .. > > > > And later, I will open an pull request to resolve this bug.
Re: Plugin development
Hi, Tiago, Thanks for your contribution! You can follow the new contribution guide[1](which is being reviewed and will be merged soon) to improve the documentation. [1] https://github.com/cxfeng1/incubator-weex-site/blob/6a04e077e896709c5797ad30d9a31632a8e0a193/source/contributing.md Thanks. Adam Feng On 5 Nov 2017, 3:28 AM +0800, Tiago Alves , wrote: > I figured it out. > > weex plugin create weex-my-plugin > > Then there are more instructions in doc/how-to-develop.md. > > I will translate this document, add more info and PR it to the docs. Seems > important! > > Tiago > > On Sat, 4 Nov 2017 at 16:06 Tiago Alves wrote: > > > Good day! > > > > I am developing a weex plugin. I feel it will be a great oportunity for me > > to help improving the plugin docs. > > > > I remember reading docs about developing a weex plugin (plugin.xml, etc), > > but thats seems to be gone along with the legacy stuff. Is there any docs > > that would help me getting started? > > > > I am using this plugin as reference > > https://github.com/weex-plugins/weex-amap, but this sort of reverse > > engineering gives the constant feeling that I am missing out on something. > > > > Thanks! > > Tiago > >
[jira] [Commented] (WEEX-91) support max-width in text component on iOS
[ https://issues.apache.org/jira/browse/WEEX-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239409#comment-16239409 ] ASF GitHub Bot commented on WEEX-91: GitHub user acton393 opened a pull request: https://github.com/apache/incubator-weex/pull/834 * [ios] support max-width when drawing text fix issue: https://issues.apache.org/jira/projects/WEEX/issues/WEEX-91?filter=allopenissues Here is the code on dotwe: http://dotwe.org/vue/7e556c582a55630518d0bf6336ddde0e I test compatibility on iOS 8,iOS9 and iOS 11. https://user-images.githubusercontent.com/11631084/32412168-51afa726-c1bd-11e7-938f-2bb7063399f5.png";> You can merge this pull request into a Git repository by running: $ git pull https://github.com/acton393/incubator-weex wip-us-master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/834.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #834 commit 81115d0bf880ede9da0dad0b74b533d6c30eef46 Author: acton393 Date: 2017-10-13T08:35:03Z * [ios] fix issue https://issues.apache.org/jira/browse/WEEX-81 that box-shadow is abnormal in border-radius commit fba9dfed38d02c6a6ddd5bbd25d10416c1d6c27c Author: acton393 Date: 2017-10-16T03:07:48Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/incubator-weex into wip-us-master commit 0e1470ae0f4744b54953f64fa48164995d61231a Author: acton393 Date: 2017-10-18T03:01:05Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/incubator-weex into wip-us-master commit 343ad6f1b49bab8908f298a25f25ca9eb4f8ba06 Author: acton393 Date: 2017-10-18T03:04:28Z * [ios] parse fetch response while the callback is existed commit 6cd64a775ecfd518ccc15fad8d4515c2097e8933 Author: acton393 Date: 2017-10-26T08:19:33Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/incubator-weex into wip-us-master commit e1f33449d9807ac34086d27a404be6847804b830 Author: acton393 Date: 2017-10-31T14:26:07Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/incubator-weex into wip-us-master commit 5896a612ac0a41b128dfda12bb3ee954f8ac612a Author: acton393 Date: 2017-11-05T04:56:55Z * [ios] fix issue https://issues.apache.org/jira/projects/WEEX/issues/WEEX-91? taking max-width into consideration when meassuring text > support max-width in text component on iOS > --- > > Key: WEEX-91 > URL: https://issues.apache.org/jira/browse/WEEX-91 > Project: Weex > Issue Type: New Feature > Components: iOS >Reporter: xingZhang >Assignee: Adam Feng > Attachments: 屏幕快照 2017-11-05 12.06.48.png > > > As I test the css for `max-width`, it works well both on Android and Web > platform except iOS. > Here is the test code on DotWe website: > http://dotwe.org/vue/7e556c582a55630518d0bf6336ddde0e > When meassuring the width of drawing text , the max-width of css-style should > take into consideration.It seems that only width for css-style works. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (WEEX-81) shadow render wrong
[ https://issues.apache.org/jira/browse/WEEX-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239406#comment-16239406 ] ASF GitHub Bot commented on WEEX-81: Github user acton393 closed the pull request at: https://github.com/apache/incubator-weex/pull/791 > shadow render wrong > --- > > Key: WEEX-81 > URL: https://issues.apache.org/jira/browse/WEEX-81 > Project: Weex > Issue Type: Bug > Components: iOS >Reporter: jackyking >Assignee: xingZhang >Priority: Minor > Attachments: correct.png, wrong.png > > > see demo http://dotwe.org/vue/fbbd9910d1423975370424d7f19893d5 > shadow should be like this: !correct.png|thumbnail! > but rendered this: !wrong.png|thumbnail! -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Re: Plugin development
Cool~~ 2017-11-05 3:28 GMT+08:00 Tiago Alves : > I figured it out. > > weex plugin create weex-my-plugin > > Then there are more instructions in doc/how-to-develop.md. > > I will translate this document, add more info and PR it to the docs. Seems > important! > > Tiago > > On Sat, 4 Nov 2017 at 16:06 Tiago Alves wrote: > > > Good day! > > > > I am developing a weex plugin. I feel it will be a great oportunity for > me > > to help improving the plugin docs. > > > > I remember reading docs about developing a weex plugin (plugin.xml, etc), > > but thats seems to be gone along with the legacy stuff. Is there any docs > > that would help me getting started? > > > > I am using this plugin as reference > > https://github.com/weex-plugins/weex-amap, but this sort of reverse > > engineering gives the constant feeling that I am missing out on > something. > > > > Thanks! > > Tiago > > >
the max-width for css-style should be taken into consideration when drawing text
Hi , I open an issue for support max-width in iOS, as it works well both on Android and web. As I test the css for `max-width`, it works well both on Android and Web platform except iOS. Here is the test code on DotWe website: http://dotwe.org/vue/7e556c582a55630518d0bf6336ddde0e When meassuring the width of drawing text , the max-width of css-style should take into consideration.It seems that only width for css-style works. The attachment is the screenshot both on iOS and web(html5). .. [image: 内嵌图片 1] And later, I will open an pull request to resolve this bug.
[jira] [Created] (WEEX-91) support max-width in text component on iOS
xingZhang created WEEX-91: - Summary: support max-width in text component on iOS Key: WEEX-91 URL: https://issues.apache.org/jira/browse/WEEX-91 Project: Weex Issue Type: New Feature Components: iOS Reporter: xingZhang Assignee: Adam Feng Attachments: 屏幕快照 2017-11-05 12.06.48.png As I test the css for `max-width`, it works well both on Android and Web platform except iOS. Here is the test code on DotWe website: http://dotwe.org/vue/7e556c582a55630518d0bf6336ddde0e When meassuring the width of drawing text , the max-width of css-style should take into consideration.It seems that only width for css-style works. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Re: Plugin development
I figured it out. weex plugin create weex-my-plugin Then there are more instructions in doc/how-to-develop.md. I will translate this document, add more info and PR it to the docs. Seems important! Tiago On Sat, 4 Nov 2017 at 16:06 Tiago Alves wrote: > Good day! > > I am developing a weex plugin. I feel it will be a great oportunity for me > to help improving the plugin docs. > > I remember reading docs about developing a weex plugin (plugin.xml, etc), > but thats seems to be gone along with the legacy stuff. Is there any docs > that would help me getting started? > > I am using this plugin as reference > https://github.com/weex-plugins/weex-amap, but this sort of reverse > engineering gives the constant feeling that I am missing out on something. > > Thanks! > Tiago >
Plugin development
Good day! I am developing a weex plugin. I feel it will be a great oportunity for me to help improving the plugin docs. I remember reading docs about developing a weex plugin (plugin.xml, etc), but thats seems to be gone along with the legacy stuff. Is there any docs that would help me getting started? I am using this plugin as reference https://github.com/weex-plugins/weex-amap, but this sort of reverse engineering gives the constant feeling that I am missing out on something. Thanks! Tiago
