[jira] [Commented] (WEEX-99) The setViewport method in WXMetaModule is ASYN right now which makes weexInstance.viewportWidth setted after view created.

2017-11-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/WEEX-99?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243460#comment-16243460
 ] 

ASF GitHub Bot commented on WEEX-99:


GitHub user myeveryheart opened a pull request:

https://github.com/apache/incubator-weex/pull/843

[WEEX-99][iOS] fix setViewport: sometimes doesn't work

[WEEX-99][iOS] fix setViewport: sometimes doesn't work.

The setViewport method in WXMetaModule is ASYN right now which makes 
weexInstance.viewportWidth setted after view created.

Bug:99

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/myeveryheart/incubator-weex 
WEEX-99-iOS-fix-setViewport-sometimes-doesn't-work

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/843.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #843


commit c6b8a28eb868853136fea9dd946404934c8816b4
Author: M 
Date:   2017-11-08T06:53:09Z

[WEEX-99][iOS] fix setViewport: sometimes doesn't work




> The setViewport method in WXMetaModule is ASYN right now which makes 
> weexInstance.viewportWidth setted after view created.
> --
>
> Key: WEEX-99
> URL: https://issues.apache.org/jira/browse/WEEX-99
> Project: Weex
>  Issue Type: Bug
>  Components: iOS
>Reporter: myeveryheart
>Assignee: Adam Feng
> Attachments: 粘贴图片.png, 粘贴图片1.png, 粘贴图片2.png, 粘贴图片3.png
>
>
> The meta module can be used to declare meta information for a single page, 
> such as the viewport of the container.
> It provides a method 'setViewport' to change the viewport of the page.
> But the method is ASYN right now which makes weexInstance.viewportWidth 
> setted after view created.
> The bug is in iOS and Android.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (WEEX-99) The setViewport method in WXMetaModule is ASYN right now which makes weexInstance.viewportWidth setted after view created.

2017-11-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/WEEX-99?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243454#comment-16243454
 ] 

ASF GitHub Bot commented on WEEX-99:


Github user myeveryheart closed the pull request at:

https://github.com/apache/incubator-weex/pull/842


> The setViewport method in WXMetaModule is ASYN right now which makes 
> weexInstance.viewportWidth setted after view created.
> --
>
> Key: WEEX-99
> URL: https://issues.apache.org/jira/browse/WEEX-99
> Project: Weex
>  Issue Type: Bug
>  Components: iOS
>Reporter: myeveryheart
>Assignee: Adam Feng
> Attachments: 粘贴图片.png, 粘贴图片1.png, 粘贴图片2.png, 粘贴图片3.png
>
>
> The meta module can be used to declare meta information for a single page, 
> such as the viewport of the container.
> It provides a method 'setViewport' to change the viewport of the page.
> But the method is ASYN right now which makes weexInstance.viewportWidth 
> setted after view created.
> The bug is in iOS and Android.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (WEEX-99) The setViewport method in WXMetaModule is ASYN right now which makes weexInstance.viewportWidth setted after view created.

2017-11-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/WEEX-99?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243472#comment-16243472
 ] 

ASF GitHub Bot commented on WEEX-99:


GitHub user myeveryheart reopened a pull request:

https://github.com/apache/incubator-weex/pull/843

[WEEX-99][iOS] fix setViewport: sometimes doesn't work

[WEEX-99][iOS] fix setViewport: sometimes doesn't work.

The setViewport method in WXMetaModule is ASYN right now which makes 
weexInstance.viewportWidth setted after view created.

Bug:99

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/myeveryheart/incubator-weex 
WEEX-99-iOS-fix-setViewport-sometimes-doesn't-work

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/843.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #843


commit c6b8a28eb868853136fea9dd946404934c8816b4
Author: M 
Date:   2017-11-08T06:53:09Z

[WEEX-99][iOS] fix setViewport: sometimes doesn't work




> The setViewport method in WXMetaModule is ASYN right now which makes 
> weexInstance.viewportWidth setted after view created.
> --
>
> Key: WEEX-99
> URL: https://issues.apache.org/jira/browse/WEEX-99
> Project: Weex
>  Issue Type: Bug
>  Components: iOS
>Reporter: myeveryheart
>Assignee: Adam Feng
> Attachments: 粘贴图片.png, 粘贴图片1.png, 粘贴图片2.png, 粘贴图片3.png
>
>
> The meta module can be used to declare meta information for a single page, 
> such as the viewport of the container.
> It provides a method 'setViewport' to change the viewport of the page.
> But the method is ASYN right now which makes weexInstance.viewportWidth 
> setted after view created.
> The bug is in iOS and Android.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (WEEX-99) The setViewport method in WXMetaModule is ASYN right now which makes weexInstance.viewportWidth setted after view created.

2017-11-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/WEEX-99?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243471#comment-16243471
 ] 

ASF GitHub Bot commented on WEEX-99:


Github user myeveryheart closed the pull request at:

https://github.com/apache/incubator-weex/pull/843


> The setViewport method in WXMetaModule is ASYN right now which makes 
> weexInstance.viewportWidth setted after view created.
> --
>
> Key: WEEX-99
> URL: https://issues.apache.org/jira/browse/WEEX-99
> Project: Weex
>  Issue Type: Bug
>  Components: iOS
>Reporter: myeveryheart
>Assignee: Adam Feng
> Attachments: 粘贴图片.png, 粘贴图片1.png, 粘贴图片2.png, 粘贴图片3.png
>
>
> The meta module can be used to declare meta information for a single page, 
> such as the viewport of the container.
> It provides a method 'setViewport' to change the viewport of the page.
> But the method is ASYN right now which makes weexInstance.viewportWidth 
> setted after view created.
> The bug is in iOS and Android.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (WEEX-99) The setViewport method in WXMetaModule is ASYN right now which makes weexInstance.viewportWidth setted after view created.

2017-11-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/WEEX-99?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243466#comment-16243466
 ] 

ASF GitHub Bot commented on WEEX-99:


Github user weex-bot commented on the issue:

https://github.com/apache/incubator-weex/pull/844
  





  

  
  Warnings

  
  
  :warning:
  No Changelog changes!

  

  :warning:
  This PR should update related documents as well. 

  




  

  
  Messages

  
  
  :book:
  danger test finished.

  




  Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS




> The setViewport method in WXMetaModule is ASYN right now which makes 
> weexInstance.viewportWidth setted after view created.
> --
>
> Key: WEEX-99
> URL: https://issues.apache.org/jira/browse/WEEX-99
> Project: Weex
>  Issue Type: Bug
>  Components: iOS
>Reporter: myeveryheart
>Assignee: Adam Feng
> Attachments: 粘贴图片.png, 粘贴图片1.png, 粘贴图片2.png, 粘贴图片3.png
>
>
> The meta module can be used to declare meta information for a single page, 
> such as the viewport of the container.
> It provides a method 'setViewport' to change the viewport of the page.
> But the method is ASYN right now which makes weexInstance.viewportWidth 
> setted after view created.
> The bug is in iOS and Android.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (WEEX-99) The setViewport method in WXMetaModule is ASYN right now which makes weexInstance.viewportWidth setted after view created.

2017-11-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/WEEX-99?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243465#comment-16243465
 ] 

ASF GitHub Bot commented on WEEX-99:


GitHub user myeveryheart opened a pull request:

https://github.com/apache/incubator-weex/pull/844

[WEEX-99][Android] fix setViewport: sometimes doesn't work

[WEEX-99][Android] fix setViewport: sometimes doesn't work.

The setViewport method in WXMetaModule is ASYN right now which makes 
weexInstance.viewportWidth setted after view created.

Bug:99

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/myeveryheart/incubator-weex 
WEEX-99-Android-fix-setViewport-sometimes-doesn't-work

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/844.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #844


commit 0fef58ff6883cf5695803adaea955d80d6cd2408
Author: M 
Date:   2017-11-08T06:56:13Z

[WEEX-99][Android] fix setViewport: sometimes doesn't work




> The setViewport method in WXMetaModule is ASYN right now which makes 
> weexInstance.viewportWidth setted after view created.
> --
>
> Key: WEEX-99
> URL: https://issues.apache.org/jira/browse/WEEX-99
> Project: Weex
>  Issue Type: Bug
>  Components: iOS
>Reporter: myeveryheart
>Assignee: Adam Feng
> Attachments: 粘贴图片.png, 粘贴图片1.png, 粘贴图片2.png, 粘贴图片3.png
>
>
> The meta module can be used to declare meta information for a single page, 
> such as the viewport of the container.
> It provides a method 'setViewport' to change the viewport of the page.
> But the method is ASYN right now which makes weexInstance.viewportWidth 
> setted after view created.
> The bug is in iOS and Android.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (WEEX-99) The setViewport method in WXMetaModule is ASYN right now which makes weexInstance.viewportWidth setted after view created.

2017-11-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/WEEX-99?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243463#comment-16243463
 ] 

ASF GitHub Bot commented on WEEX-99:


Github user weex-bot commented on the issue:

https://github.com/apache/incubator-weex/pull/843
  






  

  
  Messages

  
  
  :book:
  has no jsfm file changed.

  

  :book:
  jsfm test finished.

  




  Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS




> The setViewport method in WXMetaModule is ASYN right now which makes 
> weexInstance.viewportWidth setted after view created.
> --
>
> Key: WEEX-99
> URL: https://issues.apache.org/jira/browse/WEEX-99
> Project: Weex
>  Issue Type: Bug
>  Components: iOS
>Reporter: myeveryheart
>Assignee: Adam Feng
> Attachments: 粘贴图片.png, 粘贴图片1.png, 粘贴图片2.png, 粘贴图片3.png
>
>
> The meta module can be used to declare meta information for a single page, 
> such as the viewport of the container.
> It provides a method 'setViewport' to change the viewport of the page.
> But the method is ASYN right now which makes weexInstance.viewportWidth 
> setted after view created.
> The bug is in iOS and Android.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (WEEX-99) The setViewport method in WXMetaModule is ASYN right now which makes weexInstance.viewportWidth setted after view created.

2017-11-07 Thread myeveryheart (JIRA)
myeveryheart created WEEX-99:


 Summary: The setViewport method in WXMetaModule is ASYN right now 
which makes weexInstance.viewportWidth setted after view created.
 Key: WEEX-99
 URL: https://issues.apache.org/jira/browse/WEEX-99
 Project: Weex
  Issue Type: Bug
Reporter: myeveryheart
Assignee: Adam Feng
 Attachments: 粘贴图片.png, 粘贴图片1.png, 粘贴图片2.png, 粘贴图片3.png

The meta module can be used to declare meta information for a single page, such 
as the viewport of the container.
It provides a method 'setViewport' to change the viewport of the page.
But the method is ASYN right now which makes weexInstance.viewportWidth setted 
after view created.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (WEEX-99) The setViewport method in WXMetaModule is ASYN right now which makes weexInstance.viewportWidth setted after view created.

2017-11-07 Thread myeveryheart (JIRA)

 [ 
https://issues.apache.org/jira/browse/WEEX-99?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

myeveryheart updated WEEX-99:
-
Component/s: iOS

> The setViewport method in WXMetaModule is ASYN right now which makes 
> weexInstance.viewportWidth setted after view created.
> --
>
> Key: WEEX-99
> URL: https://issues.apache.org/jira/browse/WEEX-99
> Project: Weex
>  Issue Type: Bug
>  Components: iOS
>Reporter: myeveryheart
>Assignee: Adam Feng
> Attachments: 粘贴图片.png, 粘贴图片1.png, 粘贴图片2.png, 粘贴图片3.png
>
>
> The meta module can be used to declare meta information for a single page, 
> such as the viewport of the container.
> It provides a method 'setViewport' to change the viewport of the page.
> But the method is ASYN right now which makes weexInstance.viewportWidth 
> setted after view created.
> The bug is in iOS and Android.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (WEEX-99) The setViewport method in WXMetaModule is ASYN right now which makes weexInstance.viewportWidth setted after view created.

2017-11-07 Thread myeveryheart (JIRA)

 [ 
https://issues.apache.org/jira/browse/WEEX-99?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

myeveryheart updated WEEX-99:
-
Description: 
The meta module can be used to declare meta information for a single page, such 
as the viewport of the container.
It provides a method 'setViewport' to change the viewport of the page.
But the method is ASYN right now which makes weexInstance.viewportWidth setted 
after view created.
The bug is in iOS and Android.

  was:
The meta module can be used to declare meta information for a single page, such 
as the viewport of the container.
It provides a method 'setViewport' to change the viewport of the page.
But the method is ASYN right now which makes weexInstance.viewportWidth setted 
after view created.


> The setViewport method in WXMetaModule is ASYN right now which makes 
> weexInstance.viewportWidth setted after view created.
> --
>
> Key: WEEX-99
> URL: https://issues.apache.org/jira/browse/WEEX-99
> Project: Weex
>  Issue Type: Bug
>Reporter: myeveryheart
>Assignee: Adam Feng
> Attachments: 粘贴图片.png, 粘贴图片1.png, 粘贴图片2.png, 粘贴图片3.png
>
>
> The meta module can be used to declare meta information for a single page, 
> such as the viewport of the container.
> It provides a method 'setViewport' to change the viewport of the page.
> But the method is ASYN right now which makes weexInstance.viewportWidth 
> setted after view created.
> The bug is in iOS and Android.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (WEEX-96) Timer exposed on JSContext can not clear and it has potential crash switching globalQueue

2017-11-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/WEEX-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242525#comment-16242525
 ] 

ASF GitHub Bot commented on WEEX-96:


Github user weex-bot commented on the issue:

https://github.com/apache/incubator-weex/pull/839
  





  

  
  Warnings

  
  
  :warning:
  No Changelog changes!

  

  :warning:
  This PR should update related documents as well. 

  




  

  
  Messages

  
  
  :book:
  danger test finished.

  




  Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS




> Timer exposed on JSContext can not clear and it has potential crash switching 
> globalQueue
> -
>
> Key: WEEX-96
> URL: https://issues.apache.org/jira/browse/WEEX-96
> Project: Weex
>  Issue Type: Bug
>Reporter: xingZhang
>Assignee: Adam Feng
>Priority: Critical
>
> 1. timer can not be clear
> As the WXJSCoreBridge file  in [line 
> 544](https://github.com/apache/incubator-weex/blob/master/ios/sdk/WeexSDK/Sources/Bridge/WXJSCoreBridge.m#L544)
>   shows the code, the appId is a string , so it will never be cleared.
> 2. timer execute js function in global queue may have potential crash, it had 
> better execution in current thread.
> WXJSCoreBridge  
> https://github.com/apache/incubator-weex/blob/master/ios/sdk/WeexSDK/Sources/Bridge/WXJSCoreBridge.m#L535
> 3. timerId will always be 1, not auto-increment as the count of timer 
> increasing
> https://github.com/apache/incubator-weex/blob/master/ios/sdk/WeexSDK/Sources/Bridge/WXJSCoreBridge.m#L513



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (WEEX-94) scroller component can lead to crash in iOS 8 and older iOS version

2017-11-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/WEEX-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242522#comment-16242522
 ] 

ASF GitHub Bot commented on WEEX-94:


Github user weex-bot commented on the issue:

https://github.com/apache/incubator-weex/pull/838
  






  

  
  Messages

  
  
  :book:
  has no jsfm file changed.

  

  :book:
  jsfm test finished.

  




  Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS




> scroller component can lead to crash in iOS 8 and older iOS version
> ---
>
> Key: WEEX-94
> URL: https://issues.apache.org/jira/browse/WEEX-94
> Project: Weex
>  Issue Type: Bug
>  Components: iOS
>Reporter: xingZhang
>Assignee: Adam Feng
> Attachments: 屏幕快照 2017-11-07 20.47.29.png
>
>
>As iOS developers knows, assign property object will not be set as nil 
> when its object deallocated, and weak property will do.
>We found crash only on iOS 8 about scrollview delegate zombie object now, 
> it is necessary to fix it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (WEEX-92) How to use playground

2017-11-07 Thread xingZhang (JIRA)

[ 
https://issues.apache.org/jira/browse/WEEX-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242516#comment-16242516
 ] 

xingZhang commented on WEEX-92:
---

hi , playground on Apple Store can be used to preview your page, if you want to 
debugger locally, may be you can try weex-toolkit
https://weex.incubator.apache.org/guide/tools/toolkit.html

> How to use playground
> -
>
> Key: WEEX-92
> URL: https://issues.apache.org/jira/browse/WEEX-92
> Project: Weex
>  Issue Type: Task
>  Components: iOS
>Affects Versions: 0.12
>Reporter: wei
>Assignee: Adam Feng
>Priority: Blocker
>  Labels: weex
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Why scanning QR code use playground in phone is show a blank, i found this 
> [#http://dotwe.org/vue/6792fe75b4ba4661b0d154aa99618ed9/] only support code 
> on line. how to use playground debugger in my local?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (WEEX-98) addEvent will lead to view load again, especially the view just re-used for memory usage

2017-11-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/WEEX-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242505#comment-16242505
 ] 

ASF GitHub Bot commented on WEEX-98:


Github user weex-bot commented on the issue:

https://github.com/apache/incubator-weex/pull/837
  






  

  
  Messages

  
  
  :book:
  has no jsfm file changed.

  

  :book:
  jsfm test finished.

  




  Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS




> addEvent will lead to view load again, especially the view just re-used for 
> memory usage
> 
>
> Key: WEEX-98
> URL: https://issues.apache.org/jira/browse/WEEX-98
> Project: Weex
>  Issue Type: Bug
>  Components: iOS
>Reporter: xingZhang
>Assignee: Adam Feng
>
>   In most case , element in cell will be re-use for memory especially in very 
> long list, but if I call addEvent for this element, here will generate a new 
> view for this element.
>  For instance, image element in cell  will re-use if it is disappear in 
> vision area, and loaded again while it back to visual area. In this case , 
> when it disappear, just add event such as click, touch and so on , it will 
> then generate a new view ,and load image again, although it is off-screen.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (WEEX-96) Timer exposed on JSContext can not clear and it has potential crash switching globalQueue

2017-11-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/WEEX-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242485#comment-16242485
 ] 

ASF GitHub Bot commented on WEEX-96:


GitHub user acton393 opened a pull request:

https://github.com/apache/incubator-weex/pull/839

[WEEX-96][iOS] bug-fix about timer exposed on JSContext


  In most case , element in cell will be re-use for memory especially in 
very
long list, but if add event for this element, here will generate a new view 
for
this element,if it's nil due to a  getter method whether it is off-screen.

  For instance, image element in cell will re-use if it is disappear in 
vision area,
loaded again while it back to visual area. In this case , when it 
disappear, just
add event such as click, touch and so on , it will then create a new view,
and load image again, although it is off-screen.

  If the view is not loaded, so won't add gesture or call this view getter 
to create
any view until the view is loaded, then it will init events according to 
record in
component.

Bug: 98


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/acton393/incubator-weex 
ios-bugfix-timer-exposed-in-JSContext

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/839.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #839


commit 45c6c7e6510565030bd8196e194ee0dc542c3f08
Author: acton393 
Date:   2017-11-07T15:07:30Z

[WEEX-96][iOS] bug-fix about timer exposed on JSContext

  Timer exposed on the JSContext, so user can access the function,
though JavaScript, it has setTimeout and setInterval functions, those
function switch to global queue while execute javaScript code, it may
have potential crash about thread safe problem, and for setInterval
function, the timeId can not auto-increment, so it is hard to clear it at
the end of program.
  Overview the code, the difference between timer module and the
JSConext timer is  the execution path is more shorter, the JSContext
timer can execute javascript function immediately, but the timer module
instruction must be dispatched by weex sdk just like the common modules,
the JSContext can be used in canvas scene.

Bug: 96




> Timer exposed on JSContext can not clear and it has potential crash switching 
> globalQueue
> -
>
> Key: WEEX-96
> URL: https://issues.apache.org/jira/browse/WEEX-96
> Project: Weex
>  Issue Type: Bug
>Reporter: xingZhang
>Assignee: Adam Feng
>Priority: Critical
>
> 1. timer can not be clear
> As the WXJSCoreBridge file  in [line 
> 544](https://github.com/apache/incubator-weex/blob/master/ios/sdk/WeexSDK/Sources/Bridge/WXJSCoreBridge.m#L544)
>   shows the code, the appId is a string , so it will never be cleared.
> 2. timer execute js function in global queue may have potential crash, it had 
> better execution in current thread.
> WXJSCoreBridge  
> https://github.com/apache/incubator-weex/blob/master/ios/sdk/WeexSDK/Sources/Bridge/WXJSCoreBridge.m#L535
> 3. timerId will always be 1, not auto-increment as the count of timer 
> increasing
> https://github.com/apache/incubator-weex/blob/master/ios/sdk/WeexSDK/Sources/Bridge/WXJSCoreBridge.m#L513



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (WEEX-94) scroller component can lead to crash in iOS 8 and older iOS version

2017-11-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/WEEX-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242477#comment-16242477
 ] 

ASF GitHub Bot commented on WEEX-94:


GitHub user acton393 opened a pull request:

https://github.com/apache/incubator-weex/pull/838

[WEEX-94][iOS] fix iOS 8 scrollview assign delegate crash

As iOS developers all knowns, assign property will not be set nil when its
object deallocated, and weak object will does, so we must set it to the nil
value, in case of crash about messaging to zombie object. In iOS 8 and
the older iOS, the property of delegate of UIScrollView is assign, so we
must set it to nil manually when object deallocated. And in iOS 9 and later
iOS, apple change the delegate property of UIScrollView it to weak, so we
don't set it to nil value any more. For compatibility on iOS 8, here we must
set it to nil value.

Bug: 94

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/acton393/incubator-weex 
ios-bugfix-scrollview-assign-delegate

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/838.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #838


commit e0564d153e510b23613bda76facd89fc29e0b848
Author: acton393 
Date:   2017-11-07T14:18:24Z

[WEEX-94][iOS] fix iOS 8 scrollview assign delegate crash

As iOS developers all knowns, assign property will not be set nil when its
object deallocated, and weak object will does, so we must set it to the nil
value, in case of crash about messaging to zombie object. In iOS 8 and
the older iOS, the property of delegate of UIScrollView is assign, so we
must set it to nil manually when object deallocated. And in iOS 9 and later
iOS, apple change the delegate property of UIScrollView it to weak, so we
don't set it to nil value any more. For compatibility on iOS 8, here we must
set it to nil value.

Bug: 94




> scroller component can lead to crash in iOS 8 and older iOS version
> ---
>
> Key: WEEX-94
> URL: https://issues.apache.org/jira/browse/WEEX-94
> Project: Weex
>  Issue Type: Bug
>  Components: iOS
>Reporter: xingZhang
>Assignee: Adam Feng
> Attachments: 屏幕快照 2017-11-07 20.47.29.png
>
>
>As iOS developers knows, assign property object will not be set as nil 
> when its object deallocated, and weak property will do.
>We found crash only on iOS 8 about scrollview delegate zombie object now, 
> it is necessary to fix it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (WEEX-94) scroller component can lead to crash in iOS 8 and older iOS version

2017-11-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/WEEX-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242473#comment-16242473
 ] 

ASF GitHub Bot commented on WEEX-94:


Github user acton393 closed the pull request at:

https://github.com/apache/incubator-weex/pull/836


> scroller component can lead to crash in iOS 8 and older iOS version
> ---
>
> Key: WEEX-94
> URL: https://issues.apache.org/jira/browse/WEEX-94
> Project: Weex
>  Issue Type: Bug
>  Components: iOS
>Reporter: xingZhang
>Assignee: Adam Feng
> Attachments: 屏幕快照 2017-11-07 20.47.29.png
>
>
>As iOS developers knows, assign property object will not be set as nil 
> when its object deallocated, and weak property will do.
>We found crash only on iOS 8 about scrollview delegate zombie object now, 
> it is necessary to fix it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (WEEX-98) addEvent will lead to view load again, especially the view just re-used for memory usage

2017-11-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/WEEX-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242442#comment-16242442
 ] 

ASF GitHub Bot commented on WEEX-98:


GitHub user acton393 opened a pull request:

https://github.com/apache/incubator-weex/pull/837

[WEEX-98][iOS]bug-fix addEvent lead to generate a new view while it as been 
recycled


  In most case , element in cell will be re-use for memory especially in 
very
long list, but if add event for this element, here will generate a new view 
for
this element,if it's nil due to a  getter method whether it is off-screen.

  For instance, image element in cell will re-use if it is disappear in 
vision area,
loaded again while it back to visual area. In this case , when it 
disappear, just
add event such as click, touch and so on , it will then create a new view,
and load image again, although it is off-screen.

  If the view is not loaded, so won't add gesture or call this view getter 
to create
any view until the view is loaded, then it will init events according to 
record in
component.

Bug: 98


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/acton393/incubator-weex 
ios-bugfix-event-leadToView-loaded-again

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/837.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #837


commit 62677d7cffd2c94abfd4d82e5b3797f65872f91e
Author: acton393 
Date:   2017-11-07T17:18:26Z

[WEEX-98][iOS]bug-fix addEvent lead to generate a new view while it has 
been recycled

  In most case , element in cell will be re-use for memory especially in 
very
long list, but if add event for this element, here will generate a new view 
for
this element,if it's nil due to a  getter method whether it is off-screen.

  For instance, image element in cell will re-use if it is disappear in 
vision area,
loaded again while it back to visual area. In this case , when it 
disappear, just
add event such as click, touch and so on , it will then create a new view,
and load image again, although it is off-screen.

  If the view is not loaded, so won't add gesture or call this view getter 
to create
any view until the view is loaded, then it will init events according to 
record in
component.

Bug: 98




> addEvent will lead to view load again, especially the view just re-used for 
> memory usage
> 
>
> Key: WEEX-98
> URL: https://issues.apache.org/jira/browse/WEEX-98
> Project: Weex
>  Issue Type: Bug
>  Components: iOS
>Reporter: xingZhang
>Assignee: Adam Feng
>
>   In most case , element in cell will be re-use for memory especially in very 
> long list, but if I call addEvent for this element, here will generate a new 
> view for this element.
>  For instance, image element in cell  will re-use if it is disappear in 
> vision area, and loaded again while it back to visual area. In this case , 
> when it disappear, just add event such as click, touch and so on , it will 
> then generate a new view ,and load image again, although it is off-screen.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (WEEX-98) addEvent will lead to view load again, especially the view just re-used for memory usage

2017-11-07 Thread xingZhang (JIRA)
xingZhang created WEEX-98:
-

 Summary: addEvent will lead to view load again, especially the 
view just re-used for memory usage
 Key: WEEX-98
 URL: https://issues.apache.org/jira/browse/WEEX-98
 Project: Weex
  Issue Type: Bug
  Components: iOS
Reporter: xingZhang
Assignee: Adam Feng


  In most case , element in cell will be re-use for memory especially in very 
long list, but if I call addEvent for this element, here will generate a new 
view for this element.

 For instance, image element in cell  will re-use if it is disappear in vision 
area, and loaded again while it back to visual area. In this case , when it 
disappear, just add event such as click, touch and so on , it will then 
generate a new view ,and load image again, although it is off-screen.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (WEEX-94) scroller component can lead to crash in iOS 8 and older iOS version

2017-11-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/WEEX-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242296#comment-16242296
 ] 

ASF GitHub Bot commented on WEEX-94:


Github user acton393 commented on the issue:

https://github.com/apache/incubator-weex/pull/836
  
Okay,I will make it change in my next pull request. 


> scroller component can lead to crash in iOS 8 and older iOS version
> ---
>
> Key: WEEX-94
> URL: https://issues.apache.org/jira/browse/WEEX-94
> Project: Weex
>  Issue Type: Bug
>  Components: iOS
>Reporter: xingZhang
>Assignee: Adam Feng
> Attachments: 屏幕快照 2017-11-07 20.47.29.png
>
>
>As iOS developers knows, assign property object will not be set as nil 
> when its object deallocated, and weak property will do.
>We found crash only on iOS 8 about scrollview delegate zombie object now, 
> it is necessary to fix it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (WEEX-94) scroller component can lead to crash in iOS 8 and older iOS version

2017-11-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/WEEX-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242169#comment-16242169
 ] 

ASF GitHub Bot commented on WEEX-94:


Github user cxfeng1 commented on the issue:

https://github.com/apache/incubator-weex/pull/836
  
@acton393  one PR for one issue, please


> scroller component can lead to crash in iOS 8 and older iOS version
> ---
>
> Key: WEEX-94
> URL: https://issues.apache.org/jira/browse/WEEX-94
> Project: Weex
>  Issue Type: Bug
>  Components: iOS
>Reporter: xingZhang
>Assignee: Adam Feng
> Attachments: 屏幕快照 2017-11-07 20.47.29.png
>
>
>As iOS developers knows, assign property object will not be set as nil 
> when its object deallocated, and weak property will do.
>We found crash only on iOS 8 about scrollview delegate zombie object now, 
> it is necessary to fix it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (WEEX-94) scroller component can lead to crash in iOS 8 and older iOS version

2017-11-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/WEEX-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242152#comment-16242152
 ] 

ASF GitHub Bot commented on WEEX-94:


Github user weex-bot commented on the issue:

https://github.com/apache/incubator-weex/pull/836
  






  

  
  Messages

  
  
  :book:
  has no jsfm file changed.

  

  :book:
  jsfm test finished.

  




  Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS




> scroller component can lead to crash in iOS 8 and older iOS version
> ---
>
> Key: WEEX-94
> URL: https://issues.apache.org/jira/browse/WEEX-94
> Project: Weex
>  Issue Type: Bug
>  Components: iOS
>Reporter: xingZhang
>Assignee: Adam Feng
> Attachments: 屏幕快照 2017-11-07 20.47.29.png
>
>
>As iOS developers knows, assign property object will not be set as nil 
> when its object deallocated, and weak property will do.
>We found crash only on iOS 8 about scrollview delegate zombie object now, 
> it is necessary to fix it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (WEEX-94) scroller component can lead to crash in iOS 8 and older iOS version

2017-11-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/WEEX-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242149#comment-16242149
 ] 

ASF GitHub Bot commented on WEEX-94:


GitHub user acton393 opened a pull request:

https://github.com/apache/incubator-weex/pull/836

[WEEX-94][iOS] fix iOS 8 scrollview assign delegate crash

[WEEX-94][iOS] fix iOS 8 scrollview assign delegate crash
[WEEX-96][iOS] bug-fix about timer exposed on JSContext

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/acton393/incubator-weex 
ios-feature-0.16-bugfix-master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/836.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #836


commit 773cf1f8efa4354825812f6fae6d3a68e7ad1945
Author: acton393 
Date:   2017-11-07T14:18:24Z

[WEEX-94][iOS] fix iOS 8 scrollview assign delegate crash

As iOS developers all knowns, assign property will not be set nil when its
object deallocated, and weak object will does, so we must set it to the nil
value, in case of crash about messaging to zombie object. In iOS 8 and
the older iOS, the property of delegate of UIScrollView is assign, so we
must set it to nil manually when object deallocated. And in iOS 9 and later
iOS, apple change the delegate property of UIScrollView it to weak, so we
don't set it to nil value any more. For compatibility on iOS 8, here we must
set it to nil value.

Bug: 94

commit dcb6975b7c9cb037660535f11c17eb62154e178d
Author: acton393 
Date:   2017-11-07T15:07:30Z

[WEEX-96][iOS] bug-fix about timer exposed on JSContext

  Timer exposed on the JSContext, so user can access the function,
though JavaScript, it has setTimeout and setInterval functions, those
function switch to global queue while execute javaScript code, it may
have potential crash about thread safe problem, and for setInterval
function, the timeId can not auto-increment, so it is hard to clear it at
the end of program.
  Overview the code, the difference between timer module and the
JSConext timer is  the execution path is more shorter, the JSContext
timer can execute javascript function immediately, but the timer module
instruction must be dispatched by weex sdk just like the common modules,
the JSContext can be used in canvas scene.

Bug: 96




> scroller component can lead to crash in iOS 8 and older iOS version
> ---
>
> Key: WEEX-94
> URL: https://issues.apache.org/jira/browse/WEEX-94
> Project: Weex
>  Issue Type: Bug
>  Components: iOS
>Reporter: xingZhang
>Assignee: Adam Feng
> Attachments: 屏幕快照 2017-11-07 20.47.29.png
>
>
>As iOS developers knows, assign property object will not be set as nil 
> when its object deallocated, and weak property will do.
>We found crash only on iOS 8 about scrollview delegate zombie object now, 
> it is necessary to fix it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] incubator-weex-site pull request #2: [WEEX-86] Update documentation for cont...

2017-11-07 Thread cxfeng1
Github user cxfeng1 closed the pull request at:

https://github.com/apache/incubator-weex-site/pull/2


---


[jira] [Commented] (WEEX-86) Reorganize the structure of documents and website

2017-11-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/WEEX-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242144#comment-16242144
 ] 

ASF GitHub Bot commented on WEEX-86:


Github user cxfeng1 closed the pull request at:

https://github.com/apache/incubator-weex-site/pull/2


> Reorganize the structure of documents and website
> -
>
> Key: WEEX-86
> URL: https://issues.apache.org/jira/browse/WEEX-86
> Project: Weex
>  Issue Type: Improvement
>  Components: Project 
>Reporter: Hanks Zhang
>Assignee: zhengshihan
>
> h1. Weex Document Index
> + contributing.md
> + development-process.md
> + who-is-using-weex.md
> + releasenote.md
> + resources.md
> h2. Guide
> + index.md
> + advanced
>   + app-architecture.md
>   + downgrade.md
>   + page-architecture.md
>   + path.md
>   + use-vuex-and-vue-router.md
> + extend-android.md
> + extend-ios.md
> + extend-js-framework.md
> + extend-web-render.md
> + front-end-frameworks.md
> + integrate-devtool-to-android.md
> + integrate-devtool-to-ios.md
> + integrate-to-your-app.md
> + set-up-env.md
> + using-rax.md
> + using-vue.md
> h2.  References
> + index.md
> + android-apis.md
> + ios-apis.md
> + js-framework-apis.md
> + js-service.md
> + weex-variable.md
> h3. Components
> + a.md
> + cell.md
> + div.md
> + image.md
> + indicator.md
> + input.md
> + list.md
> + loading.md
> + refresh.md
> + scroller.md
> + slider.md
> + switch.md
> + text.md
> + textarea.md
> + video.md
> + waterfall.md
> + web.md
> h3. Modules
> + animation.md
> + clipboard.md
> + dom.md
> + globalevent.md
> + meta.md
> + modal.md
> + navigator.md
> + picker.md
> + storage.md
> + stream.md
> + websocket.md
> + webview.md
> h2. WiKi
> + color-names.md
> + common-events.md
> + common-styles.md
> + css-units.md
> + design-principles.md
> + event-bubble.md
> + faq.md
> + gestures.md
> + index.md
> + platform-difference.md
> + text-styles.md
> h2. Tools
> + helpers.md
> + index.md
> + market.md
> + toolkit.md



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (WEEX-97) font-weight and linear-gradient can't be reset on iOS and web

2017-11-07 Thread Hanks Zhang (JIRA)
Hanks Zhang created WEEX-97:
---

 Summary: font-weight and linear-gradient can't be reset on iOS and 
web
 Key: WEEX-97
 URL: https://issues.apache.org/jira/browse/WEEX-97
 Project: Weex
  Issue Type: Bug
  Components: iOS, Web Renderer
Reporter: Hanks Zhang
Assignee: xingZhang


See the example below, click the tex will toggle its styles. But the 
font-weight couldn't be reset on iOS, the linear-gradient couldn't be reset on 
web. Android is fine.

http://dotwe.org/vue/ecf6a20bde4c42ae4e7b6314ebce4438



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (WEEX-86) Reorganize the structure of documents and website

2017-11-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/WEEX-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242019#comment-16242019
 ] 

ASF GitHub Bot commented on WEEX-86:


Github user tralves commented on the issue:

https://github.com/apache/incubator-weex-site/pull/8
  
This PR is outdated since yesterday, as Drew Hansen explained in [this 
email](https://mail-archives.apache.org/mod_mbox/incubator-weex-dev/201711.mbox/%3cCAHYLpMzROK6N4TG6Wcft6vh6CC=17Bvm+-=fb77ocuity_7...@mail.gmail.com%3e).

I will retest the process and update this PR accordingly.


> Reorganize the structure of documents and website
> -
>
> Key: WEEX-86
> URL: https://issues.apache.org/jira/browse/WEEX-86
> Project: Weex
>  Issue Type: Improvement
>  Components: Project 
>Reporter: Hanks Zhang
>Assignee: zhengshihan
>
> h1. Weex Document Index
> + contributing.md
> + development-process.md
> + who-is-using-weex.md
> + releasenote.md
> + resources.md
> h2. Guide
> + index.md
> + advanced
>   + app-architecture.md
>   + downgrade.md
>   + page-architecture.md
>   + path.md
>   + use-vuex-and-vue-router.md
> + extend-android.md
> + extend-ios.md
> + extend-js-framework.md
> + extend-web-render.md
> + front-end-frameworks.md
> + integrate-devtool-to-android.md
> + integrate-devtool-to-ios.md
> + integrate-to-your-app.md
> + set-up-env.md
> + using-rax.md
> + using-vue.md
> h2.  References
> + index.md
> + android-apis.md
> + ios-apis.md
> + js-framework-apis.md
> + js-service.md
> + weex-variable.md
> h3. Components
> + a.md
> + cell.md
> + div.md
> + image.md
> + indicator.md
> + input.md
> + list.md
> + loading.md
> + refresh.md
> + scroller.md
> + slider.md
> + switch.md
> + text.md
> + textarea.md
> + video.md
> + waterfall.md
> + web.md
> h3. Modules
> + animation.md
> + clipboard.md
> + dom.md
> + globalevent.md
> + meta.md
> + modal.md
> + navigator.md
> + picker.md
> + storage.md
> + stream.md
> + websocket.md
> + webview.md
> h2. WiKi
> + color-names.md
> + common-events.md
> + common-styles.md
> + css-units.md
> + design-principles.md
> + event-bubble.md
> + faq.md
> + gestures.md
> + index.md
> + platform-difference.md
> + text-styles.md
> h2. Tools
> + helpers.md
> + index.md
> + market.md
> + toolkit.md



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] incubator-weex-site issue #8: [WEEX-86][doc] Adds a guide on how to create a...

2017-11-07 Thread tralves
Github user tralves commented on the issue:

https://github.com/apache/incubator-weex-site/pull/8
  
This PR is outdated since yesterday, as Drew Hansen explained in [this 
email](https://mail-archives.apache.org/mod_mbox/incubator-weex-dev/201711.mbox/%3cCAHYLpMzROK6N4TG6Wcft6vh6CC=17Bvm+-=fb77ocuity_7...@mail.gmail.com%3e).

I will retest the process and update this PR accordingly.


---


Re: Plugin development

2017-11-07 Thread Drew Hansen
Hi Tiago,

I can not more agree with your idea,  and the current plugin integration
mechanism still has some problems, I think it's time we should put some
people in order to optimize the developer experience with plugins.

Thanks for getting back to me.


[jira] [Created] (WEEX-96) Timer exposed on JSContext can not clear and it has potential crash switching globalQueue

2017-11-07 Thread xingZhang (JIRA)
xingZhang created WEEX-96:
-

 Summary: Timer exposed on JSContext can not clear and it has 
potential crash switching globalQueue
 Key: WEEX-96
 URL: https://issues.apache.org/jira/browse/WEEX-96
 Project: Weex
  Issue Type: Bug
Reporter: xingZhang
Assignee: Adam Feng
Priority: Critical



1. timer can not be clear
As the WXJSCoreBridge file  in [line 
544](https://github.com/apache/incubator-weex/blob/master/ios/sdk/WeexSDK/Sources/Bridge/WXJSCoreBridge.m#L544)
  shows the code, the appId is a string , so it will never be cleared.

2. timer execute js function in global queue may have potential crash, it had 
better execution in current thread.
WXJSCoreBridge  
https://github.com/apache/incubator-weex/blob/master/ios/sdk/WeexSDK/Sources/Bridge/WXJSCoreBridge.m#L535

3. timerId will always be 1, not auto-increment as the count of timer increasing
https://github.com/apache/incubator-weex/blob/master/ios/sdk/WeexSDK/Sources/Bridge/WXJSCoreBridge.m#L513





--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (WEEX-95) border-radius is overlap on Android

2017-11-07 Thread Hanks Zhang (JIRA)
Hanks Zhang created WEEX-95:
---

 Summary: border-radius is overlap on Android
 Key: WEEX-95
 URL: https://issues.apache.org/jira/browse/WEEX-95
 Project: Weex
  Issue Type: Bug
Reporter: Hanks Zhang
Assignee: Adam Feng


Look the example below, it should be a ring with pure blue color. But it 
rendered many little circles within the border on Android.

http://dotwe.org/vue/d182d36928fe79b8555324d79ed2feb5



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Re: How about creating a project channel?

2017-11-07 Thread Tiago Alves
Hi,

I understand your perspective and accept your position. The mail list must
be the official channel, and everything important should go through there.

Maybe later we can go back to this idea. I still think that a Slack or
Gitter channel, if properly supervised, would even help the mailing list.
For example, I started writing in the mailing list because Hanks pushed me
to do so in the gitter channel. The problem with unofficial channels is
that they are not listed in the official website...

Cheers!
Tiago

On Tue, 7 Nov 2017 at 01:54 Adam Feng  wrote:

> Hi Tiago
>
> Thanks for you suggestion.
>
> As Raphael said, chat is only the second communications tool at ASF, the
> problem for us before was chatting too much(in some Chinese chat tools),
> now we should first make our mailing list active enough.
>
> I think unofficial chat channels are fine,  but I suggest bring all the
> developers to mailing list first and not create any official channel for
> now.
>
>
> Thanks.
> Adam Feng
>
> On 7 Nov 2017, 5:52 AM +0800, wrote:
> >
> > Hi Tiago
> >
> > No, we have no problem with proprietary channels, as long the main
> > discussions are on the Mailing lists. There are several projects using
> > Slack, others uses HipChat. Just keep in mind, chat it's only the second
> > communications tool at ASF. As you wrote, for quick questions, etc.
> >
> > But I like chat too in some case.
>


[jira] [Created] (WEEX-94) scroller component can lead to crash in iOS 8 and older iOS version

2017-11-07 Thread xingZhang (JIRA)
xingZhang created WEEX-94:
-

 Summary: scroller component can lead to crash in iOS 8 and older 
iOS version
 Key: WEEX-94
 URL: https://issues.apache.org/jira/browse/WEEX-94
 Project: Weex
  Issue Type: Bug
  Components: iOS
Reporter: xingZhang
Assignee: Adam Feng
 Attachments: 屏幕快照 2017-11-07 20.47.29.png

   As iOS developers knows, assign property object will not be set as nil when 
its object deallocated, and weak property will do.
   We found crash only on iOS 8 about scrollview delegate zombie object now, it 
is necessary to fix it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Re: Plugin development

2017-11-07 Thread Tiago Alves
Hi Drew!

Wow, that is a lot of work. Thanks! I will try the new code later.

About the documentation, I just had submitted a PR to incubator-weex-site
, which is obviously
now outdated. I will merge your docs into that PR.

Also, I think that the documentation inside the plugin template does not
need instructions on how to create the plugin because the user obviously
already did that part. Instead, I suggest that the plugin template only has
documentation on:
1- how to install dependencies,
2- starting the debug apps
3- developing the plugin (with references to the extend-ios, extend-android
and extend-web docs, like you mentioned).

Tiago

On Tue, 7 Nov 2017 at 06:50 Drew Hansen  wrote:

> Hi, Tiago,
>
>  I have fixed this issue in the latest version of weexpack, you can update
> it with the command below:
>
> `rm -rf ~/.xtoolkit/node_modules/weexpack && weex update weexpack`
>
> Re-create your plugin project by `weex plugin create xxx`.
>
> In addition to fixing some issues on Android, some changes have also been
> made to the Initialized project:
>
> 1. Due to the fact that the ".we" project has been stopped for the moment,
> the support for ".we" in the plugin development has been removed.
>
> 2. Remove "./start" and "./start-web" file, because these commands do not
> support the development of all normal platforms (such as windows). As an
> alternative, you can startup playground via the `npm run start:web` command
> and `npm run start:native` command.
>
> 3. Added more tips on how to build thrid-part module or component on
> javascript.
>
> 4. I think we also need to put the document in the initialization project
> to facilitate the developer to view, so I created two folders en and cn-zh
> to save the doc, I will regularly pull the latest document from the
> document on "incubator-weex-site" to the folders.
>
> Let me know if you have any questions or concerns.
>
> Thanks!
>
> 2017-11-07 11:26 GMT+08:00 Tiago Alves :
>
> > Hi,
> >
> > I have been digging my issues and this is what I found:
> >
> > 1- I am really using the latest playground app. My project is using this
> > code:
> > https://github.com/weexteam/generator-weex-plugin/tree/
> > feature-generator/generators/app/templates/playground/android
> >
> > 2- I had to make the following changes:
> >
> > *playground/android/build.gradle:*
> >  - removed Alibaba maven repositories and added mavenCentral()
> >  - Android Studio upgraded gradle to 3.0.0
> >
> > *playground/**android/app/build.gradle:*
> >  - commented the lines
> > // compile ('com.taobao.android:weex_debug:0.0.1@aar') {
> > // transitive = false
> > // }
> >
> > *android/library/build.gradle:*
> >  - add the line
> > annotationProcessor 'org.weex.plugin:processor:1.0.2'
> >
> > 3- Android Studio made other changes automatically, like sdk versions
> etc.
> >
> > 4- *In the end, the playground app runs but it shows the demo playground
> > app instead of the app with the plugin.*
> >
> > I am sorry I couldn't find all the issues. Probably some of the problems
> > are caused by my machine set up...
> >
> > Any clues?
> >
> > Thanks!
> > Tiago
> >
> > On Tue, 7 Nov 2017 at 00:08 Tiago Alves  wrote:
> >
> > > Hi!
> > >
> > > Unfortunately, the android project still doesn't open.
> > >
> > > I am opening the project in Android Studio from the
> > > playground/android/build.gradle. Android Studio stays loading forever
> > with
> > > the message:
> > > Gradle: Resolve dependencies ':app:_debugCompile...
> > >
> > > This is my setup:
> > > ➜  ios git:(master) ✗ weex -v
> > >v1.1.0-beta.6
> > >  - weexpack : v0.4.7-beta.19
> > >  - weex-builder : v0.2.13-beta.4
> > >  - weex-devtool : v0.3.2-beta.7
> > >  - weex-previewer : v1.3.13-beta.8
> > >
> > > Am I doing something wrong?
> > >
> > > Thanks,
> > > Tiago
> > >
> > > On Mon, 6 Nov 2017 at 12:52 Tiago Alves  wrote:
> > >
> > >> Thanks! I will try that.
> > >>
> > >> Tiago
> > >>
> > >> On Mon, 6 Nov 2017 at 09:42 misakuo  wrote:
> > >>
> > >>> Hi Tiago,
> > >>>
> > >>> We found the old version of weexpack relied on an incorrect android
> > >>> project
> > >>> template that missing some necessary files. We just released a new
> > >>> version
> > >>> of weexpack,  you can upgrade it according to the following steps:
> > >>>
> > >>> 1. run " rm -rf ~/.xtoolkit/node_modules/weexpack "
> > >>> 2. run " weex update weexpack "
> > >>> 3. create a new plugin project using " weex plugin create xxx "
> > >>>
> > >>> Then you should be able to run playground app inslde the plugin
> project
> > >>> correctly. If you have any other questions, just feel free to ask us.
> > >>>
> > >>> Cheers.
> > >>> Misakuo
> > >>>
> > >>>
> > >>> 2017-11-05 2:06 GMT+08:00 Tiago Alves :
> > >>>
> > >>> > Good day!
> > >>> >
> > >>> > I am developing a weex plugin. I feel it will be a great oportunity
> > >>> for me
> > >>> > to help improving the plugin docs.
> > >>> >
> > >>> > I remember reading docs about de

Re: Plugin development

2017-11-07 Thread Drew Hansen
Hi, Tiago,

 I have fixed this issue in the latest version of weexpack, you can update
it with the command below:

`rm -rf ~/.xtoolkit/node_modules/weexpack && weex update weexpack`

Re-create your plugin project by `weex plugin create xxx`.

In addition to fixing some issues on Android, some changes have also been
made to the Initialized project:

1. Due to the fact that the ".we" project has been stopped for the moment,
the support for ".we" in the plugin development has been removed.

2. Remove "./start" and "./start-web" file, because these commands do not
support the development of all normal platforms (such as windows). As an
alternative, you can startup playground via the `npm run start:web` command
and `npm run start:native` command.

3. Added more tips on how to build thrid-part module or component on
javascript.

4. I think we also need to put the document in the initialization project
to facilitate the developer to view, so I created two folders en and cn-zh
to save the doc, I will regularly pull the latest document from the
document on "incubator-weex-site" to the folders.

Let me know if you have any questions or concerns.

Thanks!

2017-11-07 11:26 GMT+08:00 Tiago Alves :

> Hi,
>
> I have been digging my issues and this is what I found:
>
> 1- I am really using the latest playground app. My project is using this
> code:
> https://github.com/weexteam/generator-weex-plugin/tree/
> feature-generator/generators/app/templates/playground/android
>
> 2- I had to make the following changes:
>
> *playground/android/build.gradle:*
>  - removed Alibaba maven repositories and added mavenCentral()
>  - Android Studio upgraded gradle to 3.0.0
>
> *playground/**android/app/build.gradle:*
>  - commented the lines
> // compile ('com.taobao.android:weex_debug:0.0.1@aar') {
> // transitive = false
> // }
>
> *android/library/build.gradle:*
>  - add the line
> annotationProcessor 'org.weex.plugin:processor:1.0.2'
>
> 3- Android Studio made other changes automatically, like sdk versions etc.
>
> 4- *In the end, the playground app runs but it shows the demo playground
> app instead of the app with the plugin.*
>
> I am sorry I couldn't find all the issues. Probably some of the problems
> are caused by my machine set up...
>
> Any clues?
>
> Thanks!
> Tiago
>
> On Tue, 7 Nov 2017 at 00:08 Tiago Alves  wrote:
>
> > Hi!
> >
> > Unfortunately, the android project still doesn't open.
> >
> > I am opening the project in Android Studio from the
> > playground/android/build.gradle. Android Studio stays loading forever
> with
> > the message:
> > Gradle: Resolve dependencies ':app:_debugCompile...
> >
> > This is my setup:
> > ➜  ios git:(master) ✗ weex -v
> >v1.1.0-beta.6
> >  - weexpack : v0.4.7-beta.19
> >  - weex-builder : v0.2.13-beta.4
> >  - weex-devtool : v0.3.2-beta.7
> >  - weex-previewer : v1.3.13-beta.8
> >
> > Am I doing something wrong?
> >
> > Thanks,
> > Tiago
> >
> > On Mon, 6 Nov 2017 at 12:52 Tiago Alves  wrote:
> >
> >> Thanks! I will try that.
> >>
> >> Tiago
> >>
> >> On Mon, 6 Nov 2017 at 09:42 misakuo  wrote:
> >>
> >>> Hi Tiago,
> >>>
> >>> We found the old version of weexpack relied on an incorrect android
> >>> project
> >>> template that missing some necessary files. We just released a new
> >>> version
> >>> of weexpack,  you can upgrade it according to the following steps:
> >>>
> >>> 1. run " rm -rf ~/.xtoolkit/node_modules/weexpack "
> >>> 2. run " weex update weexpack "
> >>> 3. create a new plugin project using " weex plugin create xxx "
> >>>
> >>> Then you should be able to run playground app inslde the plugin project
> >>> correctly. If you have any other questions, just feel free to ask us.
> >>>
> >>> Cheers.
> >>> Misakuo
> >>>
> >>>
> >>> 2017-11-05 2:06 GMT+08:00 Tiago Alves :
> >>>
> >>> > Good day!
> >>> >
> >>> > I am developing a weex plugin. I feel it will be a great oportunity
> >>> for me
> >>> > to help improving the plugin docs.
> >>> >
> >>> > I remember reading docs about developing a weex plugin (plugin.xml,
> >>> etc),
> >>> > but thats seems to be gone along with the legacy stuff. Is there any
> >>> docs
> >>> > that would help me getting started?
> >>> >
> >>> > I am using this plugin as reference
> >>> > https://github.com/weex-plugins/weex-amap, but this sort of reverse
> >>> > engineering gives the constant feeling that I am missing out on
> >>> something.
> >>> >
> >>> > Thanks!
> >>> > Tiago
> >>> >
> >>>
> >>
>