[jira] [Updated] (WEEX-485) change the index of Slider works bad when set its 'scrollable' as 'false'
[ https://issues.apache.org/jira/browse/WEEX-485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] billy updated WEEX-485: --- Description: slider设置scrollable为false后，在Android平台上，通过点击导航tab切换index时slider页面切换正常，但如果用户在slider中进行横向滑动操作，再点击导航tab切换index会显示异常： index从2切换到3时表现为切换不成功页面未切换， index从2切换到0时表现为页面显示空白， 再从0切换到2时，恢复正常。 如果用户再进行横向滑动操作，又会出现相同的情况 --- 新增测试页面 - 测试页面： [http://dotwe.org/vue/b0686d8f778f67d9bea443cda54f7775] 复现步骤： 1. 用android版playground扫描二维码打开页面 2. 点击red 3. 点击yellow 4. 横向手势滑动 5. 点击red（复现成功：没有切换到red） was: slider设置scrollable为false后，在Android平台上，通过点击导航tab切换index时slider页面切换正常，但如果用户在slider中进行横向滑动操作，再点击导航tab切换index会显示异常： index从2切换到3时表现为切换不成功页面未切换， index从2切换到0时表现为页面显示空白， 再从0切换到2时，恢复正常。 如果用户再进行横向滑动操作，又会出现相同的情况 > change the index of Slider works bad when set its 'scrollable' as 'false' > - > > Key: WEEX-485 > URL: https://issues.apache.org/jira/browse/WEEX-485 > Project: Weex > Issue Type: Bug > Components: Android >Affects Versions: 0.18 >Reporter: billy >Assignee: codefurture >Priority: Major > > slider设置scrollable为false后，在Android平台上，通过点击导航tab切换index时slider页面切换正常，但如果用户在slider中进行横向滑动操作，再点击导航tab切换index会显示异常： > index从2切换到3时表现为切换不成功页面未切换， > index从2切换到0时表现为页面显示空白， > 再从0切换到2时，恢复正常。 > 如果用户再进行横向滑动操作，又会出现相同的情况 > --- 新增测试页面 > - > 测试页面： [http://dotwe.org/vue/b0686d8f778f67d9bea443cda54f7775] > 复现步骤： > 1. 用android版playground扫描二维码打开页面 > 2. 点击red > 3. 点击yellow > 4. 横向手势滑动 > 5. 点击red（复现成功：没有切换到red） -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-485) change the index of Slider works bad when set its 'scrollable' as 'false'
[ https://issues.apache.org/jira/browse/WEEX-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527190#comment-16527190 ] billy commented on WEEX-485: 测试页面： [http://dotwe.org/vue/b0686d8f778f67d9bea443cda54f7775] 复现步骤： 1. 用android版playground扫描二维码打开页面 2. 点击red 3. 点击yellow 4. 横向手势滑动 5. 点击red（复现成功：没有切换到red） > change the index of Slider works bad when set its 'scrollable' as 'false' > - > > Key: WEEX-485 > URL: https://issues.apache.org/jira/browse/WEEX-485 > Project: Weex > Issue Type: Bug > Components: Android >Affects Versions: 0.18 >Reporter: billy >Assignee: codefurture >Priority: Major > > slider设置scrollable为false后，在Android平台上，通过点击导航tab切换index时slider页面切换正常，但如果用户在slider中进行横向滑动操作，再点击导航tab切换index会显示异常： > index从2切换到3时表现为切换不成功页面未切换， > index从2切换到0时表现为页面显示空白， > 再从0切换到2时，恢复正常。 > 如果用户再进行横向滑动操作，又会出现相同的情况 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-487) Slider控件设置scrollable="false"在android上无法禁止滑动
[
https://issues.apache.org/jira/browse/WEEX-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527145#comment-16527145
]
ASF GitHub Bot commented on WEEX-487:
-
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/1302
Warnings
:warning:
No Changelog changes!
Messages
:book:
danger test finished.
Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS
> Slider控件设置scrollable="false"在android上无法禁止滑动
> ---
>
> Key: WEEX-487
> URL: https://issues.apache.org/jira/browse/WEEX-487
> Project: Weex
> Issue Type: Bug
> Components: Android
>Affects Versions: 0.18
>Reporter: billy
>Assignee: codefurture
>Priority: Major
>
> 需求是实现一个导航tab + 多个页面进行切换，但希望禁用其滑动手势，通过导航tab切换index
> 使用Slider控件，但按照文档设置scrollable="false"在Android设备上并没有禁用滑动手势，发现网上也有人遇到同样的问题：
> [https://segmentfault.com/q/101014254067]
> 查看WXSlider的源码发现：在setScrollable方法中进行了判断：
> if(mAdapter.getRealCount() > 0) {
> mViewPager.setScrollable(scrollable);
> }
> 在刚创建的时候getRealCount()为0，所以未生效，我们现在采用的临时方案是在mounted回调函数中设置Slider的scrollable属性
> 这个mAdapter.getRealCount() > 0的判断是否可以移除呢？
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WEEX-487) Slider控件设置scrollable="false"在android上无法禁止滑动
[
https://issues.apache.org/jira/browse/WEEX-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527144#comment-16527144
]
ASF GitHub Bot commented on WEEX-487:
-
GitHub user luckybilly opened a pull request:
https://github.com/apache/incubator-weex/pull/1302
[WEEX-487][Android] bug fix: scrollable="false" not work on android
[WEEX-487][Android] bug fix: scrollable="false" not work on android
issue: [[WEEX-487]](https://issues.apache.org/jira/browse/WEEX-487)
remove `mAdapter.getRealCount() > 0` from [WXSlider.setScrollable(boolean
scrollable)](https://github.com/apache/incubator-weex/blob/master/android/sdk/src/main/java/com/taobao/weex/ui/component/WXSlider.java#L403:10)
```java
@WXComponentProp(name = Constants.Name.SCROLLABLE)
public void setScrollable(boolean scrollable) {
if (mViewPager != null && mAdapter != null) {
if(mAdapter.getRealCount() > 0){ //remove this line, because there is
no data when init slider
mViewPager.setScrollable(scrollable);
}
}
}
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/luckybilly/incubator-weex
fix-slider-scrollable
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/1302.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1302
commit c64bda5c3f20c38b5d9eea8497a2b475fdddb394
Author: qiyi
Date: 2018-06-29T03:48:39Z
[WEEX-487][Android] bug fix: scrollable="false" not work on android
> Slider控件设置scrollable="false"在android上无法禁止滑动
> ---
>
> Key: WEEX-487
> URL: https://issues.apache.org/jira/browse/WEEX-487
> Project: Weex
> Issue Type: Bug
> Components: Android
>Affects Versions: 0.18
>Reporter: billy
>Assignee: codefurture
>Priority: Major
>
> 需求是实现一个导航tab + 多个页面进行切换，但希望禁用其滑动手势，通过导航tab切换index
> 使用Slider控件，但按照文档设置scrollable="false"在Android设备上并没有禁用滑动手势，发现网上也有人遇到同样的问题：
> [https://segmentfault.com/q/101014254067]
> 查看WXSlider的源码发现：在setScrollable方法中进行了判断：
> if(mAdapter.getRealCount() > 0) {
> mViewPager.setScrollable(scrollable);
> }
> 在刚创建的时候getRealCount()为0，所以未生效，我们现在采用的临时方案是在mounted回调函数中设置Slider的scrollable属性
> 这个mAdapter.getRealCount() > 0的判断是否可以移除呢？
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (WEEX-487) Slider控件设置scrollable="false"在android上无法禁止滑动
billy created WEEX-487:
--
Summary: Slider控件设置scrollable="false"在android上无法禁止滑动
Key: WEEX-487
URL: https://issues.apache.org/jira/browse/WEEX-487
Project: Weex
Issue Type: Bug
Components: Android
Affects Versions: 0.18
Reporter: billy
Assignee: codefurture
需求是实现一个导航tab + 多个页面进行切换，但希望禁用其滑动手势，通过导航tab切换index
使用Slider控件，但按照文档设置scrollable="false"在Android设备上并没有禁用滑动手势，发现网上也有人遇到同样的问题：
[https://segmentfault.com/q/101014254067]
查看WXSlider的源码发现：在setScrollable方法中进行了判断：
if(mAdapter.getRealCount() > 0) {
mViewPager.setScrollable(scrollable);
}
在刚创建的时候getRealCount()为0，所以未生效，我们现在采用的临时方案是在mounted回调函数中设置Slider的scrollable属性
这个mAdapter.getRealCount() > 0的判断是否可以移除呢？
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (WEEX-486) when i use navigator to implement multipage on android , OOM crash will easily happened
fdh19979 created WEEX-486: - Summary: when i use navigator to implement multipage on android , OOM crash will easily happened Key: WEEX-486 URL: https://issues.apache.org/jira/browse/WEEX-486 Project: Weex Issue Type: Bug Components: Android Affects Versions: 0.19 Reporter: fdh19979 Assignee: codefurture 修改webpack，实现多页面打包，在原生每个activity或者controller中render一个JS文件 我发现在安卓中，使用WXFileUtils中loadAsset时，很容易在readStreamToString中出现OOM内存溢出 使用android profile发现，不停开启新页面的情况下，内存占用一直上升，关闭页面后，内存占用并不会下降 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-485) change the index of Slider works bad when set its 'scrollable' as 'false'
[ https://issues.apache.org/jira/browse/WEEX-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527124#comment-16527124 ] ASF GitHub Bot commented on WEEX-485: - Github user weex-bot commented on the issue: https://github.com/apache/incubator-weex/pull/1301 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS > change the index of Slider works bad when set its 'scrollable' as 'false' > - > > Key: WEEX-485 > URL: https://issues.apache.org/jira/browse/WEEX-485 > Project: Weex > Issue Type: Bug > Components: Android >Affects Versions: 0.18 >Reporter: billy >Assignee: codefurture >Priority: Major > > slider设置scrollable为false后，在Android平台上，通过点击导航tab切换index时slider页面切换正常，但如果用户在slider中进行横向滑动操作，再点击导航tab切换index会显示异常： > index从2切换到3时表现为切换不成功页面未切换， > index从2切换到0时表现为页面显示空白， > 再从0切换到2时，恢复正常。 > 如果用户再进行横向滑动操作，又会出现相同的情况 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-485) change the index of Slider works bad when set its 'scrollable' as 'false'
[ https://issues.apache.org/jira/browse/WEEX-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527123#comment-16527123 ] ASF GitHub Bot commented on WEEX-485: - GitHub user luckybilly opened a pull request: https://github.com/apache/incubator-weex/pull/1301 [WEEX-485][Android] fix slider bug: scroll when scrollable=false make… [WEEX-485][Android] fix slider bug: scroll when scrollable=false make index not work issue: [[WEEX-485]](https://issues.apache.org/jira/browse/WEEX-485) You can merge this pull request into a Git repository by running: $ git pull https://github.com/luckybilly/incubator-weex fix_slider Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex/pull/1301.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1301 commit e9b1641e2ee4d486df21e527020ba702b211c78d Author: qiyi Date: 2018-06-29T03:23:25Z [WEEX-485][Android] fix slider bug: scroll when scrollable=false make index not work > change the index of Slider works bad when set its 'scrollable' as 'false' > - > > Key: WEEX-485 > URL: https://issues.apache.org/jira/browse/WEEX-485 > Project: Weex > Issue Type: Bug > Components: Android >Affects Versions: 0.18 >Reporter: billy >Assignee: codefurture >Priority: Major > > slider设置scrollable为false后，在Android平台上，通过点击导航tab切换index时slider页面切换正常，但如果用户在slider中进行横向滑动操作，再点击导航tab切换index会显示异常： > index从2切换到3时表现为切换不成功页面未切换， > index从2切换到0时表现为页面显示空白， > 再从0切换到2时，恢复正常。 > 如果用户再进行横向滑动操作，又会出现相同的情况 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (WEEX-485) change the index of Slider works bad when set its 'scrollable' as 'false'
billy created WEEX-485: -- Summary: change the index of Slider works bad when set its 'scrollable' as 'false' Key: WEEX-485 URL: https://issues.apache.org/jira/browse/WEEX-485 Project: Weex Issue Type: Bug Components: Android Affects Versions: 0.18 Reporter: billy Assignee: codefurture slider设置scrollable为false后，在Android平台上，通过点击导航tab切换index时slider页面切换正常，但如果用户在slider中进行横向滑动操作，再点击导航tab切换index会显示异常： index从2切换到3时表现为切换不成功页面未切换， index从2切换到0时表现为页面显示空白， 再从0切换到2时，恢复正常。 如果用户再进行横向滑动操作，又会出现相同的情况 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: Suggestion on moving Weex Code Repo to Gitbox
+1 It will be convenient for us if we can use Github issues and pull requests. Thanks. Adam Feng 在 2018年6月28日 +0800 PM6:14，申远 ，写道： > Hi, Folks > > Apache Infa now provided us read/write access directly to weex repos on > Github through a utility called Gitbox( https://gitbox.apache.org/). PMCs > have the option to embrace the Gitbox and using Github UI to review code, > merge PRs. > > For now, there are plenty of Apache projects hosted by GItbox( > https://gitbox.apache.org/repos/asf). Personally, I am fascinated by the > idea of directly access to Github, which will make committers life far more > easy. > > I'd like to suggest that we host Apache Weex ( > https://git-wip-us.apache.org/repos/asf?p=incubator-weex.git) on Gitbox to > enable read/write access of Repos on Github. > -- > > > Best regards, > > York Shen
回复：Suggestion on moving Weex Code Repo to Gitbox
vote +1 -- 发件人：申远 发送时间：2018年6月28日(星期四) 18:14 收件人：dev@weex.incubator.apache.org 主 题：Suggestion on moving Weex Code Repo to Gitbox Hi, Folks Apache Infa now provided us read/write access directly to weex repos on Github through a utility called Gitbox( https://gitbox.apache.org/). PMCs have the option to embrace the Gitbox and using Github UI to review code, merge PRs. For now, there are plenty of Apache projects hosted by GItbox( https://gitbox.apache.org/repos/asf). Personally, I am fascinated by the idea of directly access to Github, which will make committers life far more easy. I'd like to suggest that we host Apache Weex ( https://git-wip-us.apache.org/repos/asf?p=incubator-weex.git) on Gitbox to enable read/write access of Repos on Github. -- Best regards, York Shen
Suggestion on moving Weex Code Repo to Gitbox
Hi, Folks Apache Infa now provided us read/write access directly to weex repos on Github through a utility called Gitbox( https://gitbox.apache.org/). PMCs have the option to embrace the Gitbox and using Github UI to review code, merge PRs. For now, there are plenty of Apache projects hosted by GItbox( https://gitbox.apache.org/repos/asf). Personally, I am fascinated by the idea of directly access to Github, which will make committers life far more easy. I'd like to suggest that we host Apache Weex ( https://git-wip-us.apache.org/repos/asf?p=incubator-weex.git) on Gitbox to enable read/write access of Repos on Github. -- Best regards, York Shen
Re: [VOTE]: Release Apache Weex (Incubating) 0.19.0 [RC2]
+1 Thank you for the release. 2018-06-27 11:13 GMT+08:00 Jason Xu : > +1 > Thank you for the release. > > 2018-06-27 8:02 GMT+08:00 方曦(千之) : > > > +1. > > Thank you for the release work. > > > > 发自我的 iPhone > > > > > 在 2018年6月26日，21:32，申远 写道： > > > > > > +1 > > > Thank you for the release > > > > > > -- > Thanks. > Jason Xu >
[jira] [Commented] (WEEX-342) The index attribute of the slider component does not work on Android.
[ https://issues.apache.org/jira/browse/WEEX-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526122#comment-16526122 ] ASF GitHub Bot commented on WEEX-342: - Github user asfgit closed the pull request at: https://github.com/apache/incubator-weex-site/pull/169 > The index attribute of the slider component does not work on Android. > - > > Key: WEEX-342 > URL: https://issues.apache.org/jira/browse/WEEX-342 > Project: Weex > Issue Type: Bug > Components: Android >Affects Versions: 0.18 >Reporter: 杜相国 >Assignee: codefurture >Priority: Blocker > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] incubator-weex-site pull request #169: [WEEX-342][android] add waterfall and...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-weex-site/pull/169 ---
[jira] [Commented] (WEEX-342) The index attribute of the slider component does not work on Android.
[ https://issues.apache.org/jira/browse/WEEX-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526120#comment-16526120 ] ASF GitHub Bot commented on WEEX-342: - GitHub user gubaojian opened a pull request: https://github.com/apache/incubator-weex-site/pull/169 [WEEX-342][android] add waterfall and touch event sync dispatch example [WEEX-342][android] add waterfall and touch event sync dispatch example You can merge this pull request into a Git repository by running: $ git pull https://github.com/gubaojian/incubator-weex-site weex_site_touch Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex-site/pull/169.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #169 commit 269785322937ebcbce00403e0dcb7d5409a19369 Author: jianbai.gbj Date: 2018-06-28T08:49:25Z [WEEX-342][android] add waterfall and touch event sync dispatch example > The index attribute of the slider component does not work on Android. > - > > Key: WEEX-342 > URL: https://issues.apache.org/jira/browse/WEEX-342 > Project: Weex > Issue Type: Bug > Components: Android >Affects Versions: 0.18 >Reporter: 杜相国 >Assignee: codefurture >Priority: Blocker > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] incubator-weex-site pull request #169: [WEEX-342][android] add waterfall and...
GitHub user gubaojian opened a pull request: https://github.com/apache/incubator-weex-site/pull/169 [WEEX-342][android] add waterfall and touch event sync dispatch example [WEEX-342][android] add waterfall and touch event sync dispatch example You can merge this pull request into a Git repository by running: $ git pull https://github.com/gubaojian/incubator-weex-site weex_site_touch Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-weex-site/pull/169.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #169 commit 269785322937ebcbce00403e0dcb7d5409a19369 Author: jianbai.gbj Date: 2018-06-28T08:49:25Z [WEEX-342][android] add waterfall and touch event sync dispatch example ---
