Re: Suggestion on moving Weex Code Repo to Gitbox

2018-06-29 Thread Jonathan Dong
Vote +1.

It seems we need to get the privilege first to see if there’s any side effect. 
Anyway I believe this is good for the project.

I also hope it brings convenience in setting up the Travis cron jobs, which 
could enable us to make daily build

> On Jun 29, 2018, at 4:22 PM, Hanks Zhang  wrote:
> 
> Sounds good if PMCs have the permission to manage issues and PRs on GitHub
> directly, but I wonder if there are any side effects of the migration.
> What's the process and what will be happened about the "git-wip-us" repo?
> 
> Adam Feng  于2018年6月28日周四 下午7:49写道:
> 
>> +1
>> 
>> It will be convenient for us if we can use Github issues and pull requests.
>> 
>> 
>> Thanks.
>> Adam Feng
>> 在 2018年6月28日 +0800 PM6:14,申远 ,写道:
>>> Hi, Folks
>>> 
>>> Apache Infa now provided us read/write access directly to weex repos on
>>> Github through a utility called Gitbox( https://gitbox.apache.org/).
>> PMCs
>>> have the option to embrace the Gitbox and using Github UI to review code,
>>> merge PRs.
>>> 
>>> For now, there are plenty of Apache projects hosted by GItbox(
>>> https://gitbox.apache.org/repos/asf). Personally, I am fascinated by the
>>> idea of directly access to Github, which will make committers life far
>> more
>>> easy.
>>> 
>>> I'd like to suggest that we host Apache Weex (
>>> https://git-wip-us.apache.org/repos/asf?p=incubator-weex.git) on Gitbox
>> to
>>> enable read/write access of Repos on Github.
>>> --
>>> 
>>> 
>>> Best regards,
>>> 
>>> York Shen
>> 



Re: Suggestion on moving Weex Code Repo to Gitbox

2018-06-29 Thread Hanks Zhang
Sounds good if PMCs have the permission to manage issues and PRs on GitHub
directly, but I wonder if there are any side effects of the migration.
What's the process and what will be happened about the "git-wip-us" repo?

Adam Feng  于2018年6月28日周四 下午7:49写道:

> +1
>
> It will be convenient for us if we can use Github issues and pull requests.
>
>
> Thanks.
> Adam Feng
> 在 2018年6月28日 +0800 PM6:14,申远 ,写道:
> > Hi, Folks
> >
> > Apache Infa now provided us read/write access directly to weex repos on
> > Github through a utility called Gitbox( https://gitbox.apache.org/).
> PMCs
> > have the option to embrace the Gitbox and using Github UI to review code,
> > merge PRs.
> >
> > For now, there are plenty of Apache projects hosted by GItbox(
> > https://gitbox.apache.org/repos/asf). Personally, I am fascinated by the
> > idea of directly access to Github, which will make committers life far
> more
> > easy.
> >
> > I'd like to suggest that we host Apache Weex (
> > https://git-wip-us.apache.org/repos/asf?p=incubator-weex.git) on Gitbox
> to
> > enable read/write access of Repos on Github.
> > --
> >
> >
> > Best regards,
> >
> > York Shen
>


[jira] [Commented] (WEEX-488) InstanceWrap unavailable

2018-06-29 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/WEEX-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527288#comment-16527288
 ] 

ASF GitHub Bot commented on WEEX-488:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-weex/pull/1303


> InstanceWrap unavailable
> 
>
> Key: WEEX-488
> URL: https://issues.apache.org/jira/browse/WEEX-488
> Project: Weex
>  Issue Type: Bug
>Reporter: YorkShen
>Assignee: Adam Feng
>Priority: Major
>
> Downgrade module unavaliable



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (WEEX-488) InstanceWrap unavailable

2018-06-29 Thread YorkShen (JIRA)


 [ 
https://issues.apache.org/jira/browse/WEEX-488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

YorkShen updated WEEX-488:
--
Summary: InstanceWrap unavailable  (was: InstanceWrap unavaliable)

> InstanceWrap unavailable
> 
>
> Key: WEEX-488
> URL: https://issues.apache.org/jira/browse/WEEX-488
> Project: Weex
>  Issue Type: Bug
>Reporter: YorkShen
>Assignee: Adam Feng
>Priority: Major
>
> Downgrade module unavaliable



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WEEX-488) InstanceWrap unavailable

2018-06-29 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/WEEX-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527285#comment-16527285
 ] 

ASF GitHub Bot commented on WEEX-488:
-

GitHub user YorkShen opened a pull request:

https://github.com/apache/incubator-weex/pull/1303

[Weex-488] InstanceWrap unavailable on Android

https://issues.apache.org/jira/browse/WEEX-488

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/YorkShen/incubator-weex bugfix_downgrade

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/1303.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1303


commit 6149d49d70409faacad25e4759a564446c290838
Author: YorkShen 
Date:   2018-06-29T06:46:36Z

Revert "* [Android] Fix potential memory leak."

This reverts commit 361df72 and fix memory leak by make instanceWrap not 
global

(cherry picked from commit 07f8250)




> InstanceWrap unavailable
> 
>
> Key: WEEX-488
> URL: https://issues.apache.org/jira/browse/WEEX-488
> Project: Weex
>  Issue Type: Bug
>Reporter: YorkShen
>Assignee: Adam Feng
>Priority: Major
>
> Downgrade module unavaliable



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (WEEX-488) InstanceWrap unavaliable

2018-06-29 Thread YorkShen (JIRA)
YorkShen created WEEX-488:
-

 Summary: InstanceWrap unavaliable
 Key: WEEX-488
 URL: https://issues.apache.org/jira/browse/WEEX-488
 Project: Weex
  Issue Type: Bug
Reporter: YorkShen
Assignee: Adam Feng


Downgrade module unavaliable



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)