[DISCUSS] The Content of Weex Podling Report
Hi, Weex Community The board meeting of Apache is near, we should finish the IPMC report this week. Here is the report outline, there are many questions we should answer. I will prepare the most of them, please feel free to add your comments. Weex Weex is a framework for building high-performance mobile apps with modern web development experience. Weex has been incubating since 2016-11-30. Three most important issues to address in the move towards graduation: 1. 2. 3. Any issues that the Incubator PMC (IPMC) or ASF Board wish/need to be aware of? How has the community developed since the last report? How has the project developed since the last report? How would you assess the podling's maturity? Please feel free to add your own commentary. [ ] Initial setup [ ] Working towards the first release [x] Community building [ ] Nearing graduation [ ] Other: Date of the last release: 2018-10-08 (v0.19.0) When were the last committers or PPMC members elected? Have your mentors been helpful and responsive or are things falling through the cracks? In the latter case, please list any open issues that need to be addressed. Signed-off-by: IPMC/Shepherd notes: - Best Regards, Hanks
[jira] [Commented] (WEEX-648) introduce native batch for dom operations generating from javaScript
[
https://issues.apache.org/jira/browse/WEEX-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667241#comment-16667241
]
ASF GitHub Bot commented on WEEX-648:
-
wqyfavor commented on a change in pull request #1644: [WEEX-648][iOS]native
batch for dom operations generating from JavaScript
URL: https://github.com/apache/incubator-weex/pull/1644#discussion_r228933843
##
File path: ios/sdk/WeexSDK/Sources/Manager/WXComponentManager.mm
##
@@ -991,8 +991,38 @@ - (void) _printFlexComponentFrame:(WXComponent *)component
- (void)_syncUITasks
{
-NSArray *blocks = _uiTaskQueue;
-_uiTaskQueue = [NSMutableArray array];
+static NSInteger _syncUITaskCount = 0;
+NSInteger mismatchBeginIndex = _uiTaskQueue.count;
+for (NSInteger i = _uiTaskQueue.count - 1;i >= 0;i --) {
+if (_uiTaskQueue[i] == WXPerformUITaskBatchEndBlock) {
+_syncUITaskCount = 0;
+// clear when find the matches for end and begin tag
+break;
+}
+if (_uiTaskQueue[i] == WXPerformUITaskBatchBeginBlock) {
+mismatchBeginIndex = i;
+break;
+}
+}
+
+NSArray *blocks = nil;
Review comment:
blocks声明放到下面if (mismatchBeginIndex > 0)里吧
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> introduce native batch for dom operations generating from javaScript
>
>
> Key: WEEX-648
> URL: https://issues.apache.org/jira/browse/WEEX-648
> Project: Weex
> Issue Type: Improvement
> Components: Android, iOS
>Reporter: xingZhang
>Assignee: xingZhang
>Priority: Major
>
> We will introduce native batch for dom operations generating from javaScript
> wrap a series of dom operations with beginBatch and endBatch directives, when
> every V-sync signal comes, we ensure that the operations between beginBatch
> and endBatch can be performed in current V-sync, this policy can drop frames
> maybe, for our policy dropping frames, we only allow 20 frames at most.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WEEX-648) introduce native batch for dom operations generating from javaScript
[ https://issues.apache.org/jira/browse/WEEX-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667237#comment-16667237 ] ASF GitHub Bot commented on WEEX-648: - wqyfavor commented on a change in pull request #1644: [WEEX-648][iOS]native batch for dom operations generating from JavaScript URL: https://github.com/apache/incubator-weex/pull/1644#discussion_r228933129 ## File path: ios/sdk/WeexSDK/Sources/Manager/WXComponentManager.h ## @@ -262,4 +262,18 @@ void WXPerformBlockSyncOnComponentThread(void (^block)(void)); */ - (void)enumerateComponentsUsingBlock:(void (^)(WXComponent *, BOOL *stop))block; +#pragma mark batch mark + +/** + a start native batch tag for a group of UI operation , company with performBatchEnd + @see performBatchEnd + */ +- (void)performBatchBegin; + +/** + an end native batch tag for a group of UI operation, company with performBatchBegin Review comment: operation -> operations This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > introduce native batch for dom operations generating from javaScript > > > Key: WEEX-648 > URL: https://issues.apache.org/jira/browse/WEEX-648 > Project: Weex > Issue Type: Improvement > Components: Android, iOS >Reporter: xingZhang >Assignee: xingZhang >Priority: Major > > We will introduce native batch for dom operations generating from javaScript > wrap a series of dom operations with beginBatch and endBatch directives, when > every V-sync signal comes, we ensure that the operations between beginBatch > and endBatch can be performed in current V-sync, this policy can drop frames > maybe, for our policy dropping frames, we only allow 20 frames at most. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-648) introduce native batch for dom operations generating from javaScript
[
https://issues.apache.org/jira/browse/WEEX-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667233#comment-16667233
]
ASF GitHub Bot commented on WEEX-648:
-
wqyfavor commented on a change in pull request #1644: [WEEX-648][iOS]native
batch for dom operations generating from JavaScript
URL: https://github.com/apache/incubator-weex/pull/1644#discussion_r228932652
##
File path: ios/sdk/WeexSDK/Sources/Manager/WXComponentManager.mm
##
@@ -991,8 +991,38 @@ - (void) _printFlexComponentFrame:(WXComponent *)component
- (void)_syncUITasks
{
-NSArray *blocks = _uiTaskQueue;
-_uiTaskQueue = [NSMutableArray array];
+static NSInteger _syncUITaskCount = 0;
+NSInteger mismatchBeginIndex = _uiTaskQueue.count;
+for (NSInteger i = _uiTaskQueue.count - 1;i >= 0;i --) {
+if (_uiTaskQueue[i] == WXPerformUITaskBatchEndBlock) {
+_syncUITaskCount = 0;
+// clear when find the matches for end and begin tag
+break;
+}
+if (_uiTaskQueue[i] == WXPerformUITaskBatchBeginBlock) {
+mismatchBeginIndex = i;
+break;
+}
+}
+
+NSArray *blocks = nil;
+if (mismatchBeginIndex == _uiTaskQueue.count) {
+// here we get end tag or there are not begin and end directives
+} else {
+_syncUITaskCount ++;
+// we only find begin tag but missing end tag,
+if (_syncUITaskCount > (MAX_DROP_FRAME_FOR_BATCH)) {
+// when the wait times come to MAX_DROP_FRAME_FOR_BATCH, we will
pop all the stashed operation for user experience.
Review comment:
stashed operation -> stashed operations
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> introduce native batch for dom operations generating from javaScript
>
>
> Key: WEEX-648
> URL: https://issues.apache.org/jira/browse/WEEX-648
> Project: Weex
> Issue Type: Improvement
> Components: Android, iOS
>Reporter: xingZhang
>Assignee: xingZhang
>Priority: Major
>
> We will introduce native batch for dom operations generating from javaScript
> wrap a series of dom operations with beginBatch and endBatch directives, when
> every V-sync signal comes, we ensure that the operations between beginBatch
> and endBatch can be performed in current V-sync, this policy can drop frames
> maybe, for our policy dropping frames, we only allow 20 frames at most.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WEEX-648) introduce native batch for dom operations generating from javaScript
[ https://issues.apache.org/jira/browse/WEEX-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667235#comment-16667235 ] ASF GitHub Bot commented on WEEX-648: - wqyfavor commented on a change in pull request #1644: [WEEX-648][iOS]native batch for dom operations generating from JavaScript URL: https://github.com/apache/incubator-weex/pull/1644#discussion_r228933022 ## File path: ios/sdk/WeexSDK/Sources/Manager/WXComponentManager.h ## @@ -262,4 +262,18 @@ void WXPerformBlockSyncOnComponentThread(void (^block)(void)); */ - (void)enumerateComponentsUsingBlock:(void (^)(WXComponent *, BOOL *stop))block; +#pragma mark batch mark + +/** + a start native batch tag for a group of UI operation , company with performBatchEnd Review comment: 去掉多余的空格，operation -> operations This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > introduce native batch for dom operations generating from javaScript > > > Key: WEEX-648 > URL: https://issues.apache.org/jira/browse/WEEX-648 > Project: Weex > Issue Type: Improvement > Components: Android, iOS >Reporter: xingZhang >Assignee: xingZhang >Priority: Major > > We will introduce native batch for dom operations generating from javaScript > wrap a series of dom operations with beginBatch and endBatch directives, when > every V-sync signal comes, we ensure that the operations between beginBatch > and endBatch can be performed in current V-sync, this policy can drop frames > maybe, for our policy dropping frames, we only allow 20 frames at most. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-648) introduce native batch for dom operations generating from javaScript
[
https://issues.apache.org/jira/browse/WEEX-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667232#comment-16667232
]
ASF GitHub Bot commented on WEEX-648:
-
wqyfavor commented on a change in pull request #1644: [WEEX-648][iOS]native
batch for dom operations generating from JavaScript
URL: https://github.com/apache/incubator-weex/pull/1644#discussion_r228932274
##
File path: ios/sdk/WeexSDK/Sources/Manager/WXComponentManager.mm
##
@@ -991,8 +991,38 @@ - (void) _printFlexComponentFrame:(WXComponent *)component
- (void)_syncUITasks
{
-NSArray *blocks = _uiTaskQueue;
-_uiTaskQueue = [NSMutableArray array];
+static NSInteger _syncUITaskCount = 0;
+NSInteger mismatchBeginIndex = _uiTaskQueue.count;
+for (NSInteger i = _uiTaskQueue.count - 1;i >= 0;i --) {
+if (_uiTaskQueue[i] == WXPerformUITaskBatchEndBlock) {
+_syncUITaskCount = 0;
+// clear when find the matches for end and begin tag
+break;
+}
+if (_uiTaskQueue[i] == WXPerformUITaskBatchBeginBlock) {
+mismatchBeginIndex = i;
+break;
+}
+}
+
+NSArray *blocks = nil;
+if (mismatchBeginIndex == _uiTaskQueue.count) {
+// here we get end tag or there are not begin and end directives
+} else {
+_syncUITaskCount ++;
+// we only find begin tag but missing end tag,
+if (_syncUITaskCount > (MAX_DROP_FRAME_FOR_BATCH)) {
+// when the wait times come to MAX_DROP_FRAME_FOR_BATCH, we will
pop all the stashed operation for user experience.
+mismatchBeginIndex = _uiTaskQueue.count;
+_syncUITaskCount = 0;
+}
+}
+
+if (mismatchBeginIndex > 0) {
+blocks = [_uiTaskQueue subarrayWithRange:NSMakeRange(0,
mismatchBeginIndex)];
+[_uiTaskQueue removeObjectsInRange:NSMakeRange(0, blocks.count)];
Review comment:
blocks.count换成mismatchBeginIndex吧，看起来更对称一些，而且减少一次blocks.count调用。
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> introduce native batch for dom operations generating from javaScript
>
>
> Key: WEEX-648
> URL: https://issues.apache.org/jira/browse/WEEX-648
> Project: Weex
> Issue Type: Improvement
> Components: Android, iOS
>Reporter: xingZhang
>Assignee: xingZhang
>Priority: Major
>
> We will introduce native batch for dom operations generating from javaScript
> wrap a series of dom operations with beginBatch and endBatch directives, when
> every V-sync signal comes, we ensure that the operations between beginBatch
> and endBatch can be performed in current V-sync, this policy can drop frames
> maybe, for our policy dropping frames, we only allow 20 frames at most.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WEEX-648) introduce native batch for dom operations generating from javaScript
[
https://issues.apache.org/jira/browse/WEEX-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667231#comment-16667231
]
ASF GitHub Bot commented on WEEX-648:
-
wqyfavor commented on a change in pull request #1644: [WEEX-648][iOS]native
batch for dom operations generating from JavaScript
URL: https://github.com/apache/incubator-weex/pull/1644#discussion_r228931993
##
File path: ios/sdk/WeexSDK/Sources/Manager/WXComponentManager.mm
##
@@ -991,8 +991,38 @@ - (void) _printFlexComponentFrame:(WXComponent *)component
- (void)_syncUITasks
{
-NSArray *blocks = _uiTaskQueue;
-_uiTaskQueue = [NSMutableArray array];
+static NSInteger _syncUITaskCount = 0;
+NSInteger mismatchBeginIndex = _uiTaskQueue.count;
+for (NSInteger i = _uiTaskQueue.count - 1;i >= 0;i --) {
+if (_uiTaskQueue[i] == WXPerformUITaskBatchEndBlock) {
+_syncUITaskCount = 0;
+// clear when find the matches for end and begin tag
+break;
+}
+if (_uiTaskQueue[i] == WXPerformUITaskBatchBeginBlock) {
+mismatchBeginIndex = i;
+break;
+}
+}
+
+NSArray *blocks = nil;
+if (mismatchBeginIndex == _uiTaskQueue.count) {
+// here we get end tag or there are not begin and end directives
+} else {
+_syncUITaskCount ++;
+// we only find begin tag but missing end tag,
+if (_syncUITaskCount > (MAX_DROP_FRAME_FOR_BATCH)) {
+// when the wait times come to MAX_DROP_FRAME_FOR_BATCH, we will
pop all the stashed operation for user experience.
+mismatchBeginIndex = _uiTaskQueue.count;
+_syncUITaskCount = 0;
+}
+}
+
+if (mismatchBeginIndex > 0) {
+blocks = [_uiTaskQueue subarrayWithRange:NSMakeRange(0,
mismatchBeginIndex)];
+[_uiTaskQueue removeObjectsInRange:NSMakeRange(0, blocks.count)];
+}
+
Review comment:
把下面的dispatch_async也放到if (mismatchBeginIndex >
0)这个if里面吧，空任务的时候减少一次给main提交block。
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> introduce native batch for dom operations generating from javaScript
>
>
> Key: WEEX-648
> URL: https://issues.apache.org/jira/browse/WEEX-648
> Project: Weex
> Issue Type: Improvement
> Components: Android, iOS
>Reporter: xingZhang
>Assignee: xingZhang
>Priority: Major
>
> We will introduce native batch for dom operations generating from javaScript
> wrap a series of dom operations with beginBatch and endBatch directives, when
> every V-sync signal comes, we ensure that the operations between beginBatch
> and endBatch can be performed in current V-sync, this policy can drop frames
> maybe, for our policy dropping frames, we only allow 20 frames at most.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WEEX-648) introduce native batch for dom operations generating from javaScript
[
https://issues.apache.org/jira/browse/WEEX-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667217#comment-16667217
]
ASF GitHub Bot commented on WEEX-648:
-
wqyfavor commented on a change in pull request #1644: [WEEX-648][iOS]native
batch for dom operations generating from JavaScript
URL: https://github.com/apache/incubator-weex/pull/1644#discussion_r228928742
##
File path: ios/sdk/WeexSDK/Sources/Manager/WXComponentManager.mm
##
@@ -991,8 +991,38 @@ - (void) _printFlexComponentFrame:(WXComponent *)component
- (void)_syncUITasks
{
-NSArray *blocks = _uiTaskQueue;
-_uiTaskQueue = [NSMutableArray array];
+static NSInteger _syncUITaskCount = 0;
Review comment:
_syncUITaskCount不能声明为static，不同的instance有不同的componentManager不能共用一个变量。
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> introduce native batch for dom operations generating from javaScript
>
>
> Key: WEEX-648
> URL: https://issues.apache.org/jira/browse/WEEX-648
> Project: Weex
> Issue Type: Improvement
> Components: Android, iOS
>Reporter: xingZhang
>Assignee: xingZhang
>Priority: Major
>
> We will introduce native batch for dom operations generating from javaScript
> wrap a series of dom operations with beginBatch and endBatch directives, when
> every V-sync signal comes, we ensure that the operations between beginBatch
> and endBatch can be performed in current V-sync, this policy can drop frames
> maybe, for our policy dropping frames, we only allow 20 frames at most.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WEEX-653) feature for Rtl layout
[ https://issues.apache.org/jira/browse/WEEX-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667097#comment-16667097 ] ASF GitHub Bot commented on WEEX-653: - weex-bot edited a comment on issue #1664: [WEEX-653][android][iOS][core] Total platform support rtl direction by CSS "direction:rtl" URL: https://github.com/apache/incubator-weex/pull/1664#issuecomment-432502237 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > feature for Rtl layout > -- > > Key: WEEX-653 > URL: https://issues.apache.org/jira/browse/WEEX-653 > Project: Weex > Issue Type: New Feature > Components: Android, iOS, Web Renderer >Affects Versions: 0.18 >Reporter: Kai Tian >Assignee: YorkShen >Priority: Major > Fix For: 0.18 > > > [android][ios][core] Whole platform support rtl direction by CSS > "direction:rtl" > [core] Update the new layout engine to support inheritable CSS > "direction:rtl". > [ios][android] Update component layer, to support list, slide, scroller RTL > direction. Update WXEnvironment, now we can get system layout direction by > WXEnvironment.layoutDirection. Update WXDomModule, now we can get element > layout direction by getLayoutDirection(ref,callback) > Few languages such as Arabic, Hebrew, or Persian are written from Right to > Left, but weex not support RTL layouts. To handle them. Since this PR merged, > we can use weex for RTL languages in both android and ios. And Scroller > performance like native, layout and scroll direction will be reverse. > > There are some test Demos: > Div+Scroller http://dotwe.org/vue/9c3ee9824dd49111a87a93ea6513039a > Horizontal Scroller http://dotwe.org/vue/0dd282e3183c2384ec38a465c915ce41 > Scroller (ScrollToElement) > http://dotwe.org/vue/a24001978199df6e981673e9460598c8 > Slider http://dotwe.org/vue/7e45bcf71ad396032944bc51541d6350 > Animation http://dotwe.org/vue/b578facdbb623f6922f0905ae09b7e49 > envDirection + getLayoutDirection > http://dotwe.org/vue/d6c5cf7a2a907c33cf4ba25fea6e6ef4 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-653) feature for Rtl layout
[ https://issues.apache.org/jira/browse/WEEX-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667094#comment-16667094 ] ASF GitHub Bot commented on WEEX-653: - weex-bot edited a comment on issue #1664: [WEEX-653][android][iOS][core] Total platform support rtl direction by CSS "direction:rtl" URL: https://github.com/apache/incubator-weex/pull/1664#issuecomment-432502237 Fails :no_entry_sign: Code file weex_core/Source/android/jniprebuild/jniheader/NativeRenderObjectUtils_jni.h does not have the copyright header. Warnings :warning: No Changelog changes! :warning: Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java without metion it in commit message. You'd better add '@notdanger' in your commit log. Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > feature for Rtl layout > -- > > Key: WEEX-653 > URL: https://issues.apache.org/jira/browse/WEEX-653 > Project: Weex > Issue Type: New Feature > Components: Android, iOS, Web Renderer >Affects Versions: 0.18 >Reporter: Kai Tian >Assignee: YorkShen >Priority: Major > Fix For: 0.18 > > > [android][ios][core] Whole platform support rtl direction by CSS > "direction:rtl" > [core] Update the new layout engine to support inheritable CSS > "direction:rtl". > [ios][android] Update component layer, to support list, slide, scroller RTL > direction. Update WXEnvironment, now we can get system layout direction by > WXEnvironment.layoutDirection. Update WXDomModule, now we can get element > layout direction by getLayoutDirection(ref,callback) > Few languages such as Arabic, Hebrew, or Persian are written from Right to > Left, but weex not support RTL layouts. To handle them. Since this PR merged, > we can use weex for RTL languages in both android and ios. And Scroller > performance like native, layout and scroll direction will be reverse. > > There are some test Demos: > Div+Scroller http://dotwe.org/vue/9c3ee9824dd49111a87a93ea6513039a > Horizontal Scroller http://dotwe.org/vue/0dd282e3183c2384ec38a465c915ce41 > Scroller (ScrollToElement) > http://dotwe.org/vue/a24001978199df6e981673e9460598c8 > Slider http://dotwe.org/vue/7e45bcf71ad396032944bc51541d6350 > Animation http://dotwe.org/vue/b578facdbb623f6922f0905ae09b7e49 > envDirection + getLayoutDirection > http://dotwe.org/vue/d6c5cf7a2a907c33cf4ba25fea6e6ef4 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-653) feature for Rtl layout
[ https://issues.apache.org/jira/browse/WEEX-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667092#comment-16667092 ] ASF GitHub Bot commented on WEEX-653: - weex-bot edited a comment on issue #1664: [WEEX-653][android][iOS][core] Total platform support rtl direction by CSS "direction:rtl" URL: https://github.com/apache/incubator-weex/pull/1664#issuecomment-432502237 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > feature for Rtl layout > -- > > Key: WEEX-653 > URL: https://issues.apache.org/jira/browse/WEEX-653 > Project: Weex > Issue Type: New Feature > Components: Android, iOS, Web Renderer >Affects Versions: 0.18 >Reporter: Kai Tian >Assignee: YorkShen >Priority: Major > Fix For: 0.18 > > > [android][ios][core] Whole platform support rtl direction by CSS > "direction:rtl" > [core] Update the new layout engine to support inheritable CSS > "direction:rtl". > [ios][android] Update component layer, to support list, slide, scroller RTL > direction. Update WXEnvironment, now we can get system layout direction by > WXEnvironment.layoutDirection. Update WXDomModule, now we can get element > layout direction by getLayoutDirection(ref,callback) > Few languages such as Arabic, Hebrew, or Persian are written from Right to > Left, but weex not support RTL layouts. To handle them. Since this PR merged, > we can use weex for RTL languages in both android and ios. And Scroller > performance like native, layout and scroll direction will be reverse. > > There are some test Demos: > Div+Scroller http://dotwe.org/vue/9c3ee9824dd49111a87a93ea6513039a > Horizontal Scroller http://dotwe.org/vue/0dd282e3183c2384ec38a465c915ce41 > Scroller (ScrollToElement) > http://dotwe.org/vue/a24001978199df6e981673e9460598c8 > Slider http://dotwe.org/vue/7e45bcf71ad396032944bc51541d6350 > Animation http://dotwe.org/vue/b578facdbb623f6922f0905ae09b7e49 > envDirection + getLayoutDirection > http://dotwe.org/vue/d6c5cf7a2a907c33cf4ba25fea6e6ef4 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-653) feature for Rtl layout
[ https://issues.apache.org/jira/browse/WEEX-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667089#comment-16667089 ] ASF GitHub Bot commented on WEEX-653: - weex-bot edited a comment on issue #1664: [WEEX-653][android][iOS][core] Total platform support rtl direction by CSS "direction:rtl" URL: https://github.com/apache/incubator-weex/pull/1664#issuecomment-432502237 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > feature for Rtl layout > -- > > Key: WEEX-653 > URL: https://issues.apache.org/jira/browse/WEEX-653 > Project: Weex > Issue Type: New Feature > Components: Android, iOS, Web Renderer >Affects Versions: 0.18 >Reporter: Kai Tian >Assignee: YorkShen >Priority: Major > Fix For: 0.18 > > > [android][ios][core] Whole platform support rtl direction by CSS > "direction:rtl" > [core] Update the new layout engine to support inheritable CSS > "direction:rtl". > [ios][android] Update component layer, to support list, slide, scroller RTL > direction. Update WXEnvironment, now we can get system layout direction by > WXEnvironment.layoutDirection. Update WXDomModule, now we can get element > layout direction by getLayoutDirection(ref,callback) > Few languages such as Arabic, Hebrew, or Persian are written from Right to > Left, but weex not support RTL layouts. To handle them. Since this PR merged, > we can use weex for RTL languages in both android and ios. And Scroller > performance like native, layout and scroll direction will be reverse. > > There are some test Demos: > Div+Scroller http://dotwe.org/vue/9c3ee9824dd49111a87a93ea6513039a > Horizontal Scroller http://dotwe.org/vue/0dd282e3183c2384ec38a465c915ce41 > Scroller (ScrollToElement) > http://dotwe.org/vue/a24001978199df6e981673e9460598c8 > Slider http://dotwe.org/vue/7e45bcf71ad396032944bc51541d6350 > Animation http://dotwe.org/vue/b578facdbb623f6922f0905ae09b7e49 > envDirection + getLayoutDirection > http://dotwe.org/vue/d6c5cf7a2a907c33cf4ba25fea6e6ef4 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-653) feature for Rtl layout
[ https://issues.apache.org/jira/browse/WEEX-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667088#comment-16667088 ] ASF GitHub Bot commented on WEEX-653: - weex-bot edited a comment on issue #1664: [WEEX-653][android][iOS][core] Total platform support rtl direction by CSS "direction:rtl" URL: https://github.com/apache/incubator-weex/pull/1664#issuecomment-432502237 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > feature for Rtl layout > -- > > Key: WEEX-653 > URL: https://issues.apache.org/jira/browse/WEEX-653 > Project: Weex > Issue Type: New Feature > Components: Android, iOS, Web Renderer >Affects Versions: 0.18 >Reporter: Kai Tian >Assignee: YorkShen >Priority: Major > Fix For: 0.18 > > > [android][ios][core] Whole platform support rtl direction by CSS > "direction:rtl" > [core] Update the new layout engine to support inheritable CSS > "direction:rtl". > [ios][android] Update component layer, to support list, slide, scroller RTL > direction. Update WXEnvironment, now we can get system layout direction by > WXEnvironment.layoutDirection. Update WXDomModule, now we can get element > layout direction by getLayoutDirection(ref,callback) > Few languages such as Arabic, Hebrew, or Persian are written from Right to > Left, but weex not support RTL layouts. To handle them. Since this PR merged, > we can use weex for RTL languages in both android and ios. And Scroller > performance like native, layout and scroll direction will be reverse. > > There are some test Demos: > Div+Scroller http://dotwe.org/vue/9c3ee9824dd49111a87a93ea6513039a > Horizontal Scroller http://dotwe.org/vue/0dd282e3183c2384ec38a465c915ce41 > Scroller (ScrollToElement) > http://dotwe.org/vue/a24001978199df6e981673e9460598c8 > Slider http://dotwe.org/vue/7e45bcf71ad396032944bc51541d6350 > Animation http://dotwe.org/vue/b578facdbb623f6922f0905ae09b7e49 > envDirection + getLayoutDirection > http://dotwe.org/vue/d6c5cf7a2a907c33cf4ba25fea6e6ef4 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: Podling Report Reminder - November 2018
Sorry for not sending the IPMC report, I will start a discussion and prepare the report this week. Best Regards, Hanks Zhang Willem Jiang 于2018年10月29日周一 下午4:56写道： > As we missed the last month IPMC report. Please prepare your IPMC > report this week. > We can start the discussion on the mailing list first. > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > On Thu, Oct 25, 2018 at 5:34 AM wrote: > > > > Dear podling, > > > > This email was sent by an automated system on behalf of the Apache > > Incubator PMC. It is an initial reminder to give you plenty of time to > > prepare your quarterly board report. > > > > The board meeting is scheduled for Wed, 21 November 2018, 10:30 am PDT. > > The report for your podling will form a part of the Incubator PMC > > report. The Incubator PMC requires your report to be submitted 2 weeks > > before the board meeting, to allow sufficient time for review and > > submission (Wed, November 07). > > > > Please submit your report with sufficient time to allow the Incubator > > PMC, and subsequently board members to review and digest. Again, the > > very latest you should submit your report is 2 weeks prior to the board > > meeting. > > > > Candidate names should not be made public before people are actually > > elected, so please do not include the names of potential committers or > > PPMC members in your report. > > > > Thanks, > > > > The Apache Incubator PMC > > > > Submitting your Report > > > > -- > > > > Your report should contain the following: > > > > * Your project name > > * A brief description of your project, which assumes no knowledge of > > the project or necessarily of its field > > * A list of the three most important issues to address in the move > > towards graduation. > > * Any issues that the Incubator PMC or ASF Board might wish/need to be > > aware of > > * How has the community developed since the last report > > * How has the project developed since the last report. > > * How does the podling rate their own maturity. > > > > This should be appended to the Incubator Wiki page at: > > > > https://wiki.apache.org/incubator/November2018 > > > > Note: This is manually populated. You may need to wait a little before > > this page is created from a template. > > > > Mentors > > --- > > > > Mentors should review reports for their project(s) and sign them off on > > the Incubator wiki page. Signing off reports shows that you are > > following the project - projects that are not signed may raise alarms > > for the Incubator PMC. > > > > Incubator PMC >
[jira] [Commented] (WEEX-653) feature for Rtl layout
[ https://issues.apache.org/jira/browse/WEEX-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1896#comment-1896 ] ASF GitHub Bot commented on WEEX-653: - weex-bot edited a comment on issue #1664: [WEEX-653][android][iOS][core] Total platform support rtl direction by CSS "direction:rtl" URL: https://github.com/apache/incubator-weex/pull/1664#issuecomment-432502237 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > feature for Rtl layout > -- > > Key: WEEX-653 > URL: https://issues.apache.org/jira/browse/WEEX-653 > Project: Weex > Issue Type: New Feature > Components: Android, iOS, Web Renderer >Affects Versions: 0.18 >Reporter: Kai Tian >Assignee: YorkShen >Priority: Major > Fix For: 0.18 > > > [android][ios][core] Whole platform support rtl direction by CSS > "direction:rtl" > [core] Update the new layout engine to support inheritable CSS > "direction:rtl". > [ios][android] Update component layer, to support list, slide, scroller RTL > direction. Update WXEnvironment, now we can get system layout direction by > WXEnvironment.layoutDirection. Update WXDomModule, now we can get element > layout direction by getLayoutDirection(ref,callback) > Few languages such as Arabic, Hebrew, or Persian are written from Right to > Left, but weex not support RTL layouts. To handle them. Since this PR merged, > we can use weex for RTL languages in both android and ios. And Scroller > performance like native, layout and scroll direction will be reverse. > > There are some test Demos: > Div+Scroller http://dotwe.org/vue/9c3ee9824dd49111a87a93ea6513039a > Horizontal Scroller http://dotwe.org/vue/0dd282e3183c2384ec38a465c915ce41 > Scroller (ScrollToElement) > http://dotwe.org/vue/a24001978199df6e981673e9460598c8 > Slider http://dotwe.org/vue/7e45bcf71ad396032944bc51541d6350 > Animation http://dotwe.org/vue/b578facdbb623f6922f0905ae09b7e49 > envDirection + getLayoutDirection > http://dotwe.org/vue/d6c5cf7a2a907c33cf4ba25fea6e6ef4 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-653) feature for Rtl layout
[ https://issues.apache.org/jira/browse/WEEX-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1893#comment-1893 ] ASF GitHub Bot commented on WEEX-653: - weex-bot edited a comment on issue #1664: [WEEX-653][android][iOS][core] Total platform support rtl direction by CSS "direction:rtl" URL: https://github.com/apache/incubator-weex/pull/1664#issuecomment-432502237 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > feature for Rtl layout > -- > > Key: WEEX-653 > URL: https://issues.apache.org/jira/browse/WEEX-653 > Project: Weex > Issue Type: New Feature > Components: Android, iOS, Web Renderer >Affects Versions: 0.18 >Reporter: Kai Tian >Assignee: YorkShen >Priority: Major > Fix For: 0.18 > > > [android][ios][core] Whole platform support rtl direction by CSS > "direction:rtl" > [core] Update the new layout engine to support inheritable CSS > "direction:rtl". > [ios][android] Update component layer, to support list, slide, scroller RTL > direction. Update WXEnvironment, now we can get system layout direction by > WXEnvironment.layoutDirection. Update WXDomModule, now we can get element > layout direction by getLayoutDirection(ref,callback) > Few languages such as Arabic, Hebrew, or Persian are written from Right to > Left, but weex not support RTL layouts. To handle them. Since this PR merged, > we can use weex for RTL languages in both android and ios. And Scroller > performance like native, layout and scroll direction will be reverse. > > There are some test Demos: > Div+Scroller http://dotwe.org/vue/9c3ee9824dd49111a87a93ea6513039a > Horizontal Scroller http://dotwe.org/vue/0dd282e3183c2384ec38a465c915ce41 > Scroller (ScrollToElement) > http://dotwe.org/vue/a24001978199df6e981673e9460598c8 > Slider http://dotwe.org/vue/7e45bcf71ad396032944bc51541d6350 > Animation http://dotwe.org/vue/b578facdbb623f6922f0905ae09b7e49 > envDirection + getLayoutDirection > http://dotwe.org/vue/d6c5cf7a2a907c33cf4ba25fea6e6ef4 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-653) feature for Rtl layout
[ https://issues.apache.org/jira/browse/WEEX-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1894#comment-1894 ] ASF GitHub Bot commented on WEEX-653: - weex-bot edited a comment on issue #1664: [WEEX-653][android][iOS][core] Total platform support rtl direction by CSS "direction:rtl" URL: https://github.com/apache/incubator-weex/pull/1664#issuecomment-432502237 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > feature for Rtl layout > -- > > Key: WEEX-653 > URL: https://issues.apache.org/jira/browse/WEEX-653 > Project: Weex > Issue Type: New Feature > Components: Android, iOS, Web Renderer >Affects Versions: 0.18 >Reporter: Kai Tian >Assignee: YorkShen >Priority: Major > Fix For: 0.18 > > > [android][ios][core] Whole platform support rtl direction by CSS > "direction:rtl" > [core] Update the new layout engine to support inheritable CSS > "direction:rtl". > [ios][android] Update component layer, to support list, slide, scroller RTL > direction. Update WXEnvironment, now we can get system layout direction by > WXEnvironment.layoutDirection. Update WXDomModule, now we can get element > layout direction by getLayoutDirection(ref,callback) > Few languages such as Arabic, Hebrew, or Persian are written from Right to > Left, but weex not support RTL layouts. To handle them. Since this PR merged, > we can use weex for RTL languages in both android and ios. And Scroller > performance like native, layout and scroll direction will be reverse. > > There are some test Demos: > Div+Scroller http://dotwe.org/vue/9c3ee9824dd49111a87a93ea6513039a > Horizontal Scroller http://dotwe.org/vue/0dd282e3183c2384ec38a465c915ce41 > Scroller (ScrollToElement) > http://dotwe.org/vue/a24001978199df6e981673e9460598c8 > Slider http://dotwe.org/vue/7e45bcf71ad396032944bc51541d6350 > Animation http://dotwe.org/vue/b578facdbb623f6922f0905ae09b7e49 > envDirection + getLayoutDirection > http://dotwe.org/vue/d6c5cf7a2a907c33cf4ba25fea6e6ef4 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: Podling Report Reminder - November 2018
As we missed the last month IPMC report. Please prepare your IPMC report this week. We can start the discussion on the mailing list first. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Thu, Oct 25, 2018 at 5:34 AM wrote: > > Dear podling, > > This email was sent by an automated system on behalf of the Apache > Incubator PMC. It is an initial reminder to give you plenty of time to > prepare your quarterly board report. > > The board meeting is scheduled for Wed, 21 November 2018, 10:30 am PDT. > The report for your podling will form a part of the Incubator PMC > report. The Incubator PMC requires your report to be submitted 2 weeks > before the board meeting, to allow sufficient time for review and > submission (Wed, November 07). > > Please submit your report with sufficient time to allow the Incubator > PMC, and subsequently board members to review and digest. Again, the > very latest you should submit your report is 2 weeks prior to the board > meeting. > > Candidate names should not be made public before people are actually > elected, so please do not include the names of potential committers or > PPMC members in your report. > > Thanks, > > The Apache Incubator PMC > > Submitting your Report > > -- > > Your report should contain the following: > > * Your project name > * A brief description of your project, which assumes no knowledge of > the project or necessarily of its field > * A list of the three most important issues to address in the move > towards graduation. > * Any issues that the Incubator PMC or ASF Board might wish/need to be > aware of > * How has the community developed since the last report > * How has the project developed since the last report. > * How does the podling rate their own maturity. > > This should be appended to the Incubator Wiki page at: > > https://wiki.apache.org/incubator/November2018 > > Note: This is manually populated. You may need to wait a little before > this page is created from a template. > > Mentors > --- > > Mentors should review reports for their project(s) and sign them off on > the Incubator wiki page. Signing off reports shows that you are > following the project - projects that are not signed may raise alarms > for the Incubator PMC. > > Incubator PMC
