Re: [NEW MENTOR REQUIRED] Apache Weex (incubating)
+1. I also think Weex needs more guidance from more mentors, they can give advice from different perspectives. On the other hand, most PPMC and committers of Weex are Chinese, we wish Weex can absorb ideas form more world-wide developers from different cultures. Looking forward to your opinions. Best Regards, Hanks Zhang Jonathan Dong 于2018年11月12日周一 下午7:32写道： > Hi Folks, > > I’m writing to seek for new motivated mentors for the Apache Weex > (incubating) project, to drive and mentor the community and project to > graduate. > > Weex is a project aims to build high-performance mobile applications by > leveraging mobile web development experience. It was accepted into the > Apache Incubator since Nov. 30, 2016, there are 2 Apache releases during > the incubation period, and 11 PPMC and 3 committers by now. We have been > struggling with the active mentorship which could lead us through the > podling process and push the project to the graduation, for now we only > have one active mentor Willem Jiang (who helps a lot to grow the community > as well as the processes, thanks), and we believe it’s the right time to > invite one more mentor or two to offload some mentoring duty from Willem > and push us through the graduation. > > If you are interested, please let use know at > dev@weex.incubator.apache.org. Looking forward to your guidance. > > Cheers, > > Jonathan Dong >
[jira] [Commented] (WEEX-653) feature for Rtl layout
[ https://issues.apache.org/jira/browse/WEEX-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16686024#comment-16686024 ] ASF GitHub Bot commented on WEEX-653: - weex-bot edited a comment on issue #1664: [WEEX-653][android][iOS][core] Total platform support rtl direction by CSS "direction:rtl" URL: https://github.com/apache/incubator-weex/pull/1664#issuecomment-432502237 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > feature for Rtl layout > -- > > Key: WEEX-653 > URL: https://issues.apache.org/jira/browse/WEEX-653 > Project: Weex > Issue Type: New Feature > Components: Android, iOS, Web Renderer >Affects Versions: 0.18 >Reporter: Kai Tian >Assignee: YorkShen >Priority: Major > Fix For: 0.18 > > > [android][ios][core] Whole platform support rtl direction by CSS > "direction:rtl" > [core] Update the new layout engine to support inheritable CSS > "direction:rtl". > [ios][android] Update component layer, to support list, slide, scroller RTL > direction. Update WXEnvironment, now we can get system layout direction by > WXEnvironment.layoutDirection. Update WXDomModule, now we can get element > layout direction by getLayoutDirection(ref,callback) > Few languages such as Arabic, Hebrew, or Persian are written from Right to > Left, but weex not support RTL layouts. To handle them. Since this PR merged, > we can use weex for RTL languages in both android and ios. And Scroller > performance like native, layout and scroll direction will be reverse. > > There are some test Demos: > Div+Scroller http://dotwe.org/vue/9c3ee9824dd49111a87a93ea6513039a > Horizontal Scroller http://dotwe.org/vue/0dd282e3183c2384ec38a465c915ce41 > Scroller (ScrollToElement) > http://dotwe.org/vue/a24001978199df6e981673e9460598c8 > Slider http://dotwe.org/vue/7e45bcf71ad396032944bc51541d6350 > Animation http://dotwe.org/vue/b578facdbb623f6922f0905ae09b7e49 > envDirection + getLayoutDirection > http://dotwe.org/vue/d6c5cf7a2a907c33cf4ba25fea6e6ef4 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-653) feature for Rtl layout
[ https://issues.apache.org/jira/browse/WEEX-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16686021#comment-16686021 ] ASF GitHub Bot commented on WEEX-653: - weex-bot edited a comment on issue #1664: [WEEX-653][android][iOS][core] Total platform support rtl direction by CSS "direction:rtl" URL: https://github.com/apache/incubator-weex/pull/1664#issuecomment-432502237 Fails :no_entry_sign: Code file weex_core/Source/android/jniprebuild/jniheader/NativeRenderObjectUtils_jni.h does not have the copyright header. Warnings :warning: No Changelog changes! :warning: Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java without metion it in commit message. You'd better add '@notdanger' in your commit log. Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > feature for Rtl layout > -- > > Key: WEEX-653 > URL: https://issues.apache.org/jira/browse/WEEX-653 > Project: Weex > Issue Type: New Feature > Components: Android, iOS, Web Renderer >Affects Versions: 0.18 >Reporter: Kai Tian >Assignee: YorkShen >Priority: Major > Fix For: 0.18 > > > [android][ios][core] Whole platform support rtl direction by CSS > "direction:rtl" > [core] Update the new layout engine to support inheritable CSS > "direction:rtl". > [ios][android] Update component layer, to support list, slide, scroller RTL > direction. Update WXEnvironment, now we can get system layout direction by > WXEnvironment.layoutDirection. Update WXDomModule, now we can get element > layout direction by getLayoutDirection(ref,callback) > Few languages such as Arabic, Hebrew, or Persian are written from Right to > Left, but weex not support RTL layouts. To handle them. Since this PR merged, > we can use weex for RTL languages in both android and ios. And Scroller > performance like native, layout and scroll direction will be reverse. > > There are some test Demos: > Div+Scroller http://dotwe.org/vue/9c3ee9824dd49111a87a93ea6513039a > Horizontal Scroller http://dotwe.org/vue/0dd282e3183c2384ec38a465c915ce41 > Scroller (ScrollToElement) > http://dotwe.org/vue/a24001978199df6e981673e9460598c8 > Slider http://dotwe.org/vue/7e45bcf71ad396032944bc51541d6350 > Animation http://dotwe.org/vue/b578facdbb623f6922f0905ae09b7e49 > envDirection + getLayoutDirection > http://dotwe.org/vue/d6c5cf7a2a907c33cf4ba25fea6e6ef4 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-653) feature for Rtl layout
[ https://issues.apache.org/jira/browse/WEEX-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16686022#comment-16686022 ] ASF GitHub Bot commented on WEEX-653: - weex-bot edited a comment on issue #1664: [WEEX-653][android][iOS][core] Total platform support rtl direction by CSS "direction:rtl" URL: https://github.com/apache/incubator-weex/pull/1664#issuecomment-432502237 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > feature for Rtl layout > -- > > Key: WEEX-653 > URL: https://issues.apache.org/jira/browse/WEEX-653 > Project: Weex > Issue Type: New Feature > Components: Android, iOS, Web Renderer >Affects Versions: 0.18 >Reporter: Kai Tian >Assignee: YorkShen >Priority: Major > Fix For: 0.18 > > > [android][ios][core] Whole platform support rtl direction by CSS > "direction:rtl" > [core] Update the new layout engine to support inheritable CSS > "direction:rtl". > [ios][android] Update component layer, to support list, slide, scroller RTL > direction. Update WXEnvironment, now we can get system layout direction by > WXEnvironment.layoutDirection. Update WXDomModule, now we can get element > layout direction by getLayoutDirection(ref,callback) > Few languages such as Arabic, Hebrew, or Persian are written from Right to > Left, but weex not support RTL layouts. To handle them. Since this PR merged, > we can use weex for RTL languages in both android and ios. And Scroller > performance like native, layout and scroll direction will be reverse. > > There are some test Demos: > Div+Scroller http://dotwe.org/vue/9c3ee9824dd49111a87a93ea6513039a > Horizontal Scroller http://dotwe.org/vue/0dd282e3183c2384ec38a465c915ce41 > Scroller (ScrollToElement) > http://dotwe.org/vue/a24001978199df6e981673e9460598c8 > Slider http://dotwe.org/vue/7e45bcf71ad396032944bc51541d6350 > Animation http://dotwe.org/vue/b578facdbb623f6922f0905ae09b7e49 > envDirection + getLayoutDirection > http://dotwe.org/vue/d6c5cf7a2a907c33cf4ba25fea6e6ef4 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-661) [iOS] dev-tool feature , analyze interaction info
[ https://issues.apache.org/jira/browse/WEEX-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685407#comment-16685407 ] ASF GitHub Bot commented on WEEX-661: - weex-bot edited a comment on issue #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#issuecomment-438257775 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] dev-tool feature , analyze interaction info > -- > > Key: WEEX-661 > URL: https://issues.apache.org/jira/browse/WEEX-661 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-661) [iOS] dev-tool feature , analyze interaction info
[ https://issues.apache.org/jira/browse/WEEX-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685406#comment-16685406 ] ASF GitHub Bot commented on WEEX-661: - weex-bot edited a comment on issue #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#issuecomment-438257775 Fails :no_entry_sign: Code file ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm does not have the copyright header. Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] dev-tool feature , analyze interaction info > -- > > Key: WEEX-661 > URL: https://issues.apache.org/jira/browse/WEEX-661 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-661) [iOS] dev-tool feature , analyze interaction info
[ https://issues.apache.org/jira/browse/WEEX-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685405#comment-16685405 ] ASF GitHub Bot commented on WEEX-661: - weex-bot edited a comment on issue #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#issuecomment-438257775 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] dev-tool feature , analyze interaction info > -- > > Key: WEEX-661 > URL: https://issues.apache.org/jira/browse/WEEX-661 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-660) [iOS] add component ignoreInteraction flag (bad case addElement onScreen with loop)
[
https://issues.apache.org/jira/browse/WEEX-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685393#comment-16685393
]
ASF GitHub Bot commented on WEEX-660:
-
cxfeng1 closed pull request #1750: [WEEX-660][iOS]add component
ignoreInteraction flag (bad case addEle…
URL: https://github.com/apache/incubator-weex/pull/1750
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ios/sdk/WeexSDK/Sources/Manager/WXComponentManager.mm
b/ios/sdk/WeexSDK/Sources/Manager/WXComponentManager.mm
index e9b1733e7f..434ef36dad 100644
--- a/ios/sdk/WeexSDK/Sources/Manager/WXComponentManager.mm
+++ b/ios/sdk/WeexSDK/Sources/Manager/WXComponentManager.mm
@@ -40,6 +40,7 @@
#import "WXRootView.h"
#import "WXComponent+Layout.h"
#import "WXCoreBridge.h"
+#import "WXComponent_performance.h"
static NSThread *WXComponentThread;
@@ -279,6 +280,12 @@ - (void)addComponent:(NSString*)ref
} else {
index = (index == -1 ? supercomponent->_subcomponents.count : index);
}
+if (supercomponent.ignoreInteraction) {
+component.ignoreInteraction = YES;
+}
+if ([[component.attributes objectForKey:@"ignoreInteraction"]
isEqualToString:@"1"]) {
+component.ignoreInteraction = YES;
+}
#ifdef DEBUG
WXLogDebug(@"flexLayout -> _recursivelyAddComponent :
super:(%@,%@):[%f,%f] ,child:(%@,%@):[%f,%f],childClass:%@",
diff --git a/ios/sdk/WeexSDK/Sources/Model/WXComponent_performance.h
b/ios/sdk/WeexSDK/Sources/Model/WXComponent_performance.h
index 17153ee160..bbc18cf4e1 100644
--- a/ios/sdk/WeexSDK/Sources/Model/WXComponent_performance.h
+++ b/ios/sdk/WeexSDK/Sources/Model/WXComponent_performance.h
@@ -21,6 +21,7 @@
@interface WXComponent()
-@property (nonatomic,assign) bool hasAdd;
+@property (nonatomic,assign) BOOL hasAdd;
+@property (nonatomic,assign) BOOL ignoreInteraction;
@end
diff --git a/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance_performance.m
b/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance_performance.m
index 49da81345e..a8002b9fab 100644
--- a/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance_performance.m
+++ b/ios/sdk/WeexSDK/Sources/Model/WXSDKInstance_performance.m
@@ -70,6 +70,9 @@ - (void) _handleRenderTime:(WXComponent*)targetComponent
withModifyTime:(double)
if (nil == targetComponent) {
return;
}
+if (targetComponent.ignoreInteraction) {
+return;
+}
double diff = modifyTime - self.renderTimeOrigin;
if (diff > 8000) {
return;
@@ -85,11 +88,8 @@ - (void) _handleRenderTime:(WXComponent*)targetComponent
withModifyTime:(double)
CGRect absoluteFrame = [targetComponent.view.superview
convertRect:targetComponent.view.frame
toView:targetComponent.weexInstance.rootView];
CGRect rootFrame = targetComponent.weexInstance.rootView.frame;
-CGPoint leftTop = absoluteFrame.origin;
-CGPoint rightBottom =
CGPointMake(absoluteFrame.origin.x+absoluteFrame.size.width,
absoluteFrame.origin.y+absoluteFrame.size.height);
-
-if (!self.hasRecordFsRenderTimeByPosition && rightBottom.y >
rootFrame.size.height +1 && ![self _isViewGroup:targetComponent] ) {
+if (!self.hasRecordFsRenderTimeByPosition &&
absoluteFrame.origin.y+absoluteFrame.size.height > rootFrame.size.height +1 &&
![self _isViewGroup:targetComponent] ) {
self.newFsRenderTime = diff;
self.hasRecordFsRenderTimeByPosition = true;
[targetComponent.weexInstance.apmInstance
onStage:KEY_PAGE_STAGES_NEW_FSRENDER];
@@ -107,18 +107,17 @@ - (void) _handleRenderTime:(WXComponent*)targetComponent
withModifyTime:(double)
return;
}
-bool inScreen = CGRectContainsPoint(rootFrame, leftTop) ||
CGRectContainsPoint(rootFrame, rightBottom);
+bool inScreen = CGRectIntersectsRect(rootFrame, absoluteFrame);
if (!inScreen) {
return;
}
#ifdef DEBUG
-WXLogDebug(@"onElementChange _-> size, count :%f,inScreen:%d,
lefttop:%@,rightBottom:%@, rootFrame:%@",
+WXLogDebug(@"onElementChange _-> size, count :%f,inScreen:%d,
type:%@,attr:%@",
self.interactionAddCountRecord,
inScreen,
- NSStringFromCGPoint(leftTop),
- NSStringFromCGPoint(rightBottom),
- NSStringFromCGRect(targetComponent.weexInstance.rootView.frame)
+ targetComponent.type,
+ targetComponent.attributes
);
#endif
if
(!targetComponent.weexInstance.apmInstance.hasRecordFirstInterationView) {
diff --git a/ios/sdk/WeexSDK/Sources/Monitor/WXMonitor.m
b/ios/sdk/WeexSDK/Sources/Monitor/WXMonitor.m
index 1abe38f83d..d7fafd7532 100644
--- a/ios/sdk/WeexSDK/Sources/Monitor/WXMonitor.m
+++ b/ios/sdk/WeexSDK/Sources/M
[jira] [Created] (WEEX-661) [iOS] dev-tool feature , analyze interaction info
peihan created WEEX-661: --- Summary: [iOS] dev-tool feature , analyze interaction info Key: WEEX-661 URL: https://issues.apache.org/jira/browse/WEEX-661 Project: Weex Issue Type: New Feature Reporter: peihan Assignee: Adam Feng -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-660) [iOS] add component ignoreInteraction flag (bad case addElement onScreen with loop)
[ https://issues.apache.org/jira/browse/WEEX-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685134#comment-16685134 ] ASF GitHub Bot commented on WEEX-660: - weex-bot edited a comment on issue #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle… URL: https://github.com/apache/incubator-weex/pull/1750#issuecomment-438240112 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] add component ignoreInteraction flag (bad case addElement onScreen with > loop) > --- > > Key: WEEX-660 > URL: https://issues.apache.org/jira/browse/WEEX-660 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-660) [iOS] add component ignoreInteraction flag (bad case addElement onScreen with loop)
[ https://issues.apache.org/jira/browse/WEEX-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685138#comment-16685138 ] ASF GitHub Bot commented on WEEX-660: - weex-bot edited a comment on issue #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle… URL: https://github.com/apache/incubator-weex/pull/1750#issuecomment-438240112 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] add component ignoreInteraction flag (bad case addElement onScreen with > loop) > --- > > Key: WEEX-660 > URL: https://issues.apache.org/jira/browse/WEEX-660 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-660) [iOS] add component ignoreInteraction flag (bad case addElement onScreen with loop)
[ https://issues.apache.org/jira/browse/WEEX-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685135#comment-16685135 ] ASF GitHub Bot commented on WEEX-660: - weex-bot edited a comment on issue #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle… URL: https://github.com/apache/incubator-weex/pull/1750#issuecomment-438240112 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] add component ignoreInteraction flag (bad case addElement onScreen with > loop) > --- > > Key: WEEX-660 > URL: https://issues.apache.org/jira/browse/WEEX-660 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-660) [iOS] add component ignoreInteraction flag (bad case addElement onScreen with loop)
[ https://issues.apache.org/jira/browse/WEEX-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685107#comment-16685107 ] ASF GitHub Bot commented on WEEX-660: - weex-bot edited a comment on issue #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle… URL: https://github.com/apache/incubator-weex/pull/1750#issuecomment-438240112 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] add component ignoreInteraction flag (bad case addElement onScreen with > loop) > --- > > Key: WEEX-660 > URL: https://issues.apache.org/jira/browse/WEEX-660 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-660) [iOS] add component ignoreInteraction flag (bad case addElement onScreen with loop)
[ https://issues.apache.org/jira/browse/WEEX-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685101#comment-16685101 ] ASF GitHub Bot commented on WEEX-660: - weex-bot edited a comment on issue #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle… URL: https://github.com/apache/incubator-weex/pull/1750#issuecomment-438240112 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] add component ignoreInteraction flag (bad case addElement onScreen with > loop) > --- > > Key: WEEX-660 > URL: https://issues.apache.org/jira/browse/WEEX-660 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-660) [iOS] add component ignoreInteraction flag (bad case addElement onScreen with loop)
[ https://issues.apache.org/jira/browse/WEEX-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685103#comment-16685103 ] ASF GitHub Bot commented on WEEX-660: - weex-bot edited a comment on issue #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle… URL: https://github.com/apache/incubator-weex/pull/1750#issuecomment-438240112 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] add component ignoreInteraction flag (bad case addElement onScreen with > loop) > --- > > Key: WEEX-660 > URL: https://issues.apache.org/jira/browse/WEEX-660 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-660) [iOS] add component ignoreInteraction flag (bad case addElement onScreen with loop)
[ https://issues.apache.org/jira/browse/WEEX-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685100#comment-16685100 ] ASF GitHub Bot commented on WEEX-660: - weex-bot edited a comment on issue #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle… URL: https://github.com/apache/incubator-weex/pull/1750#issuecomment-438240112 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] add component ignoreInteraction flag (bad case addElement onScreen with > loop) > --- > > Key: WEEX-660 > URL: https://issues.apache.org/jira/browse/WEEX-660 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-660) [iOS] add component ignoreInteraction flag (bad case addElement onScreen with loop)
[ https://issues.apache.org/jira/browse/WEEX-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685099#comment-16685099 ] ASF GitHub Bot commented on WEEX-660: - weex-bot edited a comment on issue #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle… URL: https://github.com/apache/incubator-weex/pull/1750#issuecomment-438240112 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] add component ignoreInteraction flag (bad case addElement onScreen with > loop) > --- > > Key: WEEX-660 > URL: https://issues.apache.org/jira/browse/WEEX-660 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-660) [iOS] add component ignoreInteraction flag (bad case addElement onScreen with loop)
[ https://issues.apache.org/jira/browse/WEEX-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685088#comment-16685088 ] ASF GitHub Bot commented on WEEX-660: - weex-bot edited a comment on issue #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle… URL: https://github.com/apache/incubator-weex/pull/1750#issuecomment-438240112 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] add component ignoreInteraction flag (bad case addElement onScreen with > loop) > --- > > Key: WEEX-660 > URL: https://issues.apache.org/jira/browse/WEEX-660 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-660) [iOS] add component ignoreInteraction flag (bad case addElement onScreen with loop)
[ https://issues.apache.org/jira/browse/WEEX-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685090#comment-16685090 ] ASF GitHub Bot commented on WEEX-660: - weex-bot edited a comment on issue #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle… URL: https://github.com/apache/incubator-weex/pull/1750#issuecomment-438240112 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] add component ignoreInteraction flag (bad case addElement onScreen with > loop) > --- > > Key: WEEX-660 > URL: https://issues.apache.org/jira/browse/WEEX-660 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-660) [iOS] add component ignoreInteraction flag (bad case addElement onScreen with loop)
[ https://issues.apache.org/jira/browse/WEEX-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685086#comment-16685086 ] ASF GitHub Bot commented on WEEX-660: - weex-bot commented on issue #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle… URL: https://github.com/apache/incubator-weex/pull/1750#issuecomment-438240112 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] add component ignoreInteraction flag (bad case addElement onScreen with > loop) > --- > > Key: WEEX-660 > URL: https://issues.apache.org/jira/browse/WEEX-660 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-660) [iOS] add component ignoreInteraction flag (bad case addElement onScreen with loop)
[ https://issues.apache.org/jira/browse/WEEX-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685082#comment-16685082 ] ASF GitHub Bot commented on WEEX-660: - lucky-chen opened a new pull request #1750: *[iOS][WEEX-660]add component ignoreInteraction flag (bad case addEle… URL: https://github.com/apache/incubator-weex/pull/1750 add component ignoreInteraction flag bad case addElement onScreen with loop This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] add component ignoreInteraction flag (bad case addElement onScreen with > loop) > --- > > Key: WEEX-660 > URL: https://issues.apache.org/jira/browse/WEEX-660 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (WEEX-660) [iOS] add component ignoreInteraction flag (bad case addElement onScreen with loop)
peihan created WEEX-660: --- Summary: [iOS] add component ignoreInteraction flag (bad case addElement onScreen with loop) Key: WEEX-660 URL: https://issues.apache.org/jira/browse/WEEX-660 Project: Weex Issue Type: New Feature Reporter: peihan Assignee: Adam Feng -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-659) [core][eagle] support more feature in parser
[ https://issues.apache.org/jira/browse/WEEX-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684977#comment-16684977 ] ASF GitHub Bot commented on WEEX-659: - weex-bot edited a comment on issue #1749: [WEEX-659][core][eagle] support more feature in parser URL: https://github.com/apache/incubator-weex/pull/1749#issuecomment-438209245 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [core][eagle] support more feature in parser > > > Key: WEEX-659 > URL: https://issues.apache.org/jira/browse/WEEX-659 > Project: Weex > Issue Type: Bug >Reporter: yxp >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-659) [core][eagle] support more feature in parser
[ https://issues.apache.org/jira/browse/WEEX-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684976#comment-16684976 ] ASF GitHub Bot commented on WEEX-659: - weex-bot edited a comment on issue #1749: [WEEX-659][core][eagle] support more feature in parser URL: https://github.com/apache/incubator-weex/pull/1749#issuecomment-438209245 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [core][eagle] support more feature in parser > > > Key: WEEX-659 > URL: https://issues.apache.org/jira/browse/WEEX-659 > Project: Weex > Issue Type: Bug >Reporter: yxp >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-659) [core][eagle] support more feature in parser
[ https://issues.apache.org/jira/browse/WEEX-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684974#comment-16684974 ] ASF GitHub Bot commented on WEEX-659: - weex-bot commented on issue #1749: [WEEX-659][core][eagle] support more feature in parser URL: https://github.com/apache/incubator-weex/pull/1749#issuecomment-438209245 Fails :no_entry_sign: Code file ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm does not have the copyright header. Warnings :warning: No Changelog changes! :warning: Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/WXImage.java without metion it in commit message. You'd better add '@notdanger' in your commit log. Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [core][eagle] support more feature in parser > > > Key: WEEX-659 > URL: https://issues.apache.org/jira/browse/WEEX-659 > Project: Weex > Issue Type: Bug >Reporter: yxp >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (WEEX-659) [core][eagle] support more feature in parser
yxp created WEEX-659: Summary: [core][eagle] support more feature in parser Key: WEEX-659 URL: https://issues.apache.org/jira/browse/WEEX-659 Project: Weex Issue Type: Bug Reporter: yxp Assignee: Adam Feng -- This message was sent by Atlassian JIRA (v7.6.3#76005)
