[jira] [Commented] (WEEX-671) [iOS] `extendCallNative` method move to instance jscontext
[
https://issues.apache.org/jira/browse/WEEX-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702824#comment-16702824
]
ASF GitHub Bot commented on WEEX-671:
-
cxfeng1 closed pull request #1843: [WEEX-671][iOS] `extendCallNative` method
move to instance jscontext
URL: https://github.com/apache/incubator-weex/pull/1843
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
b/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
index 0dfe18dd3e..e82917787d 100644
--- a/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
+++ b/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
@@ -51,6 +51,7 @@
#import "WXJSFrameworkLoadProtocol.h"
#import "WXJSFrameworkLoadDefaultImpl.h"
#import "WXHandlerFactory.h"
+#import "WXExtendCallNativeManager.h"
#define SuppressPerformSelectorLeakWarning(Stuff) \
do { \
@@ -1125,6 +1126,10 @@ + (void)mountContextEnvironment:(JSContext*)context
NSString * levelStr = [[args lastObject] toString];
[WXBridgeContext handleConsoleOutputWithArgument:args
logLevel:(WXLogFlag)[levelMap[levelStr] integerValue]];
};
+
+context[@"extendCallNative"] = ^(JSValue *value ) {
+return [WXBridgeContext extendCallNative:[value toDictionary]];
+};
}
+ (void)handleConsoleOutputWithArgument:(NSArray *)arguments
logLevel:(WXLogFlag)logLevel
@@ -1149,4 +1154,12 @@ + (void)handleConsoleOutputWithArgument:(NSArray
*)arguments logLevel:(WXLogFlag
}
}];
}
+
++(id)extendCallNative:(NSDictionary *)dict
+{
+if(dict){
+return [WXExtendCallNativeManager sendExtendCallNativeEvent:dict];
+}
+return @(-1);
+}
@end
diff --git a/ios/sdk/WeexSDK/Sources/Bridge/WXJSCoreBridge.mm
b/ios/sdk/WeexSDK/Sources/Bridge/WXJSCoreBridge.mm
index 0e7a48d529..f6c5436a92 100644
--- a/ios/sdk/WeexSDK/Sources/Bridge/WXJSCoreBridge.mm
+++ b/ios/sdk/WeexSDK/Sources/Bridge/WXJSCoreBridge.mm
@@ -427,10 +427,6 @@ - (void)createDefaultContext
_jsContext[@"clearTimeoutWeex"] = ^(JSValue *ret) {
[weakSelf triggerClearTimeout:[ret toString]];
};
-
-_jsContext[@"extendCallNative"] = ^(JSValue *value ) {
-return [weakSelf extendCallNative:[value toDictionary]];
-};
}
-(void)addInstance:(NSString *)instance callback:(NSString *)callback
@@ -545,12 +541,4 @@ - (void)triggerClearTimeout:(NSString *)ret
}
}
--(id)extendCallNative:(NSDictionary *)dict
-{
-if(dict){
-return [WXExtendCallNativeManager sendExtendCallNativeEvent:dict];
-}
-return @(-1);
-}
-
@end
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [iOS] `extendCallNative` method move to instance jscontext
> --
>
> Key: WEEX-671
> URL: https://issues.apache.org/jira/browse/WEEX-671
> Project: Weex
> Issue Type: Improvement
>Reporter: Hao Junhua
>Assignee: Adam Feng
>Priority: Minor
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WEEX-671) [iOS] `extendCallNative` method move to instance jscontext
[ https://issues.apache.org/jira/browse/WEEX-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702799#comment-16702799 ] ASF GitHub Bot commented on WEEX-671: - weex-bot edited a comment on issue #1843: [WEEX-671][iOS] `extendCallNative` method move to instance jscontext URL: https://github.com/apache/incubator-weex/pull/1843#issuecomment-442727659 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] `extendCallNative` method move to instance jscontext > -- > > Key: WEEX-671 > URL: https://issues.apache.org/jira/browse/WEEX-671 > Project: Weex > Issue Type: Improvement >Reporter: Hao Junhua >Assignee: Adam Feng >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-671) [iOS] `extendCallNative` method move to instance jscontext
[ https://issues.apache.org/jira/browse/WEEX-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702795#comment-16702795 ] ASF GitHub Bot commented on WEEX-671: - weex-bot commented on issue #1843: [WEEX-671][iOS] `extendCallNative` method move to instance jscontext URL: https://github.com/apache/incubator-weex/pull/1843#issuecomment-442727659 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] `extendCallNative` method move to instance jscontext > -- > > Key: WEEX-671 > URL: https://issues.apache.org/jira/browse/WEEX-671 > Project: Weex > Issue Type: Improvement >Reporter: Hao Junhua >Assignee: Adam Feng >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-671) [iOS] `extendCallNative` method move to instance jscontext
[ https://issues.apache.org/jira/browse/WEEX-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702797#comment-16702797 ] ASF GitHub Bot commented on WEEX-671: - weex-bot edited a comment on issue #1843: [WEEX-671][iOS] `extendCallNative` method move to instance jscontext URL: https://github.com/apache/incubator-weex/pull/1843#issuecomment-442727659 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] `extendCallNative` method move to instance jscontext > -- > > Key: WEEX-671 > URL: https://issues.apache.org/jira/browse/WEEX-671 > Project: Weex > Issue Type: Improvement >Reporter: Hao Junhua >Assignee: Adam Feng >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-671) [iOS] `extendCallNative` method move to instance jscontext
[ https://issues.apache.org/jira/browse/WEEX-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702793#comment-16702793 ] ASF GitHub Bot commented on WEEX-671: - hjhcn opened a new pull request #1843: [WEEX-671][iOS] `extendCallNative` method move to instance jscontext URL: https://github.com/apache/incubator-weex/pull/1843 move `extendCallNative` method from globalContext to instanceContext This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] `extendCallNative` method move to instance jscontext > -- > > Key: WEEX-671 > URL: https://issues.apache.org/jira/browse/WEEX-671 > Project: Weex > Issue Type: Improvement >Reporter: Hao Junhua >Assignee: Adam Feng >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] erha19 opened a new pull request #209: [EN] update interage iOS devtool document
erha19 opened a new pull request #209: [EN] update interage iOS devtool document URL: https://github.com/apache/incubator-weex-site/pull/209 update interage iOS devtool document This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (WEEX-661) [iOS] dev-tool feature , analyze interaction info
[ https://issues.apache.org/jira/browse/WEEX-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702766#comment-16702766 ] ASF GitHub Bot commented on WEEX-661: - weex-bot edited a comment on issue #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#issuecomment-438257775 Fails :no_entry_sign: Code file ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm does not have the copyright header. Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] dev-tool feature , analyze interaction info > -- > > Key: WEEX-661 > URL: https://issues.apache.org/jira/browse/WEEX-661 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-661) [iOS] dev-tool feature , analyze interaction info
[ https://issues.apache.org/jira/browse/WEEX-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702769#comment-16702769 ] ASF GitHub Bot commented on WEEX-661: - weex-bot edited a comment on issue #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#issuecomment-438257775 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] dev-tool feature , analyze interaction info > -- > > Key: WEEX-661 > URL: https://issues.apache.org/jira/browse/WEEX-661 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (WEEX-671) [iOS] `extendCallNative` method move to instance jscontext
Hao Junhua created WEEX-671: --- Summary: [iOS] `extendCallNative` method move to instance jscontext Key: WEEX-671 URL: https://issues.apache.org/jira/browse/WEEX-671 Project: Weex Issue Type: Improvement Reporter: Hao Junhua Assignee: Adam Feng -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-661) [iOS] dev-tool feature , analyze interaction info
[ https://issues.apache.org/jira/browse/WEEX-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702767#comment-16702767 ] ASF GitHub Bot commented on WEEX-661: - weex-bot edited a comment on issue #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#issuecomment-438257775 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] dev-tool feature , analyze interaction info > -- > > Key: WEEX-661 > URL: https://issues.apache.org/jira/browse/WEEX-661 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-661) [iOS] dev-tool feature , analyze interaction info
[ https://issues.apache.org/jira/browse/WEEX-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702741#comment-16702741 ] ASF GitHub Bot commented on WEEX-661: - wqyfavor commented on a change in pull request #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#discussion_r237359187 ## File path: ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.h ## @@ -202,6 +202,7 @@ namespace WeexCore + (void)registerComponentAffineType:(NSString *)type asType:(NSString *)baseType; + (BOOL)isComponentAffineType:(NSString *)type asType:(NSString *)baseType; ++ (void)registercCoreEnv:(NSString*)key withValue:(NSString*)value; Review comment: registerc拼写错误 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] dev-tool feature , analyze interaction info > -- > > Key: WEEX-661 > URL: https://issues.apache.org/jira/browse/WEEX-661 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-661) [iOS] dev-tool feature , analyze interaction info
[ https://issues.apache.org/jira/browse/WEEX-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702712#comment-16702712 ] ASF GitHub Bot commented on WEEX-661: - weex-bot edited a comment on issue #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#issuecomment-438257775 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] dev-tool feature , analyze interaction info > -- > > Key: WEEX-661 > URL: https://issues.apache.org/jira/browse/WEEX-661 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-661) [iOS] dev-tool feature , analyze interaction info
[ https://issues.apache.org/jira/browse/WEEX-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702711#comment-16702711 ] ASF GitHub Bot commented on WEEX-661: - weex-bot edited a comment on issue #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#issuecomment-438257775 Fails :no_entry_sign: Code file ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm does not have the copyright header. Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] dev-tool feature , analyze interaction info > -- > > Key: WEEX-661 > URL: https://issues.apache.org/jira/browse/WEEX-661 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-661) [iOS] dev-tool feature , analyze interaction info
[ https://issues.apache.org/jira/browse/WEEX-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702710#comment-16702710 ] ASF GitHub Bot commented on WEEX-661: - weex-bot edited a comment on issue #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#issuecomment-438257775 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] dev-tool feature , analyze interaction info > -- > > Key: WEEX-661 > URL: https://issues.apache.org/jira/browse/WEEX-661 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-661) [iOS] dev-tool feature , analyze interaction info
[ https://issues.apache.org/jira/browse/WEEX-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702708#comment-16702708 ] ASF GitHub Bot commented on WEEX-661: - weex-bot edited a comment on issue #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#issuecomment-438257775 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] dev-tool feature , analyze interaction info > -- > > Key: WEEX-661 > URL: https://issues.apache.org/jira/browse/WEEX-661 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-661) [iOS] dev-tool feature , analyze interaction info
[ https://issues.apache.org/jira/browse/WEEX-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702706#comment-16702706 ] ASF GitHub Bot commented on WEEX-661: - weex-bot edited a comment on issue #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#issuecomment-438257775 Fails :no_entry_sign: Code file ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm does not have the copyright header. Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] dev-tool feature , analyze interaction info > -- > > Key: WEEX-661 > URL: https://issues.apache.org/jira/browse/WEEX-661 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-661) [iOS] dev-tool feature , analyze interaction info
[ https://issues.apache.org/jira/browse/WEEX-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702705#comment-16702705 ] ASF GitHub Bot commented on WEEX-661: - weex-bot edited a comment on issue #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#issuecomment-438257775 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] dev-tool feature , analyze interaction info > -- > > Key: WEEX-661 > URL: https://issues.apache.org/jira/browse/WEEX-661 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-661) [iOS] dev-tool feature , analyze interaction info
[ https://issues.apache.org/jira/browse/WEEX-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702699#comment-16702699 ] ASF GitHub Bot commented on WEEX-661: - weex-bot edited a comment on issue #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#issuecomment-438257775 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] dev-tool feature , analyze interaction info > -- > > Key: WEEX-661 > URL: https://issues.apache.org/jira/browse/WEEX-661 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-661) [iOS] dev-tool feature , analyze interaction info
[ https://issues.apache.org/jira/browse/WEEX-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702694#comment-16702694 ] ASF GitHub Bot commented on WEEX-661: - weex-bot edited a comment on issue #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#issuecomment-438257775 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] dev-tool feature , analyze interaction info > -- > > Key: WEEX-661 > URL: https://issues.apache.org/jira/browse/WEEX-661 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-661) [iOS] dev-tool feature , analyze interaction info
[ https://issues.apache.org/jira/browse/WEEX-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702695#comment-16702695 ] ASF GitHub Bot commented on WEEX-661: - weex-bot edited a comment on issue #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#issuecomment-438257775 Fails :no_entry_sign: Code file ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm does not have the copyright header. Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] dev-tool feature , analyze interaction info > -- > > Key: WEEX-661 > URL: https://issues.apache.org/jira/browse/WEEX-661 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: Thank you all for welcoming me as your mentor
Hi, Myrle Welcome again! Thanks for the the documentation guide, I have gone through the document and evaluated the overall maturity of Incubator Weex. I think the major gaps for Weex are last three: Community, Consensus Building and Independence. > CS20 > Decisions are made by consensus among PMC members 9 and are documented on the > project's main communications channel. Community opinions are taken into > account but the PMC has the final word if needed. > CS30 > Documented voting rules are used to build consensus when discussion is not > sufficient. 10 > CS40 > In Apache projects, vetoes are only valid for code commits and are justified > by a technical explanation, as per the Apache voting rules defined in CS30. > CS50 > All "important" discussions happen asynchronously in written form on the > project's main communications channel. Offline, face-to-face or private > discussions 11 that affect the project are also documented on that channel. "Documented voting rules” is a good way, maybe we should add more rules to the “How-to-contribute” document and encourage more discussions. There’re a lot of offline, face-to-face or private discussions, but none of them is documented. > IN10 > The project is independent from any corporate or organizational influence. 12 > IN20 > Contributors act as themselves as opposed to representatives of a corporation > or organization. Most of the committers come from China and work in the same company, some features are "corporation-driven" not community driven, diversity is important to our community and we need bring more committers from other companys and countries. Any other opinions from PPMC and committers? Thanks. Adam Feng 在 2018年11月28日 +0800 PM9:43，Willem Jiang ，写道： > I highly recommend PPMC go through the document and do the evaluation > yourself. > It could help you find the gap. > > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > On Wed, Nov 28, 2018 at 7:24 PM Myrle Krantz wrote: > > > > I was wondering. Are you familiar with the maturity model? > > > > https://community.apache.org/apache-way/apache-project-maturity-model.html > > > > This is not required for graduation. But it can help you determine your > > level of readiness. It can also help you find what your project might want > > to improve before (or after) graduation. > > > > Best Regards, > > Myrle > > Weex Mentor
[GitHub] erha19 opened a new pull request #208: Update integrate-devtool-to-ios.md
erha19 opened a new pull request #208: Update integrate-devtool-to-ios.md URL: https://github.com/apache/incubator-weex-site/pull/208 update document of iOS devtool This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] erha19 closed pull request #207: Update integrate-devtool-to-ios.md
erha19 closed pull request #207: Update integrate-devtool-to-ios.md
URL: https://github.com/apache/incubator-weex-site/pull/207
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/source/cn/guide/integrate-devtool-to-ios.md
b/source/cn/guide/integrate-devtool-to-ios.md
index 602406cc0..0a56a1b2f 100644
--- a/source/cn/guide/integrate-devtool-to-ios.md
+++ b/source/cn/guide/integrate-devtool-to-ios.md
@@ -88,10 +88,10 @@ pod 'WXDevtool', '0.15.3', :configurations => ['Debug']，
在你自己的程序中添加如下代码：
```object-c
-[WXDevTool
launchDevToolDebugWithUrl:@"ws://30.30.31.7:8088/debugProxy/native"];
+[WXDevTool
launchDevToolDebugWithUrl:@"ws://30.30.31.7:{port}/debugProxy/native/{channelid}"];
```
-其中的 ws 地址正是 `Weex debug` 控制台中出现的地址，直接 copy 到 `launchDevToolDebugWithUrl` 接口中。
+其中的 ws 地址正是 `Weex debug` 控制台中出现的地址，如果不是通过扫码链接的方式，你可以通过`weex debug --port
--channelid 1` 去指定端口号及`channelid`, 随后可以将链接填写到 `launchDevToolDebugWithUrl` 接口中。
如果程序一启动就开启 Weex 调试，**需要在 WeexSDK 引擎初始化之前**添加代码：
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] erha19 opened a new pull request #207: Update integrate-devtool-to-ios.md
erha19 opened a new pull request #207: Update integrate-devtool-to-ios.md URL: https://github.com/apache/incubator-weex-site/pull/207 update document of iOS devtool This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (WEEX-670) 项目执行 navigator 时playground 调试工具直接退回到扫码
[ https://issues.apache.org/jira/browse/WEEX-670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 郭宇 updated WEEX-670: Description: Application onActivityPause() Application to be in the backround 执行 navigator 跳转时 时playground 调试工具直接退回到扫码 其他模块没有问题 安卓playground 更新到最新 0.19.0 的问题 ios最新的没问题 was: Application onActivityPause() Application to be in the backround 执行 navigator 跳转时 时playground 调试工具直接退回到扫码 其他模块没有问题 > 项目执行 navigator 时playground 调试工具直接退回到扫码 > --- > > Key: WEEX-670 > URL: https://issues.apache.org/jira/browse/WEEX-670 > Project: Weex > Issue Type: Bug >Reporter: 郭宇 >Assignee: Adam Feng >Priority: Blocker > > Application onActivityPause() > Application to be in the backround > 执行 navigator 跳转时 时playground 调试工具直接退回到扫码 > 其他模块没有问题 > 安卓playground 更新到最新 0.19.0 的问题 ios最新的没问题 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (WEEX-670) 项目执行 navigator 时playground 调试工具直接退回到扫码
[ https://issues.apache.org/jira/browse/WEEX-670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 郭宇 updated WEEX-670: Priority: Blocker (was: Major) > 项目执行 navigator 时playground 调试工具直接退回到扫码 > --- > > Key: WEEX-670 > URL: https://issues.apache.org/jira/browse/WEEX-670 > Project: Weex > Issue Type: Bug >Reporter: 郭宇 >Assignee: Adam Feng >Priority: Blocker > > Application onActivityPause() > Application to be in the backround > 执行 navigator 跳转时 时playground 调试工具直接退回到扫码 > 其他模块没有问题 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: Thank you all for welcoming me as your mentor
I highly recommend PPMC go through the document and do the evaluation yourself. It could help you find the gap. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Wed, Nov 28, 2018 at 7:24 PM Myrle Krantz wrote: > > I was wondering. Are you familiar with the maturity model? > > https://community.apache.org/apache-way/apache-project-maturity-model.html > > This is not required for graduation. But it can help you determine your > level of readiness. It can also help you find what your project might want > to improve before (or after) graduation. > > Best Regards, > Myrle > Weex Mentor
Thank you all for welcoming me as your mentor
I was wondering. Are you familiar with the maturity model? https://community.apache.org/apache-way/apache-project-maturity-model.html This is not required for graduation. But it can help you determine your level of readiness. It can also help you find what your project might want to improve before (or after) graduation. Best Regards, Myrle Weex Mentor
[jira] [Created] (WEEX-670) 项目执行 navigator 时playground 调试工具直接退回到扫码
郭宇 created WEEX-670: --- Summary: 项目执行 navigator 时playground 调试工具直接退回到扫码 Key: WEEX-670 URL: https://issues.apache.org/jira/browse/WEEX-670 Project: Weex Issue Type: Bug Reporter: 郭宇 Assignee: Adam Feng Application onActivityPause() Application to be in the backround 执行 navigator 跳转时 时playground 调试工具直接退回到扫码 其他模块没有问题 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
