[jira] [Commented] (WEEX-673) [weex_core][iOS][Android] fix crash && advance RTL performance

2018-12-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/WEEX-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709780#comment-16709780
 ] 

ASF GitHub Bot commented on WEEX-673:
-

weex-bot edited a comment on issue #1860: [WEEX-673][weex_core][iOS][Android] 
fix crash && advance RTL performance
URL: https://github.com/apache/incubator-weex/pull/1860#issuecomment-444026835
 
 
   
   
   
   
   
   
 
   
 
 Messages
   
 
 
 :book:
 has no jsfm file changed.
   
 
   
 :book:
 jsfm test finished.
   
 
   
   
   
   
 Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [weex_core][iOS][Android] fix crash  && advance RTL performance
> ---
>
> Key: WEEX-673
> URL: https://issues.apache.org/jira/browse/WEEX-673
> Project: Weex
>  Issue Type: Bug
>  Components: Android, iOS
>Affects Versions: 0.20
>Reporter: KAI TIAN
>Assignee: YorkShen
>Priority: Blocker
> Fix For: 0.20
>
>
> To fix android crash when call isNativeLayoutDirectionRTL by JNI, now we 
> don't read layoutDirection manually again,only receive param which transfered 
> by C++ -> Java. 
> As we all know JNI is very slow, now we avoid call JNI method when layout, it 
> can speedup weex render.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WEEX-673) [weex_core][iOS][Android] fix crash && advance RTL performance

2018-12-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/WEEX-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709782#comment-16709782
 ] 

ASF GitHub Bot commented on WEEX-673:
-

weex-bot edited a comment on issue #1860: [WEEX-673][weex_core][iOS][Android] 
fix crash && advance RTL performance
URL: https://github.com/apache/incubator-weex/pull/1860#issuecomment-444026835
 
 
   
   
   
   
 
   
 
 Fails
   
 
 
 :no_entry_sign:
 Code file ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm does not 
have the copyright header.
   
 
   
 :no_entry_sign:
 Code file 
weex_core/Source/android/jniprebuild/jniheader/WXBridge_jni.h does not have the 
copyright header.
   
 
   
   
   
   
 
   
 
 Warnings
   
 
 
 :warning:
 No Changelog changes!
   
 
   
 :warning:
 Potential BREAK CHANGE. Modify public in 
android/sdk/src/main/java/com/taobao/weex/ui/action/GraphicActionLayout.java 
without metion it in commit message. You'd better add '@notdanger' in your 
commit log. 
   
 
   
 :warning:
 Potential BREAK CHANGE. Modify public in 
android/sdk/src/main/java/com/taobao/weex/bridge/WXBridge.java without metion 
it in commit message. You'd better add '@notdanger' in your commit log. 
   
 
   
 :warning:
 Potential BREAK CHANGE. Modify public in 
android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java without 
metion it in commit message. You'd better add '@notdanger' in your commit log. 

   
 
   
 :warning:
 Potential BREAK CHANGE. Modify public in 
android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java without 
metion it in commit message. You'd better add '@notdanger' in your commit log. 

   
 
   
   
   
   
 
   
 
 Messages
   
 
 
 :book:
 danger test finished.
   
 
   
   
   
   
 Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [weex_core][iOS][Android] fix crash  && advance RTL performance
> ---
>
> Key: WEEX-673
> URL: https://issues.apache.org/jira/browse/WEEX-673
> Project: Weex
>  Issue Type: Bug
>  Components: Android, iOS
>Affects Versions: 0.20
>Reporter: KAI TIAN
>Assignee: YorkShen
>Priority: Blocker
> Fix For: 0.20
>
>
> To fix android crash when call isNativeLayoutDirectionRTL by JNI, now we 
> don't read layoutDirection manually again,only receive param which transfered 
> by C++ -> Java. 
> As we all know JNI is very slow, now we avoid call JNI method when layout, it 
> can speedup weex render.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WEEX-673) [weex_core][iOS][Android] fix crash && advance RTL performance

2018-12-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/WEEX-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709783#comment-16709783
 ] 

ASF GitHub Bot commented on WEEX-673:
-

weex-bot edited a comment on issue #1860: [WEEX-673][weex_core][iOS][Android] 
fix crash && advance RTL performance
URL: https://github.com/apache/incubator-weex/pull/1860#issuecomment-444026835
 
 
   
   
   
   
 
   
 
 Fails
   
 
 
 :no_entry_sign:
 Failed to run assembleDebug task for android.
   
 
   
   
   
   
   
 
   
 
 Messages
   
 
 
 :book:
 android build verification finished.
   
 
   
   
   
   
 Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [weex_core][iOS][Android] fix crash  && advance RTL performance
> ---
>
> Key: WEEX-673
> URL: https://issues.apache.org/jira/browse/WEEX-673
> Project: Weex
>  Issue Type: Bug
>  Components: Android, iOS
>Affects Versions: 0.20
>Reporter: KAI TIAN
>Assignee: YorkShen
>Priority: Blocker
> Fix For: 0.20
>
>
> To fix android crash when call isNativeLayoutDirectionRTL by JNI, now we 
> don't read layoutDirection manually again,only receive param which transfered 
> by C++ -> Java. 
> As we all know JNI is very slow, now we avoid call JNI method when layout, it 
> can speedup weex render.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WEEX-673) [weex_core][iOS][Android] fix crash && advance RTL performance

2018-12-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/WEEX-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709786#comment-16709786
 ] 

ASF GitHub Bot commented on WEEX-673:
-

weex-bot edited a comment on issue #1860: [WEEX-673][weex_core][iOS][Android] 
fix crash && advance RTL performance
URL: https://github.com/apache/incubator-weex/pull/1860#issuecomment-444026835
 
 
   
   
   
   
   
   
 
   
 
 Messages
   
 
 
 :book:
 has no jsfm file changed.
   
 
   
 :book:
 jsfm test finished.
   
 
   
   
   
   
 Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [weex_core][iOS][Android] fix crash  && advance RTL performance
> ---
>
> Key: WEEX-673
> URL: https://issues.apache.org/jira/browse/WEEX-673
> Project: Weex
>  Issue Type: Bug
>  Components: Android, iOS
>Affects Versions: 0.20
>Reporter: KAI TIAN
>Assignee: YorkShen
>Priority: Blocker
> Fix For: 0.20
>
>
> To fix android crash when call isNativeLayoutDirectionRTL by JNI, now we 
> don't read layoutDirection manually again,only receive param which transfered 
> by C++ -> Java. 
> As we all know JNI is very slow, now we avoid call JNI method when layout, it 
> can speedup weex render.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WEEX-673) [weex_core][iOS][Android] fix crash && advance RTL performance

2018-12-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/WEEX-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709785#comment-16709785
 ] 

ASF GitHub Bot commented on WEEX-673:
-

weex-bot edited a comment on issue #1860: [WEEX-673][weex_core][iOS][Android] 
fix crash && advance RTL performance
URL: https://github.com/apache/incubator-weex/pull/1860#issuecomment-444026835
 
 
   
   
   
   
 
   
 
 Fails
   
 
 
 :no_entry_sign:
 Code file ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm does not 
have the copyright header.
   
 
   
 :no_entry_sign:
 Code file 
weex_core/Source/android/jniprebuild/jniheader/WXBridge_jni.h does not have the 
copyright header.
   
 
   
   
   
   
 
   
 
 Warnings
   
 
 
 :warning:
 No Changelog changes!
   
 
   
 :warning:
 Potential BREAK CHANGE. Modify public in 
android/sdk/src/main/java/com/taobao/weex/ui/action/GraphicActionLayout.java 
without metion it in commit message. You'd better add '@notdanger' in your 
commit log. 
   
 
   
 :warning:
 Potential BREAK CHANGE. Modify public in 
android/sdk/src/main/java/com/taobao/weex/bridge/WXBridge.java without metion 
it in commit message. You'd better add '@notdanger' in your commit log. 
   
 
   
 :warning:
 Potential BREAK CHANGE. Modify public in 
android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java without 
metion it in commit message. You'd better add '@notdanger' in your commit log. 

   
 
   
 :warning:
 Potential BREAK CHANGE. Modify public in 
android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java without 
metion it in commit message. You'd better add '@notdanger' in your commit log. 

   
 
   
   
   
   
 
   
 
 Messages
   
 
 
 :book:
 danger test finished.
   
 
   
   
   
   
 Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [weex_core][iOS][Android] fix crash  && advance RTL performance
> ---
>
> Key: WEEX-673
> URL: https://issues.apache.org/jira/browse/WEEX-673
> Project: Weex
>  Issue Type: Bug
>  Components: Android, iOS
>Affects Versions: 0.20
>Reporter: KAI TIAN
>Assignee: YorkShen
>Priority: Blocker
> Fix For: 0.20
>
>
> To fix android crash when call isNativeLayoutDirectionRTL by JNI, now we 
> don't read layoutDirection manually again,only receive param which transfered 
> by C++ -> Java. 
> As we all know JNI is very slow, now we avoid call JNI method when layout, it 
> can speedup weex render.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WEEX-673) [weex_core][iOS][Android] fix crash && advance RTL performance

2018-12-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/WEEX-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709792#comment-16709792
 ] 

ASF GitHub Bot commented on WEEX-673:
-

weex-bot edited a comment on issue #1860: [WEEX-673][weex_core][iOS][Android] 
fix crash && advance RTL performance
URL: https://github.com/apache/incubator-weex/pull/1860#issuecomment-444026835
 
 
   
   
   
   
 
   
 
 Fails
   
 
 
 :no_entry_sign:
 Failed to run assembleDebug task for android.
   
 
   
   
   
   
   
 
   
 
 Messages
   
 
 
 :book:
 android build verification finished.
   
 
   
   
   
   
 Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [weex_core][iOS][Android] fix crash  && advance RTL performance
> ---
>
> Key: WEEX-673
> URL: https://issues.apache.org/jira/browse/WEEX-673
> Project: Weex
>  Issue Type: Bug
>  Components: Android, iOS
>Affects Versions: 0.20
>Reporter: KAI TIAN
>Assignee: YorkShen
>Priority: Blocker
> Fix For: 0.20
>
>
> To fix android crash when call isNativeLayoutDirectionRTL by JNI, now we 
> don't read layoutDirection manually again,only receive param which transfered 
> by C++ -> Java. 
> As we all know JNI is very slow, now we avoid call JNI method when layout, it 
> can speedup weex render.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (WEEX-664) [weex_core] RTL performance is incorrect

2018-12-05 Thread KAI TIAN (JIRA)


 [ 
https://issues.apache.org/jira/browse/WEEX-664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

KAI TIAN resolved WEEX-664.
---
   Resolution: Fixed
Fix Version/s: (was: 0.19)
   0.20

> [weex_core] RTL performance is incorrect
> 
>
> Key: WEEX-664
> URL: https://issues.apache.org/jira/browse/WEEX-664
> Project: Weex
>  Issue Type: Bug
>  Components: Android, iOS
>Affects Versions: 0.19
>Reporter: KAI TIAN
>Assignee: YorkShen
>Priority: Major
> Fix For: 0.20
>
>
> RTL performance is incorrect when flex-direction:column or 
> flex-direction:column-reverse



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (WEEX-669) [android] crash when slider mAdapter null

2018-12-05 Thread KAI TIAN (JIRA)


 [ 
https://issues.apache.org/jira/browse/WEEX-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

KAI TIAN resolved WEEX-669.
---
   Resolution: Fixed
Fix Version/s: (was: 0.19)
   0.20

> [android] crash when slider mAdapter null
> -
>
> Key: WEEX-669
> URL: https://issues.apache.org/jira/browse/WEEX-669
> Project: Weex
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 0.19
>Reporter: KAI TIAN
>Assignee: YorkShen
>Priority: Major
> Fix For: 0.20
>
>
> java.lang.NullPointerException: Attempt to invoke virtual method 'void 
> com.taobao.weex.ui.view.WXCirclePageAdapter.setLayoutDirectionRTL(boolean)' 
> on a null object reference
> at com.taobao.weex.ui.component.WXSlider.setLayout(WXSlider.java:217)
> at 
> com.taobao.weex.ui.action.GraphicActionLayout.executeAction(GraphicActionLayout.java:44)
> at 
> com.taobao.weex.ui.action.BasicGraphicAction.run(BasicGraphicAction.java:68)
> at android.os.Handler.handleCallback(Handler.java:751)
> at android.os.Handler.dispatchMessage(Handler.java:95)
> at android.os.Looper.loop(Looper.java:154)
> at android.app.ActivityThread.main(ActivityThread.java:6195)
> at java.lang.reflect.Method.invoke(Native Method)
> at 
> com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889)
> at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] Hanks10100 closed pull request #224: Update richtext.md

2018-12-05 Thread GitBox
Hanks10100 closed pull request #224: Update richtext.md
URL: https://github.com/apache/incubator-weex-site/pull/224
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/source/references/components/richtext.md 
b/source/references/components/richtext.md
index 5b67f8895..ef73cf343 100644
--- a/source/references/components/richtext.md
+++ b/source/references/components/richtext.md
@@ -79,4 +79,4 @@ Weex [common 
events](https://weex-project.io/references/common-event.html) are s
 
 ## Example
 
-[richtext 示例](http://dotwe.org/vue/f60fa4323e8248c91ed88d53af2ce9fc)
\ No newline at end of file
+[richtext example](http://dotwe.org/vue/f60fa4323e8248c91ed88d53af2ce9fc)


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] Hanks10100 closed pull request #222: Update extend-ios.md

2018-12-05 Thread GitBox
Hanks10100 closed pull request #222: Update extend-ios.md
URL: https://github.com/apache/incubator-weex-site/pull/222
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/source/guide/extend-ios.md b/source/guide/extend-ios.md
index e60e8b509..4aa830363 100644
--- a/source/guide/extend-ios.md
+++ b/source/guide/extend-ios.md
@@ -267,7 +267,7 @@ after your registration for your own custom component, now 
you can call it in yo
 
 - From v0.19, Weex replaced layout engine which is C++ codes. You can get css 
styles from styles dictionary of a WXComponent. You can also access flexCssNode 
property which is of type WeexCore::WXCoreLayoutNode, but must in .mm files.
 
-- From v0.20, WeexCore is imported to iOS, and css styles is never uploaded to 
WXComponent. The styles dictionary only contains non-css styles. We think that 
upper UI components should only care about final layout results generated by 
layout engine. If you still want to access css styles, you may use flexCssNode 
in .mm files or by extension methods provided in WXComponent+Layout.h.
+- From v0.20, WeexCore is imported to iOS, and css styles are never uploaded 
to WXComponent. The styles dictionary only contains non-css styles. We think 
that upper UI components should only care about final layout results generated 
by layout engine. If you still want to access css styles, you may use 
flexCssNode in .mm files or by extension methods provided in 
WXComponent+Layout.h.
 
  ```
 /**
@@ -298,7 +298,6 @@ after your registration for your own custom component, now 
you can call it in yo
 - (WXCoreAlignSelf)getCssStyleAlignSelf;
 - (WXCorePositionType)getCssStylePositionType;
 - (NSString*)convertLayoutValueToStyleValue:(NSString*)valueName;
-- (CGFloat)safeContainerStyleWidth;
  ```
 
 ### custom your handlers


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] Hanks10100 closed pull request #223: Update extend-ios.md

2018-12-05 Thread GitBox
Hanks10100 closed pull request #223: Update extend-ios.md
URL: https://github.com/apache/incubator-weex-site/pull/223
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/source/cn/guide/extend-ios.md b/source/cn/guide/extend-ios.md
index 70bf4389c..91296470c 100644
--- a/source/cn/guide/extend-ios.md
+++ b/source/cn/guide/extend-ios.md
@@ -296,7 +296,6 @@ WeexSDK 0.9.5 之后支持了在 js 中直接调用 component 的方法,自定
 - (WXCoreAlignSelf)getCssStyleAlignSelf;
 - (WXCorePositionType)getCssStylePositionType;
 - (NSString*)convertLayoutValueToStyleValue:(NSString*)valueName;
-- (CGFloat)safeContainerStyleWidth;
  ```
 
 ## 自定义 handler 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] Hanks10100 closed pull request #220: Update video.md

2018-12-05 Thread GitBox
Hanks10100 closed pull request #220: Update video.md
URL: https://github.com/apache/incubator-weex-site/pull/220
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/source/cn/references/components/video.md 
b/source/cn/references/components/video.md
index ffd7fe818..812353f2e 100644
--- a/source/cn/references/components/video.md
+++ b/source/cn/references/components/video.md
@@ -21,6 +21,8 @@ version: 2.1
 - `src {string}`:内嵌的视频指向的URL
 - `play-status {string}`:可选值为 `play` | `pause`,用来控制视频的播放状态,`play` 或者 
`pause`,默认值是 `pause`。
 - `auto-play {boolean}`:可选值为  `true` | `false`,当页面加载初始化完成后,用来控制视频是否立即播放,默认值是 
`false`。
+- `poster {string}` v0.18+ & iOS 
only:指定视频首图的图片链接。
+- `controls {string}` v0.19+:可选值为  
`controls` | `nocontrols`,控制视频播放组件是否显示回放控制面板,默认会显示,当指定为 `nocontrols` 时不显示回放控制面板。
 
 ## 样式
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] Hanks10100 closed pull request #218: Update slider.md

2018-12-05 Thread GitBox
Hanks10100 closed pull request #218: Update slider.md
URL: https://github.com/apache/incubator-weex-site/pull/218
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/source/references/components/slider.md 
b/source/references/components/slider.md
index 18377e293..b3b1342a8 100644
--- a/source/references/components/slider.md
+++ b/source/references/components/slider.md
@@ -26,7 +26,7 @@ It supports all kinds of weex components as its slides, 
especially the `indicato
 - `infinite {boolean}`: set whether the page in the slider can be scrolled
 - `scrollable {boolean}`: set whether slider pages can be switched by sliding 
gestures
 - `keep-index {boolean}`: set whether to maintain the index of the page after 
the data changes
-- `forbid-slide-animation {boolean}`: {iOS Only}. On iOS animation is enabled 
by default, and here we provide this attribute to shutdown animation on iOS.
+- `forbid-slide-animation {boolean}`: 0.21+ & iOS 
only. On iOS animation is enabled by default, and here we provide this 
attribute to shutdown animation on iOS.
 
 - `index {number}`: specify current page index of slider
   [try in dotWe](http://dotwe.org/vue/58a29d38247e7946a6db44e1b616f082)


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] Hanks10100 closed pull request #221: Update video.md

2018-12-05 Thread GitBox
Hanks10100 closed pull request #221: Update video.md
URL: https://github.com/apache/incubator-weex-site/pull/221
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/source/references/components/video.md 
b/source/references/components/video.md
index 24c363d14..36b3af335 100644
--- a/source/references/components/video.md
+++ b/source/references/components/video.md
@@ -19,6 +19,8 @@ The video component can be used to embed video content in a 
weex page.
 * src:  The URL of the video to embed.
 * play-status:  play | pause. Use it to control video's 
play/pause status. Default value is pause.
 * auto-play:  true | false. Use it to control whether it is 
playing when the page initialization finished. Defalut value is false.
+* poster:  v0.18+ & iOS only 
Post image URL of this video if any.
+* controls:  v0.19+ If set to 
'nocontrols', native video component will hide its play-back control panel.
 
 ## Styles
 common styles: check out [common styles for 
components](/wiki/common-styles.html)


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] Hanks10100 closed pull request #217: list component scrollable attribute patch

2018-12-05 Thread GitBox
Hanks10100 closed pull request #217: list component scrollable attribute patch
URL: https://github.com/apache/incubator-weex-site/pull/217
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/source/cn/references/components/list.md 
b/source/cn/references/components/list.md
index 2613fde39..fd956bc31 100644
--- a/source/cn/references/components/list.md
+++ b/source/cn/references/components/list.md
@@ -45,6 +45,7 @@ version: 2.1
 - `loadmoreoffset {number}`:默认值为 0,触发 `loadmore` 事件所需要的垂直偏移距离(设备屏幕底部与 `` 
底部之间的距离)。当 `` 的滚动条滚动到足够接近 `` 底部时将会触发 `loadmore` 这个事件。
 - `offset-accuracy {number}` 0.11+:控制`onscroll`事件触发的频率,默认值为10,表示两次`onscroll`事件之间列表至少滚动了10px。注意,将该值设置为较小的数值会提高滚动事件采样的精度,但同时也会降低页面的性能。
 -  `pagingEnabled {boolean}`:可选值为 true/ false,默认值为 
false。控制是否每次滚动一个cell,并最终定位在元素中心位置,类似垂直的viewpage交互。则对应 `0`v0.20+.[pagingEnabled示例](http://dotwe.org/vue/1323c218072f17f10e14a5c336dac3c4)
+-  `scrollable {boolean}`:可选值为 true/ false,默认值为 true。控制list是否可以滚动
 
   ![mobile_preview](../images/list_4.jpg)
   
diff --git a/source/references/components/list.md 
b/source/references/components/list.md
index 4030470df..052e415de 100644
--- a/source/references/components/list.md
+++ b/source/references/components/list.md
@@ -42,7 +42,7 @@ Notes: The list now supports the following child components: 
cell, header, refre
 * loadmoreretry :  default value 0,whether to reset loadmore related 
UI when loadmore failed, will be deprecated in further release.
 * offset-accuracy: default value is 0, the vertical offset distance 
required to trigger the scroll event.
 * pagingEnabled:  default value is false. supporting pager style 
snapping in vertical orientation. support version: `0`v0.20+. Example : 
[pagingEnabled](http://dotwe.org/vue/1323c218072f17f10e14a5c336dac3c4)
-
+* scrollable:  default value is true.  set whether list is 
scrollable. 
 
 Please checkout [Scroller Component Attributes](./scroller.html) to have a 
look at the inherited attributes from direct parent.
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] Hanks10100 closed pull request #219: Update slider.md

2018-12-05 Thread GitBox
Hanks10100 closed pull request #219: Update slider.md
URL: https://github.com/apache/incubator-weex-site/pull/219
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/source/cn/references/components/slider.md 
b/source/cn/references/components/slider.md
index 31f706cdf..8f71ec7c2 100644
--- a/source/cn/references/components/slider.md
+++ b/source/cn/references/components/slider.md
@@ -29,7 +29,7 @@ version: 2.1
 - `index {number}`:设置显示slider的第几个页面
 - `scrollable {boolean}`:设置是否可以通过滑动手势来切换slider页面
 - `keep-index {boolean}`:设置slider中的数据发生变化后是否保持变化前的页面index
-- `forbid-slide-animation {boolean}`:{iOS Only}. 在 iOS 上,slider 
组件默认有动画,这里提供该属性可以将动画关掉。
+- `forbid-slide-animation {boolean}`:0.21+ & iOS only. 
在 iOS 上,slider 组件默认有动画,这里提供该属性可以将动画关掉。
 
 - `index {number}`: 指定当前展示页面的索引
   [体验一下](http://dotwe.org/vue/58a29d38247e7946a6db44e1b616f082)


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (WEEX-581) @focus method invoked twice on Android

2018-12-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/WEEX-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710930#comment-16710930
 ] 

ASF GitHub Bot commented on WEEX-581:
-

YorkShen commented on issue #1460: [WEEX-581][android] fix 'onFocus invoked 
twice
URL: https://github.com/apache/incubator-weex/pull/1460#issuecomment-444734099
 
 
   Please rebase your commit, there is a conflict. @chenzefeng09 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> @focus method invoked twice on Android
> --
>
> Key: WEEX-581
> URL: https://issues.apache.org/jira/browse/WEEX-581
> Project: Weex
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 0.18
>Reporter: 陈泽峰
>Assignee: YorkShen
>Priority: Minor
> Fix For: 0.19
>
>
> when input label has both ‘focus' & 'blur' method, both methods will be 
> invoked twice when trigger focus/blur event
> demo:
> [http://dotwe.org/vue/f9be1b443f95cfe550024b2e8222faec]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WEEX-581) @focus method invoked twice on Android

2018-12-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/WEEX-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710936#comment-16710936
 ] 

ASF GitHub Bot commented on WEEX-581:
-

chenzefeng09 commented on issue #1460: [WEEX-581][android] fix 'onFocus invoked 
twice
URL: https://github.com/apache/incubator-weex/pull/1460#issuecomment-444736145
 
 
   conflict resolved  @YorkShen 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> @focus method invoked twice on Android
> --
>
> Key: WEEX-581
> URL: https://issues.apache.org/jira/browse/WEEX-581
> Project: Weex
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 0.18
>Reporter: 陈泽峰
>Assignee: YorkShen
>Priority: Minor
> Fix For: 0.19
>
>
> when input label has both ‘focus' & 'blur' method, both methods will be 
> invoked twice when trigger focus/blur event
> demo:
> [http://dotwe.org/vue/f9be1b443f95cfe550024b2e8222faec]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WEEX-581) @focus method invoked twice on Android

2018-12-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/WEEX-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710938#comment-16710938
 ] 

ASF GitHub Bot commented on WEEX-581:
-

weex-bot edited a comment on issue #1460: [WEEX-581][android] fix 'onFocus 
invoked twice
URL: https://github.com/apache/incubator-weex/pull/1460#issuecomment-414888731
 
 
   
   
   
   
   
 
   
 
 Warnings
   
 
 
 :warning:
 No Changelog changes!
   
 
   
   
   
   
 
   
 
 Messages
   
 
 
 :book:
 danger test finished.
   
 
   
   
   
   
 Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> @focus method invoked twice on Android
> --
>
> Key: WEEX-581
> URL: https://issues.apache.org/jira/browse/WEEX-581
> Project: Weex
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 0.18
>Reporter: 陈泽峰
>Assignee: YorkShen
>Priority: Minor
> Fix For: 0.19
>
>
> when input label has both ‘focus' & 'blur' method, both methods will be 
> invoked twice when trigger focus/blur event
> demo:
> [http://dotwe.org/vue/f9be1b443f95cfe550024b2e8222faec]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WEEX-581) @focus method invoked twice on Android

2018-12-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/WEEX-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710937#comment-16710937
 ] 

ASF GitHub Bot commented on WEEX-581:
-

weex-bot edited a comment on issue #1460: [WEEX-581][android] fix 'onFocus 
invoked twice
URL: https://github.com/apache/incubator-weex/pull/1460#issuecomment-414888731
 
 
   
   
   
   
   
   
 
   
 
 Messages
   
 
 
 :book:
 has no jsfm file changed.
   
 
   
 :book:
 jsfm test finished.
   
 
   
   
   
   
 Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> @focus method invoked twice on Android
> --
>
> Key: WEEX-581
> URL: https://issues.apache.org/jira/browse/WEEX-581
> Project: Weex
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 0.18
>Reporter: 陈泽峰
>Assignee: YorkShen
>Priority: Minor
> Fix For: 0.19
>
>
> when input label has both ‘focus' & 'blur' method, both methods will be 
> invoked twice when trigger focus/blur event
> demo:
> [http://dotwe.org/vue/f9be1b443f95cfe550024b2e8222faec]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (WEEX-581) @focus method invoked twice on Android

2018-12-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/WEEX-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710951#comment-16710951
 ] 

ASF GitHub Bot commented on WEEX-581:
-

weex-bot edited a comment on issue #1460: [WEEX-581][android] fix 'onFocus 
invoked twice
URL: https://github.com/apache/incubator-weex/pull/1460#issuecomment-414888731
 
 
   
   
   
   
 
   
 
 Fails
   
 
 
 :no_entry_sign:
 Failed to run assembleDebug task for android.
   
 
   
   
   
   
   
 
   
 
 Messages
   
 
 
 :book:
 android build verification finished.
   
 
   
   
   
   
 Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> @focus method invoked twice on Android
> --
>
> Key: WEEX-581
> URL: https://issues.apache.org/jira/browse/WEEX-581
> Project: Weex
>  Issue Type: Bug
>  Components: Android
>Affects Versions: 0.18
>Reporter: 陈泽峰
>Assignee: YorkShen
>Priority: Minor
> Fix For: 0.19
>
>
> when input label has both ‘focus' & 'blur' method, both methods will be 
> invoked twice when trigger focus/blur event
> demo:
> [http://dotwe.org/vue/f9be1b443f95cfe550024b2e8222faec]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)