[GitHub] incubator-weex pull request #4: modified: WXRenderErrorCode.java WXSDKInstan...

[sospartan]

Github user sospartan commented on a diff in the pull request:

https://github.com/apache/incubator-weex/pull/4#discussion_r104080119
  
--- Diff: android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java ---
@@ -490,7 +490,7 @@ public void render(String template, Map 
options, String jsonInit
* weexversionWeex version(like 1.0.0)
* appversion App version(like 1.0.0)
* devidDevice id(like 
Aqh9z8dRJNBhmS9drLG5BKCmXhecHUXIZoXOctKwFebH)
-   * sysversionDevice system version(like 
5.4.4、7.0.4, should be used with os)
+   * sysversionDevice system version(like 
5.4.4�?.0.4, should be used with os)
--- End diff --

?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex pull request #4: modified: WXRenderErrorCode.java WXSDKInstan...

[sospartan]

Github user sospartan commented on a diff in the pull request:

https://github.com/apache/incubator-weex/pull/4#discussion_r104080132
  
--- Diff: android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java ---
@@ -467,7 +467,7 @@ public void render(String template, Map 
options, String jsonInit
* weexversionWeex version(like 1.0.0)
* appversion App version(like 1.0.0)
* devidDevice id(like 
Aqh9z8dRJNBhmS9drLG5BKCmXhecHUXIZoXOctKwFebH)
-   * sysversionDevice system version(like 
5.4.4、7.0.4, should be used with os)
+   * sysversionDevice system version(like 
5.4.4�?.0.4, should be used with os)
--- End diff --

what's this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---