[jira] [Commented] (WEEX-299) Touch event will transmit to next layer

2018-04-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/WEEX-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457315#comment-16457315
 ] 

ASF GitHub Bot commented on WEEX-299:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-weex/pull/1138


> Touch event will transmit to next layer
> ---
>
> Key: WEEX-299
> URL: https://issues.apache.org/jira/browse/WEEX-299
> Project: Weex
>  Issue Type: Bug
>Reporter: quanyun wei
>Assignee: Adam Feng
>Priority: Critical
>
> This is the test demo in 
> [dotwe|[http://dotwe.org/vue/d269c46eabb5da4bda6c8ac91a11c464]|http://dotwe.org/vue/d269c46eabb5da4bda6c8ac91a11c464],]
>  when touch the text, the div will also response the touch event.
> {code:java}
> //代码占位符
> 
>  ontouchcancel='ontouchcancel' ontouchend="ontouchend"
> @touchstart="ontouchstart" @touchmove="ontouchmove" @touchend="ontouchend" 
> @shouldStopPropagation="shouldStopPropagation"
> >{{forceValue}}
> 
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (WEEX-299) Touch event will transmit to next layer

2018-04-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/WEEX-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457312#comment-16457312
 ] 

ASF GitHub Bot commented on WEEX-299:
-

Github user misakuo commented on the issue:

https://github.com/apache/incubator-weex/pull/1138
  
nice


> Touch event will transmit to next layer
> ---
>
> Key: WEEX-299
> URL: https://issues.apache.org/jira/browse/WEEX-299
> Project: Weex
>  Issue Type: Bug
>Reporter: quanyun wei
>Assignee: Adam Feng
>Priority: Critical
>
> This is the test demo in 
> [dotwe|[http://dotwe.org/vue/d269c46eabb5da4bda6c8ac91a11c464]|http://dotwe.org/vue/d269c46eabb5da4bda6c8ac91a11c464],]
>  when touch the text, the div will also response the touch event.
> {code:java}
> //代码占位符
> 
>  ontouchcancel='ontouchcancel' ontouchend="ontouchend"
> @touchstart="ontouchstart" @touchmove="ontouchmove" @touchend="ontouchend" 
> @shouldStopPropagation="shouldStopPropagation"
> >{{forceValue}}
> 
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (WEEX-299) Touch event will transmit to next layer

2018-04-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/WEEX-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456118#comment-16456118
 ] 

ASF GitHub Bot commented on WEEX-299:
-

Github user weex-bot commented on the issue:

https://github.com/apache/incubator-weex/pull/1138
  






  

  
  Messages

  
  
  :book:
  has no jsfm file changed.

  

  :book:
  jsfm test finished.

  




  Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS




> Touch event will transmit to next layer
> ---
>
> Key: WEEX-299
> URL: https://issues.apache.org/jira/browse/WEEX-299
> Project: Weex
>  Issue Type: Bug
>Reporter: quanyun wei
>Assignee: Adam Feng
>Priority: Critical
>
> This is the test demo in 
> [dotwe|[http://dotwe.org/vue/d269c46eabb5da4bda6c8ac91a11c464]|http://dotwe.org/vue/d269c46eabb5da4bda6c8ac91a11c464],]
>  when touch the text, the div will also response the touch event.
> {code:java}
> //代码占位符
> 
>  ontouchcancel='ontouchcancel' ontouchend="ontouchend"
> @touchstart="ontouchstart" @touchmove="ontouchmove" @touchend="ontouchend" 
> @shouldStopPropagation="shouldStopPropagation"
> >{{forceValue}}
> 
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (WEEX-299) Touch event will transmit to next layer

2018-04-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/WEEX-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456117#comment-16456117
 ] 

ASF GitHub Bot commented on WEEX-299:
-

GitHub user gubaojian opened a pull request:

https://github.com/apache/incubator-weex/pull/1138

[WEEX-299][android] Touch event will transmit to next layer, 
requestDisallowInterceptTouchEvent should be reset for every touch event

[WEEX-299][android] Touch event will transmit to next layer, 
requestDisallowInterceptTouchEvent should be reset for every touch event

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gubaojian/incubator-weex 
release_0.19_template_list_bugfix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-weex/pull/1138.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1138


commit 5575e161add04239d26a6a9b02fe9e3dc611bdc4
Author: jianbai.gbj 
Date:   2018-04-27T08:47:13Z

[WEEX-299][android] Touch event will transmit to next layer, 
requestDisallowInterceptTouchEvent should be reset for every touch event




> Touch event will transmit to next layer
> ---
>
> Key: WEEX-299
> URL: https://issues.apache.org/jira/browse/WEEX-299
> Project: Weex
>  Issue Type: Bug
>Reporter: quanyun wei
>Assignee: Adam Feng
>Priority: Critical
>
> This is the test demo in 
> [dotwe|[http://dotwe.org/vue/d269c46eabb5da4bda6c8ac91a11c464]|http://dotwe.org/vue/d269c46eabb5da4bda6c8ac91a11c464],]
>  when touch the text, the div will also response the touch event.
> {code:java}
> //代码占位符
> 
>  ontouchcancel='ontouchcancel' ontouchend="ontouchend"
> @touchstart="ontouchstart" @touchmove="ontouchmove" @touchend="ontouchend" 
> @shouldStopPropagation="shouldStopPropagation"
> >{{forceValue}}
> 
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (WEEX-299) Touch event will transmit to next layer

2018-04-27 Thread codefurture (JIRA) 

[ 
https://issues.apache.org/jira/browse/WEEX-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456115#comment-16456115
 ] 

codefurture commented on WEEX-299:
--

i know your issues.  the stopPropagation  should be reset event touch. i will 
fix the issues later in today

> Touch event will transmit to next layer
> ---
>
> Key: WEEX-299
> URL: https://issues.apache.org/jira/browse/WEEX-299
> Project: Weex
>  Issue Type: Bug
>Reporter: quanyun wei
>Assignee: Adam Feng
>Priority: Critical
>
> This is the test demo in 
> [dotwe|[http://dotwe.org/vue/d269c46eabb5da4bda6c8ac91a11c464]|http://dotwe.org/vue/d269c46eabb5da4bda6c8ac91a11c464],]
>  when touch the text, the div will also response the touch event.
> {code:java}
> //代码占位符
> 
>  ontouchcancel='ontouchcancel' ontouchend="ontouchend"
> @touchstart="ontouchstart" @touchmove="ontouchmove" @touchend="ontouchend" 
> @shouldStopPropagation="shouldStopPropagation"
> >{{forceValue}}
> 
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (WEEX-299) Touch event will transmit to next layer

2018-04-27 Thread quanyun wei (JIRA) 

[ 
https://issues.apache.org/jira/browse/WEEX-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456100#comment-16456100
 ] 

quanyun wei commented on WEEX-299:
--

[~codefurture] But when I touch the parent directly, I think the child view is 
not in the touch response chain, am I wrong with that, if not, why the child 
view's stopPropagation works in this case?

> Touch event will transmit to next layer
> ---
>
> Key: WEEX-299
> URL: https://issues.apache.org/jira/browse/WEEX-299
> Project: Weex
>  Issue Type: Bug
>Reporter: quanyun wei
>Assignee: Adam Feng
>Priority: Critical
>
> This is the test demo in 
> [dotwe|[http://dotwe.org/vue/d269c46eabb5da4bda6c8ac91a11c464]|http://dotwe.org/vue/d269c46eabb5da4bda6c8ac91a11c464],]
>  when touch the text, the div will also response the touch event.
> {code:java}
> //代码占位符
> 
>  ontouchcancel='ontouchcancel' ontouchend="ontouchend"
> @touchstart="ontouchstart" @touchmove="ontouchmove" @touchend="ontouchend" 
> @shouldStopPropagation="shouldStopPropagation"
> >{{forceValue}}
> 
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (WEEX-299) Touch event will transmit to next layer

2018-04-27 Thread codefurture (JIRA) 

[ 
https://issues.apache.org/jira/browse/WEEX-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456084#comment-16456084
 ] 

codefurture commented on WEEX-299:
--

stopPropagation means the touch event  should stop propagation on response 
chain.  when it return true, the parent will not receive touch event.  if it 
return false, the parent will receive touch event.

> Touch event will transmit to next layer
> ---
>
> Key: WEEX-299
> URL: https://issues.apache.org/jira/browse/WEEX-299
> Project: Weex
>  Issue Type: Bug
>Reporter: quanyun wei
>Assignee: Adam Feng
>Priority: Critical
>
> This is the test demo in 
> [dotwe|[http://dotwe.org/vue/d269c46eabb5da4bda6c8ac91a11c464]|http://dotwe.org/vue/d269c46eabb5da4bda6c8ac91a11c464],]
>  when touch the text, the div will also response the touch event.
> {code:java}
> //代码占位符
> 
>  ontouchcancel='ontouchcancel' ontouchend="ontouchend"
> @touchstart="ontouchstart" @touchmove="ontouchmove" @touchend="ontouchend" 
> @shouldStopPropagation="shouldStopPropagation"
> >{{forceValue}}
> 
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (WEEX-299) Touch event will transmit to next layer

2018-04-27 Thread quanyun wei (JIRA) 

[ 
https://issues.apache.org/jira/browse/WEEX-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456083#comment-16456083
 ] 

quanyun wei commented on WEEX-299:
--

[~codefurture] Thanks for your reply. But why the div can not receive touch 
event even touch the div it self when return true in stopPropagation?

> Touch event will transmit to next layer
> ---
>
> Key: WEEX-299
> URL: https://issues.apache.org/jira/browse/WEEX-299
> Project: Weex
>  Issue Type: Bug
>Reporter: quanyun wei
>Assignee: Adam Feng
>Priority: Critical
>
> This is the test demo in 
> [dotwe|[http://dotwe.org/vue/d269c46eabb5da4bda6c8ac91a11c464]|http://dotwe.org/vue/d269c46eabb5da4bda6c8ac91a11c464],]
>  when touch the text, the div will also response the touch event.
> {code:java}
> //代码占位符
> 
>  ontouchcancel='ontouchcancel' ontouchend="ontouchend"
> @touchstart="ontouchstart" @touchmove="ontouchmove" @touchend="ontouchend" 
> @shouldStopPropagation="shouldStopPropagation"
> >{{forceValue}}
> 
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (WEEX-299) Touch event will transmit to next layer

2018-04-27 Thread codefurture (JIRA) 

[ 
https://issues.apache.org/jira/browse/WEEX-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456071#comment-16456071
 ] 

codefurture commented on WEEX-299:
--

if you don't want div receive touchstart event, in your function return true, 
to stop touch event propagation. the example is like this: 
http://dotwe.org/vue/e03984d688351b9fd985b8c291804d49

> Touch event will transmit to next layer
> ---
>
> Key: WEEX-299
> URL: https://issues.apache.org/jira/browse/WEEX-299
> Project: Weex
>  Issue Type: Bug
>Reporter: quanyun wei
>Assignee: Adam Feng
>Priority: Critical
>
> This is the test demo in 
> [dotwe|[http://dotwe.org/vue/d269c46eabb5da4bda6c8ac91a11c464]|http://dotwe.org/vue/d269c46eabb5da4bda6c8ac91a11c464],]
>  when touch the text, the div will also response the touch event.
> {code:java}
> //代码占位符
> 
>  ontouchcancel='ontouchcancel' ontouchend="ontouchend"
> @touchstart="ontouchstart" @touchmove="ontouchmove" @touchend="ontouchend" 
> @shouldStopPropagation="shouldStopPropagation"
> >{{forceValue}}
> 
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (WEEX-299) Touch event will transmit to next layer

2018-04-27 Thread codefurture (JIRA) 

[ 
https://issues.apache.org/jira/browse/WEEX-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456067#comment-16456067
 ] 

codefurture commented on WEEX-299:
--

the old version use shouldStopPropagation when beta, when release it become 
short name,  stopPropagation.

> Touch event will transmit to next layer
> ---
>
> Key: WEEX-299
> URL: https://issues.apache.org/jira/browse/WEEX-299
> Project: Weex
>  Issue Type: Bug
>Reporter: quanyun wei
>Assignee: Adam Feng
>Priority: Critical
>
> This is the test demo in 
> [dotwe|[http://dotwe.org/vue/d269c46eabb5da4bda6c8ac91a11c464]|http://dotwe.org/vue/d269c46eabb5da4bda6c8ac91a11c464],]
>  when touch the text, the div will also response the touch event.
> {code:java}
> //代码占位符
> 
>  ontouchcancel='ontouchcancel' ontouchend="ontouchend"
> @touchstart="ontouchstart" @touchmove="ontouchmove" @touchend="ontouchend" 
> @shouldStopPropagation="shouldStopPropagation"
> >{{forceValue}}
> 
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (WEEX-299) Touch event will transmit to next layer

2018-04-27 Thread quanyun wei (JIRA) 

[ 
https://issues.apache.org/jira/browse/WEEX-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456031#comment-16456031
 ] 

quanyun wei commented on WEEX-299:
--

[~cxfeng] Hi, it's Android. I also have two doubts:
 # There an error in the [weex 
document|https://weex.incubator.apache.org/wiki/gestures.html] about 
shouldStopPropagation property of touch, it may be stopPropagation?
 # After changing shouldStopPropagation to stopPropagation, it seems to work, 
but at the first time, the parent div also response the touch event. Here is 
the latest [demo|http://dotwe.org/vue/e03984d688351b9fd985b8c291804d49].

> Touch event will transmit to next layer
> ---
>
> Key: WEEX-299
> URL: https://issues.apache.org/jira/browse/WEEX-299
> Project: Weex
>  Issue Type: Bug
>Reporter: quanyun wei
>Assignee: Adam Feng
>Priority: Critical
>
> This is the test demo in 
> [dotwe|[http://dotwe.org/vue/d269c46eabb5da4bda6c8ac91a11c464]|http://dotwe.org/vue/d269c46eabb5da4bda6c8ac91a11c464],]
>  when touch the text, the div will also response the touch event.
> {code:java}
> //代码占位符
> 
>  ontouchcancel='ontouchcancel' ontouchend="ontouchend"
> @touchstart="ontouchstart" @touchmove="ontouchmove" @touchend="ontouchend" 
> @shouldStopPropagation="shouldStopPropagation"
> >{{forceValue}}
> 
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (WEEX-299) Touch event will transmit to next layer

2018-04-27 Thread Adam Feng (JIRA) 

[ 
https://issues.apache.org/jira/browse/WEEX-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456014#comment-16456014
 ] 

Adam Feng commented on WEEX-299:


[~wqycsu]   iOS or Android?

> Touch event will transmit to next layer
> ---
>
> Key: WEEX-299
> URL: https://issues.apache.org/jira/browse/WEEX-299
> Project: Weex
>  Issue Type: Bug
>Reporter: quanyun wei
>Assignee: Adam Feng
>Priority: Critical
>
> This is the test demo in 
> [dotwe|[http://dotwe.org/vue/d269c46eabb5da4bda6c8ac91a11c464]|http://dotwe.org/vue/d269c46eabb5da4bda6c8ac91a11c464],]
>  when touch the text, the div will also response the touch event.
> {code:java}
> //代码占位符
> 
>  ontouchcancel='ontouchcancel' ontouchend="ontouchend"
> @touchstart="ontouchstart" @touchmove="ontouchmove" @touchend="ontouchend" 
> @shouldStopPropagation="shouldStopPropagation"
> >{{forceValue}}
> 
> {code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)