[jira] [Commented] (WEEX-661) [iOS] dev-tool feature , analyze interaction info
[
https://issues.apache.org/jira/browse/WEEX-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702836#comment-16702836
]
ASF GitHub Bot commented on WEEX-661:
-
cxfeng1 closed pull request #1751: [WEEX-661][iOS] new feature for analyze
interaction info (dev_tool)
URL: https://github.com/apache/incubator-weex/pull/1751
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.h
b/ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.h
index 1e05c2c5bb..90b7fd147c 100644
--- a/ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.h
+++ b/ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.h
@@ -202,6 +202,7 @@ namespace WeexCore
+ (void)registerComponentAffineType:(NSString *)type asType:(NSString
*)baseType;
+ (BOOL)isComponentAffineType:(NSString *)type asType:(NSString *)baseType;
++ (void)registerCoreEnv:(NSString*)key withValue:(NSString*)value;
@end
diff --git a/ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm
b/ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm
index 78d4b4d607..a0ad6debce 100644
--- a/ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm
+++ b/ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm
@@ -1217,4 +1217,9 @@ + (void)callUpdateFinish:(NSString*)pageId
WeexCore::WeexCoreManager::Instance()->script_bridge()->core_side()->UpdateFinish([pageId
UTF8String] ?: "", nullptr, 0, nullptr, 0);
}
++ (void)registerCoreEnv:(NSString*)key withValue:(NSString*)value
+{
+
WeexCore::WeexCoreManager::Instance()->getPlatformBridge()->core_side()->RegisterCoreEnv([key
UTF8String]?:"", [value UTF8String]?:"");
+}
+
@end
diff --git a/ios/sdk/WeexSDK/Sources/Bridge/WXJSCoreBridge.mm
b/ios/sdk/WeexSDK/Sources/Bridge/WXJSCoreBridge.mm
index 0e7a48d529..dddf2795fc 100644
--- a/ios/sdk/WeexSDK/Sources/Bridge/WXJSCoreBridge.mm
+++ b/ios/sdk/WeexSDK/Sources/Bridge/WXJSCoreBridge.mm
@@ -38,6 +38,7 @@
#import "WXAppMonitorProtocol.h"
#import "JSContext+Weex.h"
#import "WXCoreBridge.h"
+#import "WXAnalyzerCenter.h"
#import
@@ -163,8 +164,9 @@ -
(void)registerCallAddElement:(WXJSCallAddElement)callAddElement
NSDictionary *componentData = [element toDictionary];
NSString *parentRef = [ref toString];
NSInteger insertIndex = [[index toNumber] integerValue];
-WXLogDebug(@"callAddElement...%@, %@, %@, %ld", instanceIdString,
parentRef, componentData, (long)insertIndex);
-
+if (WXAnalyzerCenter.isInteractionLogOpen) {
+WXLogDebug(@"wxInteractionAnalyzer :
[jsengin][addElementStart],%@,%@",instanceIdString,componentData[@"ref"]);
+}
return [JSValue
valueWithInt32:(int32_t)callAddElement(instanceIdString, parentRef,
componentData, insertIndex) inContext:[JSContext currentContext]];
};
diff --git a/ios/sdk/WeexSDK/Sources/Bridge/WXModuleMethod.m
b/ios/sdk/WeexSDK/Sources/Bridge/WXModuleMethod.m
index 882784977b..6877a9a7a6 100644
--- a/ios/sdk/WeexSDK/Sources/Bridge/WXModuleMethod.m
+++ b/ios/sdk/WeexSDK/Sources/Bridge/WXModuleMethod.m
@@ -27,6 +27,7 @@
#import "WXSDKInstance_private.h"
#import "WXHandlerFactory.h"
#import "WXValidateProtocol.h"
+#import "WXAnalyzerCenter.h"
@implementation WXModuleMethod
@@ -46,6 +47,9 @@ - (instancetype)initWithModuleName:(NSString *)moduleName
- (NSInvocation *)invoke
{
+if ([WXAnalyzerCenter isInteractionLogOpen]) {
+WXLogDebug(@"wxInteractionAnalyzer :
[client][callnativemodulestart],%@,%@,%@",self.instance.instanceId,self.moduleName,self.methodName);
+}
if (self.instance.needValidate) {
id validateHandler = [WXHandlerFactory
handlerForProtocol:@protocol(WXValidateProtocol)];
if (validateHandler) {
@@ -103,6 +107,9 @@ - (NSInvocation *)invoke
if (isSync) {
[invocation invoke];
+if ([WXAnalyzerCenter isInteractionLogOpen]) {
+WXLogDebug(@"wxInteractionAnalyzer :
[client][callnativemoduleEnd],%@,%@,%@",self.instance.instanceId,self.moduleName,self.methodName);
+}
return invocation;
} else {
[self _dispatchInvocation:invocation moduleInstance:moduleInstance];
@@ -130,6 +137,9 @@ - (void)_dispatchInvocation:(NSInvocation *)invocation
moduleInstance:(id_isTemplate) {
__weak typeof(self) weakSelf = self;
@@ -328,6 +334,9 @@ - (void)addComponent:(NSString*)ref
[WXTracingManager
startTracingWithInstanceId:strongSelf.weexInstance.instanceId ref:ref
className:nil name:type phase:WXTracingEnd functionName:@"addElement"
options:@{@"threadName":WXTUIThread}];
}];
}
+if([WXAnalyzerCenter isInteractionLogOpen]){
+WXLogDebug(@"wxInteractionAnalyzer:
[jira] [Commented] (WEEX-661) [iOS] dev-tool feature , analyze interaction info
[ https://issues.apache.org/jira/browse/WEEX-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702766#comment-16702766 ] ASF GitHub Bot commented on WEEX-661: - weex-bot edited a comment on issue #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#issuecomment-438257775 Fails :no_entry_sign: Code file ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm does not have the copyright header. Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] dev-tool feature , analyze interaction info > -- > > Key: WEEX-661 > URL: https://issues.apache.org/jira/browse/WEEX-661 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-661) [iOS] dev-tool feature , analyze interaction info
[ https://issues.apache.org/jira/browse/WEEX-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702767#comment-16702767 ] ASF GitHub Bot commented on WEEX-661: - weex-bot edited a comment on issue #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#issuecomment-438257775 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] dev-tool feature , analyze interaction info > -- > > Key: WEEX-661 > URL: https://issues.apache.org/jira/browse/WEEX-661 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-661) [iOS] dev-tool feature , analyze interaction info
[ https://issues.apache.org/jira/browse/WEEX-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702741#comment-16702741 ] ASF GitHub Bot commented on WEEX-661: - wqyfavor commented on a change in pull request #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#discussion_r237359187 ## File path: ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.h ## @@ -202,6 +202,7 @@ namespace WeexCore + (void)registerComponentAffineType:(NSString *)type asType:(NSString *)baseType; + (BOOL)isComponentAffineType:(NSString *)type asType:(NSString *)baseType; ++ (void)registercCoreEnv:(NSString*)key withValue:(NSString*)value; Review comment: registerc拼写错误 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] dev-tool feature , analyze interaction info > -- > > Key: WEEX-661 > URL: https://issues.apache.org/jira/browse/WEEX-661 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-661) [iOS] dev-tool feature , analyze interaction info
[ https://issues.apache.org/jira/browse/WEEX-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702708#comment-16702708 ] ASF GitHub Bot commented on WEEX-661: - weex-bot edited a comment on issue #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#issuecomment-438257775 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] dev-tool feature , analyze interaction info > -- > > Key: WEEX-661 > URL: https://issues.apache.org/jira/browse/WEEX-661 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-661) [iOS] dev-tool feature , analyze interaction info
[ https://issues.apache.org/jira/browse/WEEX-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702706#comment-16702706 ] ASF GitHub Bot commented on WEEX-661: - weex-bot edited a comment on issue #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#issuecomment-438257775 Fails :no_entry_sign: Code file ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm does not have the copyright header. Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] dev-tool feature , analyze interaction info > -- > > Key: WEEX-661 > URL: https://issues.apache.org/jira/browse/WEEX-661 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-661) [iOS] dev-tool feature , analyze interaction info
[ https://issues.apache.org/jira/browse/WEEX-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702705#comment-16702705 ] ASF GitHub Bot commented on WEEX-661: - weex-bot edited a comment on issue #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#issuecomment-438257775 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] dev-tool feature , analyze interaction info > -- > > Key: WEEX-661 > URL: https://issues.apache.org/jira/browse/WEEX-661 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-661) [iOS] dev-tool feature , analyze interaction info
[ https://issues.apache.org/jira/browse/WEEX-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702699#comment-16702699 ] ASF GitHub Bot commented on WEEX-661: - weex-bot edited a comment on issue #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#issuecomment-438257775 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] dev-tool feature , analyze interaction info > -- > > Key: WEEX-661 > URL: https://issues.apache.org/jira/browse/WEEX-661 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-661) [iOS] dev-tool feature , analyze interaction info
[ https://issues.apache.org/jira/browse/WEEX-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702694#comment-16702694 ] ASF GitHub Bot commented on WEEX-661: - weex-bot edited a comment on issue #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#issuecomment-438257775 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] dev-tool feature , analyze interaction info > -- > > Key: WEEX-661 > URL: https://issues.apache.org/jira/browse/WEEX-661 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-661) [iOS] dev-tool feature , analyze interaction info
[ https://issues.apache.org/jira/browse/WEEX-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702695#comment-16702695 ] ASF GitHub Bot commented on WEEX-661: - weex-bot edited a comment on issue #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#issuecomment-438257775 Fails :no_entry_sign: Code file ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm does not have the copyright header. Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] dev-tool feature , analyze interaction info > -- > > Key: WEEX-661 > URL: https://issues.apache.org/jira/browse/WEEX-661 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-661) [iOS] dev-tool feature , analyze interaction info
[ https://issues.apache.org/jira/browse/WEEX-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685407#comment-16685407 ] ASF GitHub Bot commented on WEEX-661: - weex-bot edited a comment on issue #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#issuecomment-438257775 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] dev-tool feature , analyze interaction info > -- > > Key: WEEX-661 > URL: https://issues.apache.org/jira/browse/WEEX-661 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-661) [iOS] dev-tool feature , analyze interaction info
[ https://issues.apache.org/jira/browse/WEEX-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685406#comment-16685406 ] ASF GitHub Bot commented on WEEX-661: - weex-bot edited a comment on issue #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#issuecomment-438257775 Fails :no_entry_sign: Code file ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm does not have the copyright header. Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] dev-tool feature , analyze interaction info > -- > > Key: WEEX-661 > URL: https://issues.apache.org/jira/browse/WEEX-661 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-661) [iOS] dev-tool feature , analyze interaction info
[ https://issues.apache.org/jira/browse/WEEX-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685405#comment-16685405 ] ASF GitHub Bot commented on WEEX-661: - weex-bot edited a comment on issue #1751: [WEEX-661][iOS] new feature for analyze interaction info (dev_tool) URL: https://github.com/apache/incubator-weex/pull/1751#issuecomment-438257775 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] dev-tool feature , analyze interaction info > -- > > Key: WEEX-661 > URL: https://issues.apache.org/jira/browse/WEEX-661 > Project: Weex > Issue Type: New Feature >Reporter: peihan >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
