[jira] [Commented] (WEEX-669) [android] crash when slider mAdapter null
[
https://issues.apache.org/jira/browse/WEEX-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698667#comment-16698667
]
ASF GitHub Bot commented on WEEX-669:
-
YorkShen closed pull request #1816: [WEEX-669][android] fix slider crash when
adapter is null
URL: https://github.com/apache/incubator-weex/pull/1816
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/android/sdk/src/main/java/com/taobao/weex/ui/action/GraphicActionLayout.java
b/android/sdk/src/main/java/com/taobao/weex/ui/action/GraphicActionLayout.java
index 45846cf988..24946fea87 100644
---
a/android/sdk/src/main/java/com/taobao/weex/ui/action/GraphicActionLayout.java
+++
b/android/sdk/src/main/java/com/taobao/weex/ui/action/GraphicActionLayout.java
@@ -41,7 +41,7 @@ public void executeAction() {
}
component.setDemission(mLayoutSize, mLayoutPosition);
-component.setLayout(component);
+component.setSafeLayout(component);
component.setPadding(component.getPadding(), component.getBorder());
}
}
diff --git
a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java
b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java
index fbf8bc3279..4d9447168d 100644
--- a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java
+++ b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java
@@ -682,7 +682,7 @@ public void applyLayoutAndEvent(WXComponent component) {
component = this;
}
bindComponent(component);
- setLayout(component);
+ setSafeLayout(component);
setPadding(component.getPadding(), component.getBorder());
applyEvents();
}
@@ -701,7 +701,7 @@ public void updateDemission(float top, float bottom, float
left, float right, fl
public void applyLayoutOnly(){
if(!isLazy()) {
- setLayout(this);
+ setSafeLayout(this);
setPadding(this.getPadding(), this.getBorder());
}
}
@@ -922,13 +922,19 @@ protected BorderDrawable getOrCreateBorder() {
/**
* layout view
*/
- public void setLayout(WXComponent component) {
+ public void setSafeLayout(WXComponent component) {
if (TextUtils.isEmpty(component.getComponentType())
|| TextUtils.isEmpty(component.getRef()) ||
component.getLayoutPosition() == null
|| component.getLayoutSize() == null) {
return;
}
+setLayout(component);
+ }
+ /**
+ * layout view
+ */
+ public void setLayout(WXComponent component) {
setLayoutSize(component.getLayoutSize());
setLayoutPosition(component.getLayoutPosition());
setPaddings(component.getPadding());
diff --git
a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXSlider.java
b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXSlider.java
index 8e9474069f..d0033185b3 100644
--- a/android/sdk/src/main/java/com/taobao/weex/ui/component/WXSlider.java
+++ b/android/sdk/src/main/java/com/taobao/weex/ui/component/WXSlider.java
@@ -214,7 +214,9 @@ public void run() {
@Override
public void setLayout(WXComponent component) {
-mAdapter.setLayoutDirectionRTL(this.isNativeLayoutRTL());
+if (mAdapter != null) {
+ mAdapter.setLayoutDirectionRTL(this.isNativeLayoutRTL());
+}
super.setLayout(component);
}
diff --git
a/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java
b/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java
index a9a2c67910..c994707cfe 100644
---
a/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java
+++
b/android/sdk/src/main/java/com/taobao/weex/ui/component/list/BasicListComponent.java
@@ -198,11 +198,6 @@ public void
setMarginsSupportRTL(ViewGroup.MarginLayoutParams lp, int left, int
@Override
public void setLayout(WXComponent component) {
-if (TextUtils.isEmpty(component.getComponentType())
-|| TextUtils.isEmpty(component.getRef()) ||
component.getLayoutPosition() == null
-|| component.getLayoutSize() == null) {
- return;
-}
if (component.getHostView() != null) {
int layoutDirection = component.isNativeLayoutRTL() ?
View.LAYOUT_DIRECTION_RTL : View.LAYOUT_DIRECTION_LTR;
ViewCompat.setLayoutDirection(component.getHostView(), layoutDirection);
diff --git
a/android/sdk/src/test/java/com/taobao/weex/ui/component/ComponentTest.java
b/android/sdk/src/test/java/com/taobao/weex/ui/component/ComponentTest.java
index 1e74e7a5ee..bcafc2a19f 100644
--- a/android/sdk/src/test/java/com/taobao/weex/ui/component/ComponentTest.java
+++ b/android/sdk/src/test/java/com/taobao/weex/ui/component/Component
[jira] [Commented] (WEEX-669) [android] crash when slider mAdapter null
[
https://issues.apache.org/jira/browse/WEEX-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698666#comment-16698666
]
ASF GitHub Bot commented on WEEX-669:
-
YorkShen commented on a change in pull request #1816: [WEEX-669][android] fix
slider crash when adapter is null
URL: https://github.com/apache/incubator-weex/pull/1816#discussion_r236151536
##
File path: android/sdk/src/main/java/com/taobao/weex/ui/component/WXSlider.java
##
@@ -214,7 +214,14 @@ public void run() {
@Override
public void setLayout(WXComponent component) {
-mAdapter.setLayoutDirectionRTL(this.isNativeLayoutRTL());
+if (TextUtils.isEmpty(component.getComponentType())
Review comment:
```
WXComponent.java
public static void setLayoutSafe(Component ){
if Check
setLayout(Component)
}
proctected void setLayout(Component ){
//Remove if check
}
```
Make sure codes in weex_sdk invoke setLayoutSafe
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [android] crash when slider mAdapter null
> -
>
> Key: WEEX-669
> URL: https://issues.apache.org/jira/browse/WEEX-669
> Project: Weex
> Issue Type: Bug
> Components: Android
>Affects Versions: 0.19
>Reporter: KAI TIAN
>Assignee: YorkShen
>Priority: Major
> Fix For: 0.19
>
>
> java.lang.NullPointerException: Attempt to invoke virtual method 'void
> com.taobao.weex.ui.view.WXCirclePageAdapter.setLayoutDirectionRTL(boolean)'
> on a null object reference
> at com.taobao.weex.ui.component.WXSlider.setLayout(WXSlider.java:217)
> at
> com.taobao.weex.ui.action.GraphicActionLayout.executeAction(GraphicActionLayout.java:44)
> at
> com.taobao.weex.ui.action.BasicGraphicAction.run(BasicGraphicAction.java:68)
> at android.os.Handler.handleCallback(Handler.java:751)
> at android.os.Handler.dispatchMessage(Handler.java:95)
> at android.os.Looper.loop(Looper.java:154)
> at android.app.ActivityThread.main(ActivityThread.java:6195)
> at java.lang.reflect.Method.invoke(Native Method)
> at
> com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889)
> at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WEEX-669) [android] crash when slider mAdapter null
[ https://issues.apache.org/jira/browse/WEEX-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698600#comment-16698600 ] ASF GitHub Bot commented on WEEX-669: - weex-bot edited a comment on issue #1816: [WEEX-669][android] fix slider crash when adapter is null URL: https://github.com/apache/incubator-weex/pull/1816#issuecomment-441541863 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [android] crash when slider mAdapter null > - > > Key: WEEX-669 > URL: https://issues.apache.org/jira/browse/WEEX-669 > Project: Weex > Issue Type: Bug > Components: Android >Affects Versions: 0.19 >Reporter: KAI TIAN >Assignee: YorkShen >Priority: Major > Fix For: 0.19 > > > java.lang.NullPointerException: Attempt to invoke virtual method 'void > com.taobao.weex.ui.view.WXCirclePageAdapter.setLayoutDirectionRTL(boolean)' > on a null object reference > at com.taobao.weex.ui.component.WXSlider.setLayout(WXSlider.java:217) > at > com.taobao.weex.ui.action.GraphicActionLayout.executeAction(GraphicActionLayout.java:44) > at > com.taobao.weex.ui.action.BasicGraphicAction.run(BasicGraphicAction.java:68) > at android.os.Handler.handleCallback(Handler.java:751) > at android.os.Handler.dispatchMessage(Handler.java:95) > at android.os.Looper.loop(Looper.java:154) > at android.app.ActivityThread.main(ActivityThread.java:6195) > at java.lang.reflect.Method.invoke(Native Method) > at > com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889) > at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-669) [android] crash when slider mAdapter null
[ https://issues.apache.org/jira/browse/WEEX-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698601#comment-16698601 ] ASF GitHub Bot commented on WEEX-669: - weex-bot edited a comment on issue #1816: [WEEX-669][android] fix slider crash when adapter is null URL: https://github.com/apache/incubator-weex/pull/1816#issuecomment-441541863 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [android] crash when slider mAdapter null > - > > Key: WEEX-669 > URL: https://issues.apache.org/jira/browse/WEEX-669 > Project: Weex > Issue Type: Bug > Components: Android >Affects Versions: 0.19 >Reporter: KAI TIAN >Assignee: YorkShen >Priority: Major > Fix For: 0.19 > > > java.lang.NullPointerException: Attempt to invoke virtual method 'void > com.taobao.weex.ui.view.WXCirclePageAdapter.setLayoutDirectionRTL(boolean)' > on a null object reference > at com.taobao.weex.ui.component.WXSlider.setLayout(WXSlider.java:217) > at > com.taobao.weex.ui.action.GraphicActionLayout.executeAction(GraphicActionLayout.java:44) > at > com.taobao.weex.ui.action.BasicGraphicAction.run(BasicGraphicAction.java:68) > at android.os.Handler.handleCallback(Handler.java:751) > at android.os.Handler.dispatchMessage(Handler.java:95) > at android.os.Looper.loop(Looper.java:154) > at android.app.ActivityThread.main(ActivityThread.java:6195) > at java.lang.reflect.Method.invoke(Native Method) > at > com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889) > at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-669) [android] crash when slider mAdapter null
[ https://issues.apache.org/jira/browse/WEEX-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698599#comment-16698599 ] ASF GitHub Bot commented on WEEX-669: - weex-bot edited a comment on issue #1816: [WEEX-669][android] fix slider crash when adapter is null URL: https://github.com/apache/incubator-weex/pull/1816#issuecomment-441541863 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [android] crash when slider mAdapter null > - > > Key: WEEX-669 > URL: https://issues.apache.org/jira/browse/WEEX-669 > Project: Weex > Issue Type: Bug > Components: Android >Affects Versions: 0.19 >Reporter: KAI TIAN >Assignee: YorkShen >Priority: Major > Fix For: 0.19 > > > java.lang.NullPointerException: Attempt to invoke virtual method 'void > com.taobao.weex.ui.view.WXCirclePageAdapter.setLayoutDirectionRTL(boolean)' > on a null object reference > at com.taobao.weex.ui.component.WXSlider.setLayout(WXSlider.java:217) > at > com.taobao.weex.ui.action.GraphicActionLayout.executeAction(GraphicActionLayout.java:44) > at > com.taobao.weex.ui.action.BasicGraphicAction.run(BasicGraphicAction.java:68) > at android.os.Handler.handleCallback(Handler.java:751) > at android.os.Handler.dispatchMessage(Handler.java:95) > at android.os.Looper.loop(Looper.java:154) > at android.app.ActivityThread.main(ActivityThread.java:6195) > at java.lang.reflect.Method.invoke(Native Method) > at > com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889) > at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-669) [android] crash when slider mAdapter null
[
https://issues.apache.org/jira/browse/WEEX-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698595#comment-16698595
]
ASF GitHub Bot commented on WEEX-669:
-
win80540 commented on a change in pull request #1816: [WEEX-669][android] fix
slider crash when adapter is null
URL: https://github.com/apache/incubator-weex/pull/1816#discussion_r236153772
##
File path: android/sdk/src/main/java/com/taobao/weex/ui/component/WXSlider.java
##
@@ -214,7 +214,14 @@ public void run() {
@Override
public void setLayout(WXComponent component) {
-mAdapter.setLayoutDirectionRTL(this.isNativeLayoutRTL());
+if (TextUtils.isEmpty(component.getComponentType())
Review comment:
Done
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [android] crash when slider mAdapter null
> -
>
> Key: WEEX-669
> URL: https://issues.apache.org/jira/browse/WEEX-669
> Project: Weex
> Issue Type: Bug
> Components: Android
>Affects Versions: 0.19
>Reporter: KAI TIAN
>Assignee: YorkShen
>Priority: Major
> Fix For: 0.19
>
>
> java.lang.NullPointerException: Attempt to invoke virtual method 'void
> com.taobao.weex.ui.view.WXCirclePageAdapter.setLayoutDirectionRTL(boolean)'
> on a null object reference
> at com.taobao.weex.ui.component.WXSlider.setLayout(WXSlider.java:217)
> at
> com.taobao.weex.ui.action.GraphicActionLayout.executeAction(GraphicActionLayout.java:44)
> at
> com.taobao.weex.ui.action.BasicGraphicAction.run(BasicGraphicAction.java:68)
> at android.os.Handler.handleCallback(Handler.java:751)
> at android.os.Handler.dispatchMessage(Handler.java:95)
> at android.os.Looper.loop(Looper.java:154)
> at android.app.ActivityThread.main(ActivityThread.java:6195)
> at java.lang.reflect.Method.invoke(Native Method)
> at
> com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889)
> at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WEEX-669) [android] crash when slider mAdapter null
[
https://issues.apache.org/jira/browse/WEEX-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698588#comment-16698588
]
ASF GitHub Bot commented on WEEX-669:
-
YorkShen commented on a change in pull request #1816: [WEEX-669][android] fix
slider crash when adapter is null
URL: https://github.com/apache/incubator-weex/pull/1816#discussion_r236147587
##
File path: android/sdk/src/main/java/com/taobao/weex/ui/component/WXSlider.java
##
@@ -214,7 +214,14 @@ public void run() {
@Override
public void setLayout(WXComponent component) {
-mAdapter.setLayoutDirectionRTL(this.isNativeLayoutRTL());
+if (TextUtils.isEmpty(component.getComponentType())
Review comment:
Change to this?
```
if(!TextUtils.isEmpty(component.getComponentType())&&...&&...){
if (mAdapter != null) {
mAdapter.setLayoutDirectionRTL(this.isNativeLayoutRTL());
}
super.setLayout(component);
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [android] crash when slider mAdapter null
> -
>
> Key: WEEX-669
> URL: https://issues.apache.org/jira/browse/WEEX-669
> Project: Weex
> Issue Type: Bug
> Components: Android
>Affects Versions: 0.19
>Reporter: KAI TIAN
>Assignee: YorkShen
>Priority: Major
> Fix For: 0.19
>
>
> java.lang.NullPointerException: Attempt to invoke virtual method 'void
> com.taobao.weex.ui.view.WXCirclePageAdapter.setLayoutDirectionRTL(boolean)'
> on a null object reference
> at com.taobao.weex.ui.component.WXSlider.setLayout(WXSlider.java:217)
> at
> com.taobao.weex.ui.action.GraphicActionLayout.executeAction(GraphicActionLayout.java:44)
> at
> com.taobao.weex.ui.action.BasicGraphicAction.run(BasicGraphicAction.java:68)
> at android.os.Handler.handleCallback(Handler.java:751)
> at android.os.Handler.dispatchMessage(Handler.java:95)
> at android.os.Looper.loop(Looper.java:154)
> at android.app.ActivityThread.main(ActivityThread.java:6195)
> at java.lang.reflect.Method.invoke(Native Method)
> at
> com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889)
> at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WEEX-669) [android] crash when slider mAdapter null
[
https://issues.apache.org/jira/browse/WEEX-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698564#comment-16698564
]
ASF GitHub Bot commented on WEEX-669:
-
YorkShen commented on a change in pull request #1816: [WEEX-669][android] fix
slider crash when adapter is null
URL: https://github.com/apache/incubator-weex/pull/1816#discussion_r236145649
##
File path: android/sdk/src/main/java/com/taobao/weex/ui/component/WXSlider.java
##
@@ -214,7 +214,14 @@ public void run() {
@Override
public void setLayout(WXComponent component) {
-mAdapter.setLayoutDirectionRTL(this.isNativeLayoutRTL());
+if (TextUtils.isEmpty(component.getComponentType())
Review comment:
What's reason for first `if`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [android] crash when slider mAdapter null
> -
>
> Key: WEEX-669
> URL: https://issues.apache.org/jira/browse/WEEX-669
> Project: Weex
> Issue Type: Bug
> Components: Android
>Affects Versions: 0.19
>Reporter: KAI TIAN
>Assignee: YorkShen
>Priority: Major
> Fix For: 0.19
>
>
> java.lang.NullPointerException: Attempt to invoke virtual method 'void
> com.taobao.weex.ui.view.WXCirclePageAdapter.setLayoutDirectionRTL(boolean)'
> on a null object reference
> at com.taobao.weex.ui.component.WXSlider.setLayout(WXSlider.java:217)
> at
> com.taobao.weex.ui.action.GraphicActionLayout.executeAction(GraphicActionLayout.java:44)
> at
> com.taobao.weex.ui.action.BasicGraphicAction.run(BasicGraphicAction.java:68)
> at android.os.Handler.handleCallback(Handler.java:751)
> at android.os.Handler.dispatchMessage(Handler.java:95)
> at android.os.Looper.loop(Looper.java:154)
> at android.app.ActivityThread.main(ActivityThread.java:6195)
> at java.lang.reflect.Method.invoke(Native Method)
> at
> com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889)
> at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WEEX-669) [android] crash when slider mAdapter null
[ https://issues.apache.org/jira/browse/WEEX-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698557#comment-16698557 ] ASF GitHub Bot commented on WEEX-669: - weex-bot commented on issue #1816: [WEEX-669][android] fix slider crash when adapter is null URL: https://github.com/apache/incubator-weex/pull/1816#issuecomment-441541863 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [android] crash when slider mAdapter null > - > > Key: WEEX-669 > URL: https://issues.apache.org/jira/browse/WEEX-669 > Project: Weex > Issue Type: Bug > Components: Android >Affects Versions: 0.19 >Reporter: KAI TIAN >Assignee: YorkShen >Priority: Major > Fix For: 0.19 > > > java.lang.NullPointerException: Attempt to invoke virtual method 'void > com.taobao.weex.ui.view.WXCirclePageAdapter.setLayoutDirectionRTL(boolean)' > on a null object reference > at com.taobao.weex.ui.component.WXSlider.setLayout(WXSlider.java:217) > at > com.taobao.weex.ui.action.GraphicActionLayout.executeAction(GraphicActionLayout.java:44) > at > com.taobao.weex.ui.action.BasicGraphicAction.run(BasicGraphicAction.java:68) > at android.os.Handler.handleCallback(Handler.java:751) > at android.os.Handler.dispatchMessage(Handler.java:95) > at android.os.Looper.loop(Looper.java:154) > at android.app.ActivityThread.main(ActivityThread.java:6195) > at java.lang.reflect.Method.invoke(Native Method) > at > com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889) > at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-669) [android] crash when slider mAdapter null
[ https://issues.apache.org/jira/browse/WEEX-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698559#comment-16698559 ] ASF GitHub Bot commented on WEEX-669: - weex-bot edited a comment on issue #1816: [WEEX-669][android] fix slider crash when adapter is null URL: https://github.com/apache/incubator-weex/pull/1816#issuecomment-441541863 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [android] crash when slider mAdapter null > - > > Key: WEEX-669 > URL: https://issues.apache.org/jira/browse/WEEX-669 > Project: Weex > Issue Type: Bug > Components: Android >Affects Versions: 0.19 >Reporter: KAI TIAN >Assignee: YorkShen >Priority: Major > Fix For: 0.19 > > > java.lang.NullPointerException: Attempt to invoke virtual method 'void > com.taobao.weex.ui.view.WXCirclePageAdapter.setLayoutDirectionRTL(boolean)' > on a null object reference > at com.taobao.weex.ui.component.WXSlider.setLayout(WXSlider.java:217) > at > com.taobao.weex.ui.action.GraphicActionLayout.executeAction(GraphicActionLayout.java:44) > at > com.taobao.weex.ui.action.BasicGraphicAction.run(BasicGraphicAction.java:68) > at android.os.Handler.handleCallback(Handler.java:751) > at android.os.Handler.dispatchMessage(Handler.java:95) > at android.os.Looper.loop(Looper.java:154) > at android.app.ActivityThread.main(ActivityThread.java:6195) > at java.lang.reflect.Method.invoke(Native Method) > at > com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889) > at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-669) [android] crash when slider mAdapter null
[ https://issues.apache.org/jira/browse/WEEX-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698558#comment-16698558 ] ASF GitHub Bot commented on WEEX-669: - weex-bot edited a comment on issue #1816: [WEEX-669][android] fix slider crash when adapter is null URL: https://github.com/apache/incubator-weex/pull/1816#issuecomment-441541863 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/";>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [android] crash when slider mAdapter null > - > > Key: WEEX-669 > URL: https://issues.apache.org/jira/browse/WEEX-669 > Project: Weex > Issue Type: Bug > Components: Android >Affects Versions: 0.19 >Reporter: KAI TIAN >Assignee: YorkShen >Priority: Major > Fix For: 0.19 > > > java.lang.NullPointerException: Attempt to invoke virtual method 'void > com.taobao.weex.ui.view.WXCirclePageAdapter.setLayoutDirectionRTL(boolean)' > on a null object reference > at com.taobao.weex.ui.component.WXSlider.setLayout(WXSlider.java:217) > at > com.taobao.weex.ui.action.GraphicActionLayout.executeAction(GraphicActionLayout.java:44) > at > com.taobao.weex.ui.action.BasicGraphicAction.run(BasicGraphicAction.java:68) > at android.os.Handler.handleCallback(Handler.java:751) > at android.os.Handler.dispatchMessage(Handler.java:95) > at android.os.Looper.loop(Looper.java:154) > at android.app.ActivityThread.main(ActivityThread.java:6195) > at java.lang.reflect.Method.invoke(Native Method) > at > com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889) > at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-669) [android] crash when slider mAdapter null
[ https://issues.apache.org/jira/browse/WEEX-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698556#comment-16698556 ] ASF GitHub Bot commented on WEEX-669: - win80540 opened a new pull request #1816: [WEEX-669][android] fix slider crash when adapter is null URL: https://github.com/apache/incubator-weex/pull/1816 fix slider crash when adapter is null java.lang.NullPointerException: Attempt to invoke virtual method 'void com.taobao.weex.ui.view.WXCirclePageAdapter.setLayoutDirectionRTL(boolean)' on a null object reference at com.taobao.weex.ui.component.WXSlider.setLayout(WXSlider.java:217) at com.taobao.weex.ui.action.GraphicActionLayout.executeAction(GraphicActionLayout.java:44) at com.taobao.weex.ui.action.BasicGraphicAction.run(BasicGraphicAction.java:68) at android.os.Handler.handleCallback(Handler.java:751) at android.os.Handler.dispatchMessage(Handler.java:95) at android.os.Looper.loop(Looper.java:154) at android.app.ActivityThread.main(ActivityThread.java:6195) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [android] crash when slider mAdapter null > - > > Key: WEEX-669 > URL: https://issues.apache.org/jira/browse/WEEX-669 > Project: Weex > Issue Type: Bug > Components: Android >Affects Versions: 0.19 >Reporter: KAI TIAN >Assignee: YorkShen >Priority: Major > Fix For: 0.19 > > > java.lang.NullPointerException: Attempt to invoke virtual method 'void > com.taobao.weex.ui.view.WXCirclePageAdapter.setLayoutDirectionRTL(boolean)' > on a null object reference > at com.taobao.weex.ui.component.WXSlider.setLayout(WXSlider.java:217) > at > com.taobao.weex.ui.action.GraphicActionLayout.executeAction(GraphicActionLayout.java:44) > at > com.taobao.weex.ui.action.BasicGraphicAction.run(BasicGraphicAction.java:68) > at android.os.Handler.handleCallback(Handler.java:751) > at android.os.Handler.dispatchMessage(Handler.java:95) > at android.os.Looper.loop(Looper.java:154) > at android.app.ActivityThread.main(ActivityThread.java:6195) > at java.lang.reflect.Method.invoke(Native Method) > at > com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889) > at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
