Re: Feature Proposal: Remove dependency between isJSFrameworkInit & data render

[申远]

 @ hpop1...@163.com

Thanks for your contribution, the PR has been merged.

Best Regards,
YorkShen

申远


York Shen  于2019年4月18日周四 下午8:48写道：

> Thanks for your advice.  I really like your idea and I am glad to see your
> improvement if it’s possible.
>
> Don’t be hurry, you would have plenty designing and coding.
>
> BTW: I have created a Github Project for you Schedule (
> https://github.com/apache/incubator-weex/projects/3).
>
>
> Best Regards,
> York Shen
>
> 申远
>
> 在 2019年4月18日，16:37，胥加成  写道：
>
> Background: On Android, DATA_RENDER / DATA_RENDER_BINARY render mode don't
> require JSFramework to be inited to run. Currently WXBridgeManager will
> check framework init state for every bridge call such as createInstance or
> refreshInstance.
>
> Improvement: Create a flag: dataRenderRequireJSF in WXSDKInstance, when
> checking isJSFrameworkInit in WXBridgeManager, check if render strategy is
> (DATA_RENDER|| DATA_RENDER_BINARY) && dataRenderRequireJSF. If so,
>  check isJSFrameworkInit; If not, skip checking procedure. Using Dom
> module to set up this flag. Default value is false;
>
> Influence: Weex instance that renders in data render mode.
>
> Tasks: 2 days,  modify WXSDKInstance.java WXBridgeManager.java
> && WXDomModule.java
>
>
>
>

Re: Feature Proposal: Remove dependency between isJSFrameworkInit & data render

[York Shen]

Thanks for your advice.  I really like your idea and I am glad to see your 
improvement if it’s possible.

Don’t be hurry, you would have plenty designing and coding.

BTW: I have created a Github Project for you Schedule 
(https://github.com/apache/incubator-weex/projects/3 
).


Best Regards,
York Shen

申远

> 在 2019年4月18日，16:37，胥加成  写道：
> 
> Background: On Android, DATA_RENDER / DATA_RENDER_BINARY render mode don't 
> require JSFramework to be inited to run. Currently WXBridgeManager will check 
> framework init state for every bridge call such as createInstance or 
> refreshInstance.
> 
> Improvement: Create a flag: dataRenderRequireJSF in WXSDKInstance, when 
> checking isJSFrameworkInit in WXBridgeManager, check if render strategy is 
> (DATA_RENDER|| DATA_RENDER_BINARY) && dataRenderRequireJSF. If so,
>  check isJSFrameworkInit; If not, skip checking procedure. Using Dom module 
> to set up this flag. Default value is false;
> 
> Influence: Weex instance that renders in data render mode.
> 
> Tasks: 2 days,  modify WXSDKInstance.java WXBridgeManager.java && 
> WXDomModule.java
> 
> 

Feature Proposal: Remove dependency between isJSFrameworkInit & data render

[胥加成]

Background: On Android, DATA_RENDER / DATA_RENDER_BINARY render mode don't 
require JSFramework to be inited to run. Currently WXBridgeManager will check 
framework init state for every bridge call such as createInstance or 
refreshInstance.

Improvement: Create a flag: dataRenderRequireJSF in WXSDKInstance, when 
checking isJSFrameworkInit in WXBridgeManager, check if render strategy is 
(DATA_RENDER|| DATA_RENDER_BINARY) && dataRenderRequireJSF. If so,
 check isJSFrameworkInit; If not, skip checking procedure. Using Dom module to 
set up this flag. Default value is false;

Influence: Weex instance that renders in data render mode.

Tasks: 2 days,  modify WXSDKInstance.java WXBridgeManager.java && 
WXDomModule.java