Re: More flexible Panel, Fragment, etc.
Since the release vote for 1.5 RC1 has started I guess that means this feature will unfortunately not make it into 1.5? Regards, Daniel Soneira On 10.01.2011 02:09, Igor Vaynberg wrote: i really like this. lets commit it. a couple of notes below: assocatedmarkupsourcingstrategy.oncomponenttag() may have a problem. looks like its assuming external markup files begin with wicket:xxx tag, but they may begin with html xmlns:wicket wicket:panel is the html tag stripped before this code executes and the assumption is safe to make? WebMarkupContainerWithAssociatedMarkup is still there, do we need it? it might make sense to merge IMarkupResourceStreamProvider and IMarkupCacheKeyProvider into the sourcing interface so we have one interface that deals with component-markup relationship rather then three. not sure if it makes sense though. if we do this, however, we should probably replace getMarkupSourceStrategy() with a hasMarkupSourceStategy() and newMarkupSourceStrategy() result of which is cached in the metadata - otherwise users have to add another slot to do the caching, know to cache it, know to cache it in a transient field. cheers, -igor On Sun, Jan 9, 2011 at 12:12 AM, Juergen Donnerstag juergen.donners...@gmail.com wrote: done: https://issues.apache.org/jira/browse/WICKET-3314 -Juergen On Sun, Jan 9, 2011 at 1:03 AM, Igor Vaynbergigor.vaynb...@gmail.com wrote: sounds interesting, but your patch didnt make it. attach to a jira issue? -igor On Sat, Jan 8, 2011 at 2:54 PM, Juergen Donnerstag juergen.donners...@gmail.com wrote: Hi, currently every component that requires the markup to be in an associated file must be derived from Panel. Every component that want it's markup inline must be derived from Fragment. I've changed that and moved the respective source code into something I called markup sourcing strategy. I'm not sure it's the best name, so feel free to suggest other names. Such a strategy can be provided to any component via public IMarkupSourcingStrategy getMarkupSourcingStrategy(); Obviously it makes sense that only one strategy can be associated with any component. Each strategy has its own implementations to provide the correct markup, handle the header contribution, necessary changes to the open tag and it renders the component body appropriately. Changing a FormComponent to a FormComponentPanel is now as simple as subclassing getMarkupSourcingStrategy(). And it easily be changed to become a FormComponentFragment I've attached a patch (draft) against 1.5 trunk which successfully passes all tests in core. I wonder what you think about the idea. -Juergen
Re: More flexible Panel, Fragment, etc.
On Thu, Jan 13, 2011 at 11:42 AM, Daniel Soneira daniel.sone...@joyn-it.at wrote: Since the release vote for 1.5 RC1 has started I guess that means this feature will unfortunately not make it into 1.5? According to https://issues.apache.org/jira/browse/WICKET-3314?page=com.atlassian.jira.plugin.ext.subversion%3Asubversion-commits-tabpanel it is in the release. Martijn
Re: [vote] release wicket-1.5-rc1
+1 (non binding) - looks good On 2011-01-13, at 1:20 AM, Igor Vaynberg wrote: this vote is to release wicket 1.5-rc1. the trunk has been stable for a while without any major bugs found. the api has also stabilized nicely. it is time for rc1. branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-RC1 artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-RC1/ maven repo: https://repository.apache.org/content/repositories/orgapachewicket-023/ changelog: https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=truepid=12310561fixfor=12315483sorter/field=issuekeysorter/order=DESC this vote ends Saturday, January 15 at 11:30pm GMT-8 please test the release and offer your vote cheers, -igor
Re: More flexible Panel, Fragment, etc.
An initial version went into rc1 though we are still discussing minor changes. The API might change slighty. -Juergen On Thu, Jan 13, 2011 at 11:49 AM, Martijn Dashorst martijn.dasho...@gmail.com wrote: On Thu, Jan 13, 2011 at 11:42 AM, Daniel Soneira daniel.sone...@joyn-it.at wrote: Since the release vote for 1.5 RC1 has started I guess that means this feature will unfortunately not make it into 1.5? According to https://issues.apache.org/jira/browse/WICKET-3314?page=com.atlassian.jira.plugin.ext.subversion%3Asubversion-commits-tabpanel it is in the release. Martijn
Re: More flexible Panel, Fragment, etc.
I'm pleased to see this feature included. 1.5 will rock! Cheers, Daniel On 13.01.2011 19:13, Juergen Donnerstag wrote: An initial version went into rc1 though we are still discussing minor changes. The API might change slighty. -Juergen On Thu, Jan 13, 2011 at 11:49 AM, Martijn Dashorst martijn.dasho...@gmail.com wrote: On Thu, Jan 13, 2011 at 11:42 AM, Daniel Soneira daniel.sone...@joyn-it.at wrote: Since the release vote for 1.5 RC1 has started I guess that means this feature will unfortunately not make it into 1.5? According to https://issues.apache.org/jira/browse/WICKET-3314?page=com.atlassian.jira.plugin.ext.subversion%3Asubversion-commits-tabpanel it is in the release. Martijn
Re: [vote] release wicket-1.5-rc1
Sadly I have a -1 for this, because of https://issues.apache.org/jira/browse/WICKET-3329 and https://issues.apache.org/jira/browse/WICKET-3330 3329 is almost a don't care, but 3330 sounds more serious to me. Best regards, Peter 2011-01-13 08:20 keltezéssel, Igor Vaynberg írta: this vote is to release wicket 1.5-rc1. the trunk has been stable for a while without any major bugs found. the api has also stabilized nicely. it is time for rc1. branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-RC1 artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-RC1/ maven repo: https://repository.apache.org/content/repositories/orgapachewicket-023/ changelog: https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=truepid=12310561fixfor=12315483sorter/field=issuekeysorter/order=DESC this vote ends Saturday, January 15 at 11:30pm GMT-8 please test the release and offer your vote cheers, -igor
Re: [vote] release wicket-1.5-rc1
could we please add testcases if applicable. thanks. Juergen 2011/1/13 Major Péter majorpe...@sch.bme.hu: Sadly I have a -1 for this, because of https://issues.apache.org/jira/browse/WICKET-3329 and https://issues.apache.org/jira/browse/WICKET-3330 3329 is almost a don't care, but 3330 sounds more serious to me. Best regards, Peter 2011-01-13 08:20 keltezéssel, Igor Vaynberg írta: this vote is to release wicket 1.5-rc1. the trunk has been stable for a while without any major bugs found. the api has also stabilized nicely. it is time for rc1. branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-RC1 artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-RC1/ maven repo: https://repository.apache.org/content/repositories/orgapachewicket-023/ changelog: https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=truepid=12310561fixfor=12315483sorter/field=issuekeysorter/order=DESC this vote ends Saturday, January 15 at 11:30pm GMT-8 please test the release and offer your vote cheers, -igor
Re: Display component feedback message once: safety net renders them always before
On Tue, Jan 4, 2011 at 10:13 AM, Jeremy Thomerson jer...@wickettraining.com wrote: I had encountered this issue and for one of my training classes, I threw together a solution. Your post prodded me to go ahead and post my solution as a blog post. After dusting off my long-forgotten blog, here it is: http://www.jeremythomerson.com/blog/2011/01/catching-all-feedback -messages-that-arent-rendered-by-other-feedback-panels/ (or http://bit.ly/eHUEuN if that gets chopped up). Moving this discussion to dev@ - does anyone think that I should commit this catch all feedback panel to core? Would it be useful to others? I've used it, or something similar in several applications - not sure if others have had similar requirements. -- Jeremy Thomerson http://wickettraining.com *Need a CMS for Wicket? Use Brix! http://brixcms.org*
Re: Display component feedback message once: safety net renders them always before
I'd like to see it in core! On Thu, Jan 13, 2011 at 2:19 PM, Jeremy Thomerson jer...@wickettraining.com wrote: On Tue, Jan 4, 2011 at 10:13 AM, Jeremy Thomerson jer...@wickettraining.com wrote: I had encountered this issue and for one of my training classes, I threw together a solution. Your post prodded me to go ahead and post my solution as a blog post. After dusting off my long-forgotten blog, here it is: http://www.jeremythomerson.com/blog/2011/01/catching-all-feedback -messages-that-arent-rendered-by-other-feedback-panels/ (or http://bit.ly/eHUEuN if that gets chopped up). Moving this discussion to dev@ - does anyone think that I should commit this catch all feedback panel to core? Would it be useful to others? I've used it, or something similar in several applications - not sure if others have had similar requirements. -- Jeremy Thomerson http://wickettraining.com *Need a CMS for Wicket? Use Brix! http://brixcms.org*
Re: [vote] release wicket-1.5-rc1
here is a binding -1 to close this officially. -igor 2011/1/13 Major Péter majorpe...@sch.bme.hu: Sadly I have a -1 for this, because of https://issues.apache.org/jira/browse/WICKET-3329 and https://issues.apache.org/jira/browse/WICKET-3330 3329 is almost a don't care, but 3330 sounds more serious to me. Best regards, Peter 2011-01-13 08:20 keltezéssel, Igor Vaynberg írta: this vote is to release wicket 1.5-rc1. the trunk has been stable for a while without any major bugs found. the api has also stabilized nicely. it is time for rc1. branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-RC1 artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-RC1/ maven repo: https://repository.apache.org/content/repositories/orgapachewicket-023/ changelog: https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=truepid=12310561fixfor=12315483sorter/field=issuekeysorter/order=DESC this vote ends Saturday, January 15 at 11:30pm GMT-8 please test the release and offer your vote cheers, -igor
Re: Display component feedback message once: safety net renders them always before
if you put two of them on a page do you get an infinite loop? :) -igor On Thu, Jan 13, 2011 at 12:19 PM, Jeremy Thomerson jer...@wickettraining.com wrote: On Tue, Jan 4, 2011 at 10:13 AM, Jeremy Thomerson jer...@wickettraining.com wrote: I had encountered this issue and for one of my training classes, I threw together a solution. Your post prodded me to go ahead and post my solution as a blog post. After dusting off my long-forgotten blog, here it is: http://www.jeremythomerson.com/blog/2011/01/catching-all-feedback -messages-that-arent-rendered-by-other-feedback-panels/ (or http://bit.ly/eHUEuN if that gets chopped up). Moving this discussion to dev@ - does anyone think that I should commit this catch all feedback panel to core? Would it be useful to others? I've used it, or something similar in several applications - not sure if others have had similar requirements. -- Jeremy Thomerson http://wickettraining.com *Need a CMS for Wicket? Use Brix! http://brixcms.org*
Re: [vote] release wicket-1.5-rc1
Releases can't be vetoed but it is good to see a binding -1 vote. Just call the vote cancelled because there was a problem identified On Jan 13, 2011 9:26 PM, Igor Vaynberg igor.vaynb...@gmail.com wrote: here is a binding -1 to close this officially. -igor 2011/1/13 Major Péter majorpe...@sch.bme.hu: Sadly I have a -1 for this, because of https://issues.apache.org/jira/browse/WICKET-3329 and https://issues.apache.org/jira/browse/WICKET-3330 3329 is almost a don't care, but 3330 sounds more serious to me. Best regards, Peter 2011-01-13 08:20 keltezéssel, Igor Vaynberg írta: this vote is to release wicket 1.5-rc1. the trunk has been stable for a while without any major bugs found. the api has also stabilized nicely. it is time for rc1. branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-RC1 artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-RC1/ maven repo: https://repository.apache.org/content/repositories/orgapachewicket-023/ changelog: https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=truepid=12310561fixfor=12315483sorter/field=issuekeysorter/order=DESC this vote ends Saturday, January 15 at 11:30pm GMT-8 please test the release and offer your vote cheers, -igor
Re: Display component feedback message once: safety net renders them always before
It's like crossing the streams on Ghostbusters. Just don't do it. :) On Jan 13, 2011 9:27 PM, Igor Vaynberg igor.vaynb...@gmail.com wrote: if you put two of them on a page do you get an infinite loop? :) -igor On Thu, Jan 13, 2011 at 12:19 PM, Jeremy Thomerson jer...@wickettraining.com wrote: On Tue, Jan 4, 2011 at 10:13 AM, Jeremy Thomerson jer...@wickettraining.com wrote: I had encountered this issue and for one of my training classes, I threw together a solution. Your post prodded me to go ahead and post my solution as a blog post. After dusting off my long-forgotten blog, here it is: http://www.jeremythomerson.com/blog/2011/01/catching-all-feedback -messages-that-arent-rendered-by-other-feedback-panels/ (or http://bit.ly/eHUEuN if that gets chopped up). Moving this discussion to dev@ - does anyone think that I should commit this catch all feedback panel to core? Would it be useful to others? I've used it, or something similar in several applications - not sure if others have had similar requirements. -- Jeremy Thomerson http://wickettraining.com *Need a CMS for Wicket? Use Brix! http://brixcms.org*
Re: Display component feedback message once: safety net renders them always before
Nah - it could throw an IFoundMyTwinException - except the leading I might make someone think that it was an interface! On Thu, Jan 13, 2011 at 8:26 PM, Igor Vaynberg igor.vaynb...@gmail.comwrote: if you put two of them on a page do you get an infinite loop? :) -igor On Thu, Jan 13, 2011 at 12:19 PM, Jeremy Thomerson jer...@wickettraining.com wrote: On Tue, Jan 4, 2011 at 10:13 AM, Jeremy Thomerson jer...@wickettraining.com wrote: I had encountered this issue and for one of my training classes, I threw together a solution. Your post prodded me to go ahead and post my solution as a blog post. After dusting off my long-forgotten blog, here it is: http://www.jeremythomerson.com/blog/2011/01/catching-all-feedback -messages-that-arent-rendered-by-other-feedback-panels/ (or http://bit.ly/eHUEuN if that gets chopped up). Moving this discussion to dev@ - does anyone think that I should commit this catch all feedback panel to core? Would it be useful to others? I've used it, or something similar in several applications - not sure if others have had similar requirements. -- Jeremy Thomerson http://wickettraining.com *Need a CMS for Wicket? Use Brix! http://brixcms.org* -- Jeremy Thomerson http://wickettraining.com *Need a CMS for Wicket? Use Brix! http://brixcms.org*
Re: Display component feedback message once: safety net rendersthem always before
+1 for adding to core (non-binding) --Original Message-- From: Jeremy Thomerson To: Wicket Development ReplyTo: dev@wicket.apache.org Subject: Re: Display component feedback message once: safety net rendersthem always before Sent: Jan 13, 2011 21:19 On Tue, Jan 4, 2011 at 10:13 AM, Jeremy Thomerson jer...@wickettraining.com wrote: I had encountered this issue and for one of my training classes, I threw together a solution. Your post prodded me to go ahead and post my solution as a blog post. After dusting off my long-forgotten blog, here it is: http://www.jeremythomerson.com/blog/2011/01/catching-all-feedback -messages-that-arent-rendered-by-other-feedback-panels/ (or http://bit.ly/eHUEuN if that gets chopped up). Moving this discussion to dev@ - does anyone think that I should commit this catch all feedback panel to core? Would it be useful to others? I've used it, or something similar in several applications - not sure if others have had similar requirements. -- Jeremy Thomerson http://wickettraining.com *Need a CMS for Wicket? Use Brix! http://brixcms.org*
