[GitHub] wicket issue #171: modified class resolution to account for OSGi classloader...

[martin-g]

Github user martin-g commented on the issue:

https://github.com/apache/wicket/pull/171
  
Hi,

Thank you for the Pull Request!
Could you please provide more information why this change is needed ?
For OSGi environment the application is supposed to use custom 
IClassResolver.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: MetaDataHeaderItem # generateString()

[Francois Meillet]

https://issues.apache.org/jira/browse/WICKET-6178 


François 








> Le 8 juin 2016 à 12:16, Martin Grigorov  a écrit :
> 
> Hi Francois,
> 
> On Wed, Jun 8, 2016 at 11:50 AM, Francois Meillet <
> francois.meil...@gmail.com> wrote:
> 
>> Hi Wicket Devs,
>> 
>> I think MetaDataHeaderItem # generateString() should return specials
>> characters escaped like
>> StringEscapeUtils.escapeHtml(s) does.
>> 
>> Apache Wicket 7.3.0 - MetaDataHeaderItem  - Line 126 :
>> append(JavaScriptUtils.escapeQuotes(value.toString()))
>> 
> 
> Looking at
> https://github.com/apache/wicket/blob/39fb20b112e2005dab8e17667e5a763b1d89f18e/wicket-core/src/main/java/org/apache/wicket/markup/head/MetaDataHeaderItem.java#L125-L127
> I agree that only double quotes should be escaped because only double
> quotes may end prematurely the value.
> 
> 
>> return qwerty'qwerty as qwerty\’qwerty
>> 
>> I would like the return to be qwerty'qwerty (for example for the metatag
>> description).
>> 
>> What do you think of that ?
>> 
>> Thanks
>> François
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> 

Re: MetaDataHeaderItem # generateString()

[Martin Grigorov]

Hi Francois,

On Wed, Jun 8, 2016 at 11:50 AM, Francois Meillet <
francois.meil...@gmail.com> wrote:

> Hi Wicket Devs,
>
> I think MetaDataHeaderItem # generateString() should return specials
> characters escaped like
> StringEscapeUtils.escapeHtml(s) does.
>
> Apache Wicket 7.3.0 - MetaDataHeaderItem  - Line 126 :
> append(JavaScriptUtils.escapeQuotes(value.toString()))
>

Looking at
https://github.com/apache/wicket/blob/39fb20b112e2005dab8e17667e5a763b1d89f18e/wicket-core/src/main/java/org/apache/wicket/markup/head/MetaDataHeaderItem.java#L125-L127
I agree that only double quotes should be escaped because only double
quotes may end prematurely the value.


> return qwerty'qwerty as qwerty\’qwerty
>
> I would like the return to be qwerty'qwerty (for example for the metatag
> description).
>
> What do you think of that ?
>
> Thanks
> François
>
>
>
>
>
>
>
>
>

Re: org.apache.wicket.util.string.StringEscapeUtils vs apache.commons.lang3.StringEscapeUtils

[Francois Meillet]

Agree to keep things lights

Thanks Martin,
François







> Le 8 juin 2016 à 11:58, Martin Grigorov  a écrit :
> 
> Hi Francois,
> 
> This has been done long time ago (Wicket 1.0/1.1).
> The idea is to keep Wicket light, without dependencies.
> Only the classes Wicket internals needed were copied.
> In Wicket 7.0.0 we introduced dependency to commons-fileupload to be able
> to update it. This also included commons-io as transitive dependency.
> In Wicket 7.1.0 commons-collections4 has been added for LinkedMap solely.
> This might be a good move or bad. We will see. So far no one complained
> about the extra dependencies.
> 
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
> 
> On Wed, Jun 8, 2016 at 11:51 AM, Francois Meillet <
> francois.meil...@gmail.com> wrote:
> 
>> Hi,
>> 
>> Why use a copy of the org.apache.commons.lang3.StringEscapeUtils and not
>> directly the lib ?
>> 
>> Thanks
>> François
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> 

Re: org.apache.wicket.util.string.StringEscapeUtils vs apache.commons.lang3.StringEscapeUtils

[Martin Grigorov]

Hi Francois,

This has been done long time ago (Wicket 1.0/1.1).
The idea is to keep Wicket light, without dependencies.
Only the classes Wicket internals needed were copied.
In Wicket 7.0.0 we introduced dependency to commons-fileupload to be able
to update it. This also included commons-io as transitive dependency.
In Wicket 7.1.0 commons-collections4 has been added for LinkedMap solely.
This might be a good move or bad. We will see. So far no one complained
about the extra dependencies.

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Wed, Jun 8, 2016 at 11:51 AM, Francois Meillet <
francois.meil...@gmail.com> wrote:

> Hi,
>
> Why use a copy of the org.apache.commons.lang3.StringEscapeUtils and not
> directly the lib ?
>
> Thanks
> François
>
>
>
>
>
>
>
>

org.apache.wicket.util.string.StringEscapeUtils vs apache.commons.lang3.StringEscapeUtils

[Francois Meillet]

Hi,

Why use a copy of the org.apache.commons.lang3.StringEscapeUtils and not 
directly the lib ?

Thanks
François