[GitHub] wicket pull request #240: WICKET-6055 non-blocking lazy loading

2017-11-14 Thread svenmeier 
Github user svenmeier commented on a diff in the pull request:

https://github.com/apache/wicket/pull/240#discussion_r150953339
  
--- Diff: 
wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/AjaxLazyLoadPanelTesterTest.java
 ---
@@ -38,12 +38,12 @@
@Test
public void test()
{
-   AjaxLazyLoadPanel panel = new AjaxLazyLoadPanel("panel")
+   AjaxLazyLoadPanel panel = new 
AjaxLazyLoadPanel("panel")
{
private static final long serialVersionUID = 1L;
 
@Override
-   public Component getLazyLoadComponent(final String 
markupId)
+   protected Component getLazyLoadComponent(String 
markupId)
--- End diff --

Thanks, it should still be public too.


---

Re: wicket git commit: [WICKET-6496] javadoc clean-up

2017-11-14 Thread Andrea Del Bene 
Thank you Maxim!

On Tue, Nov 14, 2017 at 4:35 AM,  wrote:

> Repository: wicket
> Updated Branches:
>   refs/heads/master cb0b1d6f7 -> 50bc0d61c
>
>
> [WICKET-6496] javadoc clean-up
>
>
> Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
> Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/50bc0d61
> Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/50bc0d61
> Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/50bc0d61
>
> Branch: refs/heads/master
> Commit: 50bc0d61c95ad13cb35f2f1b515c0241f02be756
> Parents: cb0b1d6
> Author: Maxim Solodovnik 
> Authored: Tue Nov 14 10:35:47 2017 +0700
> Committer: Maxim Solodovnik 
> Committed: Tue Nov 14 10:35:47 2017 +0700
>
> --
>  .../java/org/apache/wicket/core/util/string/JavaScriptUtils.java| 1 -
>  1 file changed, 1 deletion(-)
> --
>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> 50bc0d61/wicket-core/src/main/java/org/apache/wicket/core/
> util/string/JavaScriptUtils.java
> --
> diff --git 
> a/wicket-core/src/main/java/org/apache/wicket/core/util/string/JavaScriptUtils.java
> b/wicket-core/src/main/java/org/apache/wicket/core/util/
> string/JavaScriptUtils.java
> index b95c531..8e4d042 100644
> --- a/wicket-core/src/main/java/org/apache/wicket/core/util/
> string/JavaScriptUtils.java
> +++ b/wicket-core/src/main/java/org/apache/wicket/core/util/
> string/JavaScriptUtils.java
> @@ -83,7 +83,6 @@ public class JavaScriptUtils
>  * @param input
>  *the JavaScript which needs to be escaped
>  * @return Escaped version of the input
> -* @see org.apache.wicket.ajax.json.JSONObject#quote(String)
>  */
> public static CharSequence escapeQuotes(final CharSequence input)
> {
>
>

wicket 8 - js to asnyc and or defer?

2017-11-14 Thread Korbinian Bachl 
Hi,

after WICKET-6492 seems to take care of the bug of minification and even 
uniting of the Javascript files of wicket, I wonder if wicket cant even get 
better in the js part. Currently each page having ajax somehow ends up with 
following in the head:

(1)
(2)
(3)

(4 - inline var and not really an issue)

/**/


(5)
/**/



While 1,2 and 3 could be easily made at least defer, script 5 makes this 
impossible so far, having all 4 scripts lead to a slower DOMContentLoaded 
(requestet and executed 1 by 1), even these are not needed at that time and 
could IMHO be easily postponed to a time when the rendering tree is ready (and 
so dont block it);

The real culprint IMHO is (5) and that it immediately needs the Wicket.Event 
object - so, I see 2 solutions for this: 

1st: outline this code into a request specific js-src file that can be loaded 
like e.g.: