[GitHub] wicket pull request #253: WICKET-6498 deferred javascript

[svenmeier]

Github user svenmeier commented on a diff in the pull request:

https://github.com/apache/wicket/pull/253#discussion_r162726991
  
--- Diff: 
wicket-core/src/main/java/org/apache/wicket/markup/head/filter/FilteringHeaderResponse.java
 ---
@@ -263,14 +262,12 @@ public void markRendered(Object object)
}
};
 
-   ResourceAggregator resourceAggregator = new 
ResourceAggregator(headerRenderer);
-
for (HeaderItem curItem : resp)
{
-   resourceAggregator.render(curItem);
+   headerRenderer.render(curItem);
--- End diff --

Thanks Maxim, I'll take a look.


---

WICKET-6498 deferred javascript

[Maxim Solodovnik]

Hello All,

I was able to fix all tests broken by this PR
https://github.com/apache/wicket/pull/253
Except for FilteringHeaderResponseTest (
https://github.com/apache/wicket/pull/253#pullrequestreview-88658254)

Can someone take a look at it please?

-- 
WBR
Maxim aka solomax

Re: WICKET-6503 and hook methods

[Andrea Del Bene]

Thank you!

On Jan 19, 2018 10:24 AM, "Sven Meier"  wrote:

> Hi Andrea,
>
> I've tried to limit my clean-up to internal methods, i.e. those marked
> with "THIS METHOD IS NOT ... PUBLIC .. DO NOT CALL IT!".
>
> I see now that #onAfterRenderChildren() was protected and not marked as
> internal, but IMHO it wasn't meant to be overriden by users anyway.
>
> I'll add a sentence to the migration guide to use #afterRender() instead.
> And I will update the lifecycle doc in the user guide.
>
> Thanks
> Sven
>
>
> Am 19.01.2018 um 10:04 schrieb Andrea Del Bene:
>
>> Hi,
>>
>> I've noted that the last commit for WICKET-6503 wiped out some hook
>> methods
>> from Component and MarkupContainer classes (for example
>> MarkupContainer#onAfterRenderChildren). Is there a migration strategy for
>> this change?
>>
>> Andrea.
>>
>>
>

Re: WICKET-6503 and hook methods

[Sven Meier]

Hi Andrea,

I've tried to limit my clean-up to internal methods, i.e. those marked 
with "THIS METHOD IS NOT ... PUBLIC .. DO NOT CALL IT!".


I see now that #onAfterRenderChildren() was protected and not marked as 
internal, but IMHO it wasn't meant to be overriden by users anyway.


I'll add a sentence to the migration guide to use #afterRender() 
instead. And I will update the lifecycle doc in the user guide.


Thanks
Sven


Am 19.01.2018 um 10:04 schrieb Andrea Del Bene:

Hi,

I've noted that the last commit for WICKET-6503 wiped out some hook methods
from Component and MarkupContainer classes (for example
MarkupContainer#onAfterRenderChildren). Is there a migration strategy for
this change?

Andrea.

WICKET-6503 and hook methods

[Andrea Del Bene]

Hi,

I've noted that the last commit for WICKET-6503 wiped out some hook methods
from Component and MarkupContainer classes (for example
MarkupContainer#onAfterRenderChildren). Is there a migration strategy for
this change?

Andrea.

[GitHub] wicket pull request #255: Allow multipart submission of non modified FormDat...

[andruhon]

Github user andruhon closed the pull request at:

https://github.com/apache/wicket/pull/255


---

[GitHub] wicket issue #255: Allow multipart submission of non modified FormData with ...

[klopfdreh]

Github user klopfdreh commented on the issue:

https://github.com/apache/wicket/pull/255
  
Hi,

is this PR reflection a subset of changes of: 
https://github.com/apache/wicket/pull/256?

If yes we might consider to close this one and continue it in only one PR.

Thanks a lot for your PR @andruhon 👍 


---