wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-03-31 Thread Korbinian Bachl 
Hi, 

I deployed our app on 9.9.0 this morning and after initializing a crawl of the 
page I ended up getting a low quote of 503s. 

The 503s are always the same: 
2022-03-31 09:35:05,031 ERROR [org.apache.wicket.DefaultExceptionMapper] 
Unexpected error occurred
org.apache.wicket.markup.MarkupException:  tags are only allowed 
before , ,  etc. tag 
at 
org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.nextHeaderMarkup(AssociatedMarkupSourcingStrategy.java:341)
 ~[wicket-core-9.9.0.jar:9.9.0]
at 
org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.renderHeadFromAssociatedMarkupFile(AssociatedMarkupSourcingStrategy.java:236)
 ~[wicket-core-9.9.0.jar:9.9.0]
at 
org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.renderHead(AssociatedMarkupSourcingStrategy.java:204)
 ~[wicket-core-9.9.0.jar:9.9.0]
at org.apache.wicket.Component.internalRenderHead(Component.java:2649) 
~[wicket-core-9.9.0.jar:9.9.0] 
 
at 
org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.doWork(AbstractThreadPool.java:569)
 [nucleus-grizzly-all.jar:?] at 
org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.run(AbstractThreadPool.java:549)
 [nucleus-grizzly-all.jar:?] at java.lang.Thread.run(Thread.java:829) [?:?] 

Any idea how to debug this or where it may come from (race condition in our 
code as wicket became faster?)? 
It somehow seems to be a happen when requests coming in at the same time 
with 9.8.0 we got no such errors. 

Best, 

KB

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-03-31 Thread Maxim Solodovnik 
" tags are only allowed before , , 
etc. tag"
sounds reasonable :)

On Thu, 31 Mar 2022 at 14:56, Korbinian Bachl <
korbinian.ba...@whiskyworld.de> wrote:

> Hi,
>
> I deployed our app on 9.9.0 this morning and after initializing a crawl of
> the page I ended up getting a low quote of 503s.
>
> The 503s are always the same:
> 2022-03-31 09:35:05,031 ERROR [org.apache.wicket.DefaultExceptionMapper]
> Unexpected error occurred
> org.apache.wicket.markup.MarkupException:  tags are only
> allowed before , ,  etc. tag
> at
> org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.nextHeaderMarkup(AssociatedMarkupSourcingStrategy.java:341)
> ~[wicket-core-9.9.0.jar:9.9.0]
> at
> org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.renderHeadFromAssociatedMarkupFile(AssociatedMarkupSourcingStrategy.java:236)
> ~[wicket-core-9.9.0.jar:9.9.0]
> at
> org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.renderHead(AssociatedMarkupSourcingStrategy.java:204)
> ~[wicket-core-9.9.0.jar:9.9.0]
> at
> org.apache.wicket.Component.internalRenderHead(Component.java:2649)
> ~[wicket-core-9.9.0.jar:9.9.0]
> 
> at
> org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.doWork(AbstractThreadPool.java:569)
> [nucleus-grizzly-all.jar:?] at
> org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.run(AbstractThreadPool.java:549)
> [nucleus-grizzly-all.jar:?] at java.lang.Thread.run(Thread.java:829) [?:?]
>
> Any idea how to debug this or where it may come from (race condition in
> our code as wicket became faster?)?
> It somehow seems to be a happen when requests coming in at the same
> time with 9.8.0 we got no such errors.
>
> Best,
>
> KB
>
>
>
>

-- 
Best regards,
Maxim

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-03-31 Thread Martin Grigorov 
Hi,

The changelog is quite short:

  CHANGELOG for 9.9.0:

** Bug

 * [WICKET-6957] - Declare JSPM 'uses' for IInitializer
 * [WICKET-6965] - Memory leak in WicketEndpoint

** Improvement

 * [WICKET-6960] - Reduce allocations when encoding ComponentInfo
 * [WICKET-6963] - Use singletons for PanelMarkupSourcingStrategy
 * [WICKET-6964] - Do not allocate when escaping empty string

Maybe WICKET-6963 causes the regression ?!

Can you reproduce it in a quickstart app ?


On Thu, Mar 31, 2022 at 10:56 AM Korbinian Bachl <
korbinian.ba...@whiskyworld.de> wrote:

> Hi,
>
> I deployed our app on 9.9.0 this morning and after initializing a crawl of
> the page I ended up getting a low quote of 503s.
>
> The 503s are always the same:
> 2022-03-31 09:35:05,031 ERROR [org.apache.wicket.DefaultExceptionMapper]
> Unexpected error occurred
> org.apache.wicket.markup.MarkupException:  tags are only
> allowed before , ,  etc. tag
> at
> org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.nextHeaderMarkup(AssociatedMarkupSourcingStrategy.java:341)
> ~[wicket-core-9.9.0.jar:9.9.0]
> at
> org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.renderHeadFromAssociatedMarkupFile(AssociatedMarkupSourcingStrategy.java:236)
> ~[wicket-core-9.9.0.jar:9.9.0]
> at
> org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.renderHead(AssociatedMarkupSourcingStrategy.java:204)
> ~[wicket-core-9.9.0.jar:9.9.0]
> at
> org.apache.wicket.Component.internalRenderHead(Component.java:2649)
> ~[wicket-core-9.9.0.jar:9.9.0]
> 
> at
> org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.doWork(AbstractThreadPool.java:569)
> [nucleus-grizzly-all.jar:?] at
> org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.run(AbstractThreadPool.java:549)
> [nucleus-grizzly-all.jar:?] at java.lang.Thread.run(Thread.java:829) [?:?]
>
> Any idea how to debug this or where it may come from (race condition in
> our code as wicket became faster?)?
> It somehow seems to be a happen when requests coming in at the same
> time with 9.8.0 we got no such errors.
>
> Best,
>
> KB
>
>
>
>

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-03-31 Thread Korbinian Bachl 
Well, the only thing I did was change wicket-9.8.0 to wicket-9.9.0 
then I get these errors in production. After reverting to 9.8.0 these are 
gone 
I never touched any HTML files in between the deploys :X

What has happened here?

- Ursprüngliche Mail -
> Von: "Maxim Solodovnik" 
> An: "dev" 
> Gesendet: Donnerstag, 31. März 2022 10:06:34
> Betreff: Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I 
> get this?

> " tags are only allowed before , , 
> etc. tag"
> sounds reasonable :)
> 
> On Thu, 31 Mar 2022 at 14:56, Korbinian Bachl <
> korbinian.ba...@whiskyworld.de> wrote:
> 
>> Hi,
>>
>> I deployed our app on 9.9.0 this morning and after initializing a crawl of
>> the page I ended up getting a low quote of 503s.
>>
>> The 503s are always the same:
>> 2022-03-31 09:35:05,031 ERROR [org.apache.wicket.DefaultExceptionMapper]
>> Unexpected error occurred
>> org.apache.wicket.markup.MarkupException:  tags are only
>> allowed before , ,  etc. tag
>> at
>> org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.nextHeaderMarkup(AssociatedMarkupSourcingStrategy.java:341)
>> ~[wicket-core-9.9.0.jar:9.9.0]
>> at
>> org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.renderHeadFromAssociatedMarkupFile(AssociatedMarkupSourcingStrategy.java:236)
>> ~[wicket-core-9.9.0.jar:9.9.0]
>> at
>> org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.renderHead(AssociatedMarkupSourcingStrategy.java:204)
>> ~[wicket-core-9.9.0.jar:9.9.0]
>> at
>> org.apache.wicket.Component.internalRenderHead(Component.java:2649)
>> ~[wicket-core-9.9.0.jar:9.9.0]
>> 
>> at
>> org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.doWork(AbstractThreadPool.java:569)
>> [nucleus-grizzly-all.jar:?] at
>> org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.run(AbstractThreadPool.java:549)
>> [nucleus-grizzly-all.jar:?] at java.lang.Thread.run(Thread.java:829) [?:?]
>>
>> Any idea how to debug this or where it may come from (race condition in
>> our code as wicket became faster?)?
>> It somehow seems to be a happen when requests coming in at the same
>> time with 9.8.0 we got no such errors.
>>
>> Best,
>>
>> KB
>>
>>
>>
>>
> 
> --
> Best regards,
> Maxim

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-03-31 Thread Thomas Heigl 
This is probably caused by my change in
https://issues.apache.org/jira/browse/WICKET-6963

I have been using this code in production for a couple of weeks now without
issues, but there seem to be cases where the singleton strategy doesn't
work.

Can you reproduce this issue in a test-case?

Thomas

On Thu, Mar 31, 2022 at 10:06 AM Maxim Solodovnik 
wrote:

> " tags are only allowed before , , 
> etc. tag"
> sounds reasonable :)
>
> On Thu, 31 Mar 2022 at 14:56, Korbinian Bachl <
> korbinian.ba...@whiskyworld.de> wrote:
>
> > Hi,
> >
> > I deployed our app on 9.9.0 this morning and after initializing a crawl
> of
> > the page I ended up getting a low quote of 503s.
> >
> > The 503s are always the same:
> > 2022-03-31 09:35:05,031 ERROR [org.apache.wicket.DefaultExceptionMapper]
> > Unexpected error occurred
> > org.apache.wicket.markup.MarkupException:  tags are only
> > allowed before , ,  etc. tag
> > at
> >
> org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.nextHeaderMarkup(AssociatedMarkupSourcingStrategy.java:341)
> > ~[wicket-core-9.9.0.jar:9.9.0]
> > at
> >
> org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.renderHeadFromAssociatedMarkupFile(AssociatedMarkupSourcingStrategy.java:236)
> > ~[wicket-core-9.9.0.jar:9.9.0]
> > at
> >
> org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.renderHead(AssociatedMarkupSourcingStrategy.java:204)
> > ~[wicket-core-9.9.0.jar:9.9.0]
> > at
> > org.apache.wicket.Component.internalRenderHead(Component.java:2649)
> > ~[wicket-core-9.9.0.jar:9.9.0]
> > 
> > at
> >
> org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.doWork(AbstractThreadPool.java:569)
> > [nucleus-grizzly-all.jar:?] at
> >
> org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.run(AbstractThreadPool.java:549)
> > [nucleus-grizzly-all.jar:?] at java.lang.Thread.run(Thread.java:829)
> [?:?]
> >
> > Any idea how to debug this or where it may come from (race condition in
> > our code as wicket became faster?)?
> > It somehow seems to be a happen when requests coming in at the same
> > time with 9.8.0 we got no such errors.
> >
> > Best,
> >
> > KB
> >
> >
> >
> >
>
> --
> Best regards,
> Maxim
>

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-03-31 Thread Thomas Heigl 
I think we will have to revert WICKET-6963.

I somehow overlooked the non-final field noMoreWicketHeadTagsAllowed
in AssociatedMarkupSourcingStrategy. If this flag gets set, the singleton
strategy doesn't work.

Thomas

On Thu, Mar 31, 2022 at 10:11 AM Thomas Heigl  wrote:

> This is probably caused by my change in
> https://issues.apache.org/jira/browse/WICKET-6963
>
> I have been using this code in production for a couple of weeks now
> without issues, but there seem to be cases where the singleton strategy
> doesn't work.
>
> Can you reproduce this issue in a test-case?
>
> Thomas
>
> On Thu, Mar 31, 2022 at 10:06 AM Maxim Solodovnik 
> wrote:
>
>> " tags are only allowed before , ,
>> 
>> etc. tag"
>> sounds reasonable :)
>>
>> On Thu, 31 Mar 2022 at 14:56, Korbinian Bachl <
>> korbinian.ba...@whiskyworld.de> wrote:
>>
>> > Hi,
>> >
>> > I deployed our app on 9.9.0 this morning and after initializing a crawl
>> of
>> > the page I ended up getting a low quote of 503s.
>> >
>> > The 503s are always the same:
>> > 2022-03-31 09:35:05,031 ERROR [org.apache.wicket.DefaultExceptionMapper]
>> > Unexpected error occurred
>> > org.apache.wicket.markup.MarkupException:  tags are only
>> > allowed before , ,  etc. tag
>> > at
>> >
>> org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.nextHeaderMarkup(AssociatedMarkupSourcingStrategy.java:341)
>> > ~[wicket-core-9.9.0.jar:9.9.0]
>> > at
>> >
>> org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.renderHeadFromAssociatedMarkupFile(AssociatedMarkupSourcingStrategy.java:236)
>> > ~[wicket-core-9.9.0.jar:9.9.0]
>> > at
>> >
>> org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.renderHead(AssociatedMarkupSourcingStrategy.java:204)
>> > ~[wicket-core-9.9.0.jar:9.9.0]
>> > at
>> > org.apache.wicket.Component.internalRenderHead(Component.java:2649)
>> > ~[wicket-core-9.9.0.jar:9.9.0]
>> > 
>> > at
>> >
>> org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.doWork(AbstractThreadPool.java:569)
>> > [nucleus-grizzly-all.jar:?] at
>> >
>> org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.run(AbstractThreadPool.java:549)
>> > [nucleus-grizzly-all.jar:?] at java.lang.Thread.run(Thread.java:829)
>> [?:?]
>> >
>> > Any idea how to debug this or where it may come from (race condition in
>> > our code as wicket became faster?)?
>> > It somehow seems to be a happen when requests coming in at the same
>> > time with 9.8.0 we got no such errors.
>> >
>> > Best,
>> >
>> > KB
>> >
>> >
>> >
>> >
>>
>> --
>> Best regards,
>> Maxim
>>
>

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-03-31 Thread Maxim Solodovnik 
It seems I should cancel wicketstuff build :((

On Thu, 31 Mar 2022 at 15:14, Thomas Heigl  wrote:

> I think we will have to revert WICKET-6963.
>
> I somehow overlooked the non-final field noMoreWicketHeadTagsAllowed
> in AssociatedMarkupSourcingStrategy. If this flag gets set, the singleton
> strategy doesn't work.
>
> Thomas
>
> On Thu, Mar 31, 2022 at 10:11 AM Thomas Heigl  wrote:
>
> > This is probably caused by my change in
> > https://issues.apache.org/jira/browse/WICKET-6963
> >
> > I have been using this code in production for a couple of weeks now
> > without issues, but there seem to be cases where the singleton strategy
> > doesn't work.
> >
> > Can you reproduce this issue in a test-case?
> >
> > Thomas
> >
> > On Thu, Mar 31, 2022 at 10:06 AM Maxim Solodovnik 
> > wrote:
> >
> >> " tags are only allowed before , ,
> >> 
> >> etc. tag"
> >> sounds reasonable :)
> >>
> >> On Thu, 31 Mar 2022 at 14:56, Korbinian Bachl <
> >> korbinian.ba...@whiskyworld.de> wrote:
> >>
> >> > Hi,
> >> >
> >> > I deployed our app on 9.9.0 this morning and after initializing a
> crawl
> >> of
> >> > the page I ended up getting a low quote of 503s.
> >> >
> >> > The 503s are always the same:
> >> > 2022-03-31 09:35:05,031 ERROR
> [org.apache.wicket.DefaultExceptionMapper]
> >> > Unexpected error occurred
> >> > org.apache.wicket.markup.MarkupException:  tags are only
> >> > allowed before , ,  etc. tag
> >> > at
> >> >
> >>
> org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.nextHeaderMarkup(AssociatedMarkupSourcingStrategy.java:341)
> >> > ~[wicket-core-9.9.0.jar:9.9.0]
> >> > at
> >> >
> >>
> org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.renderHeadFromAssociatedMarkupFile(AssociatedMarkupSourcingStrategy.java:236)
> >> > ~[wicket-core-9.9.0.jar:9.9.0]
> >> > at
> >> >
> >>
> org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.renderHead(AssociatedMarkupSourcingStrategy.java:204)
> >> > ~[wicket-core-9.9.0.jar:9.9.0]
> >> > at
> >> > org.apache.wicket.Component.internalRenderHead(Component.java:2649)
> >> > ~[wicket-core-9.9.0.jar:9.9.0]
> >> > 
> >> > at
> >> >
> >>
> org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.doWork(AbstractThreadPool.java:569)
> >> > [nucleus-grizzly-all.jar:?] at
> >> >
> >>
> org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.run(AbstractThreadPool.java:549)
> >> > [nucleus-grizzly-all.jar:?] at java.lang.Thread.run(Thread.java:829)
> >> [?:?]
> >> >
> >> > Any idea how to debug this or where it may come from (race condition
> in
> >> > our code as wicket became faster?)?
> >> > It somehow seems to be a happen when requests coming in at the same
> >> > time with 9.8.0 we got no such errors.
> >> >
> >> > Best,
> >> >
> >> > KB
> >> >
> >> >
> >> >
> >> >
> >>
> >> --
> >> Best regards,
> >> Maxim
> >>
> >
>


-- 
Best regards,
Maxim

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-03-31 Thread Thomas Heigl 
Although the JavaDoc states that this should be possible:

  // reset for each render in case the strategy is re-used
noMoreWicketHeadTagsAllowed = false;

It would be great if we had a failing test-case for this. In my production
environment with about 5000 panels, there are none of these issues.

Thomas

On Thu, Mar 31, 2022 at 10:14 AM Thomas Heigl  wrote:

> I think we will have to revert WICKET-6963.
>
> I somehow overlooked the non-final field noMoreWicketHeadTagsAllowed
> in AssociatedMarkupSourcingStrategy. If this flag gets set, the singleton
> strategy doesn't work.
>
> Thomas
>
> On Thu, Mar 31, 2022 at 10:11 AM Thomas Heigl  wrote:
>
>> This is probably caused by my change in
>> https://issues.apache.org/jira/browse/WICKET-6963
>>
>> I have been using this code in production for a couple of weeks now
>> without issues, but there seem to be cases where the singleton strategy
>> doesn't work.
>>
>> Can you reproduce this issue in a test-case?
>>
>> Thomas
>>
>> On Thu, Mar 31, 2022 at 10:06 AM Maxim Solodovnik 
>> wrote:
>>
>>> " tags are only allowed before , ,
>>> 
>>> etc. tag"
>>> sounds reasonable :)
>>>
>>> On Thu, 31 Mar 2022 at 14:56, Korbinian Bachl <
>>> korbinian.ba...@whiskyworld.de> wrote:
>>>
>>> > Hi,
>>> >
>>> > I deployed our app on 9.9.0 this morning and after initializing a
>>> crawl of
>>> > the page I ended up getting a low quote of 503s.
>>> >
>>> > The 503s are always the same:
>>> > 2022-03-31 09:35:05,031 ERROR
>>> [org.apache.wicket.DefaultExceptionMapper]
>>> > Unexpected error occurred
>>> > org.apache.wicket.markup.MarkupException:  tags are only
>>> > allowed before , ,  etc. tag
>>> > at
>>> >
>>> org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.nextHeaderMarkup(AssociatedMarkupSourcingStrategy.java:341)
>>> > ~[wicket-core-9.9.0.jar:9.9.0]
>>> > at
>>> >
>>> org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.renderHeadFromAssociatedMarkupFile(AssociatedMarkupSourcingStrategy.java:236)
>>> > ~[wicket-core-9.9.0.jar:9.9.0]
>>> > at
>>> >
>>> org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.renderHead(AssociatedMarkupSourcingStrategy.java:204)
>>> > ~[wicket-core-9.9.0.jar:9.9.0]
>>> > at
>>> > org.apache.wicket.Component.internalRenderHead(Component.java:2649)
>>> > ~[wicket-core-9.9.0.jar:9.9.0]
>>> > 
>>> > at
>>> >
>>> org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.doWork(AbstractThreadPool.java:569)
>>> > [nucleus-grizzly-all.jar:?] at
>>> >
>>> org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.run(AbstractThreadPool.java:549)
>>> > [nucleus-grizzly-all.jar:?] at java.lang.Thread.run(Thread.java:829)
>>> [?:?]
>>> >
>>> > Any idea how to debug this or where it may come from (race condition in
>>> > our code as wicket became faster?)?
>>> > It somehow seems to be a happen when requests coming in at the same
>>> > time with 9.8.0 we got no such errors.
>>> >
>>> > Best,
>>> >
>>> > KB
>>> >
>>> >
>>> >
>>> >
>>>
>>> --
>>> Best regards,
>>> Maxim
>>>
>>

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-03-31 Thread Thomas Heigl 
Ok I had a closer look at AssociatedMarkupSourcingStrategy and the code
related to this flag is quite convoluted and full of TODOs and WHY
comments. I think I will have to do another take on this and replace the
field with a parameter, but this will take some time.

I would suggest we revert WICKET-6963 for now and release 9.9.1.

Sorry for that! I was confident that my change was good, because it worked
without problems in our production environment.

Thomas

On Thu, Mar 31, 2022 at 10:18 AM Thomas Heigl  wrote:

> Although the JavaDoc states that this should be possible:
>
>   // reset for each render in case the strategy is re-used
> noMoreWicketHeadTagsAllowed = false;
>
> It would be great if we had a failing test-case for this. In my production
> environment with about 5000 panels, there are none of these issues.
>
> Thomas
>
> On Thu, Mar 31, 2022 at 10:14 AM Thomas Heigl  wrote:
>
>> I think we will have to revert WICKET-6963.
>>
>> I somehow overlooked the non-final field noMoreWicketHeadTagsAllowed
>> in AssociatedMarkupSourcingStrategy. If this flag gets set, the singleton
>> strategy doesn't work.
>>
>> Thomas
>>
>> On Thu, Mar 31, 2022 at 10:11 AM Thomas Heigl 
>> wrote:
>>
>>> This is probably caused by my change in
>>> https://issues.apache.org/jira/browse/WICKET-6963
>>>
>>> I have been using this code in production for a couple of weeks now
>>> without issues, but there seem to be cases where the singleton strategy
>>> doesn't work.
>>>
>>> Can you reproduce this issue in a test-case?
>>>
>>> Thomas
>>>
>>> On Thu, Mar 31, 2022 at 10:06 AM Maxim Solodovnik 
>>> wrote:
>>>
 " tags are only allowed before , ,
 
 etc. tag"
 sounds reasonable :)

 On Thu, 31 Mar 2022 at 14:56, Korbinian Bachl <
 korbinian.ba...@whiskyworld.de> wrote:

 > Hi,
 >
 > I deployed our app on 9.9.0 this morning and after initializing a
 crawl of
 > the page I ended up getting a low quote of 503s.
 >
 > The 503s are always the same:
 > 2022-03-31 09:35:05,031 ERROR
 [org.apache.wicket.DefaultExceptionMapper]
 > Unexpected error occurred
 > org.apache.wicket.markup.MarkupException:  tags are only
 > allowed before , ,  etc. tag
 > at
 >
 org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.nextHeaderMarkup(AssociatedMarkupSourcingStrategy.java:341)
 > ~[wicket-core-9.9.0.jar:9.9.0]
 > at
 >
 org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.renderHeadFromAssociatedMarkupFile(AssociatedMarkupSourcingStrategy.java:236)
 > ~[wicket-core-9.9.0.jar:9.9.0]
 > at
 >
 org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.renderHead(AssociatedMarkupSourcingStrategy.java:204)
 > ~[wicket-core-9.9.0.jar:9.9.0]
 > at
 > org.apache.wicket.Component.internalRenderHead(Component.java:2649)
 > ~[wicket-core-9.9.0.jar:9.9.0]
 > 
 > at
 >
 org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.doWork(AbstractThreadPool.java:569)
 > [nucleus-grizzly-all.jar:?] at
 >
 org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.run(AbstractThreadPool.java:549)
 > [nucleus-grizzly-all.jar:?] at java.lang.Thread.run(Thread.java:829)
 [?:?]
 >
 > Any idea how to debug this or where it may come from (race condition
 in
 > our code as wicket became faster?)?
 > It somehow seems to be a happen when requests coming in at the same
 > time with 9.8.0 we got no such errors.
 >
 > Best,
 >
 > KB
 >
 >
 >
 >

 --
 Best regards,
 Maxim

>>>

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-03-31 Thread Korbinian Bachl 
I've looked at 
https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/markup/html/panel/AssociatedMarkupSourcingStrategy.java
 
and I somehow wonder if we couldn't get rid of this 
private boolean noMoreWicketHeadTagsAllowed = false;

at all?

It seems to be questioned in the past already:

"// wicket:head must be before border, panel or extend
// @TODO why is that? Why can't it be anywhere? (except inside wicket:fragment)"

my 2cents...



- Ursprüngliche Mail -
> Von: "Thomas Heigl" 
> An: "dev" 
> Gesendet: Donnerstag, 31. März 2022 10:18:12
> Betreff: Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I 
> get this?

> Although the JavaDoc states that this should be possible:
> 
>  // reset for each render in case the strategy is re-used
> noMoreWicketHeadTagsAllowed = false;
> 
> It would be great if we had a failing test-case for this. In my production
> environment with about 5000 panels, there are none of these issues.
> 
> Thomas
> 
> On Thu, Mar 31, 2022 at 10:14 AM Thomas Heigl  wrote:
> 
>> I think we will have to revert WICKET-6963.
>>
>> I somehow overlooked the non-final field noMoreWicketHeadTagsAllowed
>> in AssociatedMarkupSourcingStrategy. If this flag gets set, the singleton
>> strategy doesn't work.
>>
>> Thomas
>>
>> On Thu, Mar 31, 2022 at 10:11 AM Thomas Heigl  wrote:
>>
>>> This is probably caused by my change in
>>> https://issues.apache.org/jira/browse/WICKET-6963
>>>
>>> I have been using this code in production for a couple of weeks now
>>> without issues, but there seem to be cases where the singleton strategy
>>> doesn't work.
>>>
>>> Can you reproduce this issue in a test-case?
>>>
>>> Thomas
>>>
>>> On Thu, Mar 31, 2022 at 10:06 AM Maxim Solodovnik 
>>> wrote:
>>>
 " tags are only allowed before , ,
 
 etc. tag"
 sounds reasonable :)

 On Thu, 31 Mar 2022 at 14:56, Korbinian Bachl <
 korbinian.ba...@whiskyworld.de> wrote:

 > Hi,
 >
 > I deployed our app on 9.9.0 this morning and after initializing a
 crawl of
 > the page I ended up getting a low quote of 503s.
 >
 > The 503s are always the same:
 > 2022-03-31 09:35:05,031 ERROR
 [org.apache.wicket.DefaultExceptionMapper]
 > Unexpected error occurred
 > org.apache.wicket.markup.MarkupException:  tags are only
 > allowed before , ,  etc. tag
 > at
 >
 org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.nextHeaderMarkup(AssociatedMarkupSourcingStrategy.java:341)
 > ~[wicket-core-9.9.0.jar:9.9.0]
 > at
 >
 org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.renderHeadFromAssociatedMarkupFile(AssociatedMarkupSourcingStrategy.java:236)
 > ~[wicket-core-9.9.0.jar:9.9.0]
 > at
 >
 org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.renderHead(AssociatedMarkupSourcingStrategy.java:204)
 > ~[wicket-core-9.9.0.jar:9.9.0]
 > at
 > org.apache.wicket.Component.internalRenderHead(Component.java:2649)
 > ~[wicket-core-9.9.0.jar:9.9.0]
 > 
 > at
 >
 org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.doWork(AbstractThreadPool.java:569)
 > [nucleus-grizzly-all.jar:?] at
 >
 org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.run(AbstractThreadPool.java:549)
 > [nucleus-grizzly-all.jar:?] at java.lang.Thread.run(Thread.java:829)
 [?:?]
 >
 > Any idea how to debug this or where it may come from (race condition in
 > our code as wicket became faster?)?
 > It somehow seems to be a happen when requests coming in at the same
 > time with 9.8.0 we got no such errors.
 >
 > Best,
 >
 > KB
 >
 >
 >
 >

 --
 Best regards,
 Maxim

[ANNOUNCE] WicketStuff 9.9.0 Released

2022-03-31 Thread Maxim Solodovnik 
WicketStuff core 9.9.0 based on Apache Wicket 9.9.0 is released
and soon will be available at Maven Central!

Maxim Solodovnik (3):
  Switching to the next development version
  Dependencies are updated
  wicketstuff core 9.9.0 is released

The WicketStuff team

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-03-31 Thread Andrea Del Bene 
On Thu, Mar 31, 2022 at 10:33 AM Thomas Heigl  wrote:

> Ok I had a closer look at AssociatedMarkupSourcingStrategy and the code
> related to this flag is quite convoluted and full of TODOs and WHY
> comments. I think I will have to do another take on this and replace the
> field with a parameter, but this will take some time.
>
> I would suggest we revert WICKET-6963 for now and release 9.9.1.
>
> Sorry for that! I was confident that my change was good, because it worked
> without problems in our production environment.
>
>
 Don't worry, these things happened :-) . Could you take care of reverting
WICKET-6963 on git? Or if it's just a commit I can do it by myself.


> Thomas
>
> On Thu, Mar 31, 2022 at 10:18 AM Thomas Heigl  wrote:
>
> > Although the JavaDoc states that this should be possible:
> >
> >   // reset for each render in case the strategy is re-used
> > noMoreWicketHeadTagsAllowed = false;
> >
> > It would be great if we had a failing test-case for this. In my
> production
> > environment with about 5000 panels, there are none of these issues.
> >
> > Thomas
> >
> > On Thu, Mar 31, 2022 at 10:14 AM Thomas Heigl 
> wrote:
> >
> >> I think we will have to revert WICKET-6963.
> >>
> >> I somehow overlooked the non-final field noMoreWicketHeadTagsAllowed
> >> in AssociatedMarkupSourcingStrategy. If this flag gets set, the
> singleton
> >> strategy doesn't work.
> >>
> >> Thomas
> >>
> >> On Thu, Mar 31, 2022 at 10:11 AM Thomas Heigl 
> >> wrote:
> >>
> >>> This is probably caused by my change in
> >>> https://issues.apache.org/jira/browse/WICKET-6963
> >>>
> >>> I have been using this code in production for a couple of weeks now
> >>> without issues, but there seem to be cases where the singleton strategy
> >>> doesn't work.
> >>>
> >>> Can you reproduce this issue in a test-case?
> >>>
> >>> Thomas
> >>>
> >>> On Thu, Mar 31, 2022 at 10:06 AM Maxim Solodovnik <
> solomax...@gmail.com>
> >>> wrote:
> >>>
>  " tags are only allowed before , ,
>  
>  etc. tag"
>  sounds reasonable :)
> 
>  On Thu, 31 Mar 2022 at 14:56, Korbinian Bachl <
>  korbinian.ba...@whiskyworld.de> wrote:
> 
>  > Hi,
>  >
>  > I deployed our app on 9.9.0 this morning and after initializing a
>  crawl of
>  > the page I ended up getting a low quote of 503s.
>  >
>  > The 503s are always the same:
>  > 2022-03-31 09:35:05,031 ERROR
>  [org.apache.wicket.DefaultExceptionMapper]
>  > Unexpected error occurred
>  > org.apache.wicket.markup.MarkupException:  tags are
> only
>  > allowed before , ,  etc. tag
>  > at
>  >
> 
> org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.nextHeaderMarkup(AssociatedMarkupSourcingStrategy.java:341)
>  > ~[wicket-core-9.9.0.jar:9.9.0]
>  > at
>  >
> 
> org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.renderHeadFromAssociatedMarkupFile(AssociatedMarkupSourcingStrategy.java:236)
>  > ~[wicket-core-9.9.0.jar:9.9.0]
>  > at
>  >
> 
> org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.renderHead(AssociatedMarkupSourcingStrategy.java:204)
>  > ~[wicket-core-9.9.0.jar:9.9.0]
>  > at
>  > org.apache.wicket.Component.internalRenderHead(Component.java:2649)
>  > ~[wicket-core-9.9.0.jar:9.9.0]
>  > 
>  > at
>  >
> 
> org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.doWork(AbstractThreadPool.java:569)
>  > [nucleus-grizzly-all.jar:?] at
>  >
> 
> org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.run(AbstractThreadPool.java:549)
>  > [nucleus-grizzly-all.jar:?] at java.lang.Thread.run(Thread.java:829)
>  [?:?]
>  >
>  > Any idea how to debug this or where it may come from (race condition
>  in
>  > our code as wicket became faster?)?
>  > It somehow seems to be a happen when requests coming in at the same
>  > time with 9.8.0 we got no such errors.
>  >
>  > Best,
>  >
>  > KB
>  >
>  >
>  >
>  >
> 
>  --
>  Best regards,
>  Maxim
> 
> >>>
>


-- 
Andrea Del Bene.
Apache Wicket committer.

Re: wicket 9.9.0 - MarkupExceptions after upgrade - any idea why I get this?

2022-03-31 Thread Thomas Heigl 
It's just a single commit. I have reverted it for both 9.x and master.

Best,

Thomas

On Thu, Mar 31, 2022 at 11:06 AM Andrea Del Bene 
wrote:

> On Thu, Mar 31, 2022 at 10:33 AM Thomas Heigl  wrote:
>
> > Ok I had a closer look at AssociatedMarkupSourcingStrategy and the code
> > related to this flag is quite convoluted and full of TODOs and WHY
> > comments. I think I will have to do another take on this and replace the
> > field with a parameter, but this will take some time.
> >
> > I would suggest we revert WICKET-6963 for now and release 9.9.1.
> >
> > Sorry for that! I was confident that my change was good, because it
> worked
> > without problems in our production environment.
> >
> >
>  Don't worry, these things happened :-) . Could you take care of reverting
> WICKET-6963 on git? Or if it's just a commit I can do it by myself.
>
>
> > Thomas
> >
> > On Thu, Mar 31, 2022 at 10:18 AM Thomas Heigl 
> wrote:
> >
> > > Although the JavaDoc states that this should be possible:
> > >
> > >   // reset for each render in case the strategy is re-used
> > > noMoreWicketHeadTagsAllowed = false;
> > >
> > > It would be great if we had a failing test-case for this. In my
> > production
> > > environment with about 5000 panels, there are none of these issues.
> > >
> > > Thomas
> > >
> > > On Thu, Mar 31, 2022 at 10:14 AM Thomas Heigl 
> > wrote:
> > >
> > >> I think we will have to revert WICKET-6963.
> > >>
> > >> I somehow overlooked the non-final field noMoreWicketHeadTagsAllowed
> > >> in AssociatedMarkupSourcingStrategy. If this flag gets set, the
> > singleton
> > >> strategy doesn't work.
> > >>
> > >> Thomas
> > >>
> > >> On Thu, Mar 31, 2022 at 10:11 AM Thomas Heigl 
> > >> wrote:
> > >>
> > >>> This is probably caused by my change in
> > >>> https://issues.apache.org/jira/browse/WICKET-6963
> > >>>
> > >>> I have been using this code in production for a couple of weeks now
> > >>> without issues, but there seem to be cases where the singleton
> strategy
> > >>> doesn't work.
> > >>>
> > >>> Can you reproduce this issue in a test-case?
> > >>>
> > >>> Thomas
> > >>>
> > >>> On Thu, Mar 31, 2022 at 10:06 AM Maxim Solodovnik <
> > solomax...@gmail.com>
> > >>> wrote:
> > >>>
> >  " tags are only allowed before , ,
> >  
> >  etc. tag"
> >  sounds reasonable :)
> > 
> >  On Thu, 31 Mar 2022 at 14:56, Korbinian Bachl <
> >  korbinian.ba...@whiskyworld.de> wrote:
> > 
> >  > Hi,
> >  >
> >  > I deployed our app on 9.9.0 this morning and after initializing a
> >  crawl of
> >  > the page I ended up getting a low quote of 503s.
> >  >
> >  > The 503s are always the same:
> >  > 2022-03-31 09:35:05,031 ERROR
> >  [org.apache.wicket.DefaultExceptionMapper]
> >  > Unexpected error occurred
> >  > org.apache.wicket.markup.MarkupException:  tags are
> > only
> >  > allowed before , ,  etc. tag
> >  > at
> >  >
> > 
> >
> org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.nextHeaderMarkup(AssociatedMarkupSourcingStrategy.java:341)
> >  > ~[wicket-core-9.9.0.jar:9.9.0]
> >  > at
> >  >
> > 
> >
> org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.renderHeadFromAssociatedMarkupFile(AssociatedMarkupSourcingStrategy.java:236)
> >  > ~[wicket-core-9.9.0.jar:9.9.0]
> >  > at
> >  >
> > 
> >
> org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.renderHead(AssociatedMarkupSourcingStrategy.java:204)
> >  > ~[wicket-core-9.9.0.jar:9.9.0]
> >  > at
> >  >
> org.apache.wicket.Component.internalRenderHead(Component.java:2649)
> >  > ~[wicket-core-9.9.0.jar:9.9.0]
> >  > 
> >  > at
> >  >
> > 
> >
> org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.doWork(AbstractThreadPool.java:569)
> >  > [nucleus-grizzly-all.jar:?] at
> >  >
> > 
> >
> org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.run(AbstractThreadPool.java:549)
> >  > [nucleus-grizzly-all.jar:?] at
> java.lang.Thread.run(Thread.java:829)
> >  [?:?]
> >  >
> >  > Any idea how to debug this or where it may come from (race
> condition
> >  in
> >  > our code as wicket became faster?)?
> >  > It somehow seems to be a happen when requests coming in at the
> same
> >  > time with 9.8.0 we got no such errors.
> >  >
> >  > Best,
> >  >
> >  > KB
> >  >
> >  >
> >  >
> >  >
> > 
> >  --
> >  Best regards,
> >  Maxim
> > 
> > >>>
> >
>
>
> --
> Andrea Del Bene.
> Apache Wicket committer.
>

Build failed in Jenkins: Wicket » wicket-9.x #104

2022-03-31 Thread Apache Jenkins Server 
See 


Changes:

[thomas.heigl] Revert "WICKET-6963 Use singletons for 
PanelMarkupSourcingStrategy (#503)"


--
[...truncated 2.59 MB...]
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @ 
wicket-common-tests ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 1 source file to 

[INFO] 
[INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @ 
wicket-common-tests ---
[INFO] 
[INFO] ---
[INFO]  T E S T S
[INFO] ---
[INFO] Running org.apache.wicket.osgi.OsgiClashingPackagesTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.075 s 
- in org.apache.wicket.osgi.OsgiClashingPackagesTest
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] 
[INFO] --- maven-jar-plugin:3.2.0:jar (default-jar) @ wicket-common-tests ---
[INFO] Building jar: 

[INFO] 
[INFO] >>> maven-source-plugin:3.2.1:jar (attach-sources) > generate-sources @ 
wicket-common-tests >>>
[INFO] 
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven) @ 
wicket-common-tests ---
[INFO] 
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @ 
wicket-common-tests ---
[INFO] 
[INFO] <<< maven-source-plugin:3.2.1:jar (attach-sources) < generate-sources @ 
wicket-common-tests <<<
[INFO] 
[INFO] 
[INFO] --- maven-source-plugin:3.2.1:jar (attach-sources) @ wicket-common-tests 
---
[INFO] Building jar: 

[INFO] 
[INFO] >>> maven-source-plugin:3.2.1:test-jar (attach-sources) > 
generate-sources @ wicket-common-tests >>>
[INFO] 
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven) @ 
wicket-common-tests ---
[INFO] 
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @ 
wicket-common-tests ---
[INFO] 
[INFO] <<< maven-source-plugin:3.2.1:test-jar (attach-sources) < 
generate-sources @ wicket-common-tests <<<
[INFO] 
[INFO] 
[INFO] --- maven-source-plugin:3.2.1:test-jar (attach-sources) @ 
wicket-common-tests ---
[INFO] Building jar: 

[INFO] 
[INFO] --- maven-site-plugin:3.9.1:attach-descriptor (attach-descriptor) @ 
wicket-common-tests ---
[INFO] Skipping because packaging 'jar' is not pom.
[INFO] 
[INFO] --- maven-javadoc-plugin:3.3.0:jar (attach-javadocs) @ 
wicket-common-tests ---
[INFO] 
[INFO] --- japicmp-maven-plugin:0.15.5:cmp (default) @ wicket-common-tests ---
[INFO] Skipping execution because parameter 'skip' was set to true.
[INFO] 
[INFO] --- maven-install-plugin:2.5.2:install (default-install) @ 
wicket-common-tests ---
[INFO] Installing 

 to 
/home/jenkins/.m2/repository/org/apache/wicket/wicket-common-tests/9.10.0-SNAPSHOT/wicket-common-tests-9.10.0-SNAPSHOT.jar
[INFO] Installing 

 to 
/home/jenkins/.m2/repository/org/apache/wicket/wicket-common-tests/9.10.0-SNAPSHOT/wicket-common-tests-9.10.0-SNAPSHOT.pom
[INFO] Installing 

 to 
/home/jenkins/.m2/repository/org/apache/wicket/wicket-common-tests/9.10.0-SNAPSHOT/wicket-common-tests-9.10.0-SNAPSHOT-sources.jar
[INFO] Installing 

 to 
/home/jenkins/.m2/repository/org/apache/wicket/wicket-common-tests/9.10.0-SNAPSHOT/wicket-common-tests-9.10.0-SNAPSHOT-test-sources.jar
[INFO] 
[INFO] --- maven-deploy-plugin:2.8.2:deploy (default-deploy) @ 
wicket-common-tests ---
[INFO] Skipping artifact deployment
[INFO] 
[INFO] --- maven-javadoc-plugin:3.3.0:aggregate-no-fork (default-cli) @ 
wicket-common-tests ---
[INFO] 
[INFO] -< org.apache.wicket:wicket-js-tests >--
[INFO] Building Wicket JavaScript Tests 9.10.0-SNAPSHOT [31/32]
[INFO] [ jar ]-
[INFO] 
[INFO] --- maven-clean-plugin:3.1.0:clean (default-clean) @ wicket-js-tests -

[DISSCUSSION] can we drop wicketstuff-pushd*

2022-03-31 Thread Maxim Solodovnik 
Hello All,

AFAIK these days push is available out-of-the-box via websockets
Do we need all these components?

If we do need them can anyone take a look at `push-cometd`?
cometd-java-client/cometd-java-server seems to be changed a lot
and the version we are currently using reported to be vulnerable:
https://sbom.lift.sonatype.com/report/T1-a0368c8f29fdaa555824-83a6cd82eac598-1648715554-9fa6855eebd24639bf9f6239d6d95ddf

WDYT? :))

-- 
Best regards,
Maxim

Re: [DISSCUSSION] can we drop wicketstuff-pushd*

2022-03-31 Thread Martin Grigorov 
+1 to drop it!

If someone uses it then (s)he can use the old releases and send a PR later
to revive it!

On Fri, Apr 1, 2022 at 5:20 AM Maxim Solodovnik 
wrote:

> Hello All,
>
> AFAIK these days push is available out-of-the-box via websockets
> Do we need all these components?
>
> If we do need them can anyone take a look at `push-cometd`?
> cometd-java-client/cometd-java-server seems to be changed a lot
> and the version we are currently using reported to be vulnerable:
>
> https://sbom.lift.sonatype.com/report/T1-a0368c8f29fdaa555824-83a6cd82eac598-1648715554-9fa6855eebd24639bf9f6239d6d95ddf
>
> WDYT? :))
>
> --
> Best regards,
> Maxim
>