Re: rolling out wicket 9.7.0?
Just got this automatic PR for wicket-jquery-ui, following the upgrade to the same version than in wicket quickstart. Maybe it is worth to upgrade in the wicket quickstart too to prevent security checks warning/reports to be raised... [sebfz1/wicket-jquery-ui] Bump jetty-webapp from 9.4.42.v20210604 to 9.4.43.v20210629 in /wicket-jquery-ui-samples (PR #340) This automated pull request fixes a security vulnerability (moderate severity). Best regards, Sébastien
Re: rolling out wicket 9.7.0?
Hi Ernesto, Then it might be good to add a new keystore to the quickstart ; the existing one seems to have expired a couple of weeks ago... Thanks and best regards, Sébastien
Re: Wicket 10 ideas
Wicket jQuery UI / Wicket Kendo UI does not use enclosure nor queuing. I have one enclosure occurence in the sample site, so not a big deal... +1 to remove queuing +0 to remove enclosure (I have the feeling that will have a big impact on users...)
Re: [ANNOUNCE] Apache Wicket 8.12.0 released
Hi Andrea, There is a small mistake in the text (I mentioned it in case you will reuse the text template) "no API breaks are present breaks are present" Also I thought we would indicate the location to the checksum file? Did I misunderstood? Thanks and best regards, Sébastien >
Re: [VOTE] Release Apache Wicket 7.18.0
[x] Yes, release Apache Wicket 7.18.0 Tested against Wicket jQuery UI
Re: [VOTE] Release Apache Wicket 8.12.0
[x] Yes, release Apache Wicket 8.12.0 Tested on Wicket jQuery UI
Re: [VOTE] Release Apache Wicket 9.3.0
[x] Yes, release Apache Wicket 9.3.0 Tested on Wicket jQuery UI
Re: [ANNOUNCE] New Committer - Thomas Heigl
Welcome Thomas :)
Re: [VOTE] Release Apache Wicket 9.0.0-M5 TAKE 3
Hi, I'm currently testing M5 against Wicket JQuery UI / Wicket Kendo UI. With CSP disabled, it seems to work as expected! I'm upgrading the sample application to make it work with CSP enabled. So far it works (even not yet complete), but some things seems to be out of my hands, like: Content Security Policy: The page’s settings blocked the loading of a resource at inline (“style-src”). 2 jquery-3.4.1-ver-1586053743308.js :4817:39 <http://localhost:8080/wicket-jquery-ui/wicket/resource/org.apache.wicket.resource.JQueryResourceReference/jquery/jquery-3.4.1-ver-1586053743308.js> It seems to come from the bundled jQuery, here is the line: tmp = getAll( fragment.appendChild( elem ), "script" ); The CSP error seems legit, but I don't know how we can circumvent it (did not investigate yet)... I do have few others but I need to double check if it comes from my jQuery usage or not... Anyway, I think it is good enough to release this Milestone so users can test and report before the Final. [x] Yes, release Apache Wicket 9.0.0-M5 Thanks for the big work! Sebastien
Re: CSP and UI libraries
Thank you so much Emond! I will try that!
Re: CSP and UI libraries
Thank you very much for letting me know! I didn't exactly know what to expect until I would put my hands in it, but now I'm a little bit worried, haha ! Best regards, Sebastien
Re: CSP and UI libraries
Hi Martin, Actually that's a good point! I will try to upgrade Wicket jQuery UI to wicket 9/CSP to see how it behaves... Thanks and best regards, Sebastien
Re: CSP in Wicket 9
I do agree with Andrea. I think it's better to have to add one line of code to enable the feature, than the opposite... Or better, it can be a flag like development/deployment. This way we can issue a warning at startup, same kind of warning when we are running on development mode... We can also promote the feature in the migration guide, and on the website
Re: Happy new year!...and...
Happy New Year to you all too! :)
Re: [VOTE] Release Apache Wicket 9.0.0-M3 - Take three
[x] Yes, release Apache Wicket 9.0.0-M3 Tested upon wicket-jquery-ui
Re: [VOTE] Release Apache Wicket 9.0.0-M3
Unfortunately, I did not spot the problem exactly... It is related with JavaScriptResourceReference dependencies render order. I have a ConsoleJavaScriptResourceReference which extends JQueryPluginResourceReference JQueryPluginResourceReference does have dependency on JQueryResourceReference. ConsoleJavaScriptResourceReference is rendered with PriorityHeader. in -M3, ConsoleJavaScriptResourceReference is rendered before JQueryResourceReference (whereas it should not be the case due to the dependency), leading to a "ReferenceError: jQuery is not defined" in the browser's console. It works as expected in -M2 and 8.6.0 (and since several years actually). The funny thing is that I have severral other RRs extending JQueryPluginResourceReference, all work as expected, except this very one. And I really do not see what could be different with that one! I do not have time today to try to isolate the issue in a quickstart, so if someone would like to play around: $ git clone https://github.com/sebfz1/wicket-jquery-ui.git $ git checkout wicket9.x $ mvn clean install $ cd wicket-jquery-ui-samples $ mvn jetty:run go to http://localhost:8080/wicket-jquery-ui/kendo/console/DefaultConsolePage and check the console... Thanks and best regards, Sebastien On Sun, Sep 8, 2019 at 1:39 PM Andrea Del Bene wrote: > No problem for me. We can keep the vote open for two-three days more. > > On Sun, Sep 8, 2019, 12:31 PM Sebastien Briquet > wrote: > > > Hi Andrea, > > > > Can you please wait a little before closing the vote? I may have a slight > > issue with this one (that does not repro with 8.6.0), but I'm not sure > yet > > where it come from... > > Sorry for the late notice (hard to find some spare time especially during > > weekdays...) > > > > Thanks in advance, > > Sebastien > > > > > > On Wed, Sep 4, 2019 at 10:16 PM Andrea Del Bene > > wrote: > > > > > This is a vote to release Apache Wicket 9.0.0-M3 > > > > > > Please download the source distributions found in our staging area > > > linked below. > > > > > > I have included the signatures for both the source archives. This vote > > > lasts for 72 hours minimum. > > > > > > [ ] Yes, release Apache Wicket 9.0.0-M3 > > > [ ] No, don't release Apache Wicket 9.0.0-M3, because ... > > > > > > Distributions, changelog, keys and signatures can be found at: > > > > > > https://dist.apache.org/repos/dist/dev/wicket/9.0.0-M3 > > > > > > Staging repository: > > > > > > > https://repository.apache.org/content/repositories/orgapachewicket-1129 > > > > > > The binaries are available in the above link, as are a staging > > > repository for Maven. Typically the vote is on the source, but should > > > you find a problem with one of the binaries, please let me know, I can > > > re-roll them some way or the other. > > > > > > Staging git repository data: > > > > > > Repository: g...@github.com:bitstorm/wicket.git > > > Branch: build/wicket-9.0.0-M3 > > > Release tag: rel/wicket-9.0.0-M3 > > > > > > > > > > > > > > > > The signatures for the source release artefacts: > > > > > > > > > Signature for apache-wicket-9.0.0-M3.zip: > > > > > > -BEGIN PGP SIGNATURE- > > > > > > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAl1wGtAACgkQh48B+qjT > > > VuEVoQ/6A1UQE/g2XFweih85oBMsUJZe2O+AHxpZ+xcrFvvGLX/Wn0MxqtB7bBra > > > 2G7iIiF5ojRiBRxh5s3S3S+eQwGqhevPRUiQCTJNznzBZJvNWO6/8+d4Id4Fs9qr > > > LNl5CjZ3DQNZc9vjAe393SWxJUvhQMfTJPn+jObarGmTVU9M6vi3TC3y/eTOihH6 > > > D2TARlkT64oR4SCfNqFUNec9h1qEfqHNccG1I43pYaAKPb1cw/84XR3vvwF8cU3S > > > dPRP2qh3ki6p4LrVbkbi64gkVb7GyNXuiYNftrA2SVgcnoBR486HJtMujWz77z6h > > > Wc0wC30yIE7Uf1vbqOBJiowD6FvAnP+ZLXQ1iwBnGPUu/2b0r6yjxuvGOm6fHQ5/ > > > 8DWdJkOlOIdOU4LucG7uo5Z97rRzYuTtv9bOwkDBf/UDYvOaJtHc2cAca2On6fjw > > > hdvVNQ3CTHOeq3PpofRw0OFaxbOOkb7rOieh1AbfkXbn2MpwQTFVZI8G3l8u9M4R > > > WhlsuF2S3dwQ0CbnVvHfdKzlnAsNt6tnaQv2N64Nxoubwur6TcHJ1VDMh0hVhAAV > > > IoTfVtG+eEpoXuW4nHtenJWlWUaH4isv6+USibb48VZq4qTC1TRtOTqhUCP3G1oA > > > ctfBDHcFnK9mJSHMIu/UB4eRfZuuBWoQX65m/rO0M86gakEVjTA= > > > =Skwp > > > -END PGP SIGNATURE- > > > > > > Signature for apache-wicket-9.0.0-M3.tar.gz: > > > > > > -BEGIN PGP SIGNATURE- > > > > > > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAl
Re: [VOTE] Release Apache Wicket 9.0.0-M3
Hi Andrea, Can you please wait a little before closing the vote? I may have a slight issue with this one (that does not repro with 8.6.0), but I'm not sure yet where it come from... Sorry for the late notice (hard to find some spare time especially during weekdays...) Thanks in advance, Sebastien On Wed, Sep 4, 2019 at 10:16 PM Andrea Del Bene wrote: > This is a vote to release Apache Wicket 9.0.0-M3 > > Please download the source distributions found in our staging area > linked below. > > I have included the signatures for both the source archives. This vote > lasts for 72 hours minimum. > > [ ] Yes, release Apache Wicket 9.0.0-M3 > [ ] No, don't release Apache Wicket 9.0.0-M3, because ... > > Distributions, changelog, keys and signatures can be found at: > > https://dist.apache.org/repos/dist/dev/wicket/9.0.0-M3 > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachewicket-1129 > > The binaries are available in the above link, as are a staging > repository for Maven. Typically the vote is on the source, but should > you find a problem with one of the binaries, please let me know, I can > re-roll them some way or the other. > > Staging git repository data: > > Repository: g...@github.com:bitstorm/wicket.git > Branch: build/wicket-9.0.0-M3 > Release tag: rel/wicket-9.0.0-M3 > > > > > The signatures for the source release artefacts: > > > Signature for apache-wicket-9.0.0-M3.zip: > > -BEGIN PGP SIGNATURE- > > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAl1wGtAACgkQh48B+qjT > VuEVoQ/6A1UQE/g2XFweih85oBMsUJZe2O+AHxpZ+xcrFvvGLX/Wn0MxqtB7bBra > 2G7iIiF5ojRiBRxh5s3S3S+eQwGqhevPRUiQCTJNznzBZJvNWO6/8+d4Id4Fs9qr > LNl5CjZ3DQNZc9vjAe393SWxJUvhQMfTJPn+jObarGmTVU9M6vi3TC3y/eTOihH6 > D2TARlkT64oR4SCfNqFUNec9h1qEfqHNccG1I43pYaAKPb1cw/84XR3vvwF8cU3S > dPRP2qh3ki6p4LrVbkbi64gkVb7GyNXuiYNftrA2SVgcnoBR486HJtMujWz77z6h > Wc0wC30yIE7Uf1vbqOBJiowD6FvAnP+ZLXQ1iwBnGPUu/2b0r6yjxuvGOm6fHQ5/ > 8DWdJkOlOIdOU4LucG7uo5Z97rRzYuTtv9bOwkDBf/UDYvOaJtHc2cAca2On6fjw > hdvVNQ3CTHOeq3PpofRw0OFaxbOOkb7rOieh1AbfkXbn2MpwQTFVZI8G3l8u9M4R > WhlsuF2S3dwQ0CbnVvHfdKzlnAsNt6tnaQv2N64Nxoubwur6TcHJ1VDMh0hVhAAV > IoTfVtG+eEpoXuW4nHtenJWlWUaH4isv6+USibb48VZq4qTC1TRtOTqhUCP3G1oA > ctfBDHcFnK9mJSHMIu/UB4eRfZuuBWoQX65m/rO0M86gakEVjTA= > =Skwp > -END PGP SIGNATURE- > > Signature for apache-wicket-9.0.0-M3.tar.gz: > > -BEGIN PGP SIGNATURE- > > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAl1wGtAACgkQh48B+qjT > VuGsqBAAiRpOCAMGjwgcHOk19gKgjzzAJ6hBJJyMLinWQnD5VNttWiEFFbm92KC+ > qRm6lWEnBR7xwgrn5m0evcqYiOuNjr1cHuAFdHfOGJkuubsfy/K1MCG6DI7d7M2A > mv5sQJdFzMGLqCvqMzypou5CCHfIZr9FejG9FMEOIU8aHqGIgQJgpOHfQvYVxUFl > 75MCA4e180JlwLnxdvvkunomT1alhmVTdXRLiC+EzPQsSydlyeUNFGvmEBoeqEX7 > NgEFfVE3fr0uxyStzftCiMHwaQpt91d1dJ5MIgAM8xboWGB/6KqA/nE5T9/FkTS6 > 5B4HjIHULKEpwP1e+dqB5kHJO7pK7rJbj1JnE42+bbmd3GiSDNFlZX7FkIlUhwYS > RDv2gkfX1j2DtH/2ZnS/K/ACjgWpMPkbIpPKFOtH8JMjKi/RegVLUPRQYxdlj65K > 8SNxnMpzjoMlN5U3HDw/+ShZHO/NcabLelGtCCwpQdSY2PLI4JGuqDMefR1Lu20v > AMExkuNo+WOL2oForlH6jhbbUu/GVJ/GnD/4OJ7drEhBeGu1FeS78n59LNidzeKc > Xg/WPhsEi1wez0I/Y1vudwMK/ChT4GTxoxQKyIhSgYOYtot9aSbc7D/04eSvCdcB > Td1+ZqvqUFkTs0VxCOxLmxg9vesQvNcqi2Sd96desqeUZOHt3HU= > =0ALV > -END PGP SIGNATURE- > > > > CHANGELOG for 9.0.0-M3: > > ** Bug > > * [WICKET-6613] - Wicket 8.1 ModalWindow autosizing problem > * [WICKET-6676] - Quickstart application won't deploy to GlassFish > * [WICKET-6678] - Instant : Unsupported field: YearOfEra when > cookieUtils.cookieToDebugString() is called > * [WICKET-6680] - JavaScriptStripper chokes on template literals > that contain two forward slashes > * [WICKET-6689] - ClientProperties.getTimeZone() has some issue > when DST and UTC offsets are different > * [WICKET-6690] - NullPointerException in > KeyInSessionSunJceCryptFactory. > * [WICKET-6692] - Page deserialization on websocket close - > possible performance issue > * [WICKET-6697] - Wicket.DOM.toggleClass JS method is missing > > ** New Feature > > * [WICKET-6559] - Encrypted page store > > ** Improvement > > * [WICKET-6558] - Prevent package locks after commitRequest > * [WICKET-6672] - Restore constructors with Wicket Duration in 9.x > branch for easier migration > * [WICKET-6673] - PriorityHeaderItem ordering is wrong for siblings > * [WICKET-6675] - log4j-slf4j-impl requires version 1.7.25 of > slf4j-api while Wicket 8.5 requires version 1.7.26 > * [WICKET-6
Re: wicket-jquery-ui-9 release
Hi Maxim, wicket-jquery-ui-9.0.0-M2 is on its way to maven central :) Best regards, Sebastien On Sat, Jun 8, 2019 at 8:03 AM Sebastien wrote: > Hi Maxim, > > It is almost ready :) > I need to double check everything is fine and perform the release. > > I will let you know once done... > > Thanks and best regards, > Sebastien > > > On Sat, Jun 8, 2019, 13:49 Maxim Solodovnik wrote: > >> Hello Sebastien, >> >> Could you please release 9.0.0-M2? >> I'm planning to perform release of Apache OpenMeetings in 2-3 weeks, >> so I need to eliminate all SNAPSHOT dependencies :) >> >> On Sun, 21 Apr 2019 at 19:56, Maxim Solodovnik >> wrote: >> > >> > Thanks a million for the changes! >> > >> > On Sun, 21 Apr 2019 at 16:02, Sebastien Briquet >> wrote: >> > > >> > > > @Martin: thank you very much for your commits! >> > > > > Except for the java 11 javadoc-url related commit, I think it is >> safe to >> > > > > cherry-pick other commits to wicket8.x, right? >> > > > >> > > > >> > > > Yes. I think so too. >> > > > >> > > > (I'm actually wondering >> > > > > about the wicket:header-items one) >> > > > > >> > > > >> > > > This one as well. >> > > > >> > > >> > > Done, all applied. >> > > wicket8.x and wicket9.x snapshots deployed. >> > > >> > > >> > > > You can check by starting the samples in wicket8.x branch and >> checking the >> > > > browser's dev tools console. >> > > > >> > > >> > > I will check this... >> > > >> > > >> > > > >> > > > >> > > > > About Unit Tests, yes you are right there is no tests! :) The >> idea was - >> > > > > because spare time is limited of course - to test all features by >> a demo. >> > > > > This way users have a demo for each feature which is useful and >> if there >> > > > is >> > > > > an issue, they can report through a github issue. I think it is >> more >> > > > > efficient than spending a large amount of time trying to test >> everything >> > > > in >> > > > > a UI framework where the layout is also very important, and very >> > > > difficult >> > > > > to test... >> > > > > >> > > > >> > > > Amazing job! :-) >> > > > This way you had time to provide all these demos! >> > > > >> > > > >> > > Thank you !! :)) >> > > >> > > >> > > > >> > > > > I fixed the "javadoc is missing" issue I had on my side (somehow >> my JDK >> > > > did >> > > > > not contain the javadoc program. I apt install it again, as well >> as >> > > > > openjdk-11-jdk-headless package just to be sure, and it works) >> > > > > >> > > > > I also enabled TravisCI job for wicket9.x so snapshots will >> (should) be >> > > > > deployed on successful builds from now. >> > > > > https://travis-ci.org/sebfz1/wicket-jquery-ui/branches >> > > > > >> > > > > @Maxim: I merged the MR in wicket8.x and applied the change in >> wicket9.x. >> > > > > But it seems that Travis does not deploy wicket8.x branch... :( >> > > > >> > > >> > > Somehow Travis is deploying wicket8.x again, not sure I fixed >> something >> > >> > >> > >> > -- >> > WBR >> > Maxim aka solomax >> >> >> >> -- >> WBR >> Maxim aka solomax >> >
Re: wicket-jquery-ui-9 release
Hi Maxim, It is almost ready :) I need to double check everything is fine and perform the release. I will let you know once done... Thanks and best regards, Sebastien On Sat, Jun 8, 2019, 13:49 Maxim Solodovnik wrote: > Hello Sebastien, > > Could you please release 9.0.0-M2? > I'm planning to perform release of Apache OpenMeetings in 2-3 weeks, > so I need to eliminate all SNAPSHOT dependencies :) > > On Sun, 21 Apr 2019 at 19:56, Maxim Solodovnik > wrote: > > > > Thanks a million for the changes! > > > > On Sun, 21 Apr 2019 at 16:02, Sebastien Briquet > wrote: > > > > > > > @Martin: thank you very much for your commits! > > > > > Except for the java 11 javadoc-url related commit, I think it is > safe to > > > > > cherry-pick other commits to wicket8.x, right? > > > > > > > > > > > > Yes. I think so too. > > > > > > > > (I'm actually wondering > > > > > about the wicket:header-items one) > > > > > > > > > > > > > This one as well. > > > > > > > > > > Done, all applied. > > > wicket8.x and wicket9.x snapshots deployed. > > > > > > > > > > You can check by starting the samples in wicket8.x branch and > checking the > > > > browser's dev tools console. > > > > > > > > > > I will check this... > > > > > > > > > > > > > > > > > > > About Unit Tests, yes you are right there is no tests! :) The idea > was - > > > > > because spare time is limited of course - to test all features by > a demo. > > > > > This way users have a demo for each feature which is useful and if > there > > > > is > > > > > an issue, they can report through a github issue. I think it is > more > > > > > efficient than spending a large amount of time trying to test > everything > > > > in > > > > > a UI framework where the layout is also very important, and very > > > > difficult > > > > > to test... > > > > > > > > > > > > > Amazing job! :-) > > > > This way you had time to provide all these demos! > > > > > > > > > > > Thank you !! :)) > > > > > > > > > > > > > > > I fixed the "javadoc is missing" issue I had on my side (somehow > my JDK > > > > did > > > > > not contain the javadoc program. I apt install it again, as well as > > > > > openjdk-11-jdk-headless package just to be sure, and it works) > > > > > > > > > > I also enabled TravisCI job for wicket9.x so snapshots will > (should) be > > > > > deployed on successful builds from now. > > > > > https://travis-ci.org/sebfz1/wicket-jquery-ui/branches > > > > > > > > > > @Maxim: I merged the MR in wicket8.x and applied the change in > wicket9.x. > > > > > But it seems that Travis does not deploy wicket8.x branch... :( > > > > > > > > > > Somehow Travis is deploying wicket8.x again, not sure I fixed > something > > > > > > > > -- > > WBR > > Maxim aka solomax > > > > -- > WBR > Maxim aka solomax >
Re: wicket-jquery-ui-9 release
> @Martin: thank you very much for your commits! > > Except for the java 11 javadoc-url related commit, I think it is safe to > > cherry-pick other commits to wicket8.x, right? > > > Yes. I think so too. > > (I'm actually wondering > > about the wicket:header-items one) > > > > This one as well. > Done, all applied. wicket8.x and wicket9.x snapshots deployed. > You can check by starting the samples in wicket8.x branch and checking the > browser's dev tools console. > I will check this... > > > > About Unit Tests, yes you are right there is no tests! :) The idea was - > > because spare time is limited of course - to test all features by a demo. > > This way users have a demo for each feature which is useful and if there > is > > an issue, they can report through a github issue. I think it is more > > efficient than spending a large amount of time trying to test everything > in > > a UI framework where the layout is also very important, and very > difficult > > to test... > > > > Amazing job! :-) > This way you had time to provide all these demos! > > Thank you !! :)) > > > I fixed the "javadoc is missing" issue I had on my side (somehow my JDK > did > > not contain the javadoc program. I apt install it again, as well as > > openjdk-11-jdk-headless package just to be sure, and it works) > > > > I also enabled TravisCI job for wicket9.x so snapshots will (should) be > > deployed on successful builds from now. > > https://travis-ci.org/sebfz1/wicket-jquery-ui/branches > > > > @Maxim: I merged the MR in wicket8.x and applied the change in wicket9.x. > > But it seems that Travis does not deploy wicket8.x branch... :( > Somehow Travis is deploying wicket8.x again, not sure I fixed something
Re: wicket-jquery-ui-9 release
Hi Martin, Maxim @Martin: thank you very much for your commits! Except for the java 11 javadoc-url related commit, I think it is safe to cherry-pick other commits to wicket8.x, right? (I'm actually wondering about the wicket:header-items one) https://github.com/sebfz1/wicket-jquery-ui/commit/e07009f2c543a091976e67ebedbfca75681e5820 https://github.com/sebfz1/wicket-jquery-ui/commit/bf381285484af9fa20610c6cd7d1277f9ef2898a https://github.com/sebfz1/wicket-jquery-ui/commit/54d18a5ed7f992c080906c00946c62f4bb9fdfe6 https://github.com/sebfz1/wicket-jquery-ui/commit/9cc163abe9e386ef1e8bc1b638b96af6fc34d126 About Unit Tests, yes you are right there is no tests! :) The idea was - because spare time is limited of course - to test all features by a demo. This way users have a demo for each feature which is useful and if there is an issue, they can report through a github issue. I think it is more efficient than spending a large amount of time trying to test everything in a UI framework where the layout is also very important, and very difficult to test... I fixed the "javadoc is missing" issue I had on my side (somehow my JDK did not contain the javadoc program. I apt install it again, as well as openjdk-11-jdk-headless package just to be sure, and it works) I also enabled TravisCI job for wicket9.x so snapshots will (should) be deployed on successful builds from now. https://travis-ci.org/sebfz1/wicket-jquery-ui/branches @Maxim: I merged the MR in wicket8.x and applied the change in wicket9.x. But it seems that Travis does not deploy wicket8.x branch... :(
Re: wicket-jquery-ui-9 release
Hi Maxim, I've migrated to wicket9 / java 11, and upgraded all plugins/dependencies to latest versions. So far all seems to work as expected But somehow I cannot build javadoc (javadoc is missing). I need to figure out why... I push to wicket9.x branch. The command to generate javadoc is: mvn clean install -P snapshot If you want to have a try... Thanks, Sebastien
Re: wicket-jquery-ui-9 release
Hi Maxim, Well, I didn't migrate to wicket-9 / java-9 yet... I have some time today I will start to work on it. I will let you know if I can release soon! Best regards, Sebastien
Re: http://www.wicket-library.com/ still links to 7.x?
Excellent, well done !! :p On Thu, Jun 21, 2018 at 5:01 PM, Andrea Del Bene wrote: > Bytecode ninja!! > > On Thu, Jun 21, 2018, 4:00 PM Martin Grigorov > wrote: > > > Done! > > > > I just edited a .class file with a text editor on the command line and it > > just worked! :-) > > >
Re: http://www.7thweb.net/wicket-jquery-ui seems to be down
Back :) On Thu, Jun 21, 2018, 05:10 Maxim Solodovnik wrote: > subj > > -- > WBR > Maxim aka solomax >
Re: Question regarding branches
Hi Tobias, I think this is because some preliminary investigations (or work) have been done while wicket-8 was still master (I think it was about JDK-9) So logically, wicket-9.x could or should be merged into master... But, the other question could also be, why do we have master at all? In Wicket jQuery UI, I was working on wicket8.x branch already and I will remove master soon so I will only have wicket6.x, wicket7.x (prev master), wicket8.x, and wicket9.x (soon). It make more sense to me and there is no - potentially - weird rebase/merge to do to master after each major version. Best regards, Sebastien. On Thu, May 24, 2018 at 1:23 PM, Tobias Soloschenko < tobiassolosche...@googlemail.com> wrote: > Hey guys, > > maybe I missed something, but why do we have master and wicket-9.x? > > I thought the latest version is master and all others are wicket-x.x. > > kind regards > > Tobias >
Re: Preview of new wicket site
Also, In the wicket8.x start page [1], the version should be updated (2 occurrences) In the download page [2] - the "Supported Versions" section might be updated to "security fixes only, upgrade to 7.x or 8.x" - the "Unsupported releases" section might be updated to "discontinued, upgrade to 7.x or 8.x" [1] http://dashorst.github.io/wicket-site/start/wicket-8.x.html [2] http://dashorst.github.io/wicket-site/start/download.html
Re: Preview of new wicket site
Hi Martijn, I really like it! (I think I already said this but still... :p) IMHO, I'm not sure it is really worth having subsites. There is already the download page that redirect to each wicket-X.x page, so it might already be a good place to put announcement and feature list there. Thanks & best regards, Sebastien.
Re: [VOTE] Release Apache Wicket 8.0.0
[x] Yes, release Apache Wicket 8.0.0 Tested on Wicket jQuery UI Thanks! :) Sebastien. On Wed, May 16, 2018 at 10:01 PM, Andrea Del Bene wrote: > This is a vote to release Apache Wicket 8.0.0 > > Please download the source distributions found in our staging area > linked below. > > I have included the signatures for both the source archives. This vote > lasts for 72 hours minimum. > > [ ] Yes, release Apache Wicket 8.0.0 > [ ] No, don't release Apache Wicket 8.0.0, because ... > > Distributions, changelog, keys and signatures can be found at: > > https://dist.apache.org/repos/dist/dev/wicket/8.0.0 > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachewicket-1110 > >
Re: Wicket 8 site
I like it very much too !! :)
Re: Tomcat OOM Investigation (Wicket jQuery UI 8.x)
Thanks Maxim !! I've restarted it... Now I have some dumps to investigate !.. :-/ On Fri, Mar 9, 2018 at 5:25 PM, Maxim Solodovnik wrote: > Hello Sebastien, > > http://www.7thweb.net/wicket-jquery-ui reports Service Unavailable ... >
Re: [VOTE] Release Apache Wicket 6.29.0
[x] Yes, release Apache Wicket 6.29.0 Tested against Wicket jQuery UI (with java8 compiler)
Re: Tomcat OOM Investigation (Wicket jQuery UI 8.x)
Haha, but I'm sure something has been fixed in the meanwhile just to make me lie! :p But still, the "win a beer" challenge is kept opened :) So here are the dump sizes as of today: jan. 23 19:41 - tomcat_heapdump_20180123.hprof - 65 MB jan. 25 15:05 - tomcat_heapdump_20180125.hprof - 120.9 MB jan. 30 17:24 - tomcat_heapdump_20180130.hprof - 116.2 MB On the latest dump, the 2 biggest objects (by retained size) are : Class Name / Retained Size org.apache.wicket.settings.ResourceSettings#1 / 5,741,149 org.apache.wicket.core.util.resource.locator.caching.CachingResourceStreamLocator#1 / 5,450,900 Don't know what it does mean actually... Thanks & best regards, Sebastien. On Tue, Jan 30, 2018 at 5:21 PM, Andrea Del Bene wrote: > It's really disappointing when things don't go wrong :-D >
Re: Tomcat OOM Investigation (Wicket jQuery UI 8.x)
Damned, you're right Maxim! Honestly I don't remember this webapp (in wicket8.x) survived more than 1 week before... Very strange! I will generate a heap dump checkpoint to see... On Tue, Jan 30, 2018 at 5:06 PM, Maxim Solodovnik wrote: > Hello Sebastien, > > seems everything works as expected :) > No chance to win a beer :((( >
Tomcat OOM Investigation (Wicket jQuery UI 8.x)
/ started a new thread / Hi Martin, 1/ I've deployed wicket-jquery-ui-samples-8.x webapp on tomcat8 2/ I've restarted with "-XX:HeapDumpPath=/var/log/tomcat8/dumps/ -XX:+HeapDumpOnOutOfMemoryError" 3/ The initial dump (hprof format) has been generated (~68MB) 4/ Now wait (a few days) and see... The first one who reports http://www.7thweb.net/wicket-jquery-ui/ is down win a beer! :) Thanks & best regards, Sebastien. On Tue, Jan 23, 2018 at 6:02 PM, Sebastien wrote: > Hi Martin! > > On Tue, Jan 23, 2018 at 4:06 PM, Martin Grigorov > wrote: > >> Hi Sebastien, >> >> What exactly is the issue you experience ? >> > > I don't know the cause but tomcat is crashing every 3 or 4 days (out of > memory) when running the wicket8.x version of the demo webapp. > When running the wicket7.x it works fine, and always used to. > > >> >> The Log4J problem is that it doesn't release all classes/class loaders at >> undeploy. >> > But if you run the application for N weeks without undeploy+deploy then it >> should not lead to any problems. Restarting the whole web server is also >> fine. >> > > That was the part I didn't catch, thanks for the clarification! > So, it is not related to my current issue here... > > >> >> So, what exactly happens with Wicket 8.x after few weeks ? >> The application fails with OutOfMemoryError ? If this is the case then the >> way to debug it is to take heap dumps and analyze what's eating the >> memory. >> Start the application and take a heap dump. Then wait for N days and take >> another one. If you start the server with -XX:+HeapDumpOnOutOfMemoryError >> then it will dump it automatically when the OOM occurs. >> > > Ok I will do this asap : redeploy a wicket8.x version, restart with > -XX:+HeapDumpOnOutOfMemoryError and make an initial heap dump > > Thanks again ! > Sebastien. > > > Once you have the dumps you can compare them with VisualVM or analyze >> deeply with Eclipse MAT. if you upload the dumps somewhere I can analyze >> them for you ;-) >> >> Martin >> >> On Tue, Jan 23, 2018 at 11:30 AM, Sebastien wrote: >> >> > Just to let you know, I've deployed the wicket7.x version of the Wicket >> > jQuery UI demo webapp on my tomcat server about 2 weeks ago... >> Everything >> > is working fine, no leak at all so far! >> > So I think it's safe to say the leak is coming from wicket 8.x. I saw >> the >> > comments about the log4j issue and the PageStore issue (but this one was >> > reported for wildfly IIRC). >> > Was the log4j issue affecting the wicket8.x branch only? Is there >> anything >> > I can test these days on my wicket8.x version? >> > >> > Thanks in advance :) >> > Sebastien. >> > >> > >
Re: Tomcat "find leaks" button
Hi Martin! On Tue, Jan 23, 2018 at 4:06 PM, Martin Grigorov wrote: > Hi Sebastien, > > What exactly is the issue you experience ? > I don't know the cause but tomcat is crashing every 3 or 4 days (out of memory) when running the wicket8.x version of the demo webapp. When running the wicket7.x it works fine, and always used to. > > The Log4J problem is that it doesn't release all classes/class loaders at > undeploy. > But if you run the application for N weeks without undeploy+deploy then it > should not lead to any problems. Restarting the whole web server is also > fine. > That was the part I didn't catch, thanks for the clarification! So, it is not related to my current issue here... > > So, what exactly happens with Wicket 8.x after few weeks ? > The application fails with OutOfMemoryError ? If this is the case then the > way to debug it is to take heap dumps and analyze what's eating the memory. > Start the application and take a heap dump. Then wait for N days and take > another one. If you start the server with -XX:+HeapDumpOnOutOfMemoryError > then it will dump it automatically when the OOM occurs. > Ok I will do this asap : redeploy a wicket8.x version, restart with -XX:+HeapDumpOnOutOfMemoryError and make an initial heap dump Thanks again ! Sebastien. Once you have the dumps you can compare them with VisualVM or analyze > deeply with Eclipse MAT. if you upload the dumps somewhere I can analyze > them for you ;-) > > Martin > > On Tue, Jan 23, 2018 at 11:30 AM, Sebastien wrote: > > > Just to let you know, I've deployed the wicket7.x version of the Wicket > > jQuery UI demo webapp on my tomcat server about 2 weeks ago... Everything > > is working fine, no leak at all so far! > > So I think it's safe to say the leak is coming from wicket 8.x. I saw the > > comments about the log4j issue and the PageStore issue (but this one was > > reported for wildfly IIRC). > > Was the log4j issue affecting the wicket8.x branch only? Is there > anything > > I can test these days on my wicket8.x version? > > > > Thanks in advance :) > > Sebastien. > > >
Re: Tomcat "find leaks" button
Just to let you know, I've deployed the wicket7.x version of the Wicket jQuery UI demo webapp on my tomcat server about 2 weeks ago... Everything is working fine, no leak at all so far! So I think it's safe to say the leak is coming from wicket 8.x. I saw the comments about the log4j issue and the PageStore issue (but this one was reported for wildfly IIRC). Was the log4j issue affecting the wicket8.x branch only? Is there anything I can test these days on my wicket8.x version? Thanks in advance :) Sebastien.
Re: Tomcat "find leaks" button
Hi Andrea, Actually, I still have the memory leak issue on my Tomcat server using the wicket-jquery-ui samples. I've to restart once a week... :( I thought it could come from the debug-bar so I've removed it, but the problem still persists and logs are not useful at this point (only that the server is dying...) I need to find a way to increase logs and/or investigate this deeper... I also wanted to deploy my wicket 7.x because it used to be very stable at that time, I will try this asap... Thanks, Sebastien. On Wed, Jan 10, 2018 at 11:29 AM, Andrea Del Bene wrote: > Hi, > > I've noticed that with a quickstart project and with a permanent session, > with Tomcat I get the same behavior described here > https://issues.apache.org/jira/browse/WICKET-6046. > Is something we should worry about? > > Andrea. >
Re: @PMC: Request permission for a HyderabadJUG meetup for Wicket
[x] +1: yes you can use the Apache Wicket™ brand for the HyderabadJUG Le 21 déc. 2017 18:24, "Martijn Dashorst" a écrit : > Apparently to abide by the rules of the ComDev [1] I have to ask > permission to use the Apache Wicket name for organizing a meetup event > for the HyderabadJUG concerning Wicket. > > So here it goes: > > Can I, in conjunction with my co-organizers of the HyderabadJUG and > our local business partner use the Apache Wicket name to organize an > event concerning our project with one or two talks about Wicket? > > [ ] +1: yes you can use the Apache Wicket™ brand for the HyderabadJUG > [ ] -1: Nope > > Martijn > > [1] http://community.apache.org/events/small-events.html >
Re: 7thweb is down
Done! Thanks for notifying! :) Le 7 nov. 2017 05:19, "Maxim Solodovnik" a écrit : > Hello Sebastien, > > could you please restart 7thweb? :) > > -- > WBR > Maxim aka solomax >
Re: wicket-jquery-ui M8
On its way to maven central! :) I'll make the announce tomorrow...
Re: wicket-jquery-ui M8
Didn't had a chance to release today. Hopefuly tomorow!
Re: wicket-jquery-ui M8
Hi Maxim, Sure, will do it today... Best regards, Sébastien
[VOTE] Release Apache Wicket 8.0.0-M8
[x] Yes, release Apache Wicket
Re: Testing jquery-ui Wizard
Hi Maxim, Maybe that's because I forgot a small call! ;) https://github.com/sebfz1/wicket-jquery-ui/commit/56b8cccd24eb53469d73beb2f9a821b6ad62ee3f Snapshots are on their ways... Thanks & best regards, Sebastien On Thu, Oct 5, 2017 at 9:21 AM, Maxim Solodovnik wrote: > Seems to be my fault :( > I have not call open :))) > > Another question :)) > I'm trying to write the test to check if wizard buttons are enabled or not > > I'm getting DialogButton and it's enabled property to determine if button > is enabled BUT this property is always true :((( > > On Thu, Oct 5, 2017 at 12:19 PM, Maxim Solodovnik > wrote: > >> Hello Sebastien, >> >> I'm trying to write unit tests for wizard based on [1] >> I was able to display the page :) >> And wizard is accessible to WicketTester but it is not inited :((( >> I believe I need to do some "dialog magic" :)) Could you please tell me >> which behavior I need to execute to initialize the AbstractWizard? >> >> Thanks in advance! >> >> [1] https://github.com/sebfz1/wicket-jquery-ui/blob/master/w >> icket-jquery-ui/src/main/java/com/googlecode/wicket/jquery/ >> ui/widget/wizard/AbstractWizard.java >> >> -- >> WBR >> Maxim aka solomax >> > > > > -- > WBR > Maxim aka solomax >
JDK 9
https://www.infoworld.com/article/3227244/java/java-9-is-here-everything-you-need-to-know.html Some keypoints that may be interesting... - CSS APIs is now accessible for modularity. - JDK 9 includes a parser API for Nashorn’s ECMAScript syntax tree. The API enables ECMAScript code analysis by IDEs and server-side frameworks without depending on Project Nashorn’s internal implementation classes. - The beta HTTP/2 client API has come to JDK 9, implementing in Java the upgrade to the web’s core HTTP protocol. WebSocket is supported by the API as well. - In JDK 9, the Javadoc documentation tool is enhanced to generate HTML5 markup
Re: wicket-8 m8
Maybe a -M8 in the meantime? As well as 6.29 so releases cycle stay aligned? (btw, does the page store issue not applies to wicket-6.x?) On Mon, Sep 25, 2017 at 11:03 AM, Andrea Del Bene wrote: > No AFAIK but I'd rather wait for WICKET-6105 to be solved. It's a delicate > issue and I would like to collect as many user feedback as possible before > publishing the final 8.0.0 >
Re: WICKET-6308 in wicket-6.x ?
Thanks, Sven :) On Sat, Sep 23, 2017 at 11:29 PM, Sven Meier wrote: > +1 that additional constructor should do no harm > > Sven >
WICKET-6308 in wicket-6.x ?
Hi devs, Is it ok I port the following change to wicket-6.x branch? [WICKET-6308] - Add an extra constructor to EmailTextField with a custom validator but without model Thanks in advance, Sebastien.
Re: [ANNOUNCE] WicketStuff 8.0.0-M7 Released
Great, thanks Maxim ! :) On Mon, Aug 14, 2017 at 12:15 PM, Maxim Solodovnik wrote: > Andrea Del Bene (6): > Added missing class import > Time out for test raised from 10 sec to 50 sec. > Updated Ignite dependency to the 2.x branch > Fix for serialization tests > Added error logging to handleException > Update readme.md > > Christopher Miles (1): > Merge pull request #606 from ageery/openlayers3_enhancements > > Martin Tzvetanov Grigorov (1): > Fix Maven warnings > > Maxim Solodovnik (13): > Whitespaces are fixed, jquery is removed from dashboard code base > Image resources are replaced with CSS, code clean-up > Whitespaces are fixed > Merge pull request #603 from > reckart/feature/issue602-UrlParametersReceivingBehavior-subclassing > hazelcast version is updated to most recent one > Code clean-up > Fixes issue #605: tokenSeparators are passed in correct format > urlfragment: Whitespaces are fixed > Merge branch 'master' of github.com:wicketstuff/core > Fixes issue #604: UrlUtil is being conditionally created > UrlFragment: deprecated code is removed > Library versions are updated to recent versions > 8.0.0-M7 is released > > Pedro Santos (1): > Fix for issue #601 - bug: only one colunm where being skipped > from spanned area > > Richard Eckart de Castilho (1): > #602 - UrlParametersReceivingBehavior does not find resource > when subclassed > > Vit Rozkovec (2): > Use framework's JQuery reference (#598) > Expose fit markers JS (#600) > > ageery (5): > Change JS calls to ol.View.fitExtent() calls to ol.View.fit(). > Cleaned up compiler warnings. > Added an XYZ tile source and added a visibility model to Layer. > Added an ArcGIS tile source and added an opacity property to Layer. > Merge remote-tracking branch 'upstream/master' into > openlayers3_enhancements > > > The WicketStuff team >
Re: [VOTE] Release Apache Wicket 8.0.0-M7
[x] Yes, release Apache Wicket 8.0.0-M7 Tested upon wicket-jquery-ui samples
Re: Wicket 8 (M7) release
Hi KB, Thanks for your inputs! The demo app is wicket-jquery-ui-samples: https://github.com/sebfz1/wicket-jquery-ui online here: http://www.7thweb.net/wicket-jquery-ui/ If you want to give a try at profiling, you are very welcome! :) In the meantime, I launch the HPROF on the server and I will let it collect data for some hours. Will see what comes out... By monitoring the traffic, I also saw queries to the InspectorPage (yes, I've got the inspector page in "production"! But that's a demo app, that's why...). I know the inspector page can be memory consuming, so maybe it's an hit... Best regards, Sebastien On Mon, Aug 7, 2017 at 11:42 AM, Korbinian Bachl < korbinian.ba...@whiskyworld.de> wrote: > Hello Sebastien, > > that sounds bad - how big is the heap space you gave to your server? > > I'm running our app now on a testserver for 10 days and the memory usage > seems normal - even though I also did some jMeter on it during the last > week, spawning many many threads and requests; > > Heap from 8-Snapshot here reads as follows at the current time: > > Heap Memory Usage: > Memory that Java Virtual Machine initially requested to the Operating > System: 2.147.483.648 Bytes > Memory that Java Virtual Machine is guaranteed to receive from the > Operating System: 2.144.337.920 Bytes > Maximum Memory that Java Virtual Machine may get from the Operating > System: 2.144.337.920 Bytes. Note that this is not guaranteed. > Memory that Java Virtual Machine uses at this time: 1.018.066.976 Bytes > > While our production one after nealry 10 weeks uptime reads this: > > Heap Memory Usage: > Memory that Java Virtual Machine initially requested to the Operating > System: 4.294.967.296 Bytes > Memory that Java Virtual Machine is guaranteed to receive from the > Operating System: 4.151.836.672 Bytes > Maximum Memory that Java Virtual Machine may get from the Operating > System: 4.151.836.672 Bytes. Note that this is not guaranteed. > Memory that Java Virtual Machine uses at this time: 1.014.171.432 Bytes > > > > So far nothing big difference - both are far away from maximumg level; > > What kind of demo app is this? > > Best, > > KB >
Re: Wicket 8 (M7) release
Hi, Just to let you know: I deployed the wicket8.x of my demo app and it ran for 5 days before failing down (out of memory) SEVERE [ajp-nio-8009-exec-2] org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun java.lang.OutOfMemoryError: Java heap space at java.util.Arrays.copyOf(Arrays.java:3332) at java.lang.AbstractStringBuilder.ensureCapacityInternal(AbstractStringBuilder.java:124) at java.lang.AbstractStringBuilder.append(AbstractStringBuilder.java:448) at java.lang.StringBuilder.append(StringBuilder.java:136) at org.apache.wicket.Page.checkRendering(Page.java:662) at org.apache.wicket.Page.onAfterRender(Page.java:805) at org.apache.wicket.markup.html.WebPage.onAfterRender(WebPage.java:209) at org.apache.wicket.Component.afterRender(Component.java:919) at org.apache.wicket.Component.render(Component.java:2335) at org.apache.wicket.Page.renderPage(Page.java:987) at org.apache.wicket.request.handler.render.WebPageRenderer.renderPage(WebPageRenderer.java:124) at org.apache.wicket.request.handler.render.WebPageRenderer.respond(WebPageRenderer.java:236) at org.apache.wicket.core.request.handler.RenderPageRequestHandler.respond(RenderPageRequestHandler.java:202) at org.apache.wicket.request.cycle.RequestCycle$HandlerExecutor.respond(RequestCycle.java:912) at org.apache.wicket.request.RequestHandlerExecutor.execute(RequestHandlerExecutor.java:65) at org.apache.wicket.request.cycle.RequestCycle.execute(RequestCycle.java:283) at org.apache.wicket.request.cycle.RequestCycle.processRequest(RequestCycle.java:253) at org.apache.wicket.request.cycle.RequestCycle.processRequestAndDetach(RequestCycle.java:221) at org.apache.wicket.protocol.http.WicketFilter.processRequestCycle(WicketFilter.java:262) at org.apache.wicket.protocol.http.WicketFilter.processRequest(WicketFilter.java:204) at org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:286) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:106) at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:502) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:141) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:79) at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:616) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:88) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:522) at org.apache.coyote.ajp.AbstractAjpProcessor.process(AbstractAjpProcessor.java:868) There is nothing else in there. I should really run a profiler... Best regards, Sebastien. On Sun, Aug 6, 2017 at 7:34 PM, Maxim Solodovnik wrote: > As far as I can see nothing blocks the release > +1 :) > > On Mon, Aug 7, 2017 at 12:25 AM, Andrea Del Bene > wrote: > > I guess now we are ready to start the release of M7, right? > > > > > > On 05/08/2017 17:12, Maxim Solodovnik wrote: > >> > >> https://github.com/apache/wicket/pull/228 > >> > >> On Sat, Aug 5, 2017 at 12:04 PM, Maxim Solodovnik > > >> wrote: > >>> > >>> OK, thanks > >>> will prepare PR > >>> > >>> On Sat, Aug 5, 2017 at 11:59 AM, Martin Grigorov > >>> wrote: > >>>> > >>>> Hi Maxim, > >>>> > >>>> On Aug 5, 2017 3:28 AM, "Maxim Solodovnik" > wrote: > >>>> > >>>> Hello All, > >>>> > >>>> I would like to update version on libraries being used by wicket to > the > >>>> most recent versions is it OK? > >>>> > >>>> > >>>> Sure! > >>>> > >>>> > >>>> report can be get as follows (with some exceptions of course): > >>>> > >>>> mvn versions:display-dependency-updates > >>>> > >>>> > >>>> > >>>> On Sat, Aug 5, 2017 at 3:26 AM, Tobias Soloschenko < > >>>> tobiassolosche...@googlemail.com> wrote: > >>>> > >>>>> +1 for M7 > >>>>> > >>>>> kind regards > >>>>> > >>>>> Tobias > >>>>> > >>>>>> Am 04.08.2017 um 18:56 schrieb Korbinian Bachl < > >>&g
Re: Wicket 8 (M7) release
ng.reflect.Method.invoke(Method.java:498) > at > java.io.ObjectStreamClass.invokeWriteObject(ObjectStreamClass.java:1028) > at > java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1496) > at > java.io.ObjectOutputStream.writeOrdinaryObject( > ObjectOutputStream.java:1432) > at > java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178) > at > java.io.ObjectOutputStream.defaultWriteFields( > ObjectOutputStream.java:1548) > at > java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1509) > at > java.io.ObjectOutputStream.writeOrdinaryObject( > ObjectOutputStream.java:1432) > at > java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178) > at > java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:348) > at > org.apache.wicket.serialize.java.JavaSerializer$ > SerializationCheckerObjectOutputStream.writeObjectOverride( > JavaSerializer.java:368) > at > java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:344) > at > org.apache.wicket.serialize.java.JavaSerializer.serialize( > JavaSerializer.java:82) > at > org.apache.wicket.pageStore.AbstractPageStore.serializePage( > AbstractPageStore.java:133) > at > org.apache.wicket.pageStore.DefaultPageStore.createSerializedPage( > DefaultPageStore.java:281) > at > org.apache.wicket.pageStore.DefaultPageStore.storePage( > DefaultPageStore.java:61) > at > org.apache.wicket.pageStore.AsynchronousPageStore$PageSavingRunnable.run( > AsynchronousPageStore.java:225) > at java.lang.Thread.run(Thread.java:748) > > > But none of them look bad enough to stop the app. > > Martin Grigorov > Wicket Training and Consulting > https://twitter.com/mtgrigorov > > On Mon, Jul 31, 2017 at 9:28 PM, Sebastien wrote: > > > Hi Martin, > > > > Yes, that's what I was referring to. > > What I'm afraid of, is that this start & stop script may hide an > underlying > > problem... Do you remember such instabilities with examples7.x? > > > > Thanks & best regards, > > Sebastien. > > > > On Mon, Jul 31, 2017 at 8:18 PM, Martin Grigorov > > wrote: > > > > > Hi Sebastien, > > > > > > Do you talk about the OpenShift deployment of examples8x ? > > > I've added start and stop action hook scripts for it and since then it > > > seems to work fine. > > > > > > Martin Grigorov > > > Wicket Training and Consulting > > > https://twitter.com/mtgrigorov > > > > > >
Re: Wicket 8 (M7) release
Hi Martin, Yes, that's what I was referring to. What I'm afraid of, is that this start & stop script may hide an underlying problem... Do you remember such instabilities with examples7.x? Thanks & best regards, Sebastien. On Mon, Jul 31, 2017 at 8:18 PM, Martin Grigorov wrote: > Hi Sebastien, > > Do you talk about the OpenShift deployment of examples8x ? > I've added start and stop action hook scripts for it and since then it > seems to work fine. > > Martin Grigorov > Wicket Training and Consulting > https://twitter.com/mtgrigorov >
Re: Wicket 8 (M7) release
Good to know! Thanks Maxim!
Re: Wicket 8 (M7) release
Hi, Does the investigation about the server recurring downtime give something ? @andrea ? I did have a recurring crash in my demo app in wicket 8.x, which does not seem to repro in wicket 7.x. As said earlier, I did not had time to profile on my side so I was counting on Andrea's investigation to know if there could an issue in wicket 8 itself... Best regards, Sebastien On Jul 31, 2017 5:31 PM, "Martin Grigorov" wrote: > +1 from me for 8.0.0 > I don't have any planned API breaks in mind. > > Martin Grigorov > Wicket Training and Consulting > https://twitter.com/mtgrigorov > > On Mon, Jul 31, 2017 at 6:19 PM, Tobias Soloschenko < > tobiassolosche...@googlemail.com> wrote: > > > Hi, > > > > > Am 31.07.2017 um 17:18 schrieb Maxim Solodovnik >: > > > > > > Sure > > > Sorry Tobias, I wasn't aware there is something in progress :( > > > > Oh I didn’t mentioned it, yet. So it was my fault. :-) > > > > > > > > On Mon, Jul 31, 2017 at 10:16 PM, Tobias Soloschenko > > > wrote: > > >> Hi, > > >> > > >> I am going to provide a patch to wicket-8.x with some changes > regarding > > the push API, today. > > >> > > >> Maybe it is possible that it can be reviewed and merged first? > > >> > > >> kind regards > > >> > > >> Tobias > > >> > > >>> Am 31.07.2017 um 17:14 schrieb Maxim Solodovnik < > solomax...@gmail.com > > >: > > >>> > > >>> Hello All, > > >>> > > >>> As I can see there are no issues against M7, maybe it's time for > > release? > > >>> Maybe it also worth to release 8.0.0? > > >>> > > >>> -- > > >>> WBR > > >>> Maxim aka solomax > > >> > > > > > > > > > > > > -- > > > WBR > > > Maxim aka solomax > > > > kind regards > > > > Tobias > > > > >
Re: examples8x.wicket.apache.org / 503
Hi Andrea, I'm also suffering this kind of issue with the wicket-jquery-ui webapp (and I never had time to investigate). I think this investigation may lead to discover a real problem... Please let me know your conclusions :) Thanks in advance, Sebastien. On Tue, Jul 4, 2017 at 5:54 PM, Andrea Del Bene wrote: > Hi, > > no one is "officially" in charge for the site. I've also noted that after > some days of without problems, the site becomes unresponsive with a 503 > error. I've tried to restart it several times with no luck. I will try to > investigate the problem in the next days. > > On Tue, Jul 4, 2017 at 10:10 AM, Korbinian Bachl < > korbinian.ba...@whiskyworld.de> wrote: > > > Hello, > > > > http://examples8x.wicket.apache.org/ is giving me a 503 for several days > > now. Can you please tell me who is in charge of it? > > > > Best, > > > > Korbinian > > >
Re: Next attempt for 6.27.0
ok for me On Jul 1, 2017 7:23 PM, "Andrea Del Bene" wrote: > Hi, > > from what I see the blocking issues for 6.27.0 have been solved. I will > start a new release cycle for this version tomorrow if it is ok for you. > > Andrea. > >
Re: Close tag for the tag
I still agree (and remember the same)! But I also remember Wicket used to complain with self-closed inputs, what's why I need to double check (but maybe my memories are not that good ! ;)) In this particular use case, we can self-close the input anyway, there is not wicket:id...
Re: Close tag for the tag
Hi Maxim, I understand your point and I fully agree! However in certain cases it needs to be closed (not self-closed). I will double check, maybe it changed with the time... Thanks & best regards, Sebastien
Re: [VOTE] Release Apache Wicket 6.27.0 take 3
[x] Yes, release Apache Wicket 6.27.0 Tested against Wicket jQuery UI, essentially JSON stuff Thanks Andrea !! :) Sebastien. On Sun, May 28, 2017 at 12:49 PM, Andrea Del Bene wrote: > This is a vote to release Apache Wicket 6.27.0 > > Please download the source distributions found in our staging area > linked below. > > I have included the signatures for both the source archives. This vote > lasts for 72 hours minimum. > > [ ] Yes, release Apache Wicket 6.27.0 > [ ] No, don't release Apache Wicket 6.27.0, because ... > > Distributions, changelog, keys and signatures can be found at: > > https://dist.apache.org/repos/dist/dev/wicket/6.27.0 > > Staging repository: > > > https://repository.apache.org/content/repositories/orgapachewicket-1093/ > > The binaries are available in the above link, as are a staging > repository for Maven. Typically the vote is on the source, but should > you find a problem with one of the binaries, please let me know, I can > re-roll them some way or the other. > > Staging git repository data: > > Repository: g...@github.com:bitstorm/wicket.git > Branch: build/wicket-6.27.0 > Release tag: rel/wicket-6.27.0 > > > > > The signatures for the source release artefacts: > > > Signature for apache-wicket-6.27.0.zip: > > -BEGIN PGP SIGNATURE- > Version: GnuPG v1 > > iQIcBAABAgAGBQJZKqodAAoJEAzCjx+CMhBVU2MP/2UCfeFMDyggvsPJp5i7p0oF > ekpLkpHDw+0ytxoRQIzyhcPnARjcOjgDHZw/F52ESvszlVgXlb0MuAerg1mmYCfL > lLba1L4O70zx/eWBirOd8A6I2GETQwEmTvekZBMdewykWHSsoOLf3LCQpw1evcFI > KV6DSoe/V5kOi29aaXxpNjYKEShTLn0qiMorryQ+V+DR+wQuKuXDlTbTlrljdBb0 > F6FX3jDXkCksWR7DjTN+7D+pfASkuwGusL5MVNDzpC3/Zr1F88k48Zva4zEFDvI0 > QnV8Zhc85w88MInouYWqDj9Ou+ysUipdl2FEl30uIyxb7eeUrVdABz9JZKHZLFQt > rkZrpYYV34LOREfPbvNB+Jl7LlH+zie2fXZA9IecV7RfAiuZZC/I1gNUv6F+Deg3 > z/DQY5Wur3NIsGDKaNf7YLDgoii6ZZP/YAmof6jNAz6ha5WkFNy/PQDbEfIi9Wey > Lxu0eEAYZNVgEkLV2jPbSbGs/RlZHOdmGDHpT8BKSxZElWJ7GQweiQ5EEN8uayxo > stjg51dYUccNqcbw+bW0d6cIKJ+iPKi9RN5RhAJKCNJeYwv6JvtoUIqbJdV+IwYu > FbymO6i+oz1NNCWh9r9lFqHM+feZ4NsDpbmv1rEBt04fHopp+jakcsx8WjCA3lVW > n53inWtrha6M6SYJZ04i > =bONO > -END PGP SIGNATURE- > > Signature for apache-wicket-6.27.0.tar.gz: > > -BEGIN PGP SIGNATURE- > Version: GnuPG v1 > > iQIcBAABAgAGBQJZKqodAAoJEAzCjx+CMhBV9hMP/Rkzdt6hII+y7nOh5D/f5dAH > dYV88Lbs9PRS73HcvZzIL5IjklACgu3f67DpNdehEbANgwwluCh5FaWAmj9ZgGNC > xQPQLYjlzIReJUPi3reTcJIgArP3fgp563Yb8cheKd1W09YzTd61Fuy9uHUBhCT1 > yr5yqJmmbWc3TyOKy6aYcN+As9foLN6z66Acru3w03++1EtNh1ol+rTTPhYTfSAR > 9Jt8lwLVSCPE/o8G7CR1HsdWd+Qtw189pnfwHSA0cftzu2APer56cini3D3RhW7s > AVRqN7nn8nAEJZwedXSZ7DG8zRH3pWJ1x5MWREFnDj2zcTPtiwhYDry2zmT2MmCr > zD/VngEsfkRsIDEAFLyA0UznxUrZyM5Y1QITN7uJqRMkU52/DSQCwLgfmgpRzNBC > cIvM2pPPkWVHO2v55Ygol9MMdtGKKwxGnNgrhxMRbU5HdaaJiSBehp/LKg/YawBB > 3HLXw+IaMQ+A39rNG0BsBhJu0GhmzavmhK1AX6r1Z+GYK9Xz/Fc5VJvFLPjRzqJH > 3a/afSc5uzjQAkUWSqVEZ5S+fgH+mMQ6xa1e4SfT8dXZd625dbPj7uQWa922j1nz > 7LQ28kLcLGRTLFed0SHee8ZbOE3g/X7A18GuwQAdo3No/EPwwjNR/B3xk7i+2sBm > npzDCtBX6oVxHy2FbRuu > =1vlI > -END PGP SIGNATURE- > > > > CHANGELOG for 6.27.0: > > ** Bug > > * [WICKET-6165] - Inconsistent behavior of Markupstream.hasMore vs. > MarkupStream.next. > * [WICKET-6314] - 7.6 release references 7.5-SNAPSHOT poms > * [WICKET-6316] - Wicket tester encodes page id for stateless links in > stateless pages > * [WICKET-6340] - The Ajax reponse of an AjaxSubmitButton creates > invalid XHTML markup for multipart forms > * [WICKET-6356] - Clustering failover not working on Tomcat > * [WICKET-6362] - HeaderItems with different PageParameters are > treated as identical > > ** Improvement > > * [WICKET-6212] - CheckChoice / add a getAdditionalAttributes() also > for -tag > * [WICKET-6307] - SubmitLink does not work in Chrome "ff.onsubmit is > not a function" > * [WICKET-6323] - Allow ResourceBundles to use the defer attribute > * [WICKET-6351] - Form.anyFormComponentError performance degradation > * [WICKET-6364] - The autogenerated input field when a form has a > default button should not gain the focus when navigating with tab > > ** Task > > * [WICKET-6287] - Switch from json.org to open-json >
Re: [VOTE] Release Apache Wicket 8.0.0-M6
[x] Yes, release Apache Wicket 8.0.0-M6 Tested against wicket-jquery-ui, especially openjson-1.0.6 stuffs... Well done team! :)
Re: [VOTE] Release Apache Wicket 6.27.0 take 2
[x] No, don't release Apache Wicket 6.27.0, because JSONString renders nulls [1] (I'm so sorry to not have seen it in the previous take!) Hi Andrea, There is still discrepancies between wicket-6.x and wicket-7.x' json implementation. I think this roundly corresponds to that commit: https://github.com/openjson/openjson/commit/084faf72821464185d2be8bdcd99d4623f47eeb5#diff-aeecd550499d8f3624471dc0959116bcR337 I've performed a folder/files comparison between "wicket-6.x/...core/ajax/json" and "wicket-7.x/...core/ajax/json" to enlighten the diffs, and there is some others (smaller) diffs. I'm afraid my spare time is elapsed for this week-end so I cannot manage to align the code myself right now. :( Thanks & best regards (& good luck!) Sebastien [1] https://github.com/openjson/openjson/issues/7
Re: [VOTE] Release Apache Wicket 7.7.0 take 4
[x] Yes, release Apache Wicket 7.7.0 Tested upon wicket-jquery-ui, essentially JSON stuffs... Thanks & best regards, Sebastien.
Re: [VOTE] Release Apache Wicket 6.27.0
[x] No, don't release Apache Wicket 6.27.0, because: JSONObject#wrap does
not wrap "Object" objects
Hi Andrea,
The following line has not been retrofit in wicket6.x (JSONObject#wrap):
} else {
return new JSONObject(o);
}
Wicket7.x:
https://github.com/apache/wicket/blob/wicket-7.x/wicket-core/src/main/java/org/apache/wicket/ajax/json/JSONObject.java#L1011
Wicket6.x:
https://github.com/apache/wicket/blob/wicket-6.x/wicket-core/src/main/java/org/apache/wicket/ajax/json/JSONObject.java#L983
Thanks (sorry) & best regards,
Sebastien
PS: but look at the good news, Wicket7 release is now good! :)
Re: [VOTE] Release Apache Wicket 7.7.0 take 3
if opensjon 1.0.6 (from my memory) has been released the dependency to had been upgraded, yes ! :) 6.27.0 would also come in the loop with the json fix.. On May 11, 2017 18:15, "Maxim Solodovnik" wrote: > Maybe it worth to release 8.0.0-M6 after successful 7.7.0 ? > > On Thu, May 11, 2017 at 9:47 PM, Andrea Del Bene > wrote: > > Yes, the dev source is different from the release branch :-(. Sorry, I > will > > restart the vote when tomorrow. > > > > This vote is canceled. > > > > On Thu, May 11, 2017 at 3:55 PM, Maxim Solodovnik > > wrote: > > > >> Hello Andrea, > >> > >> After investigation I find out sources as wicket.git (wicket-7.x > >> branch) and sources at > >> https://dist.apache.org/repos/dist/dev/wicket/7.7.0 > >> differs :((( > >> > >> could you please double check? > >> wicket-7.x branch contains valid JSONStringer, sources available at > >> dist.a.o contains wrong JSONStringer :( > >> > >> On Thu, May 11, 2017 at 8:10 PM, Maxim Solodovnik > > >> wrote: > >> > Hello All, > >> > > >> > bad news: select2 from wicketstuff is not working > >> > build signatures etc. are OK > >> > > >> > Please give me some time to double check everything and to provide > >> > patches for both openjson and wicket7 > >> > > >> > On Thu, May 11, 2017 at 1:55 AM, Tobias Soloschenko > >> > wrote: > >> >> +1 > >> >> > >> >> kind regards > >> >> > >> >> Tobias > >> >> > >> >>> Am 10.05.2017 um 16:22 schrieb Andrea Del Bene < > an.delb...@gmail.com>: > >> >>> > >> >>> +1 to release. Tested with guide examples. > >> >>> > >> >>> On Tue, May 9, 2017 at 9:03 PM, Andrea Del Bene < > an.delb...@gmail.com> > >> >>> wrote: > >> >>> > >> This is a vote to release Apache Wicket 7.7.0 > >> > >> Please download the source distributions found in our staging area > >> linked below. > >> > >> I have included the signatures for both the source archives. This > vote > >> lasts for 72 hours minimum. > >> > >> [ ] Yes, release Apache Wicket 7.7.0 > >> [ ] No, don't release Apache Wicket 7.7.0, because ... > >> > >> Distributions, changelog, keys and signatures can be found at: > >> > >> https://dist.apache.org/repos/dist/dev/wicket/7.7.0 > >> > >> Staging repository: > >> > >> https://repository.apache.org/content/repositories/ > >> orgapachewicket-1088 > >> > >> The binaries are available in the above link, as are a staging > >> repository for Maven. Typically the vote is on the source, but > should > >> you find a problem with one of the binaries, please let me know, I > can > >> re-roll them some way or the other. > >> > >> Staging git repository data: > >> > >> Repository: g...@github.com:bitstorm/wicket.git > >> Branch: build/wicket-7.7.0 > >> Release tag: rel/wicket-7.7.0 > >> > >> > >> > >> > >> > >> The signatures for the source release artefacts: > >> > >> > >> Signature for apache-wicket-7.7.0.zip: > >> > >> -BEGIN PGP SIGNATURE- > >> Version: GnuPG v1 > >> > >> iQIcBAABAgAGBQJZEg7fAAoJEAzCjx+CMhBVWHMP/2tk+LxB2PP9BAJJDkh8JiIN > >> grzS8RTDrZgTCc25x3KyBshgwvkHy/2dhz3Rc52v40H2tmBBivsf5ANtVzm3dIKX > >> LzH2/89HrZ8O+96IccllcuMTy7LFpJY8WEMv+eK0BYSQg3+87WfTPDBRGE8+sA3E > >> HjUHJDwVpTk+pH3wXNxiwaWx7/1yawqehjZbuAI2n8cIQXjnvqTwM4XdLSLHYeTU > >> cUjLeLVdqpQXjWXHUb275ZVnwNUnm7ioCxrjWupoKV2FzbZV/mWSZKAKUZVUqmA2 > >> tAHfmFRhDgUwapIDyYUghepZuEVA9VRunoE2TDLqHZoyn8wXlIncf1H+lOQe7EGC > >> R/IXuSPXuWbVRZEOOUPEbcDKI/x3tofVHGGkXJwOCoAbfGJ7Mc6vf1k4CrIUhNOu > >> uBmAyZ7Mj+zk5sxIJw/fWSp90lxBx3m45oKuTTa33fP+6vEvbXnL9HYv79x1GQCT > >> qccl8WVf57I0Er5HOWCU9Id/tX/2K34OWXOxWpfcRTjhRb42tBNsVqezlIEbl7n4 > >> bHFp+xBxqIXuXYfs5PlrKgZGgTr5id472laYoR47kqx6+CX2J4QTKQnByaJGxVa2 > >> /SiKz6RnbjEFa1sov/nbzatmT0y7mNgG40ss6g8G763UxbGgCeG6Q+xAJMMImNni > >> hKTl4G1xWOC+9We/yoWu > >> =Yw6d > >> -END PGP SIGNATURE- > >> > >> Signature for apache-wicket-7.7.0.tar.gz: > >> > >> -BEGIN PGP SIGNATURE- > >> Version: GnuPG v1 > >> > >> iQIcBAABAgAGBQJZEg7fAAoJEAzCjx+CMhBVX/8QAK9NRsGN6tCRxel0gpEevYkR > >> T8bHXt+chTjUZdFLODfA9YIRD7uVsJI5KCR0KETXQJrlXnYRyvSumQj1+hs6f7fM > >> cucJR+wbg+YnIQ9bYS58aQRRtDA9ClA0dE4b7PReLuSyeAzKdOtbH1YbtPmupW/D > >> Pl6zgOcUaLaIvhHj2ZMlaySmCSGPLZbZFgotS9C1Wsuc0r+T3NhZIqSCJqMhcDp5 > >> m35+PrGr3azz+yOa63+FtWbluT5ORLu/frRgQxR64lq+Ac2A1jz0X5/PJPlXoWO0 > >> gm8uJ+oYoBJgyTu+vqIbNwpKHQMWCCeChd8YlAmVO1s5YUi5EWCsyOE83DByEgA6 > >> 3sd9+Nj3JxqWjsTXhRO2J9qjSq3Wu1EIRFxbXV+cOYdXsNMpntZgMNKw4uB1MHDk > >> gd4/r/HigNfJfI0C8c0m6NqfVBNSestbjdKTCy4dT3JeaAPl9QyyjZmia2fHzzIm > >> u9yvf5MKc79xCyxWRpCS+Kg2hyq2fXQhyrPCWJxZmonMT0boVGAtJ/1ZJ6s7oSzJ > >> Rtm/9aVYKQEZwvff9hjWmF1T8ILLRmqaB+q35brTW2lZ9oit
Re: [VOTE] Release Apache Wicket 7.7.0
Andrea, please make sure to start from a clean thread for the new vote, like: [VOTE] Release Apache Wicket 7.7.0 (take 3) On Mon, May 8, 2017 at 11:34 PM, Sebastien wrote: > Hi Andrea, > > From what I can tell, the json library is now iso with the previous > integration (from the usage I'm making of, at least) > It could be great to add a special note to the vote call so user having an > intensive usage of (wicket-) json will be a great help by testing the > release... > > Thanks again :) > Sebastien. > > > > On Mon, May 8, 2017 at 11:05 PM, Sebastien wrote: > >> I will test it right know ! >> >> On Mon, May 8, 2017 at 10:55 PM, Andrea Del Bene >> wrote: >> >>> Hi Sebastien, >>> >>> the commit has been applied to branch 7.x. You can test 7.7.0-SNAPSHOT >>> or we can directly start a new release phase. >>> >>> Andrea. >>> >> >
Re: [VOTE] Release Apache Wicket 7.7.0
Hi Andrea, >From what I can tell, the json library is now iso with the previous integration (from the usage I'm making of, at least) It could be great to add a special note to the vote call so user having an intensive usage of (wicket-) json will be a great help by testing the release... Thanks again :) Sebastien. On Mon, May 8, 2017 at 11:05 PM, Sebastien wrote: > I will test it right know ! > > On Mon, May 8, 2017 at 10:55 PM, Andrea Del Bene > wrote: > >> Hi Sebastien, >> >> the commit has been applied to branch 7.x. You can test 7.7.0-SNAPSHOT or >> we can directly start a new release phase. >> >> Andrea. >> >
Re: [VOTE] Release Apache Wicket 7.7.0
I will test it right know ! On Mon, May 8, 2017 at 10:55 PM, Andrea Del Bene wrote: > Hi Sebastien, > > the commit has been applied to branch 7.x. You can test 7.7.0-SNAPSHOT or > we can directly start a new release phase. > > Andrea. >
Re: [VOTE] Release Apache Wicket 7.7.0
Hi Andrea, The issue is fixed in openjson, not committed to master yet but the diffpatch is here: https://github.com/openjson/openjson/commit/427087efb1c9d9d737cfbe237caf1c1812664a5c As soon the fix is picked in wicket-6 / wicket-7, we should be able to roll a new release... Thanks & best regards, Sebastien. On Sat, Apr 29, 2017 at 3:07 PM, Andrea Del Bene wrote: > This vote has been canceled. We are waiting for > https://github.com/openjson/openjson/issues/8 to be solved. > > > > On 23/04/2017 11:47, Sebastien wrote: > >> Hi Maxim, >> >> Here we are: https://github.com/openjson/openjson/issues/8 >> Hope the explanation in there makes my idea clearer! :) >> >> Thanks a lot, >> Sebastien. >> >> On Sun, Apr 23, 2017 at 5:47 AM, Maxim Solodovnik >> wrote: >> >> This is the thing I don't understand :( >>> >>> to/from string is standard way of serializing/deserializing JSONObject >>> The original issue was regarding JSONObject constructing from "Bean >>> instanceof JSONString" >>> It make sense, Bean provide desired method of "being JSONObject", we >>> should >>> use this method in constructor >>> >>> Maybe this discussion should be moved to github? so other openjson >>> contributors can participate? >>> >>> >
Re: [VOTE] Release Apache Wicket 7.7.0
Hi Maxim, Here we are: https://github.com/openjson/openjson/issues/8 Hope the explanation in there makes my idea clearer! :) Thanks a lot, Sebastien. On Sun, Apr 23, 2017 at 5:47 AM, Maxim Solodovnik wrote: > This is the thing I don't understand :( > > to/from string is standard way of serializing/deserializing JSONObject > The original issue was regarding JSONObject constructing from "Bean > instanceof JSONString" > It make sense, Bean provide desired method of "being JSONObject", we should > use this method in constructor > > Maybe this discussion should be moved to github? so other openjson > contributors can participate? >
Re: [VOTE] Release Apache Wicket 7.7.0
To me, toJSONString transform a bean a its json string representation, but the reciprocity is not true. That's a double edged question, I'm not sure we can guess the answer 100% right. Maybe we should see what/if the jsr says something about this... On Apr 22, 2017 16:07, "Maxim Solodovnik" wrote: Actually I thought toJSONString method is required to provide correct way of creating JSONObject from bean. In this case I see no reason why we should scan bean itself On Sat, Apr 22, 2017 at 9:04 PM, Sebastien wrote: > Hi Maxim, > > Actually there was 2 questions, that's why it was not clear :) > > 1/ About how to handle the stack overflow. I saw here [1] that you handle > "instanceof JSONString" in the ctor. My question was about the accuracy of > this. Should it be handled in the ctor like this, or should it be handled > in the toString method. I prefer the second method because new > JSONObject(bean) should handle real bean properties, not the properties > that may have been set manually in toJSONString > > 2/ API break about renaming package or method signature changes is one > thing. Silent breaks are something else. If it is documented, that's fine. > But if it can be avoided and keep compatibility... that's better IMO :) > > Thanks :) > Sebastien. > > [1] > https://github.com/openjson/openjson/commit/d2367f28cebd8f21c4a4e22faec4ca > b2f8a95982#diff-d1df85e7c46815227f1dcb2b4b08ab33R204 > -- WBR Maxim aka solomax
Re: [VOTE] Release Apache Wicket 7.7.0
Hi Maxim, Actually there was 2 questions, that's why it was not clear :) 1/ About how to handle the stack overflow. I saw here [1] that you handle "instanceof JSONString" in the ctor. My question was about the accuracy of this. Should it be handled in the ctor like this, or should it be handled in the toString method. I prefer the second method because new JSONObject(bean) should handle real bean properties, not the properties that may have been set manually in toJSONString 2/ API break about renaming package or method signature changes is one thing. Silent breaks are something else. If it is documented, that's fine. But if it can be avoided and keep compatibility... that's better IMO :) Thanks :) Sebastien. [1] https://github.com/openjson/openjson/commit/d2367f28cebd8f21c4a4e22faec4cab2f8a95982#diff-d1df85e7c46815227f1dcb2b4b08ab33R204
Re: [VOTE] Release Apache Wicket 7.7.0
Hi Maxim, Thanks for your prompt action :) This is also needed to be backported in wicket7.x / 6.x, but... Yes, about the test, it's a corner case that could logically leads to a stack overflow. But the fact is that it used to work like this before, that's why I included it in the test... Question: does the object need to process toJSONString at the ctor, or should it only copy existing properties and then call toJSONString on toString time. If the API does not behave like before, this will lead to a *silent* API break in wicket 6 &7... WDYT ? Thanks & best regards, Sebastien.
Re: [VOTE] Release Apache Wicket 7.7.0
Hi again,
The issue is that pojos implementing JSONString seems to not have their
#toJSONString called during JSONObject#toString
Looking at the code does not indicates an obvious reason, and for the weird
one I have some difficulties to debug (caught the JSONException block in
debug mode, probably due to the reflection, or maybe my eclipse is dying...)
Here is a simple test case for whom would like to have a look:
@Test
public void testToString()
{
MyPojo1 myPojo1 = new MyPojo1();
MyPojo2 myPojo2 = new MyPojo2();
String json1 = new JSONObject(myPojo1).toString();
String json2 = new JSONObject(myPojo2).toString(); // FIXME:
#toJSONString is never called
Assert.assertEquals(json1,
"{\"myProp1\":\"value1\",\"myProp2\":\"value2\"}");
Assert.assertEquals(json2,
"{\"myProp3\":\"value3\",\"myProp4\":\"value4\",\"myProp5\":\"value5\"}");
}
public static class MyPojo1
{
private String myProp1 = "value1";
private String myProp2 = "value2";
public MyPojo1()
{
}
public String getMyProp1()
{
return this.myProp1;
}
public String getMyProp2()
{
return this.myProp2;
}
}
public static class MyPojo2 implements JSONString
{
private String myProp3 = "value3";
private String myProp4 = "value4";
public MyPojo2()
{
}
public String getMyProp3()
{
return this.myProp3;
}
public String getMyProp4()
{
return this.myProp4;
}
@Override
public String toJSONString()
{
JSONObject object = new JSONObject(this);
object.put("myProp5", "value5");
return object.toString();
}
}
Best regards,
Sebastien.
On Fri, Apr 21, 2017 at 8:36 PM, Andrea Del Bene
wrote:
> Take your time. Better be sure to have fixed possible problems with json
> migration.
>
>
Re: [VOTE] Release Apache Wicket 7.7.0
Hi Andrea, hi devs, I think you will hate me for the delay! Moreover I'm requesting to hold the vote conclusion until further investigation: I have another issue with the JSON library (I could hardly detect it before the others issues was fixed) I'm trying to complete the investigation/test case by tonight. Thanks in advance, Sebastien.
Re: [VOTE] Release Apache Wicket 7.7.0
I will try to test out tonight! On Tue, Apr 18, 2017 at 1:33 AM, Martin Grigorov wrote: > [ X ] Yes, release Apache Wicket 7.7.0 > > Tested: > - build from source > - Wicket JQuery Selectors, Webjars && Bootstrap > - Build and stage WicketStuff > - my daily job main application > > Martin Grigorov > Wicket Training and Consulting > https://twitter.com/mtgrigorov > > On Sat, Apr 15, 2017 at 10:38 PM, Andrea Del Bene > wrote: > > > This is a vote to release Apache Wicket 7.7.0 > > > > Please download the source distributions found in our staging area > > linked below. > > > > I have included the signatures for both the source archives. This vote > > lasts for 72 hours minimum. > > > > [ ] Yes, release Apache Wicket 7.7.0 > > [ ] No, don't release Apache Wicket 7.7.0, because ... > > > > Distributions, changelog, keys and signatures can be found at: > > > > https://dist.apache.org/repos/dist/dev/wicket/7.7.0 > > > > Staging repository: > > > > https://repository.apache.org/content/repositories/orgapachewicket-1087 > > >
Re: [VOTE] Release Apache Wicket 7.7.0
Hi Maxim, Andrea, Sorry for the late answer! @maxim: I've tested against wicket8.x (openjson, lastest snapshot) and it seems to be all right! Thanks! @andrea, I've tested against wicket7.x (7.7.0-SNAPSHOT, from bitstrom/wicket) and it also works, well done! :) Best regards, Sebastien.
Re: Question regarding new AjaxDownload (WICKET-6286)
Then, set the content type to text/html so see if the filename is correct in that case. On Wed, Apr 12, 2017 at 11:44 AM, Maxim Solodovnik wrote: > In case I'm setting file name to "backp.zip.html" the file is being > downloaded as .zip > I guess "zip" is being set from content type > File name is just ignored > > On Wed, Apr 12, 2017 at 4:38 PM, Sebastien wrote: > > > I know, it's just to test the filename... > > > > On Wed, Apr 12, 2017 at 11:29 AM, Maxim Solodovnik > > > wrote: > > > > > But I need zip extension, otherwise it will be unusable > > > > > > On Wed, Apr 12, 2017 at 4:27 PM, Sebastien wrote: > > > > > > > I did the same problem recently (I still have to answer Sven about > > this, > > > I > > > > will do it soon) > > > > Try out changing your extension to ".html" to see if it's the same > > > > behavior, maybe it will help you to investigate further. (in my case, > > > "csv" > > > > had issue with the filename and "html" was fine) > > > > > > > > > > > > > > > > -- > > > WBR > > > Maxim aka solomax > > > > > > > > > -- > WBR > Maxim aka solomax >
Re: Question regarding new AjaxDownload (WICKET-6286)
I know, it's just to test the filename... On Wed, Apr 12, 2017 at 11:29 AM, Maxim Solodovnik wrote: > But I need zip extension, otherwise it will be unusable > > On Wed, Apr 12, 2017 at 4:27 PM, Sebastien wrote: > > > I did the same problem recently (I still have to answer Sven about this, > I > > will do it soon) > > Try out changing your extension to ".html" to see if it's the same > > behavior, maybe it will help you to investigate further. (in my case, > "csv" > > had issue with the filename and "html" was fine) > > > > > > -- > WBR > Maxim aka solomax >
Re: Question regarding new AjaxDownload (WICKET-6286)
I did the same problem recently (I still have to answer Sven about this, I will do it soon) Try out changing your extension to ".html" to see if it's the same behavior, maybe it will help you to investigate further. (in my case, "csv" had issue with the filename and "html" was fine)
Re: [VOTE] Release Apache Wicket 7.7.0
Thanks a lot Andrea, I will try to compile and test over week-end!
Re: AjaxDownload with IRequestHandler / IResourceStream
You made my day, Sven! I tested it and it works! :) I have 2 comments: 1/ > With this lazy creation of the stream, it is not necessary to hold it in the component tree. Not sure I understood what you meant but the ajax download still need to be hold in the component tree right? As it is an AjaxBehavior, I do not figure out how it can work otherwise.. 2/ The content-type is supplied to the (Abstract)ResourceStreamWriter as text/csv. It works too - I can download it - but whatever the filename I provide to the ResourceStreamResource, the download dialog always suggest ".csv" (no filename, only the extension). Weird, I have to dig into this... Thanks again & best regards, Sebastien.
Re: [VOTE] Release Apache Wicket 7.7.0
Just to be clear, https://github.com/openjson/openjson/issues/7 is about a different issue for wicket8 Both issue are related to json and to nulls - wicket-8: about not rendering null *values* properties - wicket-6/7: JSONObject#wrap does not take Object type into account and then leads to rendering null *object*. @maxim : does the openjson/issue/7 also fix the second issue ? In that case I missed it... In my mind, the code was located in wicket. Thanks & best regards, Sebastien. On Fri, Apr 7, 2017 at 1:20 PM, Andrea Del Bene wrote: > I did it for 7.x I will share the branch as soon as I return from lunch :-) > > On 7 Apr 2017 13:05, "Maxim Solodovnik" wrote: > > > The fix need to be merged into wicket7 (and wicket6?) > > > > On Fri, Apr 7, 2017 at 5:33 PM, Tobias Soloschenko < > > tobiassolosche...@googlemail.com> wrote: > > > > > Thanks a ton! > > > > > > kind regards > > > > > > Tobias > > > > > > > Am 07.04.2017 um 12:20 schrieb Martin Grigorov >: > > > > > > > > Hi Tobias, > > > > > > > > Maxim, Mikhail, Sebastien and Andrea already worked it out: > > > > https://github.com/openjson/openjson/issues/7 > > > > > > > > Martin Grigorov > > > > Wicket Training and Consulting > > > > https://twitter.com/mtgrigorov > > > > > > > > On Fri, Apr 7, 2017 at 11:05 AM, Tobias Soloschenko < > > > > tobiassolosche...@googlemail.com> wrote: > > > > > > > >> Hi all, > > > >> > > > >> I just don't have any time currently to take care about the JSON > > issue. > > > >> Can someone take over it? > > > >> > > > >> Thanks a lot for the investigation Sebastien! > > > >> > > > >> kind regards > > > >> > > > >> Tobias > > > >> > > > >>> Am 04.04.2017 um 11:12 schrieb Andrea Del Bene < > an.delb...@gmail.com > > >: > > > >>> > > > >>> My bad, dont worry :) > > > >>> > > > >>>> On Tue, Apr 4, 2017 at 11:09 AM, Sebastien > > wrote: > > > >>>> > > > >>>> Hi Andrea, > > > >>>> > > > >>>> Sorry if my comment was confusing. The code has to be fixed in > > wicket > > > >>>> itself as it ports the json implementation. > > > >>>> https://github.com/openjson/openjson/issues/7 is for wicket8 > > because > > > it > > > >>>> directly uses it. > > > >>>> > > > >>>> Best regards, > > > >>>> Sebastien. > > > >>>> > > > >>>> > > > >>>> On Tue, Apr 4, 2017 at 10:58 AM, Andrea Del Bene < > > > an.delb...@gmail.com> > > > >>>> wrote: > > > >>>> > > > >>>>> Ok, > > > >>>>> > > > >>>>> This vote has been cancelled. I'll re-roll the release when > > > >>>>> https://github.com/openjson/openjson/issues/7 will be closed and > > > >>>> released. > > > >>>>> > > > >>>>>> On Sun, Apr 2, 2017 at 6:13 PM, Sebastien > > wrote: > > > >>>>>> > > > >>>>>> [x] No, don't release Apache Wicket 7.7.0 > > > >>>>>> > > > >>>>>> There is a regression with the new json integration: calling > > > >>>>>> JSONArray(Collection copyFrom) with a list of Objects leads > to > > > >>>> putting > > > >>>>>> nulls in the underlying list (JSONObject#wrap seems to not take > > > Object > > > >>>>> type > > > >>>>>> into account) > > > >>>>>> > > > >>>>> > > > >>>> > > > >> > > > > > > > > > > > -- > > WBR > > Maxim aka solomax > > >
Re: [VOTE] Release Apache Wicket 7.7.0
Hi Andrea, Sorry if my comment was confusing. The code has to be fixed in wicket itself as it ports the json implementation. https://github.com/openjson/openjson/issues/7 is for wicket8 because it directly uses it. Best regards, Sebastien. On Tue, Apr 4, 2017 at 10:58 AM, Andrea Del Bene wrote: > Ok, > > This vote has been cancelled. I'll re-roll the release when > https://github.com/openjson/openjson/issues/7 will be closed and released. > > On Sun, Apr 2, 2017 at 6:13 PM, Sebastien wrote: > > > [x] No, don't release Apache Wicket 7.7.0 > > > > There is a regression with the new json integration: calling > > JSONArray(Collection copyFrom) with a list of Objects leads to putting > > nulls in the underlying list (JSONObject#wrap seems to not take Object > type > > into account) > > >
Re: [VOTE] Proposal to remove IDetachable from IModel hierarchy
[x] No, keep IModel detachable Even I understand Pedro's concern, Emond raised one of the most important point here: detaching is entirely part of the model life-cycle.
Re: [VOTE] Release Apache Wicket 6.27.0
[x] No, don't release Apache Wicket 6.27.0, because... There is a regression with the new json integration: calling JSONArray(Collection copyFrom) with a list of Objects leads to putting nulls in the underlying list (JSONObject#wrap seems to not take Object type into account)
Re: [VOTE] Release Apache Wicket 7.7.0
[x] No, don't release Apache Wicket 7.7.0 There is a regression with the new json integration: calling JSONArray(Collection copyFrom) with a list of Objects leads to putting nulls in the underlying list (JSONObject#wrap seems to not take Object type into account)
Re: AjaxDownload with IRequestHandler / IResourceStream
Thank you very much Sven !
Yes I prefer to work with IResourceStream because the my export feature
(took from Wicket) already works this way, it just need to be ajaxified ;)
That looks nice! I somehow missed the ResourceStreamResource... I will give
a try in the coming days.
Best regards,
Sebastien.
On Sat, Apr 1, 2017 at 11:10 PM, Sven Meier wrote:
> Hi Sebastien,
>
> AjaxDownload uses IResource and ResourceReference as ResourceLink does it
> - IMO these are the most general abstractions for resources in Wicket.
>
> If you prefer to work with an IResourceStream, you can pass a
> ResourceStreamResource to AjaxDownload's constructor:
>
> new AjaxDownload(new ResourceStreamResource() {
> {
> setFileName("myfilename");
> setContentDisposition(ContentDisposition.ATTACHMENT);
> }
> protected IResourceStream getResourceStream(Attributes attributes) {
> return new DataExporterResourceStreamWriter(new
> CSVDataExporter(), provider, columns);
> }
> });
>
> With this lazy creation of the stream, it is not necessary to hold it in
> the component tree.
>
> Have fun
> Sven
>
Wicket 8 next for next release cycle?
Hi dev, I'm was wondering of we are soon ready for Wicket 8.0.0? We already issued 5 milestones, do we need to wait for some features to be still tested (like the new org.json for instance?) or some others that might break to API? Otherwise it would be nice to get a "8" cycle, like 8.0.0, 7.8.0, 6.28.0 :) WDYT ? Best regards, Sebastien
AjaxDownload with IRequestHandler / IResourceStream
Hi devs, I was wondering if would be possible to change the AjaxDownload a bit so it works with IRequestHandler or IResourceStream. Maybe something like this: AjaxDownload download = new AjaxDownload(); (...) IResourceStream stream = new DataExporterResourceStreamWriter(new CSVDataExporter(), provider, columns); download.initiate(target, stream, "myfilename") or IResourceStream stream = new DataExporterResourceStreamWriter(new CSVDataExporter(), provider, columns); IRequestHandler handler = new ResourceStreamRequestHandler(stream, filename)); download.initiate(target, handler) Thanks in advance & best regards, Sebastien.
Re: [VOTE] Release Apache Wicket 8.0.0-M5
[x] Yes, release Apache Wicket 8.0.0-M5
Re: wicket 8 m5?
+1 to release too On Thu, Mar 23, 2017 at 9:42 AM, Martin Grigorov wrote: > Hi, > > The changes so far are: > https://issues.apache.org/jira/issues/?jql=project%20%3D%20WICKET%20AND% > 20fixVersion%20%3D%208.0.0-M5 > Maybe the JSON.org issue is something major. All others are either bug > fixes or improvements. > 8.0.0-M4 has been release at Feb 13, so I agree it is time to make a new > release! > > Martin Grigorov > Wicket Training and Consulting > https://twitter.com/mtgrigorov > > On Thu, Mar 23, 2017 at 9:21 AM, Korbinian Bachl < > korbinian.ba...@whiskyworld.de> wrote: > > > Hi, > > > > is it planned to have a 8-m5 anytime soon? I ask because quite much > > changed (e.g.: BookmarkableListenerRequestHandler, other JSON) and I > > really had some time keeping up the current snapshot builds with my > project. > > > > Also, any idea when can wicket-8.0 be expected? > > > > Best, > > > > Korbinian > > >
Re: Use jQuery 3.x by default in 8.x
Hi Korbinian, Basically you are right : now vanilla js can almost replace jQuery (and that's a trending as far as I can read). But from my point of view, jQuery is more convenient to use and still has the responsibility of the cross browser compatibility (what Wicket has suffered before opting for jQuery) One more important point: several integrations relies on jQuery like jQuery UI, Kendo UI and Bootstrap (and I will not shoot myself in the foot voting for a replacement :)). Best regards, Sebastien.
Re: Use jQuery 3.x by default in 8.x
+1 too! On Mon, Mar 20, 2017 at 10:01 AM, Emond Papegaaij < emond.papega...@topicus.nl> wrote: > Agreed, +1 for 3.x > > Emond > > On maandag 20 maart 2017 09:52:17 CET Martin Grigorov wrote: > > Hi, > > > > It is 14 months since Microsoft droppped the support for IE 10 and less > [0]. > > Do you agree that it is OK to use jQuery 3.x in Wicket 8.x by default ? > > > > Applications will still be able to set custom version (like 1.x) if they > > need so. > > Also our JS tests will keep testing against jQuery 1.x, 2.x and 3.x [1]. > > > > 0. https://www.microsoft.com/en-us/WindowsForBusiness/End-of-IE-support > > 1. > > https://github.com/apache/wicket/blob/1421ea2dc9207143cdadb735f3c794 > 21674d92 > > 4d/testing/wicket-js-tests/Gruntfile.js#L111-L118 > > > > Martin Grigorov > > Wicket Training and Consulting > > https://twitter.com/mtgrigorov > > >
Re: 8.0.0-M4: org.json has issue with List
Hi Martin, Thanks a lot for the quick update! From what I can see it seems to be good! :) Best regards, Sebastien On Mon, Mar 13, 2017 at 9:10 PM, Martin Grigorov wrote: > Hi Sebastien, > > As you may have noticed I've updated the version of OpenJson to 1.0.1 with > the fix by Mikhail. > I'll check whether something has to be done for 6.x and 7.x tomorrow. > > Martin Grigorov > Wicket Training and Consulting > https://twitter.com/mtgrigorov > > On Mon, Mar 13, 2017 at 10:04 AM, Martin Grigorov > wrote: > > > Hi, > > > > Since recently [1] in 8.x we now use the fork with improvements at > > https://github.com/openjson/openjson > > Ted Dunning's impl fails badly if the original org.json library is needed > > as transitive dependency. > > > > IMO we should update the copies in 6.x/7.x with the classes from > > https://github.com/openjson/openjson as well. To keep 6.x, 7.x and 8.x > as > > close as possible. > > > > 1. https://issues.apache.org/jira/browse/WICKET-6329 > > > > Martin Grigorov > > Wicket Training and Consulting > > https://twitter.com/mtgrigorov > > > > On Sun, Mar 12, 2017 at 8:51 PM, Sebastien wrote: > > > >> Hi devs, > >> > >> The new underlying json library (open-json from tdunning) does not > convert > >> List properly (there are converted to String) [1] > >> > >> I didn't have seen where in Wicket we are returning a converted List in > a > >> json response, but I prefer you are aware :) > >> > >> Best regards, > >> Sebastien. > >> > >> [1] https://github.com/tdunning/open-json/issues/12 > >> > > > > >
8.0.0-M4: org.json has issue with List
Hi devs, The new underlying json library (open-json from tdunning) does not convert List properly (there are converted to String) [1] I didn't have seen where in Wicket we are returning a converted List in a json response, but I prefer you are aware :) Best regards, Sebastien. [1] https://github.com/tdunning/open-json/issues/12
Re: Escaping of DialogButton text
Hi Maxim,
Right! Do not exactly how I missed that... :-/
I've fixed it, the snapshot is on its way!
Thanks & best regards,
Sebastien.
On Sat, Feb 25, 2017 at 6:30 AM, Maxim Solodovnik
wrote:
> Hello Sebastien,
>
> It seems DialogButton text is not properly escaped (8.0.0-M4)
>
> new DialogButton("upload", "Démarrer l'importation", false)
>
> The following dialog button results JS error on client.
> I believe the text need to be escaped inside wicket-jquery-ui
>
> I can provide PR :)
>
> --
> WBR
> Maxim aka solomax
>
Re: wicketstuff/wicket-jquery-ui M4 release
Hi Maxim, Wicket jQuery UI 8.0.0-M4 is on its way to maven central! Enjoy, Sebastien. On Wed, Feb 8, 2017 at 4:05 AM, Maxim Solodovnik wrote: > Hello Martin, Sebastien, > > Could you please release wicketstuff/wicket-jquery-ui M4? > > I have fixed one minor issue in wicketstuff and build was successful for > me :) > > -- > WBR > Maxim aka solomax >
