Wicket Stuff commit access
Hi, I am looking to contribute in wicketstuff,need commit access for that... github username : vineetsemwal Thanks ! -- Freelance developer of web,mobile apps Vineet Semwal
wicketstuff branches query
Hi, For wickstuff : Are following the branches to which i should push changes ? 8.x remotes/origin/wicket-8.x 7.x remotes/origin/wicket-7.x 6.x remotes/origin/wicket-6.x yesterday i did git push origin local8x:remotes/origin/wicket-8.x is my workflow ok ? Thanks ! -- Freelance developer of web,mobile apps Vineet Semwal
Re: wicketstuff branches query
i see... ,i should have done git push origin local8x:wicket-8.x ? Thanks ! On Mon, Dec 24, 2018 at 12:35 PM Maxim Solodovnik wrote: > I believe all enhancements should go to `wicket-8.x` and master > > On Mon, 24 Dec 2018 at 13:27, vineet semwal > wrote: > > > > Hi, > > For wickstuff : Are following the branches to which i should push > changes ? > > 8.x remotes/origin/wicket-8.x > > 7.x remotes/origin/wicket-7.x > > 6.x remotes/origin/wicket-6.x > > > > yesterday i did git push origin local8x:remotes/origin/wicket-8.x > > is my workflow ok ? > > > > Thanks ! > > -- > > Freelance developer of web,mobile apps > > Vineet Semwal > > > > -- > WBR > Maxim aka solomax > -- Freelance developer of web,mobile apps Vineet Semwal
Re: wicketstuff branches query
Thank you martin,i understand now..yeah i will push in master branch too.. On Mon, 24 Dec 2018 18:59 Martin Grigorov Hi Vineet, > > I think all you need is: > $ git checkout local8x > $ edit files > $ git commit -a -m "did something cool" > $ git push > > "git push" will push local8x to its remote, which I suppose is wicket-8.x. > You can check this in ./.git/config file. > > But please also merge your changes to 'master' branch. Otherwise your > module (quickview) will not be released with Wicket 9 when it is released. > > On Mon, Dec 24, 2018 at 11:11 AM vineet semwal > wrote: > > > i see... ,i should have done git push origin local8x:wicket-8.x ? > > > > Thanks ! > > > > On Mon, Dec 24, 2018 at 12:35 PM Maxim Solodovnik > > wrote: > > > > > I believe all enhancements should go to `wicket-8.x` and master > > > > > > On Mon, 24 Dec 2018 at 13:27, vineet semwal > > > wrote: > > > > > > > > Hi, > > > > For wickstuff : Are following the branches to which i should push > > > changes ? > > > > 8.x remotes/origin/wicket-8.x > > > > 7.x remotes/origin/wicket-7.x > > > > 6.x remotes/origin/wicket-6.x > > > > > > > > yesterday i did git push origin local8x:remotes/origin/wicket-8.x > > > > is my workflow ok ? > > > > > > > > Thanks ! > > > > -- > > > > Freelance developer of web,mobile apps > > > > Vineet Semwal > > > > > > > > > > > > -- > > > WBR > > > Maxim aka solomax > > > > > > > > > -- > > Freelance developer of web,mobile apps > > Vineet Semwal > > >
Re: wicketstuff branches query
Thank you Maxim,i assumed yesterday that git push origin local:remotes/origin/wicket-8.x will push to wicket-8.x branch, instead it pushed a new branch at remote.. today i pushed to wicket-8.x correctly... On Mon, 24 Dec 2018 20:47 Maxim Solodovnik Hello Vineet, > > It seems you commit > to > remotes/origin/wicket-8.x > and to > wicket-8.x > > every commit trigger build, you can check it here: > https://travis-ci.org/wicketstuff/core/branches :)) > > On Mon, 24 Dec 2018 at 21:11, vineet semwal > wrote: > > > > Thank you martin,i understand now..yeah i will push in master branch > too.. > > > > > > > > On Mon, 24 Dec 2018 18:59 Martin Grigorov > > > > Hi Vineet, > > > > > > I think all you need is: > > > $ git checkout local8x > > > $ edit files > > > $ git commit -a -m "did something cool" > > > $ git push > > > > > > "git push" will push local8x to its remote, which I suppose is > wicket-8.x. > > > You can check this in ./.git/config file. > > > > > > But please also merge your changes to 'master' branch. Otherwise your > > > module (quickview) will not be released with Wicket 9 when it is > released. > > > > > > On Mon, Dec 24, 2018 at 11:11 AM vineet semwal < > vineetsemwa...@gmail.com> > > > wrote: > > > > > > > i see... ,i should have done git push origin local8x:wicket-8.x ? > > > > > > > > Thanks ! > > > > > > > > On Mon, Dec 24, 2018 at 12:35 PM Maxim Solodovnik < > solomax...@gmail.com> > > > > wrote: > > > > > > > > > I believe all enhancements should go to `wicket-8.x` and master > > > > > > > > > > On Mon, 24 Dec 2018 at 13:27, vineet semwal < > vineetsemwa...@gmail.com> > > > > > wrote: > > > > > > > > > > > > Hi, > > > > > > For wickstuff : Are following the branches to which i should push > > > > > changes ? > > > > > > 8.x remotes/origin/wicket-8.x > > > > > > 7.x remotes/origin/wicket-7.x > > > > > > 6.x remotes/origin/wicket-6.x > > > > > > > > > > > > yesterday i did git push origin local8x:remotes/origin/wicket-8.x > > > > > > is my workflow ok ? > > > > > > > > > > > > Thanks ! > > > > > > -- > > > > > > Freelance developer of web,mobile apps > > > > > > Vineet Semwal > > > > > > > > > > > > > > > > > > > > -- > > > > > WBR > > > > > Maxim aka solomax > > > > > > > > > > > > > > > > > -- > > > > Freelance developer of web,mobile apps > > > > Vineet Semwal > > > > > > > > > > > -- > WBR > Maxim aka solomax >
Re: wicketstuff branches query
Thank you maxim .. On Tue, Dec 25, 2018 at 3:04 PM Maxim Solodovnik wrote: > I'm fixing wicketstuff-core:master build failures right now (was caused by > wicket code clean-up) > > On Tue, 25 Dec 2018 at 01:20, vineet semwal > wrote: > > > Thank you Maxim,i assumed yesterday that > > git push origin local:remotes/origin/wicket-8.x > > will push to wicket-8.x branch, instead it pushed a new branch at > remote.. > > today i pushed to wicket-8.x correctly... > > > > > > On Mon, 24 Dec 2018 20:47 Maxim Solodovnik > > > > Hello Vineet, > > > > > > It seems you commit > > > to > > > remotes/origin/wicket-8.x > > > and to > > > wicket-8.x > > > > > > every commit trigger build, you can check it here: > > > https://travis-ci.org/wicketstuff/core/branches :)) > > > > > > On Mon, 24 Dec 2018 at 21:11, vineet semwal > > > wrote: > > > > > > > > Thank you martin,i understand now..yeah i will push in master branch > > > too.. > > > > > > > > > > > > > > > > On Mon, 24 Dec 2018 18:59 Martin Grigorov wrote: > > > > > > > > > Hi Vineet, > > > > > > > > > > I think all you need is: > > > > > $ git checkout local8x > > > > > $ edit files > > > > > $ git commit -a -m "did something cool" > > > > > $ git push > > > > > > > > > > "git push" will push local8x to its remote, which I suppose is > > > wicket-8.x. > > > > > You can check this in ./.git/config file. > > > > > > > > > > But please also merge your changes to 'master' branch. Otherwise > your > > > > > module (quickview) will not be released with Wicket 9 when it is > > > released. > > > > > > > > > > On Mon, Dec 24, 2018 at 11:11 AM vineet semwal < > > > vineetsemwa...@gmail.com> > > > > > wrote: > > > > > > > > > > > i see... ,i should have done git push origin > local8x:wicket-8.x ? > > > > > > > > > > > > Thanks ! > > > > > > > > > > > > On Mon, Dec 24, 2018 at 12:35 PM Maxim Solodovnik < > > > solomax...@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > I believe all enhancements should go to `wicket-8.x` and master > > > > > > > > > > > > > > On Mon, 24 Dec 2018 at 13:27, vineet semwal < > > > vineetsemwa...@gmail.com> > > > > > > > wrote: > > > > > > > > > > > > > > > > Hi, > > > > > > > > For wickstuff : Are following the branches to which i should > > push > > > > > > > changes ? > > > > > > > > 8.x remotes/origin/wicket-8.x > > > > > > > > 7.x remotes/origin/wicket-7.x > > > > > > > > 6.x remotes/origin/wicket-6.x > > > > > > > > > > > > > > > > yesterday i did git push origin > > local8x:remotes/origin/wicket-8.x > > > > > > > > is my workflow ok ? > > > > > > > > > > > > > > > > Thanks ! > > > > > > > > -- > > > > > > > > Freelance developer of web,mobile apps > > > > > > > > Vineet Semwal > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > WBR > > > > > > > Maxim aka solomax > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Freelance developer of web,mobile apps > > > > > > Vineet Semwal > > > > > > > > > > > > > > > > > > > > > > > -- > > > WBR > > > Maxim aka solomax > > > > > > > > -- > WBR > Maxim aka solomax > -- Freelance developer of web,mobile apps Vineet Semwal
