[GitHub] wicket issue #269: [WICKET-6544] mobile browser detection is improved
Github user solomax commented on the issue: https://github.com/apache/wicket/pull/269 OK, let's close this one :) ---
[GitHub] wicket issue #269: [WICKET-6544] mobile browser detection is improved
Github user klopfdreh commented on the issue: https://github.com/apache/wicket/pull/269 Close this one in favour of the mentioned one? (https://github.com/apache/wicket/pull/275) ---
[GitHub] wicket issue #269: [WICKET-6544] mobile browser detection is improved
Github user klopfdreh commented on the issue: https://github.com/apache/wicket/pull/269 See my suggestion over here: https://github.com/apache/wicket/pull/269 ---
[GitHub] wicket issue #269: [WICKET-6544] mobile browser detection is improved
Github user klopfdreh commented on the issue: https://github.com/apache/wicket/pull/269 In my opinion and because of such a big pool of browsers I would say yes. ---
[GitHub] wicket issue #269: [WICKET-6544] mobile browser detection is improved
Github user svenmeier commented on the issue: https://github.com/apache/wicket/pull/269 Guys I get it, there are many good solutions to choose from, but why should we make Wicket dependent on anyone of them? https://github.com/nielsbasjes/yauaa looks good, but do users really need assistance for this? `UserAgent userAgent = analyzer.parse(new WebClientInfo(requestCycle).getUserAgent());` ---
[GitHub] wicket issue #269: [WICKET-6544] mobile browser detection is improved
Github user klopfdreh commented on the issue: https://github.com/apache/wicket/pull/269 I also looked a bit around and stumbled over Apache DeviceMap which has been moved into the Attic and from the Attic (http://attic.apache.org/projects/devicemap.html) I followed the link to https://github.com/nielsbasjes/yauaa which seems to be maintained. @kbachl - I understand your suggestion to remove it because of reliability, but I would keep the functionality with the hint that there might be some not supported browsers which is better than no detection. ---
[GitHub] wicket issue #269: [WICKET-6544] mobile browser detection is improved
Github user martin-g commented on the issue: https://github.com/apache/wicket/pull/269 With the addition of these new mobile browsers user agent strings the code becomes more complex. Maybe we should think in direction how to make use of external libraries to do this checks, e.g. https://github.com/pieroxy/java-user-agent-detection or https://github.com/HaraldWalker/user-agent-utils ---
