[GitHub] wicket pull request: Example to run Arquillian with Wicket.

2015-06-23 Thread martin-g
Github user martin-g commented on the pull request:

https://github.com/apache/wicket/pull/129#issuecomment-114495547
  
The example/demo/test will be part of Wicket from now on so we have to 
adapt it (package names, versions, etc.).
I guess the example will be only in 7.x but the just improvement in 
BaseWicketTester will be in 6.x as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] wicket pull request: Example to run Arquillian with Wicket.

2015-06-23 Thread felipecalmeida
Github user felipecalmeida commented on a diff in the pull request:

https://github.com/apache/wicket/pull/129#discussion_r33039123
  
--- Diff: testing/wicket-arquillian/pom.xml ---
@@ -0,0 +1,345 @@
+?xml version=1.0?
+!-- JBoss, Home of Professional Open Source Copyright 2013, Red Hat, Inc. 
+   and/or its affiliates, and individual contributors by the @authors tag. 
See 
+   the copyright.txt in the distribution for a full listing of individual 
contributors. 
+   Licensed under the Apache License, Version 2.0 (the License); you may 
not 
+   use this file except in compliance with the License. You may obtain a 
copy 
+   of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless 
required 
+   by applicable law or agreed to in writing, software distributed under 
the 
+   License is distributed on an AS IS BASIS, WITHOUT WARRANTIES OR 
CONDITIONS 
+   OF ANY KIND, either express or implied. See the License for the 
specific 
+   language governing permissions and limitations under the License. --
+project xmlns=http://maven.apache.org/POM/4.0.0; 
xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
+   xsi:schemaLocation=http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;
+   modelVersion4.0.0/modelVersion
+
+   groupIdorg.wildfly.quickstarts/groupId
--- End diff --

Ok, I think so it is enough for a while. Later if you need more to help 
better I can do the changes.
I'm working on the changes now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] wicket pull request: Example to run Arquillian with Wicket.

2015-06-23 Thread felipecalmeida
Github user felipecalmeida commented on the pull request:

https://github.com/apache/wicket/pull/129#issuecomment-114494051
  
Hi Martin,
Thank's for these suggestions.

Ok, I understand now. I thougth that I've just to PR the example and not 
everything.
I'm going to change everything as you suggested.
But are the merges then going to be replicate to wicket 6.x and another 
versions? Here in my projects I'm using yet wicket 6.x.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] wicket pull request: Example to run Arquillian with Wicket.

2015-06-23 Thread martin-g
Github user martin-g commented on a diff in the pull request:

https://github.com/apache/wicket/pull/129#discussion_r33038416
  
--- Diff: testing/wicket-arquillian/pom.xml ---
@@ -0,0 +1,345 @@
+?xml version=1.0?
+!-- JBoss, Home of Professional Open Source Copyright 2013, Red Hat, Inc. 
+   and/or its affiliates, and individual contributors by the @authors tag. 
See 
+   the copyright.txt in the distribution for a full listing of individual 
contributors. 
+   Licensed under the Apache License, Version 2.0 (the License); you may 
not 
+   use this file except in compliance with the License. You may obtain a 
copy 
+   of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless 
required 
+   by applicable law or agreed to in writing, software distributed under 
the 
+   License is distributed on an AS IS BASIS, WITHOUT WARRANTIES OR 
CONDITIONS 
+   OF ANY KIND, either express or implied. See the License for the 
specific 
+   language governing permissions and limitations under the License. --
+project xmlns=http://maven.apache.org/POM/4.0.0; 
xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
+   xsi:schemaLocation=http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;
+   modelVersion4.0.0/modelVersion
+
+   groupIdorg.wildfly.quickstarts/groupId
--- End diff --

The smaller the test/demo, the better!
I'd prefer if there is no code that is not needed for the Wicket 
integration.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] wicket pull request: Example to run Arquillian with Wicket.

2015-06-23 Thread felipecalmeida
Github user felipecalmeida commented on a diff in the pull request:

https://github.com/apache/wicket/pull/129#discussion_r33037792
  
--- Diff: testing/wicket-arquillian/pom.xml ---
@@ -0,0 +1,345 @@
+?xml version=1.0?
+!-- JBoss, Home of Professional Open Source Copyright 2013, Red Hat, Inc. 
+   and/or its affiliates, and individual contributors by the @authors tag. 
See 
+   the copyright.txt in the distribution for a full listing of individual 
contributors. 
+   Licensed under the Apache License, Version 2.0 (the License); you may 
not 
+   use this file except in compliance with the License. You may obtain a 
copy 
+   of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless 
required 
+   by applicable law or agreed to in writing, software distributed under 
the 
+   License is distributed on an AS IS BASIS, WITHOUT WARRANTIES OR 
CONDITIONS 
+   OF ANY KIND, either express or implied. See the License for the 
specific 
+   language governing permissions and limitations under the License. --
+project xmlns=http://maven.apache.org/POM/4.0.0; 
xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
+   xsi:schemaLocation=http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;
+   modelVersion4.0.0/modelVersion
+
+   groupIdorg.wildfly.quickstarts/groupId
--- End diff --

I didn't do a whole test, testing the entities and DAO and etc.
What I did is just the test to verify where the BaseWicketTester is or is 
not providing the ServletContext.
Would you like to me to do a complete test or is it fine?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] wicket pull request: Example to run Arquillian with Wicket.

2015-06-23 Thread felipecalmeida
Github user felipecalmeida commented on the pull request:

https://github.com/apache/wicket/pull/129#issuecomment-114519411
  
Do I have to change the Header license? Actual is:

{code}
!--
JBoss, Home of Professional Open Source
Copyright 2013, Red Hat, Inc. and/or its affiliates, and individual
contributors by the @authors tag. See the copyright.txt in the
distribution for a full listing of individual contributors.

Licensed under the Apache License, Version 2.0 (the License);
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an AS IS BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
--
{code}


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] wicket pull request: Example to run Arquillian with Wicket.

2015-06-23 Thread felipecalmeida
Github user felipecalmeida commented on the pull request:

https://github.com/apache/wicket/pull/129#issuecomment-114594960
  
Done! I hope that's all.
If you need more information just send.
Thank's.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] wicket pull request: Example to run Arquillian with Wicket.

2015-06-23 Thread martin-g
Github user martin-g commented on a diff in the pull request:

https://github.com/apache/wicket/pull/129#discussion_r33015039
  
--- Diff: testing/wicket-arquillian/README.md ---
@@ -0,0 +1,89 @@
+wicket-war: Wicket Framework used in a WAR.
+===
+Author: Ondrej Zizka ozi...@redhat.com
+Level: Intermediate
+Technologies: Apache Wicket, JPA
+Summary: Demonstrates how to use the Wicket Framework 1.5 with the JBoss 
server using the Wicket-Stuff Java EE integration packaged as a WAR
+Target Project: WildFly
+Source: https://github.com/wildfly/quickstart/
+
+What is it?
+---
+
+This is an example of how to use Wicket Framework 1.5 with WildFly, 
leveraging features of Java EE 7, using the Wicket-Stuff Java EE integration.
--- End diff --

We should use Wicket 7.x


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] wicket pull request: Example to run Arquillian with Wicket.

2015-06-23 Thread martin-g
Github user martin-g commented on a diff in the pull request:

https://github.com/apache/wicket/pull/129#discussion_r33015273
  
--- Diff: testing/wicket-arquillian/src/test/resources/arquillian.xml ---
@@ -0,0 +1,22 @@
+?xml version=1.0 encoding=UTF-8?
+arquillian xmlns=http://jboss.org/schema/arquillian;
+xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
+xsi:schemaLocation=http://jboss.org/schema/arquillian 
http://jboss.org/schema/arquillian/arquillian_1_0.xsd;
+
+defaultProtocol type=Servlet 3.0 /
+engine
+property name=deploymentExportPathtarget/property
+/engine
+
+container qualifier=wildfly default=true
+   configuration
+   property 
name=jbossHometarget/wildfly-8.1.0.Final/property
+!-- JDK before 8: -XX:MaxPermSize=128m -XX --
+!-- JDK 8 and later: -XX:MaxMetaspaceSize=128m --
+!-- DEBUG MODE MANAGED: 
-Xrunjdwp:transport=dt_socket,address=8787,server=y,suspend=y --
+   property name=javaVmArguments-Xmx128m 
-XX:MaxPermSize=128m 
-Xrunjdwp:transport=dt_socket,address=8787,server=y,suspend=n
--- End diff --

Wicket 7.x is built with JDK 7, so we have to change this before merging to 
master branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] wicket pull request: Example to run Arquillian with Wicket.

2015-06-23 Thread martin-g
Github user martin-g commented on a diff in the pull request:

https://github.com/apache/wicket/pull/129#discussion_r33015092
  
--- Diff: testing/wicket-arquillian/pom.xml ---
@@ -0,0 +1,345 @@
+?xml version=1.0?
+!-- JBoss, Home of Professional Open Source Copyright 2013, Red Hat, Inc. 
+   and/or its affiliates, and individual contributors by the @authors tag. 
See 
+   the copyright.txt in the distribution for a full listing of individual 
contributors. 
+   Licensed under the Apache License, Version 2.0 (the License); you may 
not 
+   use this file except in compliance with the License. You may obtain a 
copy 
+   of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless 
required 
+   by applicable law or agreed to in writing, software distributed under 
the 
+   License is distributed on an AS IS BASIS, WITHOUT WARRANTIES OR 
CONDITIONS 
+   OF ANY KIND, either express or implied. See the License for the 
specific 
+   language governing permissions and limitations under the License. --
+project xmlns=http://maven.apache.org/POM/4.0.0; 
xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
+   xsi:schemaLocation=http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;
+   modelVersion4.0.0/modelVersion
+
+   groupIdorg.wildfly.quickstarts/groupId
--- End diff --

We should change this to `org.apache.wicket:wicket-arquillian-testing` or 
something similar.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] wicket pull request: Example to run Arquillian with Wicket.

2015-06-23 Thread martin-g
Github user martin-g commented on a diff in the pull request:

https://github.com/apache/wicket/pull/129#discussion_r33015149
  
--- Diff: testing/wicket-arquillian/pom.xml ---
@@ -0,0 +1,345 @@
+?xml version=1.0?
+!-- JBoss, Home of Professional Open Source Copyright 2013, Red Hat, Inc. 
+   and/or its affiliates, and individual contributors by the @authors tag. 
See 
+   the copyright.txt in the distribution for a full listing of individual 
contributors. 
+   Licensed under the Apache License, Version 2.0 (the License); you may 
not 
+   use this file except in compliance with the License. You may obtain a 
copy 
+   of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless 
required 
+   by applicable law or agreed to in writing, software distributed under 
the 
+   License is distributed on an AS IS BASIS, WITHOUT WARRANTIES OR 
CONDITIONS 
+   OF ANY KIND, either express or implied. See the License for the 
specific 
+   language governing permissions and limitations under the License. --
+project xmlns=http://maven.apache.org/POM/4.0.0; 
xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
+   xsi:schemaLocation=http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;
+   modelVersion4.0.0/modelVersion
+
+   groupIdorg.wildfly.quickstarts/groupId
+   artifactIdwildfly-arquillian-wicket-war/artifactId
+   version8.0.0-SNAPSHOT/version
+   packagingwar/packaging
+
+   nameWildFly Quickstarts: Wicket: WAR/name
+   licenses
+   license
+   nameApache License, Version 2.0/name
+   distributionrepo/distribution
+   
urlhttp://www.apache.org/licenses/LICENSE-2.0.html/url
+   /license
+   /licenses
+
+   description
+A sample JAVA EE 6 project demonstrating how to use Wicket 
Framework with JBoss WildFly.
+WAR version (everything in a single .war file).
+/description
+
+
+   properties
+   !-- Explicitly declaring the source encoding eliminates the 
following 
+   message: --
+   !-- [WARNING] Using platform encoding (UTF-8 actually) to copy 
filtered 
+   resources, i.e. build is platform dependent! --
+   
project.build.sourceEncodingUTF-8/project.build.sourceEncoding
+
+   !-- JBoss dependency versions --
+
+   
version.wildfly.maven.plugin1.0.2.Final/version.wildfly.maven.plugin
+
+   
version.jboss.spec.javaee.7.03.0.2.Final/version.jboss.spec.javaee.7.0
+
+
+   !-- Other dependency versions --
+   version.org.apache.wicket1.5.5/version.org.apache.wicket
+   
version.net.ftlines.wicket-cdi1.2/version.net.ftlines.wicket-cdi
--- End diff --

Should use wicket-cdi[-1.1]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] wicket pull request: Example to run Arquillian with Wicket.

2015-06-23 Thread martin-g
Github user martin-g commented on a diff in the pull request:

https://github.com/apache/wicket/pull/129#discussion_r33015132
  
--- Diff: testing/wicket-arquillian/pom.xml ---
@@ -0,0 +1,345 @@
+?xml version=1.0?
+!-- JBoss, Home of Professional Open Source Copyright 2013, Red Hat, Inc. 
+   and/or its affiliates, and individual contributors by the @authors tag. 
See 
+   the copyright.txt in the distribution for a full listing of individual 
contributors. 
+   Licensed under the Apache License, Version 2.0 (the License); you may 
not 
+   use this file except in compliance with the License. You may obtain a 
copy 
+   of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless 
required 
+   by applicable law or agreed to in writing, software distributed under 
the 
+   License is distributed on an AS IS BASIS, WITHOUT WARRANTIES OR 
CONDITIONS 
+   OF ANY KIND, either express or implied. See the License for the 
specific 
+   language governing permissions and limitations under the License. --
+project xmlns=http://maven.apache.org/POM/4.0.0; 
xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
+   xsi:schemaLocation=http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;
+   modelVersion4.0.0/modelVersion
+
+   groupIdorg.wildfly.quickstarts/groupId
+   artifactIdwildfly-arquillian-wicket-war/artifactId
+   version8.0.0-SNAPSHOT/version
+   packagingwar/packaging
+
+   nameWildFly Quickstarts: Wicket: WAR/name
+   licenses
+   license
+   nameApache License, Version 2.0/name
+   distributionrepo/distribution
+   
urlhttp://www.apache.org/licenses/LICENSE-2.0.html/url
+   /license
+   /licenses
+
+   description
+A sample JAVA EE 6 project demonstrating how to use Wicket 
Framework with JBoss WildFly.
+WAR version (everything in a single .war file).
+/description
+
+
+   properties
+   !-- Explicitly declaring the source encoding eliminates the 
following 
+   message: --
+   !-- [WARNING] Using platform encoding (UTF-8 actually) to copy 
filtered 
+   resources, i.e. build is platform dependent! --
+   
project.build.sourceEncodingUTF-8/project.build.sourceEncoding
+
+   !-- JBoss dependency versions --
+
+   
version.wildfly.maven.plugin1.0.2.Final/version.wildfly.maven.plugin
+
+   
version.jboss.spec.javaee.7.03.0.2.Final/version.jboss.spec.javaee.7.0
+
+
+   !-- Other dependency versions --
+   version.org.apache.wicket1.5.5/version.org.apache.wicket
--- End diff --

Wicket 7.x


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] wicket pull request: Example to run Arquillian with Wicket.

2015-06-23 Thread martin-g
Github user martin-g commented on a diff in the pull request:

https://github.com/apache/wicket/pull/129#discussion_r33015115
  
--- Diff: testing/wicket-arquillian/pom.xml ---
@@ -0,0 +1,345 @@
+?xml version=1.0?
+!-- JBoss, Home of Professional Open Source Copyright 2013, Red Hat, Inc. 
+   and/or its affiliates, and individual contributors by the @authors tag. 
See 
+   the copyright.txt in the distribution for a full listing of individual 
contributors. 
+   Licensed under the Apache License, Version 2.0 (the License); you may 
not 
+   use this file except in compliance with the License. You may obtain a 
copy 
+   of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless 
required 
+   by applicable law or agreed to in writing, software distributed under 
the 
+   License is distributed on an AS IS BASIS, WITHOUT WARRANTIES OR 
CONDITIONS 
+   OF ANY KIND, either express or implied. See the License for the 
specific 
+   language governing permissions and limitations under the License. --
+project xmlns=http://maven.apache.org/POM/4.0.0; 
xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
+   xsi:schemaLocation=http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;
+   modelVersion4.0.0/modelVersion
+
+   groupIdorg.wildfly.quickstarts/groupId
+   artifactIdwildfly-arquillian-wicket-war/artifactId
+   version8.0.0-SNAPSHOT/version
--- End diff --

The version should be 7.0.0-SNAPSHOT, as the other Wicket modules


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] wicket pull request: Example to run Arquillian with Wicket.

2015-06-23 Thread martin-g
Github user martin-g commented on the pull request:

https://github.com/apache/wicket/pull/129#issuecomment-114388258
  
I've added some comments - we have to upgrade to latest Wicket. I can help 
here if you want.

I don't see the change in BaseWicketTester in this PR. Please add it so we 
can review it too.

Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] wicket pull request: Example to run Arquillian with Wicket.

2015-06-23 Thread martin-g
Github user martin-g commented on a diff in the pull request:

https://github.com/apache/wicket/pull/129#discussion_r33015211
  
--- Diff: testing/wicket-arquillian/src/main/webapp/WEB-INF/web.xml ---
@@ -0,0 +1,49 @@
+?xml version=1.0 encoding=UTF-8?
+!--
+JBoss, Home of Professional Open Source
+Copyright 2013, Red Hat, Inc. and/or its affiliates, and individual
+contributors by the @authors tag. See the copyright.txt in the
+distribution for a full listing of individual contributors.
+
+Licensed under the Apache License, Version 2.0 (the License);
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an AS IS BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+--
+web-app xmlns=http://java.sun.com/xml/ns/javaee; 
xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
+xsi:schemaLocation=http://java.sun.com/xml/ns/javaee 
http://java.sun.com/xml/ns/javaee/web-app_2_5.xsd;
+version=2.5
+
+display-nameWildFly Quickstart: Wicket WAR/display-name
+
+!-- Enable Wicket --
+filter
+filter-nameWicket/filter-name
+
filter-classorg.apache.wicket.protocol.http.WicketFilter/filter-class
+init-param
+!-- Specify the entry point for Wicket to configure itself 
+from --
+param-nameapplicationClassName/param-name
+
param-valueorg.jboss.as.quickstarts.wicketWar.WicketJavaEEApplication/param-value
--- End diff --

Change the package name to `org.apache.wicket`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] wicket pull request: Example to run Arquillian with Wicket.

2015-06-22 Thread felipecalmeida
Github user felipecalmeida commented on the pull request:

https://github.com/apache/wicket/pull/129#issuecomment-114310198
  
Using Arquillian with Java EE 6 (CDI+EJB+JPA) and Wicket and the applied 
the patch suggested. Was so fast and I the configuration is less than before.

![screenshot from 2015-06-22 21 11 
49](https://cloud.githubusercontent.com/assets/6169365/8296161/83010f94-1923-11e5-9f57-1d1778e300cc.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] wicket pull request: Example to run Arquillian with Wicket.

2015-06-21 Thread felipecalmeida
Github user felipecalmeida commented on the pull request:

https://github.com/apache/wicket/pull/129#issuecomment-113866263
  
I'm using JDK 8 here.
So if you uses JDK 7, you have to change the file arquillian.xml, on the 
property javaVmArguments. Change the parameter:
-XX:MaxMetaspaceSize=128m
to
-XX:MaxPermSize=128m


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] wicket pull request: Example to run Arquillian with Wicket.

2015-06-21 Thread felipecalmeida
GitHub user felipecalmeida opened a pull request:

https://github.com/apache/wicket/pull/129

Example to run Arquillian with Wicket.

I'm using Wildfly example from
https://github.com/wildfly/quickstart/tree/master/wicket-war
Made some modifications and added an Arquillian Test configured and
running, everything passing, and has some LOG to help to understand.
To run for the first time just type: mvn install
Then mvn test.
Import to Eclipse (or any IDE), and run the example inside, to debug,
has to run the test normally and connect as remote.
Not necessary to download any Application Server, the maven plugin
already do this for you (It's managed).

Signed-off-by: Felipe C Almeida fr.ang.os.tr...@gmail.com

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/felipecalmeida/wicket master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/wicket/pull/129.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #129


commit 11b458bc303a75b071acbdd1593dca657da1ee8e
Author: Felipe C fr.ang.os.tr...@gmail.com
Date:   2015-06-21T06:08:56Z

Example to run Arquillian with Wicket.
I'm using Wildfly example from
https://github.com/wildfly/quickstart/tree/master/wicket-war
Made some modifications and added an Arquillian Test configured and
running, everything passing, and has some LOG to help to understand.
To run for the first time just type: mvn install
Then mvn test.
Import to Eclipse (or any IDE), and run the example inside, to debug,
has to run the test normally and connect as remote.
Not necessary to download any Application Server, the maven plugin
already do this for you (It's managed).

Signed-off-by: Felipe C Almeida fr.ang.os.tr...@gmail.com




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] wicket pull request: Example to run Arquillian with Wicket.

2015-06-21 Thread felipecalmeida
Github user felipecalmeida commented on the pull request:

https://github.com/apache/wicket/pull/129#issuecomment-113866069
  
This Pull is to help understand the improvement at JIRA - 
https://issues.apache.org/jira/browse/WICKET-5926


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---