[GitHub] wicket pull request: Use jQuery instead of $ in wicket-autocom...

2014-03-04 Thread martin-g
Github user martin-g commented on the pull request:

https://github.com/apache/wicket/pull/71#issuecomment-36607567
  
The change is merged in `wicket-6.x` and `master` branches.

Please close this PR because we cannot do it.
Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] wicket pull request: Use jQuery instead of $ in wicket-autocom...

2014-03-04 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/wicket/pull/71


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] wicket pull request: Use jQuery instead of $ in wicket-autocom...

2014-03-01 Thread bsaad
GitHub user bsaad opened a pull request:

https://github.com/apache/wicket/pull/71

Use jQuery instead of $  in wicket-autocomplete.js

This was already the case in the file, but there was one forgotten 
occurrence of using the $ sign.
This is done to support the no-conflict mode of jQuery.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bsaad/wicket master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/wicket/pull/71.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #71


commit 17e7279a7ca50fe529d810b3418f5d55e28a1ebf
Author: bsaad saad.bourz...@gmail.com
Date:   2014-03-01T18:11:38Z

Change $ to jQuery in wicket-autocomplete.js

This helps to avoid conflicts, and to support the no conflict mode of 
jQuery




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---